Re: Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68941/ --- (Updated Oct. 7, 2018, 11:56 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems.

> On Oct. 5, 2018, 7:23 p.m., Meng Zhu wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp > > Lines 2037 (patched) > > > > > > This could lead to test flakiness. > > The test only awaits for

Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209298 --- Do we plan to close it when backporting to 1.4.x finished? -

Re: Review Request 68945: Fused constructors of `MethodNotAllowed` into one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68945/#review209302 --- PASS: Mesos patch 68945 was successfully built and tested.

Re: Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68941/#review209299 --- PASS: Mesos patch 68941 was successfully built and tested.

Re: Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68941/#review209301 --- Ship it! Ship It! - Qian Zhang On Oct. 8, 2018, 2:56 p.m.,

Re: Review Request 68944: Used delegating constructors in `Response` types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68944/#review209306 --- Ship it! Nice find, I think this is exactly the use-case

Re: Review Request 68945: Fused constructors of `MethodNotAllowed` into one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68945/ --- (Updated Oct. 8, 2018, 7:50 a.m.) Review request for mesos and Benno Evers.

Re: Review Request 68945: Fused constructors of `MethodNotAllowed` into one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68945/#review209305 --- Ship it! 3rdparty/libprocess/include/process/http.hpp Lines

Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68929/#review209300 --- Fix it, then Ship it!

Review Request 68950: Moved `get_agent_address` from `util.py` to `mesos.py` in new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68950/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8795

Review Request 68949: Removed unused `lib/cli/tasks.py` for new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68949/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8795

Re: Review Request 68711: Added `task ls` command to new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68711/ --- (Updated Oct. 8, 2018, 3:09 p.m.) Review request for mesos, Eric Chung and

Re: Review Request 68950: Moved `get_agent_address` from `util.py` to `mesos.py` in new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68950/#review209309 --- Ship it! Ship It! - Kevin Klues On Okt. 8, 2018, 1:08

Re: Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68941/#review209312 --- Bad patch! Reviews applied: [68941, 68929] Failed command:

Re: Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

> On Oct. 8, 2018, 8:12 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Line 97 (original), 97 (patched) > > > > > > IIUC, then `sys.executable` may be `None`. Shall we guard against that? As described

Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68951/ --- Review request for mesos, Till Toenshoff and Vinod Kone. Bugs: MESOS-9253

Re: Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68951/#review209317 --- support/verify-reviews.py Line 97 (original), 97 (patched)

Re: Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68951/#review209334 --- PASS: Mesos patch 68951 was successfully built and tested.

Re: Review Request 68940: Added a 1.7.0 performance improvements blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68940/ --- (Updated Oct. 9, 2018, 12:43 a.m.) Review request for mesos, Benno Evers,

Review Request 68955: Add per framework metrics in member function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68955/ --- Review request for mesos. Repository: mesos Description --- This is a

Review Request 68953: Refactor allocator configuration into class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/ --- Review request for mesos. Repository: mesos Description --- Refactor

Review Request 68954: Fix tests related to allocator options refactor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68954/ --- Review request for mesos. Repository: mesos Description --- Fix tests

Review Request 68956: Add flag to toggle per framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- Review request for mesos. Repository: mesos Description --- In clusters

Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- Review request for mesos. Repository: mesos Description --- Add

Re: Review Request 68940: Added a 1.7.0 performance improvements blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68940/#review209345 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209339 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209344 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 68945: Fused constructors of `MethodNotAllowed` into one.

> On Oct. 8, 2018, 10:49 a.m., Benno Evers wrote: > > 3rdparty/libprocess/include/process/http.hpp > > Lines 777 (patched) > > > > > > I'd probably consider using `strings::format()` here. It is indeed a bit nicer,

Re: Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68941/ --- (Updated Oct. 8, 2018, 10:36 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68929/ --- (Updated Oct. 8, 2018, 10:36 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68951/#review209323 --- Bad patch! Reviews applied: [68951] Failed command: python

Re: Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68951/#review209324 --- Ship it! Ship It! - Vinod Kone On Oct. 8, 2018, 6:06 p.m.,

Re: Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

> On Oct. 8, 2018, 6:12 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Line 97 (original), 97 (patched) > > > > > > IIUC, then `sys.executable` may be `None`. Shall we guard against that? > > Armand

Re: Review Request 68941: Added an unit test for agent recovery with new cgroup subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68941/#review209320 --- PASS: Mesos patch 68941 was successfully built and tested.