Re: Review Request 69311: Enabled parallel test runner to cmake build.

2018-11-14 Thread Benjamin Bannier
> On Nov. 13, 2018, 11:48 a.m., Benno Evers wrote: > > cmake/MesosConfigure.cmake > > Lines 56 (patched) > > > > > > If I configure with `ENABLE_PARALLEL_TEST_EXECUTION=ON` and then > > reconfigure with

Re: Review Request 69311: Enabled parallel test runner to cmake build.

2018-11-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69311/ --- (Updated Nov. 14, 2018, 2:11 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69157: Fixed handling for offer operation updates.

2018-11-14 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210540 --- Ship it! Ship It! - Jan Schlicht On Nov. 13, 2018, 10:10

Review Request 69337: Garbage collected disappeared resource providers from master state.

2018-11-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-9384

Review Request 69338: Change agent to not report disconnected resource providers.

2018-11-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69338/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Bugs: MESOS-9384

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210544 --- src/tests/slave_recovery_tests.cpp Lines 4822 (patched)

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/ --- (Updated Nov. 14, 2018, 3:23 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 69338: Change agent to not report disconnected resource providers.

2018-11-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69338/#review210548 --- PASS: Mesos patch 69338 was successfully built and tested.

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

2018-11-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/#review210549 --- FAIL: Failed to apply the dependent review: 67844. Failed

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210550 --- PASS: Mesos patch 69273 was successfully built and tested.

Re: Review Request 69171: Added validation of cache files to the URI Fetcher.

2018-11-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69171/#review210558 --- Ship it! Ship It! - Joseph Wu On Oct. 29, 2018, 3:33 p.m.,

Re: Review Request 69311: Enabled parallel test runner to cmake build.

2018-11-14 Thread Joseph Wu
> On Nov. 13, 2018, 2:48 a.m., Benno Evers wrote: > > src/tests/CMakeLists.txt > > Lines 365 (patched) > > > > > > Does this preserve user-specified `MESOS_GTEST_RUNNER_FLAGS`? Or, the > > other way round, will a

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210559 --- Ship it! src/tests/slave_recovery_tests.cpp Lines 4822