Re: Review Request 69563: Made master process authorization results properly for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69563/#review211323 --- Could you please add a test, and break out refactorings and

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211340 --- Ship it! Ship It! - Vinod Kone On Dec. 13, 2018, 3:59 p.m.,

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/#review211342 --- src/common/protobuf_utils.cpp Lines 470 (patched)

Re: Review Request 69445: WIP: Moved `ReadOnlyHandler` into separate header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69445/#review211328 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 69557: Removed redundant handling of empty framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69557/#review211327 --- Bad patch! Reviews applied: [69557, 69398, 69397] Failed

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/#review211329 --- Bad patch! Reviews applied: [69436] Failed command: ['bash',

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

> On Dec. 13, 2018, 9:58 p.m., Vinod Kone wrote: > > git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > > Failed command: git reset --hard > > b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > > > > Error: b'fatal: Cannot do hard reset with paths.\n' > > > > > > This looks bad?

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211332 --- PASS: Mesos patch 69559 was successfully built and tested.

Re: Review Request 69541: Added volume gid manager.

> On Dec. 13, 2018, 8:36 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp > > Lines 100 (patched) > > > > > > I have a small concern regarding unconditionally

Re: Review Request 69338: Change agent to not report disconnected resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69338/ --- (Updated Dec. 14, 2018, 4:56 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/ --- (Updated Dec. 14, 2018, 4:56 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/#review211333 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69569: Added missing code to set resource provider and agent ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-9479

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

> On Dec. 14, 2018, 1:23 p.m., Armand Grillet wrote: > > Bad patch! > > > > Reviews applied: [69436] > > > > Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' > > BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose > > --disable-libtool-wrappers'

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

> On Dec. 14, 2018, 4:23 a.m., Armand Grillet wrote: > > Bad patch! > > > > Reviews applied: [69436] > > > > Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' > > BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose > > --disable-libtool-wrappers'

Re: Review Request 69338: Change agent to not report disconnected resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69338/#review211336 --- PASS: Mesos patch 69338 was successfully built and tested.

Re: Review Request 69563: Made master process authorization results properly for offer operations.

> On Dec. 14, 2018, 8:58 a.m., Benjamin Bannier wrote: > > src/master/master.cpp > > Lines 4757-4758 (original), 4757-4758 (patched) > > > > > > Performing this change in this patch makes it hard to review the > >

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/#review211339 --- Fix it, then Ship it! src/master/master.cpp Lines 8208