Re: Review Request 70741: Adopted container file operations for secrets volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70741/#review215696 --- src/common/protobuf_utils.hpp Lines 100 (patched)

Re: Review Request 70741: Adopted container file operations for secrets volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70741/ --- (Updated June 5, 2019, 8:44 a.m.) Review request for mesos, Xudong Ni, Gilbert

Re: Review Request 70741: Adopted container file operations for secrets volumes.

> On June 5, 2019, 7:16 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/volume/secret.cpp > > Line 138 (original), 147 (patched) > > > > > > Do you know why `launchInfo.mounts` was not used

Re: Review Request 70782: Added a non-deterministic test for MESOS-9808.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70782/ --- (Updated June 5, 2019, 3:47 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/ --- (Updated June 5, 2019, 4:13 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/ --- (Updated June 5, 2019, 3:37 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/#review215701 --- 3rdparty/libprocess/src/metrics/metrics.cpp Lines 212-226

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/ --- (Updated June 5, 2019, 3:39 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

> On June 4, 2019, 8:42 p.m., Joseph Wu wrote: > > I think it is a little unfortunate that we end up with a conditional > > `select()` and an extra chaining step in this endpoint. But since we > > aren't saving the vector of keys/futures/statistics anywhere, the chaining > > is mostly

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

> On June 5, 2019, 1:05 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp > > Lines 199-207 (patched) > > > > > > If we consolidate the logging between user timeout and slow timeout can >

Re: Review Request 70782: Added a non-deterministic test for MESOS-9808.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70782/ --- (Updated June 5, 2019, 3:42 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70728/#review215705 --- s/completelt/completely/ in the description.

Re: Review Request 70738: Allow roles to burst up to quota limits in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70738/#review215704 --- Patch looks great! Reviews applied: [70779, 70780, 70738]

Re: Review Request 70741: Adopted container file operations for secrets volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70741/#review215708 --- Patch looks great! Reviews applied: [70741] Passed command:

Re: Review Request 70786: Moved `class ResourceQuantities` to public header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70786/#review215707 --- Patch looks great! Reviews applied: [70786] Passed command:

Re: Review Request 70783: Added debug logging for metrics which are slow to become ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70783/#review215710 --- Patch looks great! Reviews applied: [70783] Passed command:

Re: Review Request 70766: Fixed chaining futures infinitely in `UriDiskProfileAdaptor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70766/ --- (Updated June 6, 2019, 4:58 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70765: Renamed struct `ProfileRecord` to `ProfileData` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70765/#review215711 --- Bad review! Reviews applied: [70765, 70766, 70622, 70621, 70620]

Review Request 70788: Garbage-collected disappeared RPs when agent resources remain unchanged.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70788/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9831