[GitHub] [mesos] bluezd commented on a change in pull request #353: hook manager mutex and global variable enhancement

bluezd commented on a change in pull request #353: hook manager mutex and global variable enhancement URL: https://github.com/apache/mesos/pull/353#discussion_r397585853 ## File path: src/hook/manager.cpp ## @@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;

[GitHub] [mesos] bluezd commented on a change in pull request #353: Hook manager mutex and global variable enhancement.

bluezd commented on a change in pull request #353: Hook manager mutex and global variable enhancement. URL: https://github.com/apache/mesos/pull/353#discussion_r397585853 ## File path: src/hook/manager.cpp ## @@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;

[GitHub] [mesos] bluezd commented on a change in pull request #353: Hook manager mutex and global variable enhancement.

bluezd commented on a change in pull request #353: Hook manager mutex and global variable enhancement. URL: https://github.com/apache/mesos/pull/353#discussion_r397585853 ## File path: src/hook/manager.cpp ## @@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;

[GitHub] [mesos] bmahler commented on issue #354: Avoid error on mesos logs upon docker image fetch

bmahler commented on issue #354: Avoid error on mesos logs upon docker image fetch URL: https://github.com/apache/mesos/pull/354#issuecomment-603477873 Thanks @kamaradclimber, we chatted a bit in slack about this since it looked a bit surprising to me:

Re: Review Request 72262: Added resource limits to v0 endpoint results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72262/#review220064 --- Patch looks great! Reviews applied: [72262] Passed command:

Re: Review Request 72262: Added resource limits to v0 endpoint results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72262/#review220065 --- src/tests/common/http_tests.cpp Lines 115-119 (patched)

Review Request 72263: Moved containerizer utils in CMakeLists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72263/ --- Review request for mesos and Greg Mann. Bugs: MESOS-10048

Re: Review Request 72263: Moved containerizer utils in CMakeLists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72263/#review220067 --- Patch looks great! Reviews applied: [72263] Passed command:

Re: Review Request 72263: Moved containerizer utils in CMakeLists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72263/#review220072 --- Ship it! Ship It! - Greg Mann On March 24, 2020, 8:40 a.m.,

[GitHub] [mesos] bmahler commented on a change in pull request #353: hook manager mutex and global variable enhancement

bmahler commented on a change in pull request #353: hook manager mutex and global variable enhancement URL: https://github.com/apache/mesos/pull/353#discussion_r397425354 ## File path: src/hook/manager.cpp ## @@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;

[GitHub] [mesos] bmahler commented on issue #353: hook manager mutex and global variable enhancement

bmahler commented on issue #353: hook manager mutex and global variable enhancement URL: https://github.com/apache/mesos/pull/353#issuecomment-603473389 @asekretenko these are good questions to be asking, as I also felt this looked a bit strange. I suspect it's just modeled in the same

Re: Review Request 72262: Added resource limits to v0 endpoint results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72262/ --- (Updated March 24, 2020, 8:48 p.m.) Review request for mesos and Qian Zhang.

[GitHub] [mesos] bmahler commented on a change in pull request #353: hook manager mutex and global variable enhancement

bmahler commented on a change in pull request #353: hook manager mutex and global variable enhancement URL: https://github.com/apache/mesos/pull/353#discussion_r397426753 ## File path: src/hook/manager.cpp ## @@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;

Re: Review Request 72262: Added resource limits to v0 endpoint results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72262/#review220074 --- Patch looks great! Reviews applied: [72262] Passed command:

Re: Review Request 72262: Added resource limits to v0 endpoint results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72262/#review220076 --- Ship it! Ship It! - Qian Zhang On March 25, 2020, 4:48