[GitHub] [mesos] akornatskyy commented on a change in pull request #361: Added ability to specify a root dir for boost-libs and curl.

akornatskyy commented on a change in pull request #361: URL: https://github.com/apache/mesos/pull/361#discussion_r416710336 ## File path: 3rdparty/CMakeLists.txt ## @@ -696,7 +701,16 @@ if (ENABLE_SECCOMP_ISOLATOR) URL ${LIBSECCOMP_URL} URL_HASH

Re: Review Request 72445: Fixed operator api event inconsistencies issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72445/ --- (Updated April 28, 2020, 9:13 p.m.) Review request for mesos and Andrei

[GitHub] [mesos] greggomann commented on a change in pull request #361: Added ability to specify a root dir for boost-libs, curl and libseccomp.

greggomann commented on a change in pull request #361: URL: https://github.com/apache/mesos/pull/361#discussion_r416643733 ## File path: 3rdparty/CMakeLists.txt ## @@ -696,7 +701,16 @@ if (ENABLE_SECCOMP_ISOLATOR) URL ${LIBSECCOMP_URL} URL_HASH

Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72399/#review220528 --- src/slave/containerizer/mesos/containerizer.cpp Lines 2460-2463

Re: Review Request 72398: Added `cpus_soft_limit` field to `ResourceStatistics` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72398/#review220527 --- Ship it! Ship It! - Greg Mann On April 24, 2020, 12:24

Re: Review Request 72401: Updated Docker containerizer by not updating resources for command task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72401/#review220529 --- Could you update the description of the patch to describe the

Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72402/#review220530 --- src/slave/containerizer/docker.cpp Lines 2077-2099 (patched)

Re: Review Request 72448: Fixed operator api event inconsistencies issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72448/#review220537 --- Bad review! Reviews applied: [] Error: No reviewers specified.

[GitHub] [mesos] akornatskyy commented on a change in pull request #361: Added ability to specify a root dir for boost-libs and curl.

akornatskyy commented on a change in pull request #361: URL: https://github.com/apache/mesos/pull/361#discussion_r417074587 ## File path: 3rdparty/CMakeLists.txt ## @@ -194,29 +194,34 @@ endfunction() # Boost: C++ Libraries. # http://www.boost.org ###

Re: Review Request 72410: Updated existing documentation for resource limits.

> On April 28, 2020, 9:59 a.m., Qian Zhang wrote: > > docs/task-state-reasons.md > > Lines 126-133 (patched) > > > > > > If we revert the changes about > > `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in > >

Re: Review Request 72409: Added intro docs on running workloads.

> On April 22, 2020, 2:09 p.m., Qian Zhang wrote: > > docs/running-workloads.md > > Lines 65-67 (patched) > > > > > > Do we want to mention how we set OOM score adjustment for burstable > > tasks somewhere in the

Re: Review Request 72410: Updated existing documentation for resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72410/#review220536 --- Patch looks great! Reviews applied: [72408, 72409, 72410]

Re: Review Request 72413: Updated executor API docs to include the domain socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72413/ --- (Updated April 28, 2020, 11:08 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 72409: Added intro docs on running workloads.

> On April 22, 2020, 1:21 p.m., Qian Zhang wrote: > > docs/running-workloads.md > > Lines 30 (patched) > > > > > > What do you mean for "task is specified with executor ID"? Why do we > > want to specify an executor

[GitHub] [mesos] greggomann commented on a change in pull request #361: Added ability to specify a root dir for boost-libs and curl.

greggomann commented on a change in pull request #361: URL: https://github.com/apache/mesos/pull/361#discussion_r416997093 ## File path: 3rdparty/CMakeLists.txt ## @@ -194,29 +194,34 @@ endfunction() # Boost: C++ Libraries. # http://www.boost.org ###

Re: Review Request 72409: Added intro docs on running workloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72409/ --- (Updated April 29, 2020, 12:01 a.m.) Review request for mesos, Andrei Budnik,

Review Request 72448: Fixed operator api event inconsistencies issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72448/ --- Review request for mesos. Repository: mesos Description --- This patch

Re: Review Request 72409: Added intro docs on running workloads.

> On April 22, 2020, 1:21 p.m., Qian Zhang wrote: > > docs/running-workloads.md > > Lines 30 (patched) > > > > > > What do you mean for "task is specified with executor ID"? Why do we > > want to specify an executor

Re: Review Request 72409: Added intro docs on running workloads.

> On April 22, 2020, 9:21 p.m., Qian Zhang wrote: > > docs/running-workloads.md > > Lines 30 (patched) > > > > > > What do you mean for "task is specified with executor ID"? Why do we > > want to specify an executor

Re: Review Request 72409: Added intro docs on running workloads.

> On April 22, 2020, 10:09 p.m., Qian Zhang wrote: > > docs/running-workloads.md > > Lines 65-67 (patched) > > > > > > Do we want to mention how we set OOM score adjustment for burstable > > tasks somewhere in the

Re: Review Request 72410: Updated existing documentation for resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72410/#review220519 --- docs/task-state-reasons.md Lines 126-133 (patched)

Review Request 72445: Fixed operator api event inconsistencies issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72445/ --- Review request for mesos and Andrei Sekretenko. Repository: mesos

Re: Review Request 72408: Made the scheduler resources a top-level item in the documentation.

> On April 22, 2020, 5:07 p.m., Qian Zhang wrote: > > docs/home.md > > Line 76 (original), 76 (patched) > > > > > > Should we name it `Frameworks`? > > Greg Mann wrote: > I went with Ben's suggestion, let me

Re: Review Request 72445: Fixed operator api event inconsistencies issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72445/#review220521 --- Bad patch! Reviews applied: [72445] Failed command: ['bash',