Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-04 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/ --- (Updated May 4, 2020, 4:12 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220592 --- Bad patch! Reviews applied: [72368, 72363, 72364] Failed

Re: Review Request 72363: Fixed handling disconnected agents by REACTIVATE_AGENT call.

2020-05-04 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72363/ --- (Updated May 4, 2020, 12:37 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-04 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/ --- (Updated May 4, 2020, 12:28 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.

2020-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72442/#review220599 --- Ship it! I would recommend updating the description so that

Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.

2020-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72399/#review220602 --- Fix it, then Ship it!

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220606 --- Bad patch! Reviews applied: [72368, 72364] Failed command:

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

2020-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated May 5, 2020, 5:22 a.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220617 --- src/tests/master_draining_tests.cpp Lines 239 (patched)

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

2020-05-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated May 5, 2020, 5:10 a.m.) Review request for mesos, Andrei Sekretenko