On May 11, 2015, 10:58 p.m., Adam B wrote:
src/cli/execute.cpp, lines 203-204
https://reviews.apache.org/r/33109/diff/5-6/?file=939687#file939687line203
You can keep this as one statement, just wrap with the '=' at the start
of the newline.
Correction... wrap after the '='.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review83364
---
Ship it!
Looks great! Sorry I was so slow. Didn't realize it would
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33109/
---
(Updated May 12, 2015, 6:24 a.m.)
Review request for mesos and Adam B.
Bugs:
On March 4, 2015, 4:03 p.m., Niklas Nielsen wrote:
Do you want this in? If so, please update the review :)
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/#review72824
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/
---
(Updated May 12, 2015, 5:13 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32398/
---
(Updated May 12, 2015, 6:44 p.m.)
Review request for mesos, Alexander
On April 17, 2015, 12:01 p.m., Alexander Rojas wrote:
src/tests/slave_tests.cpp, lines 146-148
https://reviews.apache.org/r/33152/diff/1/?file=926674#file926674line146
One line break too many.
forgot to publish the updated diff?
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/
---
(Updated May 12, 2015, 6:41 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32398/#review83464
---
Patch looks great!
Reviews applied: [32139, 32140, 32149, 32150,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/#review83461
---
Ship it!
Left a minor suggestion but otherwise it looks good to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33876/
---
(Updated May 12, 2015, 1:55 p.m.)
Review request for mesos, Jie Yu and Vinod
On April 30, 2015, 4:09 p.m., Joe Smith wrote:
docs/metrics.md, line 221
https://reviews.apache.org/r/33241/diff/3/?file=938848#file938848line221
master/slave_shutdowns_completed
These are slaves which were not heard from despite the slave-removal
rate limit, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review83491
---
Patch looks great!
Reviews applied: [33241]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/
---
(Updated May 12, 2015, 2:23 p.m.)
Review request for mesos, Benjamin Hindman,
On May 11, 2015, 11:32 p.m., Jie Yu wrote:
src/tests/reservation_tests.cpp, line 365
https://reviews.apache.org/r/29748/diff/17/?file=954334#file954334line365
YOu do need a snake_case checker:)
Sigh... Sorry :( Fixed.
On May 11, 2015, 11:32 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/
---
(Updated May 12, 2015, 5:22 p.m.)
Review request for mesos, Chi Zhang, Dominic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32891/
---
(Updated May 12, 2015, 5:22 p.m.)
Review request for mesos, Chi Zhang, Jay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34016/
---
(Updated May 13, 2015, 2:21 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/#review83533
---
3rdparty/libprocess/src/process.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34135/
---
Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34140/
---
Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34141/
---
Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34137/
---
Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33155/#review83538
---
Patch looks great!
Reviews applied: [33152, 33153, 33154, 33155]
On May 11, 2015, 10:19 p.m., Ben Mahler wrote:
src/slave/slave.cpp, line 155
https://reviews.apache.org/r/34016/diff/1/?file=954524#file954524line155
unique_ptr is not a POD, so this will still try to run the destructor
of the function during exit of the program.
Can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34134/
---
Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34129/#review83544
---
Patch looks great!
Reviews applied: [34129]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34152/
---
Review request for mesos.
Bugs: MESOS-2723
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30643/#review83550
---
Patch looks great!
Reviews applied: [30643]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33746/
---
(Updated May 12, 2015, 5:23 p.m.)
Review request for mesos, Chi Zhang and Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30643/
---
(Updated May 12, 2015, 5:22 p.m.)
Review request for mesos, Timothy Chen and
On May 7, 2015, 6:16 p.m., Niklas Nielsen wrote:
src/messages/messages.proto, line 339
https://reviews.apache.org/r/33919/diff/1/?file=951655#file951655line339
Is the slave id going to be implicit from the sender PID in the master?
Also, do we need a time stamp?
Yeah, we need
On May 12, 2015, 7:31 p.m., Vinod Kone wrote:
LGTM. Can you add a comment on removeSlave() on why it takes a const ref of
'reason' per Alex's comments?
I've just removed the const reference instead, to take a copy.
- Ben
---
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33154/
---
(Updated May 12, 2015, 11:28 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/
---
Review request for mesos.
Bugs: MESOS-809
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33155/
---
(Updated May 12, 2015, 11:32 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33152/
---
(Updated May 12, 2015, 10:22 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/
---
(Updated May 12, 2015, 11:23 p.m.)
Review request for mesos.
Bugs: MESOS-809
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34129/
---
Review request for mesos.
Bugs: MESOS-809
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33153/
---
(Updated May 12, 2015, 11:28 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/#review83529
---
Patch looks great!
Reviews applied: [34128]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33919/#review83562
---
Patch looks great!
Reviews applied: [33918, 33919]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review83553
---
Patch looks great!
Reviews applied: [32891, 32978, 31444]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33746/#review83555
---
Patch looks great!
Reviews applied: [33746]
All tests passed.
-
44 matches
Mail list logo
