Re: Review Request 34529: Add non-const reference version of Option::get.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/#review85899 --- Patch looks great! Reviews applied: [34529] All tests passed. - M

Re: Review Request 34529: Add non-const reference version of Option::get.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/ --- (Updated May 31, 2015, 4:39 a.m.) Review request for mesos and Joris Van Remoor

Re: Review Request 34529: Add non-const reference version of Option::get.

> On May 31, 2015, 3:15 a.m., Michael Park wrote: > > Mark, thanks for your contribution! I've left a couple of comments below > > regarding the test, but the option code looks good to me! Thanks for the review, Michael! > On May 31, 2015, 3:15 a.m., Michael Park wrote: > > 3rdparty/libproces

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review85893 --- Patch looks great! Reviews applied: [34687] All tests passed. - M

Re: Review Request 34529: Add non-const reference version of Option::get.

On May 31, 2015, 3:15 a.m., Mark Wang wrote: > > for Not sure how this got here. Please ignore. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/#review85890 --

Re: Review Request 34529: Add non-const reference version of Option::get.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/#review85890 --- Ship it! Mark, thanks for your contribution! I've left a couple of

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/ --- (Updated May 31, 2015, 2:58 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 34529: Add non-const reference version of Option::get.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/#review85889 --- Patch looks great! Reviews applied: [34529] All tests passed. - M

Re: Review Request 34529: Add non-const reference version of Option::get.

> On May 29, 2015, 8:21 p.m., Joris Van Remoortere wrote: > > Hey Mark, > > Thanks for your work! > > I left some comments, but this looks good to me once you fix them. > > Will you be making a follow up review that gets rid of the cases you used > > as justification for this change? > > > > Jo

Re: Review Request 34529: Add non-const reference version of Option::get.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/ --- (Updated May 31, 2015, 1:13 a.m.) Review request for mesos and Joris Van Remoor

Re: Review Request 34529: Add non-const reference version of Option::get.

> On May 29, 2015, 8:21 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp, line 115 > > > > > > Could you please elaborate why we are adding this? > > I can't tell th

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/ --- (Updated May 30, 2015, 9 p.m.) Review request for mesos, Chi Zhang, Ian Downes,

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

> On May 30, 2015, 6:12 p.m., Isabel Jimenez wrote: > > src/linux/routing/queueing/internal.hpp, line 128 > > > > > > Why use reinterpret_cast here? am I missing something that needs > > changing the bit interpretatio

Re: Review Request 34193: Refactored common functionality into FlagsBase

> On May 30, 2015, 12:21 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 89-121 > > > > > > The wrapping here is still weird. I would just ask benh to f

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/#review85828 --- Ship it! src/linux/routing/queueing/fq_codel.hpp