Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96302 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 6:43 p.m., Jos

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96301 --- include/mesos/maintenance/maintenance.proto (line 19)

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review96299 --- include/mesos/master/quota.proto (line 19)

Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37621/#review96296 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m., Jor

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/#review96294 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:44 a.m., Jor

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/#review96291 --- Patch looks great! Reviews applied: [36321, 36571, 37314, 37325, 37

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review96284 --- include/mesos/v1/mesos.proto (line 907)

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/#review96285 --- Patch looks great! Reviews applied: [37655] All tests passed. - M

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/#review96281 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m., Jor

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/ --- (Updated Aug. 25, 2015, 2:44 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/#review96280 --- Bad patch! Reviews applied: [37196, 37197, 37198, 37200] Failed co

Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37621/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/ --- (Updated Aug. 25, 2015, 2:14 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37281/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37176/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Aug. 25, 2015, 2:12 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Aug. 25, 2015, 2:12 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/ --- (Updated Aug. 25, 2015, 2:12 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/ --- (Updated Aug. 25, 2015, 2:12 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37738: Added a filesystem isolator test to test image in volume while the container root filesystem is also specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37738/#review96277 --- Patch looks great! Reviews applied: [37726, 37734, 37735, 37738] A

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96272 --- src/messages/messages.proto (line 350)

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

> On Aug. 12, 2015, 9:16 p.m., Joseph Wu wrote: > > Why are the InverseOffers (and Offers) hashed as pointers? Can you point to an example. I don't understand your question. - Joris --- This is an automatically generated e-mail. To repl

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/#review96269 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 12:14 a.m., Jo

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

> On Aug. 18, 2015, 9:33 p.m., Joseph Wu wrote: > > src/master/master.hpp, line 478 > > > > > > Why is this return type `Nothing`, instead of `void`? It was `Nothing` as I was calling this function from the tests be

Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37497/ --- (Updated Aug. 25, 2015, 1:35 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/ --- (Updated Aug. 25, 2015, 1:34 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37495: Docker provisioner local store unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/ --- (Updated Aug. 25, 2015, 1:34 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37101: Remove unused sched API's

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/#review96266 --- Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 9:30 p.m., Con

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 25, 2015, 1:33 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 25, 2015, 1:32 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 25, 2015, 1:31 a.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/ --- (Updated Aug. 25, 2015, 1:28 a.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/#review96265 --- include/mesos/scheduler/scheduler.proto (line 70)

Re: Review Request 37101: Remove unused sched API's

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/#review96263 --- Patch looks great! Reviews applied: [36410, 36411, 36412, 36413, 37

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 24, 2015, 5:59 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96259 --- include/mesos/mesos.proto (line 125)

Re: Review Request 37726: Added support for preparing images specified in volumes.

> On Aug. 25, 2015, 12:33 a.m., Timothy Chen wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, line 485 > > > > > > How about trying multiple rootfs in the same container? Yeah, that needs a few refa

Re: Review Request 37726: Added support for preparing images specified in volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37726/#review96254 --- src/tests/containerizer/filesystem_isolator_tests.cpp (line 485)

Re: Review Request 37722: Added definitions of container rootfs directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/#review96252 --- The slave provisioners path LGTM! src/slave/containerizer/provisio

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review96251 --- Bad patch! Reviews applied: [37585] Failed command: ./support/appl

Re: Review Request 37541: Add TraceEvent API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Aug. 25, 2015, 12:17 a.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 37540: Add PerfEvent API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Aug. 25, 2015, 12:16 a.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/ --- (Updated Aug. 24, 2015, 5:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37722: Added definitions of container rootfs directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/#review96246 --- Patch looks great! Reviews applied: [37722] All tests passed. - M

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/#review96244 --- Ship it! Ship It! include/mesos/mesos.proto (line 98)

Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96240 --- This review is a bit hard to follow because it's doing multiple thin

Re: Review Request 37198: Add Docker image provisioner and copy backend.

> On Aug. 19, 2015, 6:21 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker.hpp, line 81 > > > > > > Did we introduce DockerImageName later? > > A pair of strings is pretty confusing, how ab

Review Request 37738: Added a filesystem isolator test to test image in volume while the container root filesystem is also specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37738/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Repositor

Review Request 37735: Refactored filesystem isolator tests to allow multiple rootfses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37735/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Repositor

Review Request 37734: Used recursive bind mounts for volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37734/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Repositor

Re: Review Request 37427: Docker registry: adding TokenManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review96233 --- Patch looks great! Reviews applied: [37426, 37427] All tests passe

Re: Review Request 37501: Add support for removing capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37501/#review96232 --- Ship it! Ship It! - Vinod Kone On Aug. 15, 2015, 4:35 p.m., Adit

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/ --- (Updated Aug. 24, 2015, 9:54 p.m.) Review request for mesos, Cody Maloney and T

Re: Review Request 36127: Removing '.json' extension in files endpoints url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review96218 --- Patch looks great! Reviews applied: [36127] All tests passed. - M

Re: Review Request 37541: Add TraceEvent API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Aug. 24, 2015, 9:32 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 37540: Add PerfEvent API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Aug. 24, 2015, 9:31 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 37101: Remove unused sched API's

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/ --- (Updated Aug. 24, 2015, 9:30 p.m.) Review request for mesos, Ian Downes, Jie Yu

Re: Review Request 37729: Remove extraneous IsolatorProcess declaration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37729/#review96215 --- Ship it! Ship It! - Jie Yu On Aug. 24, 2015, 9:09 p.m., Joseph W

Re: Review Request 37729: Remove extraneous IsolatorProcess declaration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37729/#review96214 --- Ship it! Ship It! - Kapil Arya On Aug. 24, 2015, 5:09 p.m., Jose

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 24, 2015, 2:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review96213 --- include/mesos/master/quota.proto (line 19)

Review Request 37729: Remove extraneous IsolatorProcess declaration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37729/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and Kapil Arya. Reposit

Re: Review Request 37268: Style checker checking for { on newline

> On Aug. 24, 2015, 8:34 p.m., Jose Guilherme Vanz wrote: > > Ship It! > > Jose Guilherme Vanz wrote: > Ops... sorry. My "Ship it" is not valid. I'm the author... sorry - Jose Guilherme --- This is an automatically generated e-mail

Re: Review Request 37268: Style checker checking for { on newline

> On Aug. 24, 2015, 8:34 p.m., Jose Guilherme Vanz wrote: > > Ship It! Ops... sorry. - Jose Guilherme --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37268/#review96194 --

Re: Review Request 37268: Style checker checking for { on newline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37268/#review96194 --- Ship it! Ship It! - Jose Guilherme Vanz On Aug. 12, 2015, 1:15 a

Review Request 37726: Added support for preparing images specified in volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37726/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MES

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/ --- (Updated Aug. 24, 2015, 11:43 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37358/ --- (Updated Aug. 24, 2015, 11:54 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 24, 2015, 12:03 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

> On Aug. 12, 2015, 10:31 a.m., Joseph Wu wrote: > > src/master/maintenance.cpp, lines 126-130 > > > > > > Note: Considering the "machine" field in the master's local state > > (https://reviews.apache.org/r/37170/di

Re: Review Request 37197: Docker image store.

> On Aug. 19, 2015, 6:11 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 1 > > > > > > Btw this is actually renamed to be local store later right? > > > > How about ju

Re: Review Request 37364: Maintenance Primitives: Adds an endpoint for retrieving the maintenance status for machines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37364/ --- (Updated Aug. 24, 2015, 12:09 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/ --- (Updated Aug. 24, 2015, 11:48 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for transitioning agents back into Normal mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37362/ --- (Updated Aug. 24, 2015, 12:08 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/ --- (Updated Aug. 24, 2015, 11:33 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

> On June 15, 2015, 12:07 p.m., Niklas Nielsen wrote: > > Hey Robert; BenH helped out and wrote a PoC patch here > > https://reviews.apache.org/r/35405 > > > > In short; it is not safe to delete the detector at this point. The patch > > above does it in join() and has a good descriptive block

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

> On Aug. 21, 2015, 11:35 a.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, lines 917-920 > > > > > > I think the name `Unavailability` is too specific to maintenance, how > > about something more gene

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

> On Aug. 24, 2015, 5:53 p.m., Cong Wang wrote: > > src/linux/perf.cpp, line 418 > > > > > > This is not expected, right? > > Paul Brett wrote: > It would be a rare event but not completly unexpected. After all

Re: Review Request 37722: Added definitions of container rootfs directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/ --- (Updated Aug. 24, 2015, 11:26 a.m.) Review request for mesos, Lily Chen, Chi Zh

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 24, 2015, 11:26 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35405: Enable deleting MasterDetector in MesosSchedulerDriver::join.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35405/#review96176 --- Robert; did you still run into problems with the current patch? If s

Re: Review Request 34361: converted hard-coded strings to consts

> On June 9, 2015, 6:25 p.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, lines 3031-3034 > > > > > > Why bother with all this? Why not just have `"key1"`, `"value1"`, > > `"key2"`, `"value2"` inlined appropria

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

> On Aug. 24, 2015, 5:53 p.m., Cong Wang wrote: > > src/linux/perf.cpp, line 418 > > > > > > This is not expected, right? It would be a rare event but not completly unexpected. After all, perf can be upgraded whil

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review96172 --- src/linux/perf.cpp (line 418)

Re: Review Request 37479: Move QoS plug-ins to a specified folder like resource_estimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/#review96170 --- Ship it! LGTM, sorry for the long turn around time on this review -

Review Request 37722: Added definitions of container rootfs directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/ --- Review request for mesos, Lily Chen, Chi Zhang, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review96168 --- src/tests/containerizer/perf_tests.cpp (line 52)

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review96166 --- src/linux/perf.cpp (line 418)

Re: Review Request 37427: Docker registry: adding TokenManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 24, 2015, 5:16 p.m.) Review request for mesos, Lily Chen, Joris V

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 24, 2015, 3:05 p.m., Alexander Rojas wrote: > > src/linux/cgroups.cpp, line 1750 > > > > > > Not sure if `chain` needs to be an attribute. The only reason I see is > > the discard call in `finalize()`. B

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96139 --- Given the rather complicated setup of this ( destroy -> Destroyer -.

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96144 --- src/linux/cgroups.cpp (lines 1486 - 1487)

  1   2   >