Re: Review Request 41318: Fixed a connection leak in ProcessTest.Http1.

> On Dec. 13, 2015, 11:55 a.m., Alexander Rojas wrote: > > Ship It! to clarify, it is a fiix-it the. ship it. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41318/#review110116

Re: Review Request 41318: Fixed a connection leak in ProcessTest.Http1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41318/#review110116 --- Ship it! Ship It! - Alexander Rojas On Dec. 13, 2015, 12:11

Re: Review Request 41320: Clarified Subprocess PIPE usage in Subprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41320/#review110117 --- Ship it! Ship It! - Alexander Rojas On Dec. 13, 2015, 12:11

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated Dec. 13, 2015, 11:35 a.m.) Review request for mesos, Artem

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 14, 2015, 2:14 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 431 > > > > > > Honestly, I'd like to separate optimistic resources into other counter > > in allocator; it's a

Re: Review Request 41254: Enable master get ALLOCATION_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41254/ --- (Updated Dec. 13, 2015, 3:08 p.m.) Review request for mesos, Artem

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41250/ --- (Updated Dec. 13, 2015, 3:08 p.m.) Review request for mesos, Artem

Review Request 41326: Fixed error in authentication cleanup function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41326/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.

Review Request 41327: Fixed a race in Authentication tests where it was possible to connect to a non yet routed endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41327/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Repository:

Re: Review Request 40966: Corrected termination of Docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40966/#review110120 --- Patch looks great! Reviews applied: [40966] Passed command:

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Dec. 13, 2015, 11:28 p.m.) Review request for mesos and Michael Park.

Re: Review Request 41327: Fixed a race in Authentication tests where it was possible to connect to a non yet routed endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41327/ --- (Updated Dec. 13, 2015, 5:34 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41212: Adjust timeout value in HealthCheckTest.CheckCommandTimeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41212/#review110121 --- Patch looks great! Reviews applied: [41212] Passed command:

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41308/#review110122 --- Patch looks great! Reviews applied: [41302, 41305, 41306, 41308]

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review110125 --- Patch looks great! Reviews applied: [40375, 40379] Passed

Re: Review Request 41318: Fixed a connection leak in ProcessTest.Http1.

> On Dec. 13, 2015, 12:34 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 1778-1794 > > > > > > This test also suffers from the same problem. > > Mind fixing this

Re: Review Request 41275: Introduced a field for specifying grace period in Shutdown Event for Executor V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41275/#review110143 --- include/mesos/executor/executor.proto (line 93)

Re: Review Request 36816: Support HTTP checks in Mesos health check program

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review110144 --- Patch looks great! Reviews applied: [36816] Passed command:

Re: Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41302/#review110152 --- include/mesos/mesos.proto (lines 509 - 512)

Review Request 41334: Added helper functions to filter allocation slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu,

Review Request 41333: Added helper functions to filter usage slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu,

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 14, 2015, 2:14 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 431 > > > > > > Honestly, I'd like to separate optimistic resources into other counter > > in allocator; it's a

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review110154 --- src/master/allocator/mesos/hierarchical.cpp (line 431)

Re: Review Request 41275: Introduced a field for specifying grace period in Shutdown Event for Executor V1 API.

> On Dec. 13, 2015, 11:47 p.m., Qian Zhang wrote: > > include/mesos/executor/executor.proto, line 96 > > > > > > Just a quicky question, how will agent fill this field when it asks the > > executor to shutdown? Is

Re: Review Request 41299: Allow DockerContainerizer log to console.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review110156 --- Patch looks great! Reviews applied: [41299] Passed command:

Re: Review Request 40529: Added helper function to get stateless resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated Dec. 14, 2015, 5:56 a.m.) Review request for mesos, Artem

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated Dec. 14, 2015, 6:05 a.m.) Review request for mesos, Artem

Re: Review Request 41246: Enabled slave get USAGE_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41246/ --- (Updated Dec. 14, 2015, 6:48 a.m.) Review request for mesos, Artem

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41306/#review110172 --- src/master/validation.cpp

Re: Review Request 41254: Enabled master get ALLOCATION_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41254/ --- (Updated Dec. 14, 2015, 7:15 a.m.) Review request for mesos, Artem

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

> On Dec. 14, 2015, 2:14 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 431 > > > > > > Honestly, I'd like to separate optimistic resources into other counter > > in allocator; it's a

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/#review110166 --- src/master/master.cpp (line 2830)

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated Dec. 14, 2015, 6:31 a.m.) Review request for mesos, Artem

Re: Review Request 41333: Added helper functions to filter usage slack resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/#review110171 --- src/v1/resources.cpp (line 696)

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated Dec. 14, 2015, 6:41 a.m.) Review request for mesos, Artem

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41250/ --- (Updated Dec. 14, 2015, 7:13 a.m.) Review request for mesos, Artem

Re: Review Request 41254: Enable master get ALLOCATION_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41254/ --- (Updated Dec. 14, 2015, 7:13 a.m.) Review request for mesos, Artem

Re: Review Request 41248: Enabled master get USAGE_SLACK metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41248/ --- (Updated Dec. 14, 2015, 7:13 a.m.) Review request for mesos, Artem

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41306/#review110175 --- src/slave/slave.cpp