Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43263/ --- (Updated Feb. 6, 2016, 7:02 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-06 Thread Kapil Arya
> On Feb. 5, 2016, 8:51 p.m., Ben Mahler wrote: > > site/README.md, lines 27-31 > > > > > > Does this need to be removed by the user at some point? Can this be > > permanently set? Tricky for me to figure out what

Re: Review Request 43127: Introduced Appc image cache.

2016-02-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43127/ --- (Updated Feb. 6, 2016, 11:11 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43122/ --- (Updated Feb. 6, 2016, 6:30 p.m.) Review request for mesos, Joseph Wu and Neil

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/#review118161 --- Patch looks great! Reviews applied: [43283, 43284] Passed

Re: Review Request 43200: Updated role documentation.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review118158 --- Patch looks great! Reviews applied: [43199, 43200] Passed

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43267/#review118159 --- Patch looks great! Reviews applied: [43267] Passed command:

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/#review118154 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/ --- Review request for mesos and Jan Schlicht. Bugs: MESOS-4039

Review Request 43289: Add missing mesos/appc/spec.proto in CMakefile.txt.

2016-02-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43289/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4617

Review Request 43284: Wait for perf statistics processes exit.

2016-02-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- Review request for mesos and Jan Schlicht. Bugs: MESOS-4039

Review Request 43285: Fixed flakiness in SlaveRecoveryTest/0.CleanupHTTPExecutor.

2016-02-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43285/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4614

Review Request 43288: Re-enabled test ExamplesTest.EventCallFramework.

2016-02-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43288/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3273

Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

2016-02-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43286/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3273

Re: Review Request 43285: Fixed flakiness in SlaveRecoveryTest/0.CleanupHTTPExecutor.

2016-02-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43285/#review118149 --- Ship it! Ship It! - haosdent huang On 二月 6, 2016, 5:51

Re: Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

2016-02-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43286/#review118150 --- Ship it! Ship It! - haosdent huang On 二月 6, 2016, 5:51

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Maged Michael
> On Feb. 6, 2016, 10:11 a.m., Guangya Liu wrote: > > docs/configuration.md, lines 1679-1682 > > > > > > How about: Libprocess will normally use a thread pool sized according > > to the number of active CPUs. This

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Maged Michael
> On Feb. 6, 2016, 10:11 a.m., Guangya Liu wrote: > > docs/configuration.md, lines 1679-1682 > > > > > > How about: Libprocess will normally use a thread pool sized according > > to the number of active CPUs. This

Re: Review Request 42998: Added docs for shareable resources.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42998/#review118146 --- Patch looks great! Reviews applied: [42992, 42993, 42994, 42995,

Re: Review Request 43272: Modify the containerizer, fetcher, and container logger's environment.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43272/#review118152 --- Patch looks great! Reviews applied: [43260, 43261, 43271, 43272]

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Guangya Liu
> On 二月 6, 2016, 10:11 a.m., Guangya Liu wrote: > > docs/configuration.md, lines 1679-1682 > > > > > > How about: Libprocess will normally use a thread pool sized according > > to the number of active CPUs. This

Re: Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

2016-02-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43159/#review118166 --- Ship it! Ship It! - Klaus Ma On Feb. 4, 2016, 7:11 a.m.,

Review Request 43292: Fixed cleanup logic in `cgroups/net_cls` isolator.

2016-02-06 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43292/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4345

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review118168 --- @Maged, I think that you can now find a shephard for this. You

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Maged Michael
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 7, 2016, 3:34 a.m.) Review request for mesos, Guangya Liu, Klaus

Re: Review Request 43288: Re-enabled test ExamplesTest.EventCallFramework.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43288/#review118162 --- Patch looks great! Reviews applied: [43285, 43286, 43287, 43288]

Re: Review Request 43289: Add missing mesos/appc/spec.proto in CMakefile.txt.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43289/#review118163 --- Patch looks great! Reviews applied: [43289] Passed command:

Re: Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

2016-02-06 Thread Klaus Ma
> On Feb. 7, 2016, 11:29 a.m., Klaus Ma wrote: > > Ship It! Add test case for duplicated keys in our output: did not prase json, just `std::count` should be OK. - Klaus --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43263/#review118170 --- Patch looks great! Reviews applied: [43120, 43121, 43122, 43263]

Re: Review Request 43292: Fixed cleanup logic in `cgroups/net_cls` isolator.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43292/#review118171 --- Patch looks great! Reviews applied: [43292] Passed command:

Review Request 43293: Ignored invalid env vars.

2016-02-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43293/ --- Review request for mesos, Jie Yu and Timothy Chen. Bugs: MESOS-4607

Re: Review Request 43293: Ignored invalid env vars.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43293/#review118173 --- Patch looks great! Reviews applied: [43293] Passed command:

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review118141 --- docs/configuration.md (lines 1679 - 1682)

Re: Review Request 42946: Replaced tabs with spaces in configure.ac.

2016-02-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/#review118142 --- ping @Joris, any comments on this? - Klaus Ma On Jan. 29,

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

2016-02-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43267/#review118143 --- src/slave/http.cpp (line 402)

Re: Review Request 43199: Updated authorization documentation.

2016-02-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/#review118140 --- docs/authorization.md (line 50)