Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-06 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/
---

(Updated Feb. 6, 2016, 7:02 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Updated readme.


Summary (updated)
-

Updated site building instructions in site/README.md.


Repository: mesos


Description (updated)
---

See summary.


Diffs (updated)
-

  site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9 

Diff: https://reviews.apache.org/r/43263/diff/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-06 Thread Kapil Arya 


> On Feb. 5, 2016, 8:51 p.m., Ben Mahler wrote:
> > site/README.md, lines 27-31
> > 
> >
> > Does this need to be removed by the user at some point? Can this be 
> > permanently set? Tricky for me to figure out what this is for, would help 
> > to explain why this needs to be set in the comment here.

I have updated the README with the explanation. To summarize, we need this 
change for proper linking for markdown files in the doxygen introduction page.

As I noted in the README, may be we should just drop markdown files from 
doxygen. They don't serve any purpose in there since we already have them as 
part of [Mesos documentation](http://mesos.apache.org/documentation/latest). If 
we drop markdown files from doxygen, we don't need to change this 
`STRIP_FROM_PATH` flag.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/#review118121
---


On Feb. 6, 2016, 7:02 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43263/
> ---
> 
> (Updated Feb. 6, 2016, 7:02 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9 
> 
> Diff: https://reviews.apache.org/r/43263/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43127: Introduced Appc image cache.

2016-02-06 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43127/
---

(Updated Feb. 6, 2016, 11:11 p.m.)


Review request for mesos and Jie Yu.


Changes
---

rebase; added imageid to cache key.


Bugs: MESOS-4439 and MESOS-4575
https://issues.apache.org/jira/browse/MESOS-4439
https://issues.apache.org/jira/browse/MESOS-4575


Repository: mesos


Description
---

Image cache will cache metadata about all Appc images stores in the store's
image directory. This cache could be useful to:
  - Quickly query if an image is present in the store.
  - By sharing the cache with other components like fetcher, an image can be
  checked if its present before fetching it.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/appc/cache.hpp 
4a63d479d3328605bac08fddffe190dbe21ad2b7 
  src/slave/containerizer/mesos/provisioner/appc/cache.cpp 
af69db3cdfea05c72ecc6ed18adc9ce520ecdd7e 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
1f9b573f9388aafff3304358b8822a48075afb44 
  src/tests/containerizer/provisioner_appc_tests.cpp 
012dba4e24b9a94dc8da0d329baf4bec2d33ffca 

Diff: https://reviews.apache.org/r/43127/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-06 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43122/
---

(Updated Feb. 6, 2016, 6:30 p.m.)


Review request for mesos, Joseph Wu and Neil Conway.


Bugs: MESOS-4584
https://issues.apache.org/jira/browse/MESOS-4584


Repository: mesos


Description (updated)
---

There are three components to generating new doxygen pages:

1. Now that we have a Doxyfile, pass it to `doxygen` command.
2. Genarate doxygen pages in a diretcory named `doxygen` in the current 
directory.
3. Once the doxygen pages have been generated, move them into 
`publish/api/latest/c++`.

After step 3, one can copy over the publish directory to mesos-site svn 
repository.


Diffs
-

  site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 

Diff: https://reviews.apache.org/r/43122/diff/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/#review118161
---



Patch looks great!

Reviews applied: [43283, 43284]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 6, 2016, 5:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43284/
> ---
> 
> (Updated Feb. 6, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Paul Brett.
> 
> 
> Bugs: MESOS-4039
> https://issues.apache.org/jira/browse/MESOS-4039
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wait for perf statistics processes exit.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
> 65e731886b9e5cac07ae3ad6398faf8f50de5650 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
> 5ef4ae5c468580352cd16e7716b9ca4c0acde659 
> 
> Diff: https://reviews.apache.org/r/43284/diff/
> 
> 
> Testing
> ---
> 
> Without this patch, when running 
> ```
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
> ```
> , would got this error
> ```
> [--] Global test environment tear-down
> ../../src/tests/environment.cpp:732: Failure
> Failed
> Tests completed with child processes remaining:
> -+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
> --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
>  |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
> --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
>  | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event 
> cycles --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock 
> --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
>  |   --- 16584 sleep 0.25
>  --- 16581 ()
> [==] 1 test from 1 test case ran. (4095 ms total)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43200: Updated role documentation.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43200/#review118158
---



Patch looks great!

Reviews applied: [43199, 43200]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 6, 2016, 3:47 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43200/
> ---
> 
> (Updated Feb. 6, 2016, 3:47 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated role documentation.
> 
> Added information on the distinction between roles and principals.
> 
> 
> Diffs
> -
> 
>   docs/roles.md c84a483259922be01d1686befd01b7b1c4005bbd 
> 
> Diff: https://reviews.apache.org/r/43200/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43267/#review118159
---



Patch looks great!

Reviews applied: [43267]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 5, 2016, 10:46 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43267/
> ---
> 
> (Updated Feb. 5, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-4066
> https://issues.apache.org/jira/browse/MESOS-4066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This will help operators hitting the /state endpoint by not returning 
> incomplete
> data when slave is still recoverying.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 9167030e77efc7e1d0dc0c6bd800d20ba9c55e3c 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
> 
> Diff: https://reviews.apache.org/r/43267/diff/
> 
> 
> Testing
> ---
> 
> make -j3 check GTEST_FILTER="*StateEndpointUnavailableDuringRecovery*"
> 
> ./bin/mesos-tests.sh 
> --gtest_filter="*StateEndpointUnavailableDuringRecovery*" --gtest_repeat=1000 
> --gtest_break_on_failure
> 
> ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43269/#review118154
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On Feb. 6, 2016, 12:20 a.m., Mark Cavage wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43269/
> ---
> 
> (Updated Feb. 6, 2016, 12:20 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MasterContender/MasterDetector loadable as modules.
> 
> There is a large set of changes here, mostly due to a namespace rename. The 
> previous version had the MasterContender/Detector APIs under an internal 
> namespace, which didn't seem appropriate for an external contract. So the 
> actual code changes that were impactful are relatively surgical, with then a 
> wide ranging downstream cleanup to make the existing code base reference the 
> new location.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/contender.hpp PRE-CREATION 
>   include/mesos/master/detector.hpp PRE-CREATION 
>   include/mesos/module/contender.hpp PRE-CREATION 
>   include/mesos/module/detector.hpp PRE-CREATION 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/Makefile.am 22f51319a1c06da02cac5822d42315e3027cf500 
>   src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
>   src/examples/test_contender_module.cpp PRE-CREATION 
>   src/examples/test_detector_module.cpp PRE-CREATION 
>   src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
>   src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
>   src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
>   src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 
>   src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
>   src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 
>   src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
>   src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
>   src/slave/slave.hpp a3830ff460a6f6c5661fb8a0172fae303b245889 
>   src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 
>   src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
>   src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
>   src/tests/fault_tolerance_tests.cpp 
> 982468f851cd9d95eb6cde7c57f2d737d46a827c 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
>   src/tests/master_authorization_tests.cpp 
> 29c89fb11da792c3e71eb880a19657ea225b3cc8 
>   src/tests/master_contender_detector_tests.cpp 
> 6375586c31b1fd406529bf299dad6e321b945de8 
>   src/tests/master_slave_reconciliation_tests.cpp 
> d41178eb41df519073fc0890c5716bbc9fed6ad2 
>   src/tests/master_tests.cpp 0357b1c259472213181a65e5adbe6d5caa1698ad 
>   src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/oversubscription_tests.cpp 
> c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb 
>   src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 
>   src/tests/persistent_volume_tests.cpp 
> cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 
>   src/tests/reconciliation_tests.cpp 1cbc3230d003a84277b91da6470828ebf73ef897 
>   src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 
>   src/tests/scheduler_event_call_tests.cpp 
> bd8920fa9d5475e5f6533c8424ebff1588bfe645 
>   src/tests/scheduler_http_api_tests.cpp 
> 9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 
>   src/tests/slave_recovery_tests.cpp bccdf37ced5de8e759c6abb91337e7bfecc77b77 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
> 
> Diff: https://reviews.apache.org/r/43269/diff/
> 
> 
> Testing
> ---
> 
> In addition to all unit tests passing, we are currently using this 
> functionality in our environment with a custom consensus stack. In our world, 
> we have a C++ plugin that calls out to an HTTP REST service (implemented in 
> Java/Scala, not that it matters).
> 
> 
> Thanks,
> 
> Mark Cavage
> 
>

Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
---

Review request for mesos and Jan Schlicht.


Bugs: MESOS-4039
https://issues.apache.org/jira/browse/MESOS-4039


Repository: mesos


Description
---

Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.


Diffs
-

  src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 

Diff: https://reviews.apache.org/r/43283/diff/


Testing
---


Thanks,

haosdent huang

Review Request 43289: Add missing mesos/appc/spec.proto in CMakefile.txt.

2016-02-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43289/
---

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-4617
https://issues.apache.org/jira/browse/MESOS-4617


Repository: mesos


Description
---

Add missing mesos/appc/spec.proto in CMakefile.txt.


Diffs
-

  src/CMakeLists.txt 4a2954498efa48a4eb43f82827ff1d6f5f65d389 

Diff: https://reviews.apache.org/r/43289/diff/


Testing
---


Thanks,

haosdent huang

Review Request 43284: Wait for perf statistics processes exit.

2016-02-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/
---

Review request for mesos and Jan Schlicht.


Bugs: MESOS-4039
https://issues.apache.org/jira/browse/MESOS-4039


Repository: mesos


Description
---

Wait for perf statistics processes exit.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
65e731886b9e5cac07ae3ad6398faf8f50de5650 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
5ef4ae5c468580352cd16e7716b9ca4c0acde659 

Diff: https://reviews.apache.org/r/43284/diff/


Testing
---

Without this patch, when running 
```
sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
```
, would got this error
```
[--] Global test environment tear-down
../../src/tests/environment.cpp:732: Failure
Failed
Tests completed with child processes remaining:
-+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 |-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests 
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
 | -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event cycles 
--cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock --cgroup 
mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
 |   --- 16584 sleep 0.25
 --- 16581 ()
[==] 1 test from 1 test case ran. (4095 ms total)
```


Thanks,

haosdent huang

Review Request 43285: Fixed flakiness in SlaveRecoveryTest/0.CleanupHTTPExecutor.

2016-02-06 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43285/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4614
https://issues.apache.org/jira/browse/MESOS-4614


Repository: mesos


Description
---

This change fixes the flakiness in this test. The issue was a race between the 
`connected` callback being called before we did `process::spawn` to start the 
process.

The details of the race that lead to the failure are as follows:
- We started the executor library inside the constructor of `TestExecutor`. The 
callback function did `process::defer(self(), ::connected)`
- The `connected` callback can be invoked by the Executor library before we got 
a chance to actually invoke `process::spawn` on the `TestExecutor` process 
itself. This in can turn lead to the `dispatch` being silently dropped.
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/process.cpp#L2456

This change now starts the library inside the `initialize` function that is 
gurranteed to be called after `process::spawn` is invoked.


Diffs
-

  src/examples/test_http_executor.cpp 4916e0ebb7215d911556561a8560d78a1192001c 

Diff: https://reviews.apache.org/r/43285/diff/


Testing
---

make check + The flakiness is really easy to reproduce under load:

- Run the tests with `stress --cpu 4 --timeout 120` running in the background.


Thanks,

Anand Mazumdar

Review Request 43288: Re-enabled test ExamplesTest.EventCallFramework.

2016-02-06 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43288/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3273
https://issues.apache.org/jira/browse/MESOS-3273


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/examples_tests.cpp a9b685b0290f23461f43b12f05f6071fa46412a6 

Diff: https://reviews.apache.org/r/43288/diff/


Testing
---

make check + testing done using steps on r43285


Thanks,

Anand Mazumdar

Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

2016-02-06 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43286/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3273
https://issues.apache.org/jira/browse/MESOS-3273


Repository: mesos


Description
---

See summary. The root cause is similar to r43285.


Diffs
-

  src/examples/event_call_framework.cpp 
8cfe1a0794b476bc099b067a9aeb79f099bbc18c 

Diff: https://reviews.apache.org/r/43286/diff/


Testing
---

make check + testing steps done in r43285


Thanks,

Anand Mazumdar

Re: Review Request 43285: Fixed flakiness in SlaveRecoveryTest/0.CleanupHTTPExecutor.

2016-02-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43285/#review118149
---


Ship it!




Ship It!

- haosdent huang


On 二月 6, 2016, 5:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43285/
> ---
> 
> (Updated 二月 6, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4614
> https://issues.apache.org/jira/browse/MESOS-4614
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change fixes the flakiness in this test. The issue was a race between 
> the `connected` callback being called before we did `process::spawn` to start 
> the process.
> 
> The details of the race that lead to the failure are as follows:
> - We started the executor library inside the constructor of `TestExecutor`. 
> The callback function did `process::defer(self(), ::connected)`
> - The `connected` callback can be invoked by the Executor library before we 
> got a chance to actually invoke `process::spawn` on the `TestExecutor` 
> process itself. This in can turn lead to the `dispatch` being silently 
> dropped.
> https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/process.cpp#L2456
> 
> This change now starts the library inside the `initialize` function that is 
> gurranteed to be called after `process::spawn` is invoked.
> 
> 
> Diffs
> -
> 
>   src/examples/test_http_executor.cpp 
> 4916e0ebb7215d911556561a8560d78a1192001c 
> 
> Diff: https://reviews.apache.org/r/43285/diff/
> 
> 
> Testing
> ---
> 
> make check + The flakiness is really easy to reproduce under load:
> 
> - Run the tests with `stress --cpu 4 --timeout 120` running in the background.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

2016-02-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43286/#review118150
---


Ship it!




Ship It!

- haosdent huang


On 二月 6, 2016, 5:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43286/
> ---
> 
> (Updated 二月 6, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3273
> https://issues.apache.org/jira/browse/MESOS-3273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. The root cause is similar to r43285.
> 
> 
> Diffs
> -
> 
>   src/examples/event_call_framework.cpp 
> 8cfe1a0794b476bc099b067a9aeb79f099bbc18c 
> 
> Diff: https://reviews.apache.org/r/43286/diff/
> 
> 
> Testing
> ---
> 
> make check + testing steps done in r43285
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Maged Michael 


> On Feb. 6, 2016, 10:11 a.m., Guangya Liu wrote:
> > docs/configuration.md, lines 1679-1682
> > 
> >
> > How about: Libprocess will normally use a thread pool sized according 
> > to the number of active CPUs. This can be overridden by setting the 
> > LIBPROCESS_MAX_WORKER_THREADS environment variable to the desired thread 
> > count. Normally, this will provides an upper bound on the number of worker 
> > threads.

The setting is always an upper bound. I tried to follow the same form of the 
descriptions of other environment variables "If set, ...".
How about the following?
  If set, this provides an upper bound on the size of the
  libprocess thread pool. By default, libprocess uses a thread
  pool sized according to the number of CPUs, but not less than 8.


- Maged


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review118141
---


On Feb. 5, 2016, 9:46 p.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> ---
> 
> (Updated Feb. 5, 2016, 9:46 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, and Qian Zhang.
> 
> 
> Bugs: MESOS-4353
> https://issues.apache.org/jira/browse/MESOS-4353
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added env var to set upper bound on number of libprocess worker threads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp d8a74d7 
>   docs/configuration.md 4b5a394 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> ---
> 
> Passed make check on x86_64 Ubuntu 14.04.
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as 
> expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. 
> The last 3 tests generated warnings.
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Maged Michael 


> On Feb. 6, 2016, 10:11 a.m., Guangya Liu wrote:
> > docs/configuration.md, lines 1679-1682
> > 
> >
> > How about: Libprocess will normally use a thread pool sized according 
> > to the number of active CPUs. This can be overridden by setting the 
> > LIBPROCESS_MAX_WORKER_THREADS environment variable to the desired thread 
> > count. Normally, this will provides an upper bound on the number of worker 
> > threads.
> 
> Maged Michael wrote:
> The setting is always an upper bound. I tried to follow the same form of 
> the descriptions of other environment variables "If set, ...".
> How about the following?
>   If set, this provides an upper bound on the size of the
>   libprocess thread pool. By default, libprocess uses a thread
>   pool sized according to the number of CPUs, but not less than 8.

How about?
  If set to a positive integer value, this provides an upper bound
  on the size of the libprocess thread pool. By default,
  libprocess uses a thread pool sized according to the number of
  CPUs, but not less than 8.  If set to a valid value, the size of
  the thread pool is min(value, max(8, number of
  CPUs)). Otherwise, it is max(8, number of CPUs).


- Maged


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review118141
---


On Feb. 5, 2016, 9:46 p.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> ---
> 
> (Updated Feb. 5, 2016, 9:46 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, and Qian Zhang.
> 
> 
> Bugs: MESOS-4353
> https://issues.apache.org/jira/browse/MESOS-4353
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added env var to set upper bound on number of libprocess worker threads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp d8a74d7 
>   docs/configuration.md 4b5a394 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> ---
> 
> Passed make check on x86_64 Ubuntu 14.04.
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as 
> expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. 
> The last 3 tests generated warnings.
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Re: Review Request 42998: Added docs for shareable resources.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42998/#review118146
---



Patch looks great!

Reviews applied: [42992, 42993, 42994, 42995, 42996, 42997, 42998]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 5, 2016, 10:59 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42998/
> ---
> 
> (Updated Feb. 5, 2016, 10:59 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4325
> https://issues.apache.org/jira/browse/MESOS-4325
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs for shareable resources.
> 
> 
> Diffs
> -
> 
>   docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88 
>   docs/shareable-resources.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42998/diff/
> 
> 
> Testing
> ---
> 
> Just documentation changes in this RR.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 43272: Modify the containerizer, fetcher, and container logger's environment.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43272/#review118152
---



Patch looks great!

Reviews applied: [43260, 43261, 43271, 43272]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 5, 2016, 11:25 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43272/
> ---
> 
> (Updated Feb. 5, 2016, 11:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4609
> https://issues.apache.org/jira/browse/MESOS-4609
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Delegates some of the environment logic in the containerizer and fetcher to 
> the `subprocess_environment` helper.
> Changes the logrotate container logger to use the default `environment` for 
> `subprocess`.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 01a3ff031b70366443214e2895803cd4b2606ad8 
>   src/slave/containerizer/containerizer.cpp 
> 59904684cdeb17ef2b42092a3558802c42bfb6bd 
>   src/slave/containerizer/fetcher.cpp 
> 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161 
> 
> Diff: https://reviews.apache.org/r/43272/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Guangya Liu 


> On 二月 6, 2016, 10:11 a.m., Guangya Liu wrote:
> > docs/configuration.md, lines 1679-1682
> > 
> >
> > How about: Libprocess will normally use a thread pool sized according 
> > to the number of active CPUs. This can be overridden by setting the 
> > LIBPROCESS_MAX_WORKER_THREADS environment variable to the desired thread 
> > count. Normally, this will provides an upper bound on the number of worker 
> > threads.
> 
> Maged Michael wrote:
> The setting is always an upper bound. I tried to follow the same form of 
> the descriptions of other environment variables "If set, ...".
> How about the following?
>   If set, this provides an upper bound on the size of the
>   libprocess thread pool. By default, libprocess uses a thread
>   pool sized according to the number of CPUs, but not less than 8.
> 
> Maged Michael wrote:
> How about?
>   If set to a positive integer value, this provides an upper bound
>   on the size of the libprocess thread pool. By default,
>   libprocess uses a thread pool sized according to the number of
>   CPUs, but not less than 8.  If set to a valid value, the size of
>   the thread pool is min(value, max(8, number of
>   CPUs)). Otherwise, it is max(8, number of CPUs).

What about the following? I think that we can remove the first sentense.
  This provides an upper bound on the size of the libprocess thread pool. 
By default,
  libprocess uses a thread pool sized according to the number of
  CPUs, but not less than 8.  If set to a valid value, the size of
  the thread pool is min(value, max(8, number of
  CPUs)). Otherwise, it is max(8, number of CPUs).


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review118141
---


On 二月 5, 2016, 9:46 p.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> ---
> 
> (Updated 二月 5, 2016, 9:46 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, and Qian Zhang.
> 
> 
> Bugs: MESOS-4353
> https://issues.apache.org/jira/browse/MESOS-4353
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added env var to set upper bound on number of libprocess worker threads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp d8a74d7 
>   docs/configuration.md 4b5a394 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> ---
> 
> Passed make check on x86_64 Ubuntu 14.04.
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as 
> expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. 
> The last 3 tests generated warnings.
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Re: Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

2016-02-06 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43159/#review118166
---


Ship it!




Ship It!

- Klaus Ma


On Feb. 4, 2016, 7:11 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43159/
> ---
> 
> (Updated Feb. 4, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4582
> https://issues.apache.org/jira/browse/MESOS-4582
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new `jsonify` library is a writer-based approach, and does not keep track 
> of the fields that have been written out so far.
> The previous version of `summarize(framework)` and `model(framework)` had a 
> duplicate `"active"` field which was de-duplicated since they simply get 
> inserted to a `std::map`, overriding the previous value.
> 
> In the `jsonify` case, this pattern results in duplicate key in the JSON 
> output. Although the presence of duplicate keys is technically not 
> __invalid__ according to the JSON specification, some JSON libraries disallow 
> them.
> As such, we should generate JSON outputs without duplicate keys.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3d7a624b78fd85a8d99bce609e37411ed660678c 
> 
> Diff: https://reviews.apache.org/r/43159/diff/
> 
> 
> Testing
> ---
> 
> Verified that `make check` __with__ https://reviews.apache.org/r/43160/ + 
> https://reviews.apache.org/r/43161/ and __without__ this patch breaks.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 43292: Fixed cleanup logic in `cgroups/net_cls` isolator.

2016-02-06 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43292/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4345
https://issues.apache.org/jira/browse/MESOS-4345


Repository: mesos


Description
---

We should be responsible for freeing a handle only if the handle
manager is set.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
fd674090d4b7f22b98571b693d71493d71b8e05e 

Diff: https://reviews.apache.org/r/43292/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review118168
---



@Maged, I think that you can now find a shephard for this. You can post an 
email to d...@mesos.apache.org to ask for a shephard for MESOS-4353

- Guangya Liu


On 二月 7, 2016, 3:34 a.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> ---
> 
> (Updated 二月 7, 2016, 3:34 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, and Qian Zhang.
> 
> 
> Bugs: MESOS-4353
> https://issues.apache.org/jira/browse/MESOS-4353
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added env var to set upper bound on number of libprocess worker threads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp d8a74d7 
>   docs/configuration.md 4b5a394 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> ---
> 
> Passed make check on x86_64 Ubuntu 14.04.
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as 
> expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. 
> The last 3 tests generated warnings.
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Maged Michael 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/
---

(Updated Feb. 7, 2016, 3:34 a.m.)


Review request for mesos, Guangya Liu, Klaus Ma, and Qian Zhang.


Bugs: MESOS-4353
https://issues.apache.org/jira/browse/MESOS-4353


Repository: mesos


Description
---

Added env var to set upper bound on number of libprocess worker threads.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp d8a74d7 
  docs/configuration.md 4b5a394 

Diff: https://reviews.apache.org/r/43144/diff/


Testing
---

Passed make check on x86_64 Ubuntu 14.04.

Invocations of mesos-master, mesos-slave, and mesos-tests with the 
LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
"-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as 
expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. 
The last 3 tests generated warnings.


Thanks,

Maged Michael

Re: Review Request 43288: Re-enabled test ExamplesTest.EventCallFramework.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43288/#review118162
---



Patch looks great!

Reviews applied: [43285, 43286, 43287, 43288]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 6, 2016, 5:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43288/
> ---
> 
> (Updated Feb. 6, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3273
> https://issues.apache.org/jira/browse/MESOS-3273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/examples_tests.cpp a9b685b0290f23461f43b12f05f6071fa46412a6 
> 
> Diff: https://reviews.apache.org/r/43288/diff/
> 
> 
> Testing
> ---
> 
> make check + testing done using steps on r43285
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43289: Add missing mesos/appc/spec.proto in CMakefile.txt.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43289/#review118163
---



Patch looks great!

Reviews applied: [43289]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 6, 2016, 6:50 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43289/
> ---
> 
> (Updated Feb. 6, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4617
> https://issues.apache.org/jira/browse/MESOS-4617
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add missing mesos/appc/spec.proto in CMakefile.txt.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 4a2954498efa48a4eb43f82827ff1d6f5f65d389 
> 
> Diff: https://reviews.apache.org/r/43289/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

2016-02-06 Thread Klaus Ma 


> On Feb. 7, 2016, 11:29 a.m., Klaus Ma wrote:
> > Ship It!

Add test case for duplicated keys in our output: did not prase json, just 
`std::count` should be OK.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43159/#review118166
---


On Feb. 4, 2016, 7:11 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43159/
> ---
> 
> (Updated Feb. 4, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4582
> https://issues.apache.org/jira/browse/MESOS-4582
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new `jsonify` library is a writer-based approach, and does not keep track 
> of the fields that have been written out so far.
> The previous version of `summarize(framework)` and `model(framework)` had a 
> duplicate `"active"` field which was de-duplicated since they simply get 
> inserted to a `std::map`, overriding the previous value.
> 
> In the `jsonify` case, this pattern results in duplicate key in the JSON 
> output. Although the presence of duplicate keys is technically not 
> __invalid__ according to the JSON specification, some JSON libraries disallow 
> them.
> As such, we should generate JSON outputs without duplicate keys.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 3d7a624b78fd85a8d99bce609e37411ed660678c 
> 
> Diff: https://reviews.apache.org/r/43159/diff/
> 
> 
> Testing
> ---
> 
> Verified that `make check` __with__ https://reviews.apache.org/r/43160/ + 
> https://reviews.apache.org/r/43161/ and __without__ this patch breaks.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43263: Updated site building instructions in site/README.md.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43263/#review118170
---



Patch looks great!

Reviews applied: [43120, 43121, 43122, 43263]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 7, 2016, 12:02 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43263/
> ---
> 
> (Updated Feb. 7, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   site/README.md 71ca3ebbc645c6c188223895d12fb436b55038f9 
> 
> Diff: https://reviews.apache.org/r/43263/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 43292: Fixed cleanup logic in `cgroups/net_cls` isolator.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43292/#review118171
---



Patch looks great!

Reviews applied: [43292]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 7, 2016, 1:09 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43292/
> ---
> 
> (Updated Feb. 7, 2016, 1:09 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4345
> https://issues.apache.org/jira/browse/MESOS-4345
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should be responsible for freeing a handle only if the handle
> manager is set.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> fd674090d4b7f22b98571b693d71493d71b8e05e 
> 
> Diff: https://reviews.apache.org/r/43292/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 43293: Ignored invalid env vars.

2016-02-06 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43293/
---

Review request for mesos, Jie Yu and Timothy Chen.


Bugs: MESOS-4607
https://issues.apache.org/jira/browse/MESOS-4607


Repository: mesos


Description
---

Ignored invalid env vars when creating docker image.


Diffs
-

  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/tests/containerizer/docker_tests.cpp 
620819330847a10d9dcd817968df9d2b180a9a29 

Diff: https://reviews.apache.org/r/43293/diff/


Testing
---

make
make check

GLOG_v=2 ./bin/mesos-tests.sh  
--gtest_filter="DockerImageTest.ParseInspectonImage" --verbose
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from DockerImageTest
[ RUN  ] DockerImageTest.ParseInspectonImage
I0207 10:30:01.894125 2034615040 process.cpp:2489] Spawned process 
files@192.168.0.100:49551
I0207 10:30:01.894136 211529728 process.cpp:2499] Resuming 
files@192.168.0.100:49551 at 2016-02-07 02:30:01.894163968+00:00
I0207 10:30:01.894317 210456576 process.cpp:2499] Resuming 
help@192.168.0.100:49551 at 2016-02-07 02:30:01.894332928+00:00
I0207 10:30:01.898862 2034615040 docker.cpp:397] Skipping duplicate environment 
variable: JAVA_VERSION
I0207 10:30:01.898892 2034615040 docker.cpp:390] Skipping invalid environment 
variable: JAVA_VERSION+8u66for 'ContainerConfig.Env'
I0207 10:30:01.899473 20992 process.cpp:2499] Resuming 
AuthenticationRouter(1)@192.168.0.100:49551 at 2016-02-07 
02:30:01.899522048+00:00
I0207 10:30:01.899983 213139456 process.cpp:2499] Resuming 
files@192.168.0.100:49551 at 2016-02-07 02:30:01.9+00:00
I0207 10:30:01.900032 213139456 process.cpp:2604] Cleaning up 
files@192.168.0.100:49551
I0207 10:30:01.900244 211529728 process.cpp:2499] Resuming 
help@192.168.0.100:49551 at 2016-02-07 02:30:01.900256000+00:00
[   OK ] DockerImageTest.ParseInspectonImage (8 ms)
[--] 1 test from DockerImageTest (8 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (18 ms total)
[  PASSED  ] 1 test.


Thanks,

Guangya Liu

Re: Review Request 43293: Ignored invalid env vars.

2016-02-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43293/#review118173
---



Patch looks great!

Reviews applied: [43293]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 7, 2016, 2:35 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43293/
> ---
> 
> (Updated Feb. 7, 2016, 2:35 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4607
> https://issues.apache.org/jira/browse/MESOS-4607
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored invalid env vars when creating docker image.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/tests/containerizer/docker_tests.cpp 
> 620819330847a10d9dcd817968df9d2b180a9a29 
> 
> Diff: https://reviews.apache.org/r/43293/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> GLOG_v=2 ./bin/mesos-tests.sh  
> --gtest_filter="DockerImageTest.ParseInspectonImage" --verbose
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from DockerImageTest
> [ RUN  ] DockerImageTest.ParseInspectonImage
> I0207 10:30:01.894125 2034615040 process.cpp:2489] Spawned process 
> files@192.168.0.100:49551
> I0207 10:30:01.894136 211529728 process.cpp:2499] Resuming 
> files@192.168.0.100:49551 at 2016-02-07 02:30:01.894163968+00:00
> I0207 10:30:01.894317 210456576 process.cpp:2499] Resuming 
> help@192.168.0.100:49551 at 2016-02-07 02:30:01.894332928+00:00
> I0207 10:30:01.898862 2034615040 docker.cpp:397] Skipping duplicate 
> environment variable: JAVA_VERSION
> I0207 10:30:01.898892 2034615040 docker.cpp:390] Skipping invalid environment 
> variable: JAVA_VERSION+8u66for 'ContainerConfig.Env'
> I0207 10:30:01.899473 20992 process.cpp:2499] Resuming 
> AuthenticationRouter(1)@192.168.0.100:49551 at 2016-02-07 
> 02:30:01.899522048+00:00
> I0207 10:30:01.899983 213139456 process.cpp:2499] Resuming 
> files@192.168.0.100:49551 at 2016-02-07 02:30:01.9+00:00
> I0207 10:30:01.900032 213139456 process.cpp:2604] Cleaning up 
> files@192.168.0.100:49551
> I0207 10:30:01.900244 211529728 process.cpp:2499] Resuming 
> help@192.168.0.100:49551 at 2016-02-07 02:30:01.900256000+00:00
> [   OK ] DockerImageTest.ParseInspectonImage (8 ms)
> [--] 1 test from DockerImageTest (8 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (18 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-06 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review118141
---




docs/configuration.md (lines 1679 - 1682)


How about: Libprocess will normally use a thread pool sized according to 
the number of active CPUs. This can be overridden by setting the 
LIBPROCESS_MAX_WORKER_THREADS environment variable to the desired thread count. 
Normally, this will provides an upper bound on the number of worker threads.


- Guangya Liu


On 二月 5, 2016, 9:46 p.m., Maged Michael wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> ---
> 
> (Updated 二月 5, 2016, 9:46 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, and Qian Zhang.
> 
> 
> Bugs: MESOS-4353
> https://issues.apache.org/jira/browse/MESOS-4353
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added env var to set upper bound on number of libprocess worker threads.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp d8a74d7 
>   docs/configuration.md 4b5a394 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> ---
> 
> Passed make check on x86_64 Ubuntu 14.04.
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as 
> expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. 
> The last 3 tests generated warnings.
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Re: Review Request 42946: Replaced tabs with spaces in configure.ac.

2016-02-06 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42946/#review118142
---



ping @Joris, any comments on this?

- Klaus Ma


On Jan. 29, 2016, 4:19 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42946/
> ---
> 
> (Updated Jan. 29, 2016, 4:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4519
> https://issues.apache.org/jira/browse/MESOS-4519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace tabs with spaces in configure.ac.
> 
> 
> Diffs
> -
> 
>   configure.ac cb39c7f 
> 
> Diff: https://reviews.apache.org/r/42946/diff/
> 
> 
> Testing
> ---
> 
> ../configure
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

2016-02-06 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43267/#review118143
---




src/slave/http.cpp (line 402)


For GUI developer, it's better to export more info when it's recovering, 
e.g. build_time, build_date. So I'd like to export agent state in `/state`.



src/tests/slave_tests.cpp (line 1405)


```
driver.stop()
driver.join()
```


- Klaus Ma


On Feb. 6, 2016, 6:46 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43267/
> ---
> 
> (Updated Feb. 6, 2016, 6:46 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-4066
> https://issues.apache.org/jira/browse/MESOS-4066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This will help operators hitting the /state endpoint by not returning 
> incomplete
> data when slave is still recoverying.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 9167030e77efc7e1d0dc0c6bd800d20ba9c55e3c 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
> 
> Diff: https://reviews.apache.org/r/43267/diff/
> 
> 
> Testing
> ---
> 
> make -j3 check GTEST_FILTER="*StateEndpointUnavailableDuringRecovery*"
> 
> ./bin/mesos-tests.sh 
> --gtest_filter="*StateEndpointUnavailableDuringRecovery*" --gtest_repeat=1000 
> --gtest_break_on_failure
> 
> ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 43199: Updated authorization documentation.

2016-02-06 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43199/#review118140
---




docs/authorization.md (line 50)


Do u want to add an example for quota_principals?



docs/authorization.md (line 76)


Can you please add a link here for ACL? 
https://github.com/apache/mesos/blob/master/docs/authorization.md


- Guangya Liu


On 二月 6, 2016, 2:40 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43199/
> ---
> 
> (Updated 二月 6, 2016, 2:40 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated authorization documentation.
> 
> Added information about the distinction between roles and principals, as well 
> as a real-world authorization example.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
> 
> Diff: https://reviews.apache.org/r/43199/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>