Re: Review Request 43569: Updated log message if container not found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/#review119210 --- Patch looks great! Reviews applied: [43569] Passed command:

Re: Review Request 43569: Updated log message if container not found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/ --- (Updated 二月 15, 2016, 4:17 a.m.) Review request for mesos, Jie Yu and Timothy

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review119208 --- src/slave/containerizer/docker.cpp (line 505)

Re: Review Request 43569: Updated log message if container not found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/#review119209 --- Just some flyby comments. src/slave/containerizer/docker.cpp

Re: Review Request 43569: Updated log message if container not found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/#review119206 --- Patch looks great! Reviews applied: [43569] Passed command:

Re: Review Request 43569: Updated log message if container not found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/ --- (Updated 二月 15, 2016, 1:56 a.m.) Review request for mesos, Jie Yu and Timothy

Review Request 43569: Updated log message if container not found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43569/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos

Re: Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

> On 二月 15, 2016, 1:17 a.m., Guangya Liu wrote: > > src/slave/containerizer/composing.cpp, line 513 > > > > > > I was that mesos containizers are using `return Failure("Unknown > > container: " +

Re: Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43565/#review119201 --- src/slave/containerizer/composing.cpp (line 230)

Re: Review Request 43293: Ignored invalid env vars.

> On 二月 14, 2016, 8:42 a.m., Timothy Chen wrote: > > src/tests/containerizer/docker_tests.cpp, lines 506-507 > > > > > > Is this even a valid docker inspect output? > > In what situations will we get this? Yes,

Re: Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- (Updated Feb. 14, 2016, 12:47 p.m.) Review request for mesos and Adam B.

Re: Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review119184 --- Patch looks great! Reviews applied: [42719] Passed command:

Re: Review Request 42719: Add doc for weights.

> On Feb. 10, 2016, 9:03 a.m., Adam B wrote: > > Looks good, but I think we can pull this information into the roles.md and > > endpoint help docs, rather than create a new docs page. Maybe weight will also be supported for framework in the future, so I think it is better to create a new doc

Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43565/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4670

Review Request 43564: Defined `status` method for `ComposingContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43564/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4670

Review Request 43566: Modified `NetClsIsolatorTest` to use `ComposingContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43566/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4670

Re: Review Request 43284: Wait for perf statistics processes exit.

> On Feb. 8, 2016, 10:47 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp, lines > > 132-134 > > > > > > I think you should discard the future and let it do the correct

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Feb. 9, 2016, 7:07 a.m., Adam B wrote: > > src/master/master.cpp, lines 1560-1561 > > > > > > Can you explain more clearly why this needs to be done? Is it because > > we already initialized the allocator

Re: Review Request 43293: Ignored invalid env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43293/#review119173 --- src/tests/containerizer/docker_tests.cpp (lines 506 - 507)

Re: Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42691/#review119174 --- Sorry for the late review, I can't apply the review at this

Re: Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks.

> On Feb. 14, 2016, 8:44 a.m., Timothy Chen wrote: > > Sorry for the late review, I can't apply the review at this moment. Can you > > rebase? I saw current code have already added this. Let me discard this patch. - haosdent --- This

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review119176 --- Patch looks great! Reviews applied: [43015] Passed command:

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review119171 --- Patch looks great! Reviews applied: [43561] Passed command:

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Feb. 14, 2016, 11:37 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Feb. 14, 2016, 12:02 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

> On Feb. 8, 2016, 8:44 p.m., Jie Yu wrote: > > I realized a tricky part in the recovery path while dealing with potential > > conflicts with MesosContainerizer (LinuxFilesystemIsolator). For instance, > > will the LinuxFilesystemIsolator try to umount some persistent volume > > mounts that

Re: Review Request 43015: Fixed persistent volumes with docker tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/ --- (Updated Feb. 14, 2016, 8:38 a.m.) Review request for mesos and Jie Yu.