Re: Review Request 44144: Improved the documentation for setting ACLs.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44144/#review121127
---


Ship it!




Ship It!

- Adam B


On Feb. 27, 2016, 9:49 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44144/
> ---
> 
> (Updated Feb. 27, 2016, 9:49 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved the documentation for setting ACLs.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md feb0ddd6514106f0778db7b5428e47d4d8dc4d42 
> 
> Diff: https://reviews.apache.org/r/44144/diff/
> 
> 
> Testing
> ---
> 
> Checked via gist: https://gist.github.com/joerg84/6c2a86e1b0c378c4c8c9
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

[haosdent huang]

> On Feb. 8, 2016, 10:52 p.m., Ian Downes wrote:
> > src/linux/perf.cpp, lines 423-426
> > 
> >
> > Hmmm, I'm not satisfied with this. I thought the new output format was 
> > introduced at a specific kernel version (3.13.0 might not be correct). 
> > Could you please confirm that the 3.10 on CentOS7.1 has the new unit field 
> > but other 3.10 kernels don't.
> 
> haosdent huang wrote:
> The interesting thing here is I saw `unit` appear since 3.14 
> http://lxr.free-electrons.com/source/tools/perf/util/evsel.h?v=3.14#L72 I 
> think I missing something, let me find out more details about this.
> 
> haosdent huang wrote:
> According 
> https://github.com/torvalds/linux/blob/v3.13/tools/perf/builtin-stat.c#L1190-L1206
>  , I think the `perf stat` format for 3.13.0 also is `value,event,cgroup`.
> The `unit` added in this commit which contains since 3.14. 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=410136f5dd96b6013fe6d1011b523b1c247e1ccb
> Let me try create a virtual machine to verify this.
> 
> haosdent huang wrote:
> I try this in 
> 
> ```
> # cat /etc/issue
> Ubuntu 14.04.3 LTS \n \l
> ```
> 
> Kernel is 
> 
> ```
> uname -a
> Linux haosdent 3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 
> 2014 x86_64 x86_64 x86_64 GNU/Linux
> 
> 
> The `perf stat` output don't contains unit:
> 
> ```
> perf stat --all-cpus --field-separator , --log-fd 1 --event cycles 
> --cgroup mesos --event task-clock --cgroup mesos -- sleep 0.25
> ,cycles,mesos
> ,task-clock,mesos
> ```
> 
> Ian Downes wrote:
> Okay, if I'm understanding you correctly the value,unit,event,cgroup 
> format came in 3.14.0, not 3.13.0 as the current code states. Can we not 
> adjust the cases to correctly match the precise kernel versions?

Sorry, I could not get your idea here. Do you mean we need add a check >= 3.0.0 
?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118314
---


On Feb. 14, 2016, 7:59 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> ---
> 
> (Updated Feb. 14, 2016, 7:59 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4655
> https://issues.apache.org/jira/browse/MESOS-4655
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> ---
> 
> This also fix similar error in 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44042/#review121122
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 25, 2016, 9:16 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44042/
> ---
> 
> (Updated Feb. 25, 2016, 9:16 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> f1d38029eef7e89dfdb8915158fba17865e6855b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 84a2a021859d4e5c8547ad2a509eebda428a8255 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> 625636525ee0fb35214cc3df3a304c40c9a0b0a6 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> d3ba0b4ff5d2d125252389a0f8f618c78aa6d948 
> 
> Diff: https://reviews.apache.org/r/44042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44045/#review121121
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 25, 2016, 10:28 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44045/
> ---
> 
> (Updated Feb. 25, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Style fixes to `stout/include/Makefile.am`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 03eff5a831283f6d298e9a1feecfdc7369cacfe7 
> 
> Diff: https://reviews.apache.org/r/44045/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44046: Windows: Used `evutil_socket_t` typedef for sockets.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44046/#review121120
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 26, 2016, 4:09 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44046/
> ---
> 
> (Updated Feb. 26, 2016, 4:09 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Used `evutil_socket_t` typedef for sockets.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent.cpp 
> c787fa9622a22894535ebe64327dd33cfaf1fcd7 
> 
> Diff: https://reviews.apache.org/r/44046/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44075/#review121119
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44075/
> ---
> 
> (Updated Feb. 26, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3632
> https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Isolated shell argouments in a namespace.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp 
> e0039fdab20ba547dc2bb78c544549c30c535294 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 
> 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b 
> 
> Diff: https://reviews.apache.org/r/44075/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44076/#review121118
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44076/
> ---
> 
> (Updated Feb. 26, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3632
> https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: [2/3] Used `os::execlp` in launch.cpp.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launch.cpp 
> 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 
> 
> Diff: https://reviews.apache.org/r/44076/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44077: Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44077/#review121117
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44077/
> ---
> 
> (Updated Feb. 26, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3632
> https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 
> 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b 
> 
> Diff: https://reviews.apache.org/r/44077/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43822/#review121115
---


Ship it!





src/master/http.cpp (line 1228)


Committed with the `const` qualifier preserved.


- Michael Park


On Feb. 28, 2016, 12:15 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43822/
> ---
> 
> (Updated Feb. 28, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/slaves` master endpoint to use jsonify.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 
> 
> Diff: https://reviews.apache.org/r/43822/diff/
> 
> 
> Testing
> ---
> 
> make check. Also verified that this endpoint is covered by the unit tests.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43817: Removed no-longer-used model functions.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/#review121116
---


Ship it!




Ship It!

- Michael Park


On Feb. 28, 2016, 12:17 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43817/
> ---
> 
> (Updated Feb. 28, 2016, 12:17 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4731
> https://issues.apache.org/jira/browse/MESOS-4731
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These `model()` variants provided functionality that is now
> implemented via jsonify; no more call-sites of the old functions
> remain.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 
> 
> Diff: https://reviews.apache.org/r/43817/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also updated a few comments to not refer to `summarize`.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44047/#review121114
---




docs/persistent-volume.md (lines 372 - 374)


Only the `reserved_resources_full` was mentioned here, what about 
`used_resources_full` and `reserved_resources_full`? I think that those new 
metrics should also be mentioned here to clarify the meaning of them.



docs/reservation.md (lines 363 - 365)


ditto



src/master/http.cpp (line 1043)


s/offered resources/offered resources per agent


- Guangya Liu


On 二月 28, 2016, 12:17 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44047/
> ---
> 
> (Updated 二月 28, 2016, 12:17 a.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-4667
> https://issues.apache.org/jira/browse/MESOS-4667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows operators to list all the dynamic reservations and persistent
> volumes in a cluster. This is important in itself; it also makes it easier to
> use the `/unreserve` and `/destroy-volumes` endpoints.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 
>   docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 
>   src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 08b9102318b826bab9d2c1d389fb80b86949218c 
> 
> Diff: https://reviews.apache.org/r/44047/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43816/#review121113
---


Ship it!




Ship It!

- Michael Park


On Feb. 28, 2016, 12:15 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43816/
> ---
> 
> (Updated Feb. 28, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4731
> https://issues.apache.org/jira/browse/MESOS-4731
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/frameworks` master endpoint to use jsonify.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 
> 
> Diff: https://reviews.apache.org/r/43816/diff/
> 
> 
> Testing
> ---
> 
> 1. make check
> 2. Verified that after introducing a bug into the jsonify version of 
> `frameworks()`, `make check` fails (i.e., the test suite covers the 
> `/frameworks` endpoint).
> 3. Compared output of `/frameworks` with old and new implementation on a test 
> Mesos installation to try to gauge correctness visually.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43938: Required jsonifying of generic protobuf to be explicit opt-in [stout].

[Michael Park]

> On Feb. 26, 2016, 9:38 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 625
> > 
> >
> > Is this the best name for this type? Not sure there's a better name, 
> > but `JSON::Protobuf` doesn't necessarily imply to me that the type names a 
> > certain representation of `google::protobuf::Message`. What about 
> > `JSON::RawProtobuf`?

I'm not sure if it's the best name. At least at the call-site it seems ok to 
me. This is internal anyway, so we can always change it later :)


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43938/#review120963
---


On Feb. 28, 2016, 2:17 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43938/
> ---
> 
> (Updated Feb. 28, 2016, 2:17 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4754
> https://issues.apache.org/jira/browse/MESOS-4754
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Required jsonifying of generic protobuf to be explicit opt-in [stout].
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> eb5502c4987da5593169a86b21f60c01aa5b5170 
>   3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp 
> 22f70f7536c6f5d24ff59228d8ba7bf41319fd4a 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> 8dd9cfd3e7d1e3ab4ace87066a43a3094b776d82 
> 
> Diff: https://reviews.apache.org/r/43938/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 43938: Required jsonifying of generic protobuf to be explicit opt-in [stout].

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43938/
---

(Updated Feb. 28, 2016, 2:17 a.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Neil 
Conway.


Changes
---

Addressed Neil's comment.


Bugs: MESOS-4754
https://issues.apache.org/jira/browse/MESOS-4754


Repository: mesos


Description (updated)
---

Required jsonifying of generic protobuf to be explicit opt-in [stout].


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
eb5502c4987da5593169a86b21f60c01aa5b5170 
  3rdparty/libprocess/3rdparty/stout/include/stout/representation.hpp 
22f70f7536c6f5d24ff59228d8ba7bf41319fd4a 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
8dd9cfd3e7d1e3ab4ace87066a43a3094b776d82 

Diff: https://reviews.apache.org/r/43938/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44047/#review12
---



Patch looks great!

Reviews applied: [43937, 43938, 43939, 43816, 43822, 43823, 43817, 43910, 
43911, 44047]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 28, 2016, 12:17 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44047/
> ---
> 
> (Updated Feb. 28, 2016, 12:17 a.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-4667
> https://issues.apache.org/jira/browse/MESOS-4667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This allows operators to list all the dynamic reservations and persistent
> volumes in a cluster. This is important in itself; it also makes it easier to
> use the `/unreserve` and `/destroy-volumes` endpoints.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 
>   docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 
>   src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 08b9102318b826bab9d2c1d389fb80b86949218c 
> 
> Diff: https://reviews.apache.org/r/44047/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44113: Cleaned up assertions in test cases.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44113/#review121110
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 27, 2016, 1:56 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44113/
> ---
> 
> (Updated Feb. 27, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensure that `EXPECT_EQ` and friends use "expected, actual" as the
> order of arguments.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_spec_tests.cpp 
> 5799dc9c871c6ccaddb209ab7ec1112b192f3d41 
>   src/tests/containerizer/docker_tests.cpp 
> 620819330847a10d9dcd817968df9d2b180a9a29 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8 
>   src/tests/module_tests.cpp 121d65337bdf29f6049ac44bfd903a1f5ea1a09d 
>   src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
>   src/tests/sorter_tests.cpp 22bc618f9b4958fbd8e6c5dfee94b26fe13ec47a 
> 
> Diff: https://reviews.apache.org/r/44113/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43636: Cleaned up various code in a test file.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43636/#review121109
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 27, 2016, 1:58 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43636/
> ---
> 
> (Updated Feb. 27, 2016, 1:58 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up various code in a test file.
> 
> 
> Diffs
> -
> 
>   src/tests/teardown_tests.cpp 5753559003d703138d2bbee6a1ac93473ba0b0c0 
> 
> Diff: https://reviews.apache.org/r/43636/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43910/
---

(Updated Feb. 28, 2016, 12:21 a.m.)


Review request for mesos and Michael Park.


Repository: mesos


Description
---

Enhanced a test case for the `/state` agent endpoint.


Diffs
-

  src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 

Diff: https://reviews.apache.org/r/43910/diff/


Testing (updated)
---

make check

Note that we don't currently check the conversion of `TaskInfo` -> JSON, which 
is used for `queuedTasks`. Would be nice to improve the test case so that the 
slave has a queued task, although this will probably require some 
`DROP_MESSAGE` trickery...


Thanks,

Neil Conway

Re: Review Request 43817: Removed no-longer-used model functions.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43817/
---

(Updated Feb. 28, 2016, 12:17 a.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731


Repository: mesos


Description
---

These `model()` variants provided functionality that is now
implemented via jsonify; no more call-sites of the old functions
remain.


Diffs (updated)
-

  src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 

Diff: https://reviews.apache.org/r/43817/diff/


Testing
---

make check

Also updated a few comments to not refer to `summarize`.


Thanks,

Neil Conway

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44047/
---

(Updated Feb. 28, 2016, 12:17 a.m.)


Review request for mesos, Michael Park and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-4667
https://issues.apache.org/jira/browse/MESOS-4667


Repository: mesos


Description
---

This allows operators to list all the dynamic reservations and persistent
volumes in a cluster. This is important in itself; it also makes it easier to
use the `/unreserve` and `/destroy-volumes` endpoints.


Diffs (updated)
-

  docs/persistent-volume.md 47ada98413f1670e9fc4ebd9d1ead6af9b120184 
  docs/reservation.md 450f4eec49d957b096df1380c3e79d5f743cc829 
  src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 
  src/tests/persistent_volume_endpoints_tests.cpp 
08b9102318b826bab9d2c1d389fb80b86949218c 

Diff: https://reviews.apache.org/r/44047/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43911/
---

(Updated Feb. 28, 2016, 12:16 a.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated `/state` agent endpoint to use jsonify.


Diffs (updated)
-

  src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 

Diff: https://reviews.apache.org/r/43911/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/
---

(Updated Feb. 28, 2016, 12:15 a.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated `/tasks` master endpoint to use jsonify.


Diffs (updated)
-

  src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 

Diff: https://reviews.apache.org/r/43823/diff/


Testing
---

make check. Also verified that this endpoint is covered by the unit tests.


Thanks,

Neil Conway

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43816/
---

(Updated Feb. 28, 2016, 12:15 a.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-4731
https://issues.apache.org/jira/browse/MESOS-4731


Repository: mesos


Description
---

Updated `/frameworks` master endpoint to use jsonify.


Diffs (updated)
-

  src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 

Diff: https://reviews.apache.org/r/43816/diff/


Testing
---

1. make check
2. Verified that after introducing a bug into the jsonify version of 
`frameworks()`, `make check` fails (i.e., the test suite covers the 
`/frameworks` endpoint).
3. Compared output of `/frameworks` with old and new implementation on a test 
Mesos installation to try to gauge correctness visually.


Thanks,

Neil Conway

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43822/
---

(Updated Feb. 28, 2016, 12:15 a.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated `/slaves` master endpoint to use jsonify.


Diffs (updated)
-

  src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 

Diff: https://reviews.apache.org/r/43822/diff/


Testing
---

make check. Also verified that this endpoint is covered by the unit tests.


Thanks,

Neil Conway

Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43910/
---

(Updated Feb. 28, 2016, 12:15 a.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Enhanced a test case for the `/state` agent endpoint.


Diffs (updated)
-

  src/tests/slave_tests.cpp 322f3ddaf11885d7e61e0e9232c0342e97d8bfa1 

Diff: https://reviews.apache.org/r/43910/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 41760: Add initialization method to Anonymous class.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41760/#review121102
---



Hi Marco,

Sorry for the delayed response. While I already gave it a ship-it from the 
functionality point of view, there are still some style issues to be addressed 
before this can be merged.

Also, can you separate out the changes to slave/ into a separate review just 
like you have for the master/ changes?


include/mesos/module/anonymous.hpp (line 23)


Pls replace it with `'.



include/mesos/module/anonymous.hpp (line 58)


Remove double backquote.



include/mesos/module/anonymous.hpp (line 59)


Indent by four spaces.



src/examples/test_anonymous_module.hpp (lines 22 - 26)


Move `using ...` to top. Kill the newline.



src/examples/test_anonymous_module.hpp (lines 31 - 36)


Fix Indentation.



src/examples/test_anonymous_module.hpp (lines 32 - 34)


Drop `virtual`?



src/examples/test_anonymous_module.cpp (line 49)


Kill the extra space after return type.



src/examples/test_anonymous_module.cpp (line 68)


May be drop the `-`?



src/examples/test_anonymous_module.cpp (line 70)


Kill extra newline.



src/examples/test_anonymous_module.cpp (line 77)


Add another newline.



src/examples/test_anonymous_module.cpp (line 83)


Add another newline.



src/examples/test_anonymous_module.cpp (lines 86 - 92)


Not yours, but could you fix the indentation here too?



src/examples/test_anonymous_module.cpp (lines 93 - 94)


Kill extra newlines.



src/slave/main.cpp (lines 298 - 299)


Update the comment to reflect the initialization functionality.



src/slave/main.cpp (line 307)


Drop this log message. This is redundant with the one above.



src/tests/anonymous_tests.cpp (lines 17 - 18)


Not used.



src/tests/anonymous_tests.cpp (line 51)


Brace on a newline.



src/tests/anonymous_tests.cpp (lines 53 - 58)


Indent by two spaces.



src/tests/anonymous_tests.cpp (line 71)


Drop `std::`.



src/tests/anonymous_tests.cpp (lines 93 - 99)


Consolidate line 93 and 99.



src/tests/anonymous_tests.cpp (lines 95 - 102)


Fix indentation



src/tests/anonymous_tests.cpp (line 97)


s/ASSERT_SOME/EXPECT_SOME/



src/tests/anonymous_tests.cpp (line 102)


Replace with `EXPECT_SOME(result)`.



src/tests/anonymous_tests.cpp (line 106)


s/ASSERT/EXPECT/



src/tests/module.hpp (line 48)


s/TestInitModule/TestInitAnonymous/

Here and everywhere else.


- Kapil Arya


On Feb. 13, 2016, 1:24 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41760/
> ---
> 
> (Updated Feb. 13, 2016, 1:24 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Bugs: MESOS-4253
> https://issues.apache.org/jira/browse/MESOS-4253
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Jira: MESOS-4253
> 
> To provide a basic "context" to anonymous modules, we provide
> an `initialize(const FlagsBase&)` method that will be invoked
> shortly after creation of the module class.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/anonymous.hpp 629eb123b9d5fa9e07ddb1c704ee72e96e8fec5b 
>   src/examples/test_anonymous_module.hpp 
> 3da33a42f04b7421cee8fbb85e29b66e352f5894 
>   src/examples/test_anonymous_module.cpp 
> dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 

Re: Review Request 44126: Fixed a few style issues in the docs.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44126/#review121107
---


Ship it!




Ship It!

- Joris Van Remoortere


On Feb. 27, 2016, 1:57 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44126/
> ---
> 
> (Updated Feb. 27, 2016, 1:57 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a few style issues in the docs.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
> 
> Diff: https://reviews.apache.org/r/44126/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43709/#review121106
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43709/
> ---
> 
> (Updated Feb. 18, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4704
> https://issues.apache.org/jira/browse/MESOS-4704
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This review was originally at #40582, put up by Dario Bazan. Dario went
> on paternity leave, so I've dusted it off, rebased it against the state
> of the art, and gotten it ready for submission. It remains mostly
> unchanged, with only minor alterations from the original.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
> 3d074a5296b4435b29792201cb9a1b021673fd97 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp 
> eb52beb2bcdfbdb71e1456f3286e087e7bbf524e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp 
> 8698e997965add14e0a8a268b0ebcf1a5ab4d49d 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 3c65d0422dc6e198180d53d1c9e6cb2839137434 
> 
> Diff: https://reviews.apache.org/r/43709/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43903: Stout: Add `WindowsError` constructor to `Result`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43903/#review121105
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 25, 2016, 7:13 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43903/
> ---
> 
> (Updated Feb. 25, 2016, 7:13 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Add `WindowsError` constructor to `Result`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 
> 577c8e459f505b7b9021153d5e42e9d5a892ec33 
> 
> Diff: https://reviews.apache.org/r/43903/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43905/#review121104
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43905/
> ---
> 
> (Updated Feb. 25, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `su` does not exist on Windows. Unfortunately, the launcher also depends
> on it. In this commit, we remove Windows support for the launcher flag
> `user`, which controls whether we use `su` in the launcher. This
> allows us to divest ourselves of `su` altogether on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> d917a99a46841156dc1e359c44010938cc45e943 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 129406abdff715e321f683911e404c46676b6daf 
>   src/slave/containerizer/mesos/launch.hpp 
> 7e29ca2b8bec1c20aef122472cff60f6003603ad 
>   src/slave/containerizer/mesos/launch.cpp 
> 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 
> 
> Diff: https://reviews.apache.org/r/43905/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43904: Windows: Removed `rootfs` launcher flag, preventing `chroot`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43904/#review121103
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43904/
> ---
> 
> (Updated Feb. 25, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4780
> https://issues.apache.org/jira/browse/MESOS-4780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `chroot` is does not exist on Windows. Unfortunately, the launcher also
> depends on it. In this commit, we remove Windows support for the
> launcher flag `rootfs`, which controls whether we use `chroot` in the
> launcher. This allows us to divest ourselves of `chroot` altogether on
> Windows.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 129406abdff715e321f683911e404c46676b6daf 
>   src/slave/containerizer/mesos/launch.hpp 
> 7e29ca2b8bec1c20aef122472cff60f6003603ad 
>   src/slave/containerizer/mesos/launch.cpp 
> 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 
> 
> Diff: https://reviews.apache.org/r/43904/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/#review121100
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 25, 2016, 7:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43907/
> ---
> 
> (Updated Feb. 25, 2016, 7:41 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] Fix error reporting bug in `os::rmdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> bc420c9c10d93ddd619a9eb2c5f4db67f31d722f 
> 
> Diff: https://reviews.apache.org/r/43907/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/#review121099
---


Ship it!




Ship It!

- Daniel Pravat


On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43906/
> ---
> 
> (Updated Feb. 25, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added files to be built as part of libmesos.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
> 
> Diff: https://reviews.apache.org/r/43906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/#review121098
---




src/CMakeLists.txt (line 376)


Please lift the values used by the build.cpp and passed as BUILD* defines 
into their ows CMAKE macros to get dynamic values into a subsequential commit.


- Daniel Pravat


On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43906/
> ---
> 
> (Updated Feb. 25, 2016, 7:17 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added files to be built as part of libmesos.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
> 
> Diff: https://reviews.apache.org/r/43906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44144: Improved the documentation for setting ACLs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44144/#review121097
---



Patch looks great!

Reviews applied: [44144]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 27, 2016, 5:49 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44144/
> ---
> 
> (Updated Feb. 27, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved the documentation for setting ACLs.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md feb0ddd6514106f0778db7b5428e47d4d8dc4d42 
> 
> Diff: https://reviews.apache.org/r/44144/diff/
> 
> 
> Testing
> ---
> 
> Checked via gist: https://gist.github.com/joerg84/6c2a86e1b0c378c4c8c9
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44144: Improved the documentation for setting ACLs.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44144/#review121096
---


Ship it!




Ship It!

- Neil Conway


On Feb. 27, 2016, 5:49 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44144/
> ---
> 
> (Updated Feb. 27, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved the documentation for setting ACLs.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md feb0ddd6514106f0778db7b5428e47d4d8dc4d42 
> 
> Diff: https://reviews.apache.org/r/44144/diff/
> 
> 
> Testing
> ---
> 
> Checked via gist: https://gist.github.com/joerg84/6c2a86e1b0c378c4c8c9
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44144: Improved the documentation for setting ACLs.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44144/#review121095
---


Ship it!




Ship It!

- Alexander Rojas


On Feb. 27, 2016, 6:49 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44144/
> ---
> 
> (Updated Feb. 27, 2016, 6:49 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved the documentation for setting ACLs.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md feb0ddd6514106f0778db7b5428e47d4d8dc4d42 
> 
> Diff: https://reviews.apache.org/r/44144/diff/
> 
> 
> Testing
> ---
> 
> Checked via gist: https://gist.github.com/joerg84/6c2a86e1b0c378c4c8c9
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 44144: Improved the documentation for setting ACLs.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44144/
---

Review request for mesos, Adam B, Alexander Rojas, and Neil Conway.


Repository: mesos


Description
---

Improved the documentation for setting ACLs.


Diffs
-

  docs/authorization.md feb0ddd6514106f0778db7b5428e47d4d8dc4d42 

Diff: https://reviews.apache.org/r/44144/diff/


Testing
---

Checked via gist: https://gist.github.com/joerg84/6c2a86e1b0c378c4c8c9


Thanks,

Joerg Schad

Re: Review Request 41790: Add tests for /weights endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121092
---



Patch looks great!

Reviews applied: [41597, 41681, 43863, 41790]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 27, 2016, 1:55 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> ---
> 
> (Updated Feb. 27, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> ---
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==] Running 11 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 11 tests from DynamicWeightsTest
> [ RUN  ] DynamicWeightsTest.PutInvalidRequest
> [   OK ] DynamicWeightsTest.PutInvalidRequest (85 ms)
> [ RUN  ] DynamicWeightsTest.ZeroWeight
> [   OK ] DynamicWeightsTest.ZeroWeight (46 ms)
> [ RUN  ] DynamicWeightsTest.NegativeWeight
> [   OK ] DynamicWeightsTest.NegativeWeight (49 ms)
> [ RUN  ] DynamicWeightsTest.NonNumericWeight
> [   OK ] DynamicWeightsTest.NonNumericWeight (49 ms)
> [ RUN  ] DynamicWeightsTest.MissingRole
> [   OK ] DynamicWeightsTest.MissingRole (50 ms)
> [ RUN  ] DynamicWeightsTest.UnknownRole
> [   OK ] DynamicWeightsTest.UnknownRole (49 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (45 ms)
> [ RUN  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [   OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (45 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [   OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
> (36 ms)
> [ RUN  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
> [--] 11 tests from DynamicWeightsTest (527 ms total)
> 
> [--] Global test environment tear-down
> [==] 11 tests from 1 test case ran. (536 ms total)
> [  PASSED  ] 11 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41790: Add tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
---

(Updated Feb. 27, 2016, 1:55 p.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Addressed comments of Adam.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Add tests for /weights endpoint.


Diffs (updated)
-

  src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
  src/tests/dynamic_weights_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41790/diff/


Testing (updated)
---

Make and Make check successfully!

./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==] Running 11 tests from 1 test case.
[--] Global test environment set-up.
[--] 11 tests from DynamicWeightsTest
[ RUN  ] DynamicWeightsTest.PutInvalidRequest
[   OK ] DynamicWeightsTest.PutInvalidRequest (85 ms)
[ RUN  ] DynamicWeightsTest.ZeroWeight
[   OK ] DynamicWeightsTest.ZeroWeight (46 ms)
[ RUN  ] DynamicWeightsTest.NegativeWeight
[   OK ] DynamicWeightsTest.NegativeWeight (49 ms)
[ RUN  ] DynamicWeightsTest.NonNumericWeight
[   OK ] DynamicWeightsTest.NonNumericWeight (49 ms)
[ RUN  ] DynamicWeightsTest.MissingRole
[   OK ] DynamicWeightsTest.MissingRole (50 ms)
[ RUN  ] DynamicWeightsTest.UnknownRole
[   OK ] DynamicWeightsTest.UnknownRole (49 ms)
[ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (45 ms)
[ RUN  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[   OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (45 ms)
[ RUN  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[   OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (37 ms)
[ RUN  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[   OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
(36 ms)
[ RUN  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[   OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (35 ms)
[--] 11 tests from DynamicWeightsTest (527 ms total)

[--] Global test environment tear-down
[==] 11 tests from 1 test case ran. (536 ms total)
[  PASSED  ] 11 tests.


Thanks,

Yongqiao Wang

Re: Review Request 43863: Move the implementation of updateWeights out of header.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43863/#review121088
---



Patch looks great!

Reviews applied: [41597, 41681, 43863]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 27, 2016, 12:43 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43863/
> ---
> 
> (Updated Feb. 27, 2016, 12:43 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4214
> https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Move the implementation of updateWeights out of header.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
>   src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 
>   src/master/weights.hpp PRE-CREATION 
>   src/master/weights.cpp PRE-CREATION 
>   src/master/weights_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43863/diff/
> 
> 
> Testing
> ---
> 
> make && make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 41790: Add tests for /weights endpoint.

[Yongqiao Wang]

> On Feb. 27, 2016, 12:21 p.m., Adam B wrote:
> > Sorry this took me forever to get to. Looks pretty good except for some 
> > indentation and some unnecessary lines.
> > I'd also like to see a couple of registrar tests, like AlexR suggested.

Thanks Adam. I will add a couple of registrar tests later in another patches, 
is it OK?


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121077
---


On Jan. 25, 2016, 3:47 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> ---
> 
> (Updated Jan. 25, 2016, 3:47 p.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> ---
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==] Running 11 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 11 tests from DynamicWeightsTest
> [ RUN  ] DynamicWeightsTest.PutInvalidRequest
> [   OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN  ] DynamicWeightsTest.ZeroWeight
> [   OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN  ] DynamicWeightsTest.NegativeWeight
> [   OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN  ] DynamicWeightsTest.MissingRole
> [   OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN  ] DynamicWeightsTest.UnknownRole
> [   OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [   OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [   OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
> (37 ms)
> [ RUN  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [--] 11 tests from DynamicWeightsTest (492 ms total)
> 
> [--] Global test environment tear-down
> [==] 11 tests from 1 test case ran. (503 ms total)
> [  PASSED  ] 11 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43806: Add comments for rebalance.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review121087
---


Ship it!




Ship It!

- Adam B


On Feb. 27, 2016, 4:26 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
> ---
> 
> (Updated Feb. 27, 2016, 4:26 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add comments for rebalance.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57 
> 
> Diff: https://reviews.apache.org/r/43806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review121086
---


Ship it!




LGTM, but I didn't try to run the script to verify.

- Adam B


On Feb. 24, 2016, 9:32 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> ---
> 
> (Updated Feb. 24, 2016, 9:32 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kevin Klues, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> support/generate-endpoint-help.py is adding a title to every generated 
> endpoint markdown file.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> ---
> 
> This is the patch for support/generate-endpoint-help.py to include the 
> generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43863: Move the implementation of updateWeights out of header.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43863/
---

(Updated Feb. 27, 2016, 12:43 p.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Changes
---

Addressed the comments of Adam.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Move the implementation of updateWeights out of header.


Diffs (updated)
-

  src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e 
  src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 
  src/master/weights.hpp PRE-CREATION 
  src/master/weights.cpp PRE-CREATION 
  src/master/weights_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/43863/diff/


Testing
---

make && make check successfully!


Thanks,

Yongqiao Wang

Re: Review Request 43863: Move the implementation of updateWeights out of header.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43863/
---

(Updated Feb. 27, 2016, 12:40 p.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Changes
---

Addressed the comments of Adam.


Bugs: MESOS-4214
https://issues.apache.org/jira/browse/MESOS-4214


Repository: mesos


Description
---

Move the implementation of updateWeights out of header.


Diffs (updated)
-

  src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e 
  src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 
  src/master/weights.hpp PRE-CREATION 
  src/master/weights.cpp PRE-CREATION 
  src/master/weights_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/43863/diff/


Testing
---

make && make check successfully!


Thanks,

Yongqiao Wang

Re: Review Request 43863: Move the implementation of updateWeights out of header.

[Yongqiao Wang]

> On Feb. 27, 2016, 11:17 a.m., Adam B wrote:
> > Looks good to me. I'm assuming you didn't change anything substantial in 
> > the implementation when you moved it. It looks the same to me.

Yes, I didn't change anything substantial in the implementation.


> On Feb. 27, 2016, 11:17 a.m., Adam B wrote:
> > src/Makefile.am, lines 630-631
> > 
> >
> > Do these need to be in separate files?

Yes, I think weights_handler.cpp only contains the logic to handle the http 
request, like quota and maintenance features, they all use the separated files. 
Maybe my mainly reason is better to keep consistent.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43863/#review121078
---


On Feb. 23, 2016, 2:18 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43863/
> ---
> 
> (Updated Feb. 23, 2016, 2:18 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4214
> https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Move the implementation of updateWeights out of header.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
>   src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
>   src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
>   src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
>   src/master/weights.hpp PRE-CREATION 
>   src/master/weights.cpp PRE-CREATION 
>   src/master/weights_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43863/diff/
> 
> 
> Testing
> ---
> 
> make && make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43716: Added title to every endpoint markdown file.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43716/#review121084
---


Ship it!




Ship It!

- Adam B


On Feb. 24, 2016, 10:51 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43716/
> ---
> 
> (Updated Feb. 24, 2016, 10:51 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kevin Klues, and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Endpoint documents with title.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> 7c7049344980a16978a25431e713fbfe61e1cc5f 
>   docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
>   docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
>   docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
>   docs/endpoints/files/download.json.md 
> 77c6b97988c30ddcd71d69da1ffa55a10e871051 
>   docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
>   docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
>   docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
>   docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
>   docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
>   docs/endpoints/master/api/v1/scheduler.md 
> 6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
>   docs/endpoints/master/create-volumes.md 
> 1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53 
>   docs/endpoints/master/destroy-volumes.md 
> 7209a7cf788116a29eb6235d3a8a0225253c04f7 
>   docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
>   docs/endpoints/master/frameworks.md 
> bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
>   docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
>   docs/endpoints/master/machine/down.md 
> 82cce61e2a02f7896e7db351bed7a08138e87768 
>   docs/endpoints/master/machine/up.md 
> 5bfd95e0945d82030ee536ee247665c455629a64 
>   docs/endpoints/master/maintenance/schedule.md 
> e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
>   docs/endpoints/master/maintenance/status.md 
> 17e3eef1c2fac12375892ec125a727a62a4ebfca 
>   docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
>   docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
>   docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
>   docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778 
>   docs/endpoints/master/roles.json.md 
> d67779c246cceae2209f2611f32ada4493ae6f83 
>   docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
>   docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
>   docs/endpoints/master/state-summary.md 
> a6d79f0e5703c3f9118869e287fbb512e86c22c0 
>   docs/endpoints/master/state.json.md 
> dad5627eea9481fdbfd91966062c813be7e0f586 
>   docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488 
>   docs/endpoints/master/tasks.json.md 
> cb1856f296d7420ce3162a60bf634de0991cdde4 
>   docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
>   docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
>   docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0 
>   docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
>   docs/endpoints/monitor/statistics.json.md 
> 5ce4fc69aaa4b54541841e58ffa29703363b73e2 
>   docs/endpoints/monitor/statistics.md 
> 602104b2484022cfa7f41b04affc106703e6f09f 
>   docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
>   docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
>   docs/endpoints/registrar/registry.md 
> 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
>   docs/endpoints/slave/api/v1/executor.md 
> e92df49b0a50e0152e54866e812438c9af63c4e0 
>   docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
>   docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
>   docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65 
>   docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966 
>   docs/endpoints/system/stats.json.md 
> a5fb58f35c602c8b03ed911eb374d26f98449585 
>   docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
> 
> Diff: https://reviews.apache.org/r/43716/diff/
> 
> 
> Testing
> ---
> 
> This patch includes all the endpoint documents with title generated from 
> generated-endpoint-help.py file.
> Tested on live site using "rake"
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 43328: Added a title to all documentation markdown files.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review121082
---


Ship it!




Ship It!

- Adam B


On Feb. 24, 2016, 10:50 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> ---
> 
> (Updated Feb. 24, 2016, 10:50 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kevin Klues, and Neil Conway.
> 
> 
> Bugs: MESOS-4588
> https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> All the documentation markdown files are updated with a title so that UI 
> shows the title on browser.
> 
> 
> Diffs
> -
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/documentation-guide.md b7e861468e8abe1b8e83c115d353e78e601fb41f 
>   docs/doxygen-style-guide.md 1bd3b3d373af4ab39df1ab8b1ed9c78dc3bfc721 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md 15f70b51294fa647d653bfe4d641dc032ec91f44 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md 2e5b700691744798c9a84874fd5f1d17aa151346 
>   docs/high-availability-framework-guide.md 
> 0d9c483985d61b512339f50f395f9360de034e2d 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md 07214b927c112d7a180507ae03245892455fd757 
>   docs/logging.md 50a95ba5fedcb5b803e183bea8243e2e7750aa3e 
>   docs/maintenance.md 4d24ec680f3245b12b99e4bb6440ae5aab473460 
>   docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/multiple-disk.md ab2e7e84398fda4abdae1bdd5daebe78b1e075b3 
>   docs/network-monitoring.md 57b859e9292dc22613e235710312d1a33f58e0c0 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md a4d6710a8a3a4cde10fdccad332e3d539246ec83 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md d29bbaf5677b68ee1f47308047a1c56869284710 
>   docs/quota.md d4233be0f39e05c1c326680dbddae1ec601eef4f 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md f0963e750494fcf1f9d80e87bac8dbd6f76adc9f 
>   docs/replicated-log-internals.md 4f379a3ff4e957a486fa13d721f4b66333aea6b3 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   docs/reservation.md b98ebe6df0739b48c5fa58e087fd64b1c6c5d456 
>   docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
>   docs/roles.md 84e5b7eaa4cf5cd3e7ebd6151928210be93d1d56 
>   docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
>   docs/scheduler-http-api.md 42e2c514ad027b9007aadda46eabd5c530f89eaa 
>   docs/slave-recovery.md 

Re: Review Request 43806: Add comments for rebalance.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/
---

(Updated Feb. 27, 2016, 12:26 p.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Changes
---

Update the comment for rebalance by Adam's comment.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add comments for rebalance.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57 

Diff: https://reviews.apache.org/r/43806/diff/


Testing
---


Thanks,

Yongqiao Wang

Re: Review Request 41790: Add tests for /weights endpoint.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review121077
---



Sorry this took me forever to get to. Looks pretty good except for some 
indentation and some unnecessary lines.
I'd also like to see a couple of registrar tests, like AlexR suggested.


src/tests/dynamic_weights_tests.cpp (lines 71 - 74)


You can just use `process::http::Headers` instead.



src/tests/dynamic_weights_tests.cpp (line 108)


s/Req/Request/ (we don't like abbrev's)



src/tests/dynamic_weights_tests.cpp (line 113)


s/json/"%s"/ - no reaon to create a local variable for a string constant 
that isn't reused.



src/tests/dynamic_weights_tests.cpp (lines 134 - 150)


Seems like this should be an if/else, rather than always evaluating 
JSON::parse("[...]") even if the value's getting thrown away. Maybe something 
more like:
```Try expected;
if (weights == "") {
  expected = "[..short..]";
} else if (weights == WEIGHTS) {
  expected = "[...longer...]";
} else {
  expected = Error("Unexpected weights string.");
}```



src/tests/dynamic_weights_tests.cpp (lines 215 - 219)


This seems like an arbitrary indentation. Either align with the parentheses 
(too far over in this case), or indent 4 spaces in from the previous line.



src/tests/dynamic_weights_tests.cpp (lines 215 - 219)


This seems like an arbitrary indentation. Either align with the parentheses 
(too far over in this case), or indent 4 spaces in from the previous line.



src/tests/dynamic_weights_tests.cpp (line 227)


s/filed/field/



src/tests/dynamic_weights_tests.cpp (lines 236 - 240)


Fix the indent again, everywhere.



src/tests/dynamic_weights_tests.cpp (line 247)


Soon this line won't be necessary, but we'll try to get your patch 
committed before Joseph's so he's the one who has to rebase, not you. :)



src/tests/dynamic_weights_tests.cpp (line 290)


Please add another Bad Request test for a non-numeric weight value, like 
"role1=two"



src/tests/dynamic_weights_tests.cpp (line 322)


s/empty (Only a space) role/empty role (only a space)/



src/tests/dynamic_weights_tests.cpp (line 400)


s/does not/not/



src/tests/dynamic_weights_tests.cpp (line 472)


You can remove the `UpdateWeightsWithImplicitRoles` test, since this test 
already tests implicit roles.



src/tests/dynamic_weights_tests.cpp (line 523)


This line should be unnecessary. If there are no credentials in the 
request, and authenticate_http=false (meaning authn is not required), then your 
request should be allowed through without authn.
In this setup, the master would still use its --credentials to authenticate 
any client that tries to use credentials.



src/tests/dynamic_weights_tests.cpp (lines 553 - 556)


These lines should be unnecessary if the ACLs are restrictive by default.


- Adam B


On Jan. 25, 2016, 7:47 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> ---
> 
> (Updated Jan. 25, 2016, 7:47 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> ---
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==] Running 11 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 11 tests from DynamicWeightsTest
> [ RUN  ] DynamicWeightsTest.PutInvalidRequest
> [   OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN  ] DynamicWeightsTest.ZeroWeight
> [   OK ] 

Re: Review Request 43847: Added master/scheduler failover tests for scheduler library.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43847/#review121080
---



Patch looks great!

Reviews applied: [43657, 43658, 43659, 43660, 43661, 43662, 43667, 39372, 
43846, 43847]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 27, 2016, 10:30 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43847/
> ---
> 
> (Updated Feb. 27, 2016, 10:30 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4686
> https://issues.apache.org/jira/browse/MESOS-4686
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. This are a follow up to the patches for MESOS-3570 around 
> modifying the scheduler library to use HTTP Pipelining.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 
> 
> Diff: https://reviews.apache.org/r/43847/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43806: Add comments for rebalance.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review121079
---



I took a stab at rewording your comment. I particularly didn't like starting 
with an ambiguous "It".


src/master/allocator/mesos/hierarchical.cpp (line 1069)


"The allocator only needs to rebalance if there is a framework registered 
with this role. The roleSorter contains only roles for registered frameworks, 
but quotaRoleSorter contains any role with quota set, regardless of whether any 
frameworks are registered with that role."
This might belong above both the quota and roleSorter checks.


- Adam B


On Feb. 20, 2016, 6:26 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
> ---
> 
> (Updated Feb. 20, 2016, 6:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add comments for rebalance.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
> 
> Diff: https://reviews.apache.org/r/43806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43863: Move the implementation of updateWeights out of header.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43863/#review121078
---


Fix it, then Ship it!




Looks good to me. I'm assuming you didn't change anything substantial in the 
implementation when you moved it. It looks the same to me.


src/Makefile.am (lines 630 - 631)


Do these need to be in separate files?



src/master/weights.hpp (line 60)


This fits on one line if you exclude variable names for the fields you 
don't use, e.g. `  Try perform(Registry* registry, hashset*, 
bool);`



src/master/weights.cpp (line 25)


Only indent 2 spaces


- Adam B


On Feb. 22, 2016, 6:18 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43863/
> ---
> 
> (Updated Feb. 22, 2016, 6:18 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4214
> https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Move the implementation of updateWeights out of header.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
>   src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e 
>   src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
>   src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 
>   src/master/weights.hpp PRE-CREATION 
>   src/master/weights.cpp PRE-CREATION 
>   src/master/weights_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43863/diff/
> 
> 
> Testing
> ---
> 
> make && make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43847: Added master/scheduler failover tests for scheduler library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43847/
---

(Updated Feb. 27, 2016, 10:30 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Make ReviewBot run again after using UNREACHABLE in r43662.


Bugs: MESOS-4686
https://issues.apache.org/jira/browse/MESOS-4686


Repository: mesos


Description
---

See summary. This are a follow up to the patches for MESOS-3570 around 
modifying the scheduler library to use HTTP Pipelining.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9 

Diff: https://reviews.apache.org/r/43847/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43662/
---

(Updated Feb. 27, 2016, 10:30 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Used UNREACHABLE to make gcc happy.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

Previously, the scheduler library used to chain calls on previous call 
responses. This was inherently slow. This change adds support for pipelining 
all calls to the master on a single connection via the `http::Connection` 
abstraction in libprocess.

This change also adds support for handling various error scenarios when we 
notice a disconnection instead of just relying on the master detector for 
invoking the `disconnected` callback.


Diffs (updated)
-

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43662/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

[Guangya Liu]

> On 二月 25, 2016, 12:08 p.m., Guangya Liu wrote:
> > src/docker/docker.cpp, lines 229-251
> > 
> >
> > What about as this:
> > 
> > Try Docker::validateVersion(const Version& minVersion) const
> > {
> >   if (dockerVersion < minVersion) {
> > string msg = "Insufficient version '" + stringify(version.get()) +
> >  "' of Docker. Please upgrade to >=' " +
> >  stringify(minVersion) + "'";
> > return Error(msg);
> >   }
> > 
> >   return Nothing();
> > }
> 
> Abhishek Dasgupta wrote:
> As we have to use dockerVersion as string, we may expect a parsing error. 
> So that error check is necessary.

Thanks @Abhishek, we can wait and see the comments from @tnachen and @jieyu. 
I'm not sure if we need to update version.cpp to enable it support `=` 
operation.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review120689
---


On 二月 24, 2016, 2:10 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> ---
> 
> (Updated 二月 24, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Set Docker labels based on TaskInfo labels.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
>   src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a299c9e0744b5657984e5bb0afbe4874a266ddb6 
>   src/tests/containerizer/docker_tests.cpp 
> 620819330847a10d9dcd817968df9d2b180a9a29 
>   src/tests/health_check_tests.cpp 59ef31970af2d255abe169dfbc2e6e0314d29e9a 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
>   src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 
> 
> Diff: https://reviews.apache.org/r/43032/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to 
> docker run command through arguments.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>