Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

[zhou xing]

> On 三月 18, 2016, 6:51 p.m., Vinod Kone wrote:
> > Looks good to me. Couple of things before this can get committed.
> > 
> > --> Have you sent an email to dev/user list about this backwards 
> > incompatible change? If not, you should.
> >  
> > --> If users are depending on the return code (need to ask on the above 
> > email) we need to do a proper deprecation warning in 0.29.0 CHANGELOG 
> > (Deprecations section) and change the behavior in 0.30.0.
> > 
> > --> If no one is depending on the return code, we might just do the change 
> > in 0.29.0. This should go into the 0.29.0 CHANGELOG though (API Changes 
> > section).
> 
> zhou xing wrote:
> Thanks for the review, we have sent a message to the community to see 
> wether anyone are using the return code. will update you the latest feedbacks 
> we collect, thx
> 
> Kevin Klues wrote:
> I Zhao, I'm curious if you got any feedback on this.  Also, did you get a 
> chance to address Neil's comments about updating the documentation? I think 
> that would need to be included as part of this work, though I'd probably 
> submit it as a separate patch that "Depends On" this one.

Kevin, we haven't got any response for this issue from the community yet. So 
I'm thinking whether we can just merge this patch in release 0.29? if so, I can 
update the change log and submit another patch, thanks


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review124249
---


On 三月 10, 2016, 7:11 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> ---
> 
> (Updated 三月 10, 2016, 7:11 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod 
> Kone.
> 
> 
> Bugs: mesos-4580
> https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan 
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/create-volumes.md 
> 542f555d9b6f07bde58d49ab1bc408b4d0aa7b9f 
>   docs/endpoints/master/destroy-volumes.md 
> d5d98198e70fae4f6ea6791511f3b26e792f66d1 
>   docs/endpoints/master/reserve.md 3e2a857ce784496d4de872bd00b1560c058b667d 
>   docs/endpoints/master/unreserve.md d26ae7cb7ec7a2c75ac45b792213fe8d82e8929d 
>   docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 
>   docs/reservation.md 55924adb94028702e15db7e191915157552981d0 
>   docs/upgrades.md e888b233351b2da05a5e5c63138de5f60708afea 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 81185a161498394020a27f1f5bf747bac5425f43 
>   src/tests/reservation_endpoints_tests.cpp 
> f95ae7a32c3809d150adf1e9e515a3b527e61699 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

[Jie Yu]

> On March 25, 2016, 12:20 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 438
> > 
> >
> > Why do you need to get os::environment()?
> 
> Qian Zhang wrote:
> The reason is, CNI plugin needs to call `iptables` to set up IPMasq, if 
> we do not do this, the plugin will fail with an error:
>   {
>   "code": 100,
>   "msg": "failed to locate iptables: exec: \"iptables\": executable 
> file not found in $PATH"
>   }
>   
> Maybe we could explicitly set `$PATH` as 
> `/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin` rather than 
> call `os::environment()`?

Or you can only keep PATH in os::environment() and strip the rest. Please add a 
NOTE about that.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44706/#review125367
---


On March 26, 2016, 2:53 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44706/
> ---
> 
> (Updated March 26, 2016, 2:53 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented isolate() method of "network/cni" isolator.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 7bda2ac684f38da94e334f0cef843614687ae4aa 
>   src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> b1b7205f4f10b6dc256fcc4ecb3210105c1240b4 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 7cda5715814a0cfc4b394eb04437831e6dc44e3f 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44706/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 45373: WIP: Checkpointed container external mount info during prepare().

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45373/
---

Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description
---

Checkpointed container external mount info during prepare().


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45373/diff/


Testing
---


Thanks,

Guangya Liu

Review Request 45275: Implemented prepare() for dvd isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45275/
---

Review request for mesos.


Repository: mesos


Description
---

Implemented prepare() for dvd isolator.


Diffs (updated)
-

  src/CMakeLists.txt 7bda2ac684f38da94e334f0cef843614687ae4aa 
  src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c 
  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
  src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
9fc7c48f99155750fd3c18c7c102507e2726362b 

Diff: https://reviews.apache.org/r/45275/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 45370: Implemented prepare() for dvd isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45370/
---

Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description
---

Implemented prepare() for dvd isolator.


Diffs
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
  src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
9fc7c48f99155750fd3c18c7c102507e2726362b 

Diff: https://reviews.apache.org/r/45370/diff/


Testing
---

The execute.cpp is mainly for test, will remove this file once test finished.


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

(Updated 三月 28, 2016, 2:44 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Added spec protobut for external mount.


Diffs (updated)
-

  src/CMakeLists.txt 7bda2ac684f38da94e334f0cef843614687ae4aa 
  src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44378/
---

(Updated March 28, 2016, 10:21 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Summary (updated)
-

Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].


Bugs: MESOS-4803
https://issues.apache.org/jira/browse/MESOS-4803


Repository: mesos


Description (updated)
---

Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
6b07aefc58a1daa235b35e83832e47d1878e2e94 
  3rdparty/libprocess/3rdparty/libev-4.15.patch 
bbd83e6928e6caba3bc5a9739823d60923cfaa2a 
  3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 
4c282b573aa9331fd16197ef286faf323b6515eb 
  3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 
  3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/versions.am 
98195b8eb60b2673d610d8ab7ea31103f137debf 

Diff: https://reviews.apache.org/r/44378/diff/


Testing
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45371/
---

Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Repository: mesos


Description
---

Upgrade libev to 4.22 to support PowerPC LE platform [mesos].


Diffs
-

  3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
  LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
  src/python/native_common/ext_modules.py.in 
c335bd83024bc07b6243dd59d775e7f29adc7520 

Diff: https://reviews.apache.org/r/45371/diff/


Testing
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PPC LE platform [libprocess].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44372/
---

(Updated March 28, 2016, 10:09 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Summary (updated)
-

Upgrade http-parser to 2.6.1 to support PPC LE platform [libprocess].


Bugs: MESOS-4805
https://issues.apache.org/jira/browse/MESOS-4805


Repository: mesos


Description (updated)
---

Upgrade http-parser to 2.6.1 to support PPC LE platform [libprocess].


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
6b07aefc58a1daa235b35e83832e47d1878e2e94 
  3rdparty/libprocess/3rdparty/Makefile.am 
ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
  3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch 
f9fac12437a6bedc66353fda1ce9c0d7a383225a 
  3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz 
b811b63ce0ad6d71d9d296fed76656c023c76fc5 
  3rdparty/libprocess/3rdparty/versions.am 
98195b8eb60b2673d610d8ab7ea31103f137debf 
  3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
  3rdparty/libprocess/src/decoder.hpp a20b5ba8fc50d834573d253948645cc863f030dd 

Diff: https://reviews.apache.org/r/44372/diff/


Testing
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Review Request 45369: Upgrade http-parser to 2.6.1 to support PowerPC LE platform [mesos].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45369/
---

Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Repository: mesos


Description
---

Upgrade http-parser to 2.6.1 to support PowerPC LE platform [mesos].


Diffs
-

  3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
  LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 

Diff: https://reviews.apache.org/r/45369/diff/


Testing
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45367/
---

Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Repository: mesos


Description
---

Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].


Diffs
-

  3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
  LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
  configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 
  src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af 
  src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 
  src/python/native_common/ext_modules.py.in 
c335bd83024bc07b6243dd59d775e7f29adc7520 
  src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b 

Diff: https://reviews.apache.org/r/45367/diff/


Testing
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45368/
---

Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Repository: mesos


Description
---

Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].


Diffs
-

  3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz 
e600ac57be4c88efb5f146e4b3ec226d8f685033 
  3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/versions.am 
98195b8eb60b2673d610d8ab7ea31103f137debf 

Diff: https://reviews.apache.org/r/45368/diff/


Testing
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout].

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44257/
---

(Updated March 28, 2016, 9:53 a.m.)


Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
and Vinod Kone.


Summary (updated)
-

Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout].


Bugs: MESOS-4678
https://issues.apache.org/jira/browse/MESOS-4678


Repository: mesos


Description (updated)
---

Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout].


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/README.md 
c534835db7baca1138791f2c700e95ff73052d85 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 
3d1f13082a65f9b1694ee7c65ba0cec131c18c5a 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 
fb11b1147b3a1872f60e90d0691723f9b2985427 
  3rdparty/libprocess/3rdparty/versions.am 
98195b8eb60b2673d610d8ab7ea31103f137debf 

Diff: https://reviews.apache.org/r/44257/diff/


Testing
---

sudo make dist check

sudo ./src/mesos-tests --benchmark

sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build


Thanks,

Zhiwei Chen

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

[Zhiwei Chen]

> On March 26, 2016, 5:04 a.m., Vinod Kone wrote:
> > Can you split this review into 2 reviews
> > 
> > 1) Changes needed just for protobuf upgrade to 2.6.1
> > 2) Changes needed to make it compile for PPC

Thanks, actually there is no specific changes for PPC, I just separated this 
patch for three: mesos, libprocess and stout.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44257/#review125471
---


On March 24, 2016, 9:28 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44257/
> ---
> 
> (Updated March 24, 2016, 9:28 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-4678
> https://issues.apache.org/jira/browse/MESOS-4678
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade protobuf to 2.6.1 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 
>   3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz 
> e600ac57be4c88efb5f146e4b3ec226d8f685033 
>   3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> c534835db7baca1138791f2c700e95ff73052d85 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 
> 3d1f13082a65f9b1694ee7c65ba0cec131c18c5a 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 
> fb11b1147b3a1872f60e90d0691723f9b2985427 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
>   configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 
>   src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af 
>   src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 
>   src/python/native_common/ext_modules.py.in 
> c335bd83024bc07b6243dd59d775e7f29adc7520 
>   src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b 
> 
> Diff: https://reviews.apache.org/r/44257/diff/
> 
> 
> Testing
> ---
> 
> sudo make dist check
> 
> sudo ./src/mesos-tests --benchmark
> 
> sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 43935: Allow setting role in mesos-execute.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43935/
---

(Updated 三月 28, 2016, 1:30 a.m.)


Review request for mesos, Greg Mann, Shuai Lin, and Michael Park.


Changes
---

Fix michale's comment


Bugs: MESOS-4744
https://issues.apache.org/jira/browse/MESOS-4744


Repository: mesos


Description
---

Allow setting role in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/43935/diff/


Testing
---

make & make check

start master.
./bin/mesos-master.sh --work_dir=/tmp/mesos

start slave.
./bin/mesos-slave.sh --work_dir=/tmp/mesos --master=192.168.99.1:5050 
--resources="cpus:1;cpus(test):1;mem:7500;mem(test):7500"

running mesos-execute without specifying role succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --resources="cpus:1;mem:512"

running mesos-execute with role test succeeds.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test" --resources="cpus:2;mem:512"

running mesos-execute with role test1 fails.
./src/mesos-execute --master=192.168.99.1:5050 --name="test" --command="sleep 
10" --role="test1" --resources="cpus:2;mem:512"


Thanks,

Jian Qiu

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

[Neil Conway]

> On March 26, 2016, 12:53 a.m., Jie Yu wrote:
> > src/tests/persistent_volume_tests.cpp, line 810
> > 
> >
> > What the purpose of adding another file here?

I wanted to check that if files are directly written into the directory that 
corresponds to the persistent volume (not via the task itself), they are still 
cleaned up when the volume is destroyed.


> On March 26, 2016, 12:53 a.m., Jie Yu wrote:
> > src/tests/persistent_volume_tests.cpp, line 388
> > 
> >
> > Do you want to check if MOUNT disk is empty?

Simplest way to do this seemed to be via `fs::list`.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45122/#review125499
---


On March 21, 2016, 6:44 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45122/
> ---
> 
> (Updated March 21, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2408
> https://issues.apache.org/jira/browse/MESOS-2408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated tests for deletion of persistent volumes.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 26fff19daa8b175fdcc06fd9467224d5920a1967 
> 
> Diff: https://reviews.apache.org/r/45122/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45122/
---

(Updated March 27, 2016, 10:05 p.m.)


Review request for mesos, Jie Yu and Joris Van Remoortere.


Changes
---

Address some review comments.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Updated tests for deletion of persistent volumes.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
26fff19daa8b175fdcc06fd9467224d5920a1967 

Diff: https://reviews.apache.org/r/45122/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45364/#review125571
---



Patch looks great!

Reviews applied: [45083, 45084, 45350, 45085, 45086, 45087, 45351, 45352, 
45353, 45354, 45362, 45363, 45364]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 27, 2016, 4:14 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45364/
> ---
> 
> (Updated March 27, 2016, 4:14 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5045
> https://issues.apache.org/jira/browse/MESOS-5045
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Migrate test cases for `memory` subsystem to cgroups unified isolator.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> c4e467c8227f9e4129b05d173812592f39a04e06 
> 
> Diff: https://reviews.apache.org/r/45364/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45361: Remove rmdir_tests.cpp from CMake Windows build

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45361/#review125569
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On March 27, 2016, 4:03 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45361/
> ---
> 
> (Updated March 27, 2016, 4:03 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove rmdir_tests.cpp from CMake Windows build, as it does not compile on 
> Windows. It has been moved to the NOT WIN32 section.
> 
> 
> Diffs
> -
> 
>   
> "a/C://Users//jlarriba//AppData//Local//Temp//TortoiseGit//CMa4473.tmp//CMakeLists-5e0be20-left.txt"
>  c9d331d 
> 
> Diff: https://reviews.apache.org/r/45361/diff/
> 
> 
> Testing
> ---
> 
> Correctly built mesos agent on Windows with CMake.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45121: Implemented deletion for persistent volumes.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45121/
---

(Updated March 27, 2016, 6:08 p.m.)


Review request for mesos, Jie Yu and Joris Van Remoortere.


Changes
---

Address review comments.


Bugs: MESOS-2408
https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
---

Prior to this commit, destroying a persistent volume would remove
the Mesos-level metadata about the volume, but wouldn't destroy
any of the volume's filesystem content. We now remove the volume
from the slave's filesystem, essentially via "rm -r".


Diffs (updated)
-

  src/slave/slave.cpp f383605a52f31d7b805ad6153adc409dcb40f83a 

Diff: https://reviews.apache.org/r/45121/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 45121: Implemented deletion for persistent volumes.

[Neil Conway]

> On March 26, 2016, 12:37 a.m., Jie Yu wrote:
> > src/slave/slave.cpp, line 2375
> > 
> >
> > I would suggest we don't use CHECK here. We can just LOG(ERROR) if the 
> > deletion fails. Given the TODO above, we could leak disk space anyway.

I used `CHECK_SOME` because we use the same error-handling strategy when 
creating the persistent volume fails, or if the slave fails to checkpoint 
resources to disk successfully. Are you sure we want to handle `rmdir` errors 
differently?


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45121/#review125492
---


On March 21, 2016, 6:44 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45121/
> ---
> 
> (Updated March 21, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2408
> https://issues.apache.org/jira/browse/MESOS-2408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this commit, destroying a persistent volume would remove
> the Mesos-level metadata about the volume, but wouldn't destroy
> any of the volume's filesystem content. We now remove the volume
> from the slave's filesystem, essentially via "rm -r".
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
> 
> Diff: https://reviews.apache.org/r/45121/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 45345: Added a python module to mock a CNI plugin and IPAM.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45345/#review125567
---



Patch looks great!

Reviews applied: [45345]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 27, 2016, 2:52 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45345/
> ---
> 
> (Updated March 27, 2016, 2:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-4763
> https://issues.apache.org/jira/browse/MESOS-4763
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a python module to mock a CNI plugin and IPAM.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/network/cni/cniplugin.py PRE-CREATION 
>   src/tests/containerizer/network/cni/cniplugin_test.conf PRE-CREATION 
>   src/tests/containerizer/network/cni/cniplugin_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45345/diff/
> 
> 
> Testing
> ---
> 
> Ran a test configuration against the mock plugin to make sure that the output 
> is similar to that returned by a real CNI plugin.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45362/
---

(Updated March 27, 2016, 4:19 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description (updated)
---

Add `cgroups::memory::pressure::Counter::snapshot` method. Because 
`cgroups::memory::pressure::Counter::value` method return `Future` which we 
want to avoid in `MemorySubsystem::usage`.


Diffs
-

  src/linux/cgroups.hpp 51ccefd1fd2d0989b9bd31342d3d1e3701f88ed2 
  src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 

Diff: https://reviews.apache.org/r/45362/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45363: Add `MemorySubsystem ` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45363/
---

(Updated March 27, 2016, 4:17 p.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-

Add `MemorySubsystem ` for cgroups unified isolator.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description (updated)
---

Add `MemorySubsystem ` for cgroups unified isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45363/diff/


Testing
---


Thanks,

haosdent huang

Review Request 45363: Add `MemSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45363/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `MemSubsystem` for cgroups unified isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45363/diff/


Testing
---


Thanks,

haosdent huang

Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45362/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Add `cgroups::memory::pressure::Counter::snapshot` method.


Diffs
-

  src/linux/cgroups.hpp 51ccefd1fd2d0989b9bd31342d3d1e3701f88ed2 
  src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 

Diff: https://reviews.apache.org/r/45362/diff/


Testing
---


Thanks,

haosdent huang

Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45364/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5045
https://issues.apache.org/jira/browse/MESOS-5045


Repository: mesos


Description
---

Migrate test cases for `memory` subsystem to cgroups unified isolator.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45364/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45353: Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45353/
---

(Updated March 27, 2016, 4:13 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45353/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45354: Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45354/
---

(Updated March 27, 2016, 4:13 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45354/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45352/
---

(Updated March 27, 2016, 4:13 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5043
https://issues.apache.org/jira/browse/MESOS-5043


Repository: mesos


Description
---

Add `CpuacctSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45352/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45084/
---

(Updated March 27, 2016, 4:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5039
https://issues.apache.org/jira/browse/MESOS-5039


Repository: mesos


Description
---

Add `Subsystem` abstraction for cgroups.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45084/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45350/
---

(Updated March 27, 2016, 4:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5040
https://issues.apache.org/jira/browse/MESOS-5040


Repository: mesos


Description
---

Add `--cgroups_subsystems` in agent flags.


Diffs (updated)
-

  docs/configuration.md 9ad0c2a201130ac23b22b1a844396dc97ec5ff70 
  src/slave/flags.hpp 9ee7f349cc2bb3fa76141645f4a06fad57664367 
  src/slave/flags.cpp fd9fbbaa911cc77a21574ba314c50ac226fa49ce 

Diff: https://reviews.apache.org/r/45350/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45351: Migrate test cases for `cpu` subsystem to cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45351/
---

(Updated March 27, 2016, 4:13 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Migrate test cases for `cpu` subsystem to cgroups unified isolator.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 

Diff: https://reviews.apache.org/r/45351/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/
---

(Updated March 27, 2016, 4:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Enable cgroups unified isolator in isolation.


Diffs (updated)
-

  src/CMakeLists.txt 7bda2ac684f38da94e334f0cef843614687ae4aa 
  src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c 
  src/slave/containerizer/mesos/containerizer.cpp 
e7f7e7fd1304e14dbfaab8b53cea16efc0417911 

Diff: https://reviews.apache.org/r/45086/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45087/
---

(Updated March 27, 2016, 4:13 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5042
https://issues.apache.org/jira/browse/MESOS-5042


Repository: mesos


Description
---

Add `CpuSubsystem` for cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45087/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45085: Add cgroups unified isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45085/
---

(Updated March 27, 2016, 4:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Add cgroups unified isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/45085/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45083: Added a any mechanism for futures.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
---

(Updated March 27, 2016, 4:12 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038


Repository: mesos


Description
---

Added a any mechanism for futures.


Diffs (updated)
-

  3rdparty/libprocess/include/process/collect.hpp 
5a92b72eb7668494dc832ec446a41b3d673a20cc 
  3rdparty/libprocess/src/tests/collect_tests.cpp 
155e0bb75cf723a0a6c29020f9f767e3ba3d7401 

Diff: https://reviews.apache.org/r/45083/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45361: Remove rmdir_tests.cpp from CMake Windows build

[Juan Larriba]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45361/
---

(Updated Mar. 27, 2016, 4:03 p.m.)


Review request for mesos.


Repository: mesos


Description
---

Remove rmdir_tests.cpp from CMake Windows build, as it does not compile on 
Windows. It has been moved to the NOT WIN32 section.


Diffs
-

  
"a/C://Users//jlarriba//AppData//Local//Temp//TortoiseGit//CMa4473.tmp//CMakeLists-5e0be20-left.txt"
 c9d331d 

Diff: https://reviews.apache.org/r/45361/diff/


Testing
---

Correctly built mesos agent on Windows with CMake.


Thanks,

Juan Larriba

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/#review125566
---



Patch looks great!

Reviews applied: [45358]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 27, 2016, 2:41 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45358/
> ---
> 
> (Updated March 27, 2016, 2:41 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.
> 
> 
> Bugs: MESOS-4944
> https://issues.apache.org/jira/browse/MESOS-4944
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved overlay backend to make the rootfs writable.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> e7f7e7fd1304e14dbfaab8b53cea16efc0417911 
>   src/slave/containerizer/mesos/provisioner/backend.hpp 
> c6cca81e287bb9a62e0390f96e1773841887a206 
>   src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
> 9eda944e14f2b05f28620c2e40594ed4e7bab69e 
>   src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
> 9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
>   src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
> b62507f9fc757349d39f39a6654ddd69053bf0e7 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
> f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
> 85cc737438c88b355f37611bfde50dc80efab017 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 5cc0f8b5a8cd4c945023f874056a8184113186c5 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 8a4938ebe4e00779e88e7c538445e9ffd51202e2 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 23a5b1059b4d9fde1e4a1aab5cd4fa6d05862332 
>   src/tests/containerizer/provisioner_backend_tests.cpp 
> d49204f220c6212f83c2adf5544d04b3386c8eb7 
> 
> Diff: https://reviews.apache.org/r/45358/diff/
> 
> 
> Testing
> ---
> 
> - make check
> - tested manually, with slave using overlay backend. Create a task with mesos 
> containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
> /abc/def.txt`.
> - also tested manually with alpine image to verify overlay backend could 
> support 1-layer images.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 45345: Added a python module to mock a CNI plugin and IPAM.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45345/
---

(Updated March 27, 2016, 2:52 p.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
---

Fixed a typo in the comments.


Bugs: MESOS-4763
https://issues.apache.org/jira/browse/MESOS-4763


Repository: mesos


Description
---

Added a python module to mock a CNI plugin and IPAM.


Diffs (updated)
-

  src/tests/containerizer/network/cni/cniplugin.py PRE-CREATION 
  src/tests/containerizer/network/cni/cniplugin_test.conf PRE-CREATION 
  src/tests/containerizer/network/cni/cniplugin_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/45345/diff/


Testing
---

Ran a test configuration against the mock plugin to make sure that the output 
is similar to that returned by a real CNI plugin.


Thanks,

Avinash sridharan

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/
---

(Updated March 27, 2016, 2:41 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.


Bugs: MESOS-4944
https://issues.apache.org/jira/browse/MESOS-4944


Repository: mesos


Description
---

Improved overlay backend to make the rootfs writable.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
e7f7e7fd1304e14dbfaab8b53cea16efc0417911 
  src/slave/containerizer/mesos/provisioner/backend.hpp 
c6cca81e287bb9a62e0390f96e1773841887a206 
  src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
9eda944e14f2b05f28620c2e40594ed4e7bab69e 
  src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
  src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
b62507f9fc757349d39f39a6654ddd69053bf0e7 
  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
85cc737438c88b355f37611bfde50dc80efab017 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
5cc0f8b5a8cd4c945023f874056a8184113186c5 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
8a4938ebe4e00779e88e7c538445e9ffd51202e2 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_appc_tests.cpp 
23a5b1059b4d9fde1e4a1aab5cd4fa6d05862332 
  src/tests/containerizer/provisioner_backend_tests.cpp 
d49204f220c6212f83c2adf5544d04b3386c8eb7 

Diff: https://reviews.apache.org/r/45358/diff/


Testing
---

- make check
- tested manually, with slave using overlay backend. Create a task with mesos 
containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
/abc/def.txt`.
- also tested manually with alpine image to verify overlay backend could 
support 1-layer images.


Thanks,

Shuai Lin

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/
---

(Updated March 27, 2016, 2:40 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.


Repository: mesos


Description
---

Improved overlay backend to make the rootfs writable.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
e7f7e7fd1304e14dbfaab8b53cea16efc0417911 
  src/slave/containerizer/mesos/provisioner/backend.hpp 
c6cca81e287bb9a62e0390f96e1773841887a206 
  src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
9eda944e14f2b05f28620c2e40594ed4e7bab69e 
  src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
  src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
b62507f9fc757349d39f39a6654ddd69053bf0e7 
  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
85cc737438c88b355f37611bfde50dc80efab017 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
5cc0f8b5a8cd4c945023f874056a8184113186c5 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
8a4938ebe4e00779e88e7c538445e9ffd51202e2 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_appc_tests.cpp 
23a5b1059b4d9fde1e4a1aab5cd4fa6d05862332 
  src/tests/containerizer/provisioner_backend_tests.cpp 
d49204f220c6212f83c2adf5544d04b3386c8eb7 

Diff: https://reviews.apache.org/r/45358/diff/


Testing (updated)
---

- make check
- tested manually, with slave using overlay backend. Create a task with mesos 
containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
/abc/def.txt`.
- also tested manually with alpine image to verify overlay backend could 
support 1-layer images.


Thanks,

Shuai Lin

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/
---

(Updated March 27, 2016, 2:39 p.m.)


Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.


Changes
---

Overlay backend can also support one-layer images now.


Repository: mesos


Description (updated)
---

Improved overlay backend to make the rootfs writable.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
e7f7e7fd1304e14dbfaab8b53cea16efc0417911 
  src/slave/containerizer/mesos/provisioner/backend.hpp 
c6cca81e287bb9a62e0390f96e1773841887a206 
  src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
9eda944e14f2b05f28620c2e40594ed4e7bab69e 
  src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
  src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
b62507f9fc757349d39f39a6654ddd69053bf0e7 
  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
85cc737438c88b355f37611bfde50dc80efab017 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
5cc0f8b5a8cd4c945023f874056a8184113186c5 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
8a4938ebe4e00779e88e7c538445e9ffd51202e2 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_appc_tests.cpp 
23a5b1059b4d9fde1e4a1aab5cd4fa6d05862332 
  src/tests/containerizer/provisioner_backend_tests.cpp 
d49204f220c6212f83c2adf5544d04b3386c8eb7 

Diff: https://reviews.apache.org/r/45358/diff/


Testing
---

- make check
- tested manually, with slave using overlay backend. Create a task with mesos 
containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
/abc/def.txt`.


Thanks,

Shuai Lin

Review Request 45358: Improved overlay backend to make the rootfs writable.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45358/
---

Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu.


Repository: mesos


Description
---

Containerizer now passes the task sandbox directory as the extra parameter to 
the provisioner, so overlayfs backend can create the upperdir and workdir there.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
e7f7e7fd1304e14dbfaab8b53cea16efc0417911 
  src/slave/containerizer/mesos/provisioner/backend.hpp 
c6cca81e287bb9a62e0390f96e1773841887a206 
  src/slave/containerizer/mesos/provisioner/backends/bind.hpp 
9eda944e14f2b05f28620c2e40594ed4e7bab69e 
  src/slave/containerizer/mesos/provisioner/backends/bind.cpp 
9b9f0b9e99a0fc0e9bad8fb2dad41acdc0ca1da1 
  src/slave/containerizer/mesos/provisioner/backends/copy.hpp 
b62507f9fc757349d39f39a6654ddd69053bf0e7 
  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 
f353c89806816e85bb27875ef5fa68d5c0eaf9ca 
  src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 
85cc737438c88b355f37611bfde50dc80efab017 
  src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
5cc0f8b5a8cd4c945023f874056a8184113186c5 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
8a4938ebe4e00779e88e7c538445e9ffd51202e2 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_appc_tests.cpp 
23a5b1059b4d9fde1e4a1aab5cd4fa6d05862332 
  src/tests/containerizer/provisioner_backend_tests.cpp 
d49204f220c6212f83c2adf5544d04b3386c8eb7 

Diff: https://reviews.apache.org/r/45358/diff/


Testing
---

- make check
- tested manually, with slave using overlay backend. Create a task with mesos 
containerizer, ubuntu docker image, with the command `mkdir -p /abc && touch 
/abc/def.txt`.


Thanks,

Shuai Lin