Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46187/#review130285
---



Patch looks great!

Reviews applied: [46187]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 24, 2016, 12:18 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46187/
> ---
> 
> (Updated April 24, 2016, 12:18 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Terminate when receiving the ACK of terminal status update.
> 
> 
> Diffs
> -
> 
>   src/launcher/http_command_executor.cpp 
> 0b4136c040ec9cf585c0d38f8471495a855cd640 
> 
> Diff: https://reviews.apache.org/r/46187/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45377: Ignored docker volume when updating container volume path.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45377/#review130284
---




src/slave/slave.cpp (lines 3826 - 3831)


Can you adjust the comments here? It's not just for docker volumes. For 
other volume source types we'll add in the future, it also applies, right?


- Jie Yu


On April 24, 2016, 3:44 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45377/
> ---
> 
> (Updated April 24, 2016, 3:44 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored docker volume when updating container volume path.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp ebf26065326be67db435f1b097964c8ff2e1dbe0 
> 
> Diff: https://reviews.apache.org/r/45377/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45377: Ignored docker volume when updating container volume path.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45377/
---

(Updated 四月 24, 2016, 3:44 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Ignored docker volume when updating container volume path.


Diffs (updated)
-

  src/slave/slave.cpp ebf26065326be67db435f1b097964c8ff2e1dbe0 

Diff: https://reviews.apache.org/r/45377/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45377: Ignored docker volume when updating container volume path.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45377/#review130282
---


Fix it, then Ship it!





src/slave/slave.cpp (line 3825)


Add one more line above.


- Gilbert Song


On April 22, 2016, 7:03 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45377/
> ---
> 
> (Updated April 22, 2016, 7:03 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ignored docker volume when updating container volume path.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp ebf26065326be67db435f1b097964c8ff2e1dbe0 
> 
> Diff: https://reviews.apache.org/r/45377/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45670: Updated tests for HTTP command executor.

[Qian Zhang]

> On April 13, 2016, 5:11 a.m., Vinod Kone wrote:
> > Are you also planning to update slave recovery tests? Those are the most 
> > crucial.
> 
> Qian Zhang wrote:
> Sure, I will update slave recovery tests soon. Just want to double 
> confirm, in `slave_recovery_tests.cpp`, I see there are two TODOs related to 
> HTTP based command executor in two test cases:
> 
> https://github.com/apache/mesos/blob/0.28.0/src/tests/slave_recovery_tests.cpp#L462
> 
> https://github.com/apache/mesos/blob/0.28.0/src/tests/slave_recovery_tests.cpp#L1082
> 
> You mean I need to update these two test cases with the HTTP command 
> executor I implemented in MESOS-3558, right?
> 
> Vinod Kone wrote:
> Definitely those two and the one we talked about in the earlier review.
> 
> It would also be good to add the following tests for HTTP command 
> executor. There are already tests for this for driver based command executor.
> 
> --> RecoverUnregisteredHTTPExecutor 
> --> RecoverTerminatedExecutor
> --> KillTask
> 
> Qian Zhang wrote:
> OK, I have posted a patch (https://reviews.apache.org/r/46204/) to update 
> those two tests and add two more (`RecoverUnregisteredHTTPExecutor` and 
> `KillTaskWithHTTPExecutor`) in slave recovery tests, and I will post a 
> separate patch for adding the test that slave restarts with flag change.
> 
> But for the test `RecoverTerminatedExecutor`, I have a question: we need 
> to shutdown the executor when agent is down, for the driver based executor, I 
> see we use `process::post(executorPid, ShutdownExecutorMessage())`, but for 
> HTTP based executor, I am not sure how to shutdown it in the test, any 
> suggestions? Thanks.
> 
> Anand Mazumdar wrote:
> We currently don't have the ability to insert `Event`'s on the response 
> stream. I filed https://issues.apache.org/jira/browse/MESOS-5220 to deal with 
> it.
> 
> As Vinod suggested: For now, you would need to manually kill the 
> `forkedPid` similar to what is being done here: 
> https://github.com/apache/mesos/blob/master/src/tests/slave_recovery_tests.cpp#L2484
> 
> Can you also add a comment adding a `TODO` linking to MESOS-5220 once you 
> do this change so that this is tracked?

Thanks Anand, I have posted a separate patch for the test 
`SlaveRecoveryTest.RecoverTerminatedHTTPExecutor`: 
https://reviews.apache.org/r/46609/.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45670/#review128535
---


On April 13, 2016, 5:15 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45670/
> ---
> 
> (Updated April 13, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated tests for HTTP command executor.
> 
> 
> Diffs
> -
> 
>   src/tests/command_executor_tests.cpp 
> 843233adaa68ab1f5cedb7b075439bb8b77469a8 
> 
> Diff: https://reviews.apache.org/r/45670/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 46609: [WIP] Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46609/
---

(Updated April 24, 2016, 8:26 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".


Diffs
-

  src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c 

Diff: https://reviews.apache.org/r/46609/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 46609: [WIP] Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46609/
---

(Updated April 24, 2016, 8:25 a.m.)


Review request for mesos.


Summary (updated)
-

[WIP] Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".


Repository: mesos


Description (updated)
---

Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".


Diffs
-

  src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c 

Diff: https://reviews.apache.org/r/46609/diff/


Testing
---


Thanks,

Qian Zhang

Review Request 46609: Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46609/
---

Review request for mesos.


Repository: mesos


Description
---

[WIP]Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".


Diffs
-

  src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c 

Diff: https://reviews.apache.org/r/46609/diff/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 46204: Updated slave recovery tests with HTTP command executor.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46204/
---

(Updated April 24, 2016, 8:23 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Updated slave recovery tests with HTTP command executor.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 8ad63224e0fdd203cb8dbfbc2d2484e3ce52a10c 

Diff: https://reviews.apache.org/r/46204/diff/


Testing
---

$ sudo make check GTEST_FILTER="SlaveRecoveryTest*HTTPExecutor"
...

[==] Running 4 tests from 1 test case.
[--] Global test environment set-up.
[--] 4 tests from SlaveRecoveryTest/0, where TypeParam = 
mesos::internal::slave::MesosContainerizer
[ RUN  ] SlaveRecoveryTest/0.ReconnectHTTPExecutor
I0414 23:13:11.715150  1989 executor.cpp:174] Version: 0.29.0
Received SUBSCRIBED event
Subscribed executor on mesos
Received LAUNCH event
Starting task bf66407c-b780-4bcc-b8de-6d30fe7b2660
Forked command at 1997
sh -c 'sleep 1000'
Received ERROR event
Error: Received unexpected '500 Internal Server Error' () for UPDATE
E0414 23:13:11.819635  1994 executor.cpp:663] End-Of-File received from agent. 
The agent closed the event stream
Received ERROR event
Error: Received unexpected '400 Bad Request' () for SUBSCRIBE
Received SUBSCRIBED event
Subscribed executor on mesos
Received ACKNOWLEDGED event
Received SHUTDOWN event
Shutting down
Sending SIGTERM to process tree at pid 1997
[   OK ] SlaveRecoveryTest/0.ReconnectHTTPExecutor (3418 ms)
[ RUN  ] SlaveRecoveryTest/0.RecoverUnregisteredHTTPExecutor
I0414 23:13:15.050401  2021 executor.cpp:174] Version: 0.29.0
Received ERROR event
Error: Received unexpected '500 Internal Server Error' () for SUBSCRIBE
[   OK ] SlaveRecoveryTest/0.RecoverUnregisteredHTTPExecutor (1502 ms)
[ RUN  ] SlaveRecoveryTest/0.CleanupHTTPExecutor
I0414 23:13:16.502077  2081 executor.cpp:174] Version: 0.29.0
Received SUBSCRIBED event
Subscribed executor on mesos
Received LAUNCH event
Starting task 1efe8ac8-d2d5-46d3-99e5-b09cfbab269d
Forked command at 2088
sh -c 'sleep 1000'
Received ERROR event
Error: Received unexpected '500 Internal Server Error' () for UPDATE
E0414 23:13:16.604841  2080 executor.cpp:663] End-Of-File received from agent. 
The agent closed the event stream
Received ERROR event
Error: Received unexpected '400 Bad Request' () for SUBSCRIBE
[   OK ] SlaveRecoveryTest/0.CleanupHTTPExecutor (2348 ms)
[ RUN  ] SlaveRecoveryTest/0.KillTaskWithHTTPExecutor
I0414 23:13:18.936816  2130 executor.cpp:174] Version: 0.29.0
Received SUBSCRIBED event
Subscribed executor on mesos
Received LAUNCH event
Starting task f399801f-0f78-4458-8485-a50a2f082c45
Forked command at 2133
sh -c 'sleep 1000'
Received ACKNOWLEDGED event
E0414 23:13:19.176312  2127 executor.cpp:663] End-Of-File received from agent. 
The agent closed the event stream
Received ERROR event
Error: Received unexpected '400 Bad Request' () for SUBSCRIBE
Received SUBSCRIBED event
Subscribed executor on mesos
Received KILL event
Received kill for task f399801f-0f78-4458-8485-a50a2f082c45
Sending SIGTERM to process tree at pid 2133
Sent SIGTERM to the following process trees:
[ 
-+- 2133 sh -c sleep 1000 
 --- 2134 sleep 1000 
]
Command terminated with signal Terminated (pid: 2133)
Received ACKNOWLEDGED event
[   OK ] SlaveRecoveryTest/0.KillTaskWithHTTPExecutor (3725 ms)
[--] 4 tests from SlaveRecoveryTest/0 (11033 ms total)

[--] Global test environment tear-down
[==] 4 tests from 1 test case ran. (11052 ms total)
[  PASSED  ] 4 tests.


Thanks,

Qian Zhang

Re: Review Request 46188: Added the missing 'break' when handling ERROR event.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46188/
---

(Updated April 24, 2016, 8:20 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Added the missing 'break' when handling ERROR event.


Diffs
-

  src/launcher/http_command_executor.cpp 
ad484e0e6f5067b6c166111c91b1ff1e8c05d9ac 

Diff: https://reviews.apache.org/r/46188/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46187/
---

(Updated April 24, 2016, 8:18 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Made sure the executor self terminates if the task has not been launched when 
receiving SHUTDOWN event.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Terminate when receiving the ACK of terminal status update.


Diffs (updated)
-

  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 

Diff: https://reviews.apache.org/r/46187/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46392/#review130278
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On April 23, 2016, 10:28 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46392/
> ---
> 
> (Updated April 23, 2016, 10:28 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit introduces temporary versions of 2 important functions:
> `os::nonblock` and `os::cloexec`. We put them here in a placeholder
> commit so that reviewers can make progress on subprocess. In the
> immediate term, the plan is to figure out on a callsite-by-callsite
> basis how to work around the functionality of `os::cloexec`. When we
> collect more data, we will be in a better position to offer a way
> forward here.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/fcntl.hpp 
> 14734317d7fb40053ee808745ac3ba8c706a7669 
> 
> Diff: https://reviews.apache.org/r/46392/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/
---

(Updated April 23, 2016, 11:41 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637


Repository: mesos


Description
---

Libprocess: Implemented `subprocess_windows.cpp`.


Diffs
-

  3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46608/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46608/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Libprocess: Implemented `subprocess_windows.cpp`.


Diffs
-

  3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46608/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/
---

(Updated April 23, 2016, 11:40 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Summary (updated)
-

Windows: Forked `subprocess.cpp`.


Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637


Repository: mesos


Description
---

Windows: Forked subprocess.cpp, added `Windows` implementation.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 
  3rdparty/libprocess/include/process/subprocess.hpp 
6ce1a827e36e0c65985e3928c89f51561fdd70cd 
  3rdparty/libprocess/src/CMakeLists.txt 
a8379d323f30037bdd15e151957f885664b5e242 
  3rdparty/libprocess/src/subprocess.cpp 
bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 
  3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
  3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46423/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46395/
---

(Updated April 23, 2016, 11:26 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637


Repository: mesos


Description
---

Windows: Removed `std::bind` from `process.cpp` to build on Windows.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 8727eb202e9699f0ac3c95788257cf1a22b0da7b 

Diff: https://reviews.apache.org/r/46395/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46344/#review130277
---



Patch looks great!

Reviews applied: [46009, 46010, 43985, 46447, 46285, 46293, 46013, 46014, 
46015, 46191, 46192, 46193, 46340, 46341, 46344]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 23, 2016, 9:50 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46344/
> ---
> 
> (Updated April 23, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3656
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46344/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

[Qian Zhang]

> On April 15, 2016, 12:49 a.m., Vinod Kone wrote:
> > src/launcher/http_command_executor.cpp, line 749
> > 
> >
> > Looking at slave::statusUpdate() code there are several scenarios where 
> > the slave ignores a status update sent by the executor; this means this 
> > executor could end up not terminating forever.
> > 
> > Can you do the following:
> > 
> > --> Enque a message in the queue to self terminate after some timeout 
> > (you can use the delay() function) to be safe.
> > 
> > --> Add a TODO that we do this to be safe and also because slave 
> > sometimes doesn't ACK a status update. Link to a ticket that fixes the 
> > slave status update semantics to always ACK a status update sent by an 
> > executor.
> > 
> > sounds good?
> 
> Vinod Kone wrote:
> @Qian, any update on this? If this particular review is going to take 
> some time, I think it is still useful two commit the other 2 reviews in this 
> chain. AFAICT, they are independent of this review?
> 
> Qian Zhang wrote:
> @Vinod, sorry for the late. I have filed a ticket 
> (https://issues.apache.org/jira/browse/MESOS-5262) for enhancing 
> `slave::statusUpdate()` to always ACK the status update sent by executor.
> 
> And can you please elaborate about the specific scenarios this executor 
> could not terminate forever. Originially I thought the scenario should be: 
> executor sends a terminal status upate to slave when the corresponding 
> framework is in `TERMINATING` state (e.g., operator tears down the 
> framework), then in `Slave::statusUpdate()`, this status update will be 
> ignored, so the executor will not get the ACK. But after testing, I found in 
> this case the executor can still terminate, because the container 
> corresponded to this executor will be destroyed by 
> `Slave::shutdownExecutorTimeout()` -> `MesosContainerizer::destroy()`, so 
> after `--executor_shutdown_grace_period`, the executor can still terminate. 
> So I am not in which case the executor will never terminate.
> 
> And yes, the other 2 patches are independent of this one, I will make 
> them not depending on this one in the review board, thanks!

After more thinking, I see one scenario the executor could never terminate is: 
agent is down right after it sends SHUTDOWN event to executor. In this case, 
when handling the SHUTDOWN event, executor will kill the task and send 
TASK_KILLED status update to agent, but it will not get ACK since agent is 
already down, so the executor will still run. But I think once agent is started 
again, executor will receive the ACK and then terminate. I am not sure if this 
behavior is OK, or we want executor to terminate once it receives the SHUTDOWN 
event rather than wait for agent is started again?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46187/#review128916
---


On April 14, 2016, 1:17 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46187/
> ---
> 
> (Updated April 14, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Terminate when receiving the ACK of terminal status update.
> 
> 
> Diffs
> -
> 
>   src/launcher/http_command_executor.cpp 
> ad484e0e6f5067b6c166111c91b1ff1e8c05d9ac 
> 
> Diff: https://reviews.apache.org/r/46187/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

[Alex Clemmer]

> On April 22, 2016, 10:04 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/process.cpp, line 897
> > 
> >
> > space between `(char*)` and ``

Let's actually make it a C++ cast.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46395/#review130196
---


On April 19, 2016, 4:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46395/
> ---
> 
> (Updated April 19, 2016, 4:35 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Removed `std::bind` from `process.cpp` to build on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> d2c458ed93307f75358bb642aaf2ed8e17b2fe97 
> 
> Diff: https://reviews.apache.org/r/46395/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46424: Windows: Added libprocess to build.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46424/
---

(Updated April 23, 2016, 10:30 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3103
https://issues.apache.org/jira/browse/MESOS-3103


Repository: mesos


Description
---

Windows: Added libprocess to build.


Diffs (updated)
-

  3rdparty/libprocess/CMakeLists.txt 5633c395bcb3b3ce377193c1ca1d6d9810c97852 
  3rdparty/libprocess/src/tests/CMakeLists.txt 
9558adf1e45043630b637fa6fb21dc92ec036bd4 
  3rdparty/libprocess/src/tests/main.cpp 
78858a2b84a439d8f8a60ec8bcb6ac3a308087a6 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46424/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46392: Windows:[PLACEHOLDER] Implemented fcntl nonblock and other items.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46392/
---

(Updated April 23, 2016, 10:28 p.m.)


Review request for mesos.


Repository: mesos


Description
---

This commit introduces temporary versions of 2 important functions:
`os::nonblock` and `os::cloexec`. We put them here in a placeholder
commit so that reviewers can make progress on subprocess. In the
immediate term, the plan is to figure out on a callsite-by-callsite
basis how to work around the functionality of `os::cloexec`. When we
collect more data, we will be in a better position to offer a way
forward here.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/fcntl.hpp 
14734317d7fb40053ee808745ac3ba8c706a7669 

Diff: https://reviews.apache.org/r/46392/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46607: Stout:[2/2] Added `socket_tests.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46607/
---

(Updated April 23, 2016, 10:27 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout:[2/2] Added `socket_tests.cpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 
f7aa579f133d19c3ef252773c5ed868c977785cd 

Diff: https://reviews.apache.org/r/46607/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 46607: Stout:[2/2] Added `socket_tests.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46607/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout:[2/2] Added `socket_tests.cpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 
f7aa579f133d19c3ef252773c5ed868c977785cd 

Diff: https://reviews.apache.org/r/46607/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 46606: Stout:[1/2] Added `socket_tests.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46606/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout:[1/2] Added `socket_tests.cpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/Makefile.am 
10be36652034ea5860f122ffb45ee50cc72ffdb3 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp 
6290234aa0ac682270cfe3a9512676e181128b60 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
c9df907dd09de1c09dd8dfb74e052eb2fc8e9935 
  3rdparty/libprocess/3rdparty/stout/tests/os/socket_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46606/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

[Alex Clemmer]

> On April 22, 2016, 9:20 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/windows/winsock.hpp, lines 56-68
> > 
> >
> > Why not use the `Once` pattern used for initialization in the rest of 
> > the code base.
> > Take a look at `process.cpp`

I don't know what you had in mind, so I just `Once`'d the `initialize` 
function, and just made the destructor stupider (_i.e._, we no longer check 
that cleanup was successful).


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46344/#review130185
---


On April 23, 2016, 9:50 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46344/
> ---
> 
> (Updated April 23, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3656
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46344/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46344/
---

(Updated April 23, 2016, 9:50 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3656
https://issues.apache.org/jira/browse/MESOS-3656


Repository: mesos


Description
---

Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.


Diffs (updated)
-

  3rdparty/libprocess/include/Makefile.am 
47f5347988a61140c87bcd329e25d5a4d52e17a0 
  3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46344/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46393: Windows: Fixed shell constants, mark `os::shell` as deleted.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46393/
---

(Updated April 23, 2016, 6:56 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Summary (updated)
-

Windows: Fixed shell constants, mark `os::shell` as deleted.


Bugs: MESOS-3643
https://issues.apache.org/jira/browse/MESOS-3643


Repository: mesos


Description
---

Windows: Added Windows support for `stout/os/shell.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 
18f038fa405b45daa5b3b46e4caee0904d7fdd1c 

Diff: https://reviews.apache.org/r/46393/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46564: Fixed a typo in Docker containerizer.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46564/#review130258
---


Ship it!




Ship It!

- Timothy Chen


On April 22, 2016, 10:40 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46564/
> ---
> 
> (Updated April 22, 2016, 10:40 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a typo in Docker containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 30f85a13f70fc2b1e04dbf0ca7f47bff806e4672 
> 
> Diff: https://reviews.apache.org/r/46564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45671: Added version checking for dvdcli.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/#review130254
---



Patch looks great!

Reviews applied: [45671]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 23, 2016, 2:16 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45671/
> ---
> 
> (Updated April 23, 2016, 2:16 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5251
> https://issues.apache.org/jira/browse/MESOS-5251
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added version checking for dvdcli.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> c63fa02b8f13014bbcac6984a49eaa919d26b489 
> 
> Diff: https://reviews.apache.org/r/45671/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130253
---



Patch looks great!

Reviews applied: [45377, 45370, 45375, 45674, 44454]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 23, 2016, 8:37 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated April 23, 2016, 8:37 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

[Qian Zhang]

> On April 15, 2016, 12:49 a.m., Vinod Kone wrote:
> > src/launcher/http_command_executor.cpp, line 749
> > 
> >
> > Looking at slave::statusUpdate() code there are several scenarios where 
> > the slave ignores a status update sent by the executor; this means this 
> > executor could end up not terminating forever.
> > 
> > Can you do the following:
> > 
> > --> Enque a message in the queue to self terminate after some timeout 
> > (you can use the delay() function) to be safe.
> > 
> > --> Add a TODO that we do this to be safe and also because slave 
> > sometimes doesn't ACK a status update. Link to a ticket that fixes the 
> > slave status update semantics to always ACK a status update sent by an 
> > executor.
> > 
> > sounds good?
> 
> Vinod Kone wrote:
> @Qian, any update on this? If this particular review is going to take 
> some time, I think it is still useful two commit the other 2 reviews in this 
> chain. AFAICT, they are independent of this review?

@Vinod, sorry for the late. I have filed a ticket 
(https://issues.apache.org/jira/browse/MESOS-5262) for enhancing 
`slave::statusUpdate()` to always ACK the status update sent by executor.

And can you please elaborate about the specific scenarios this executor could 
not terminate forever. Originially I thought the scenario should be: executor 
sends a terminal status upate to slave when the corresponding framework is in 
`TERMINATING` state (e.g., operator tears down the framework), then in 
`Slave::statusUpdate()`, this status update will be ignored, so the executor 
will not get the ACK. But after testing, I found in this case the executor can 
still terminate, because the container corresponded to this executor will be 
destroyed by `Slave::shutdownExecutorTimeout()` -> 
`MesosContainerizer::destroy()`, so after `--executor_shutdown_grace_period`, 
the executor can still terminate. So I am not in which case the executor will 
never terminate.

And yes, the other 2 patches are independent of this one, I will make them not 
depending on this one in the review board, thanks!


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46187/#review128916
---


On April 14, 2016, 1:17 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46187/
> ---
> 
> (Updated April 14, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Terminate when receiving the ACK of terminal status update.
> 
> 
> Diffs
> -
> 
>   src/launcher/http_command_executor.cpp 
> ad484e0e6f5067b6c166111c91b1ff1e8c05d9ac 
> 
> Diff: https://reviews.apache.org/r/46187/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 46428: Added agent flag to turn on/off docker volume reference counter.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46428/
---

(Updated 四月 23, 2016, 8:54 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Added agent flag to turn on/off docker volume reference counter.


Diffs (updated)
-

  docs/configuration.md 86ba66ac62295ca148524bcb2e57fee560ac4ac5 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 
  src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a 
  src/slave/flags.cpp 10d2974bd2b6e79255fc894979607f0d2d00c315 

Diff: https://reviews.apache.org/r/46428/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45265: Plugged in docker volume isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45265/
---

(Updated 四月 23, 2016, 8:49 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Plugged in docker volume isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
133c0fed49b626ce730c8a23565aeca437558424 

Diff: https://reviews.apache.org/r/45265/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 44609: Enabled sequene when unmount.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44609/
---

Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Enabled sequene when unmount.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
bedc687cc280d0b721fb84801039fd3614364cca 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 

Diff: https://reviews.apache.org/r/44609/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 44454: Enabled Sequence mount for prepare().

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/
---

(Updated 四月 23, 2016, 8:37 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Enabled Sequence mount for prepare().


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
bedc687cc280d0b721fb84801039fd3614364cca 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 

Diff: https://reviews.apache.org/r/44454/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45674: Implemented recover() for dvd isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45674/
---

(Updated 四月 23, 2016, 8:20 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5104
https://issues.apache.org/jira/browse/MESOS-5104


Repository: mesos


Description
---

Implemented recover() for dvd isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
bedc687cc280d0b721fb84801039fd3614364cca 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 

Diff: https://reviews.apache.org/r/45674/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 44454: Enabled Sequence mount for prepare().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130251
---



Bad patch!

Reviews applied: [44454, 45370, 45377]

Failed command: ./support/apply-review.sh -n -r 44454

Error:
2016-04-23 08:08:20 URL:https://reviews.apache.org/r/44454/diff/raw/ 
[3213/3213] -> "44454.patch" [1]
error: patch failed: 
src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp:87
error: src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp: 
patch does not apply
error: patch failed: 
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp:241
error: src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp: 
patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12685/console

- Mesos ReviewBot


On April 22, 2016, 4:11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated April 22, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45375/
---

(Updated 四月 23, 2016, 7:58 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Implemented cleanup() for docker volume isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
bedc687cc280d0b721fb84801039fd3614364cca 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 

Diff: https://reviews.apache.org/r/45375/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45370: Implemented prepare() for volume isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45370/
---

(Updated 四月 23, 2016, 7:06 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Implemented prepare() for volume isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
bedc687cc280d0b721fb84801039fd3614364cca 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 
  src/slave/containerizer/mesos/isolators/docker/volume/state.hpp 
bc0c3299f9f3e351aaa20652b784bccbfd40c1a5 

Diff: https://reviews.apache.org/r/45370/diff/


Testing
---

make
make check

Will update `Sequence` later.


Thanks,

Guangya Liu