> On April 22, 2016, 9:20 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/windows/winsock.hpp, lines 56-68 > > <https://reviews.apache.org/r/46344/diff/1/?file=1348676#file1348676line56> > > > > Why not use the `Once` pattern used for initialization in the rest of > > the code base. > > Take a look at `process.cpp`
I don't know what you had in mind, so I just `Once`'d the `initialize` function, and just made the destructor stupider (_i.e._, we no longer check that cleanup was successful). - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46344/#review130185 ----------------------------------------------------------- On April 23, 2016, 9:50 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46344/ > ----------------------------------------------------------- > > (Updated April 23, 2016, 9:50 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3656 > https://issues.apache.org/jira/browse/MESOS-3656 > > > Repository: mesos > > > Description > ------- > > Libprocess: Created Winsock class to handle WSAStartup/WSACleanup. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > 47f5347988a61140c87bcd329e25d5a4d52e17a0 > 3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46344/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
