Re: Review Request 47069: Added `user` field to `Task` protobuf message.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/#review134233
---



Do we not need to update other parts such as `bool operator==(const Task&, 
const Task&);`, and exposing the `user` field in `/state`, etc?

- Michael Park


On May 17, 2016, 9:28 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47069/
> ---
> 
> (Updated May 17, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The LocalAuthorizer might use the OS \`user\` for
> authorization of tasks, so we add it to the \`Task\` protobuf
> message. Note that the master stores \`Task\` (as opposed
> to \`TaskInfo\`) for running and completed tasks.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
>   src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
> 
> Diff: https://reviews.apache.org/r/47069/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

[haosdent huang]

> On May 20, 2016, 5:02 a.m., Cong Wang wrote:
> > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3927
> > 
> >
> > You need to move this check into the script rather than in the C++ 
> > code. Something like "test -f /proc/sys/net/ipv6/conf/all/disable_ipv6 && 
> > echo 1 > /proc/sys/net/ipv6/conf/all/disable_ipv6".
> 
> Zhengju Sha wrote:
> Thanks for the reply.
> I thought this way before, but I notice that we also use os::exists() to 
> check other file in this function, so I choose to keep in consistent. Both of 
> the manner is okay IMHO, is there other considerations to move it to bash 
> script?
> 
> haosdent huang wrote:
> Hmm, keep consistent more reasonable. Because we have
> 
> ```
>   // Enable route_localnet on lo because by default 127.0.0.1 traffic
>   // is dropped. This feature exists on 3.6 kernel or newer.
>   if (os::exists(path::join("/proc/sys/net/ipv4/conf", lo, 
> "route_localnet"))) {
> script << "echo 1 > /proc/sys/net/ipv4/conf/" << lo << 
> "/route_localnet\n";
>   }
> ```
> 
> Cong Wang wrote:
> Nope, you don't understand it. Ipv6 module could be removed during 
> preparation and launch, although not likely, but still.

Thanks @wangcong's nice explanation, it make sense. My bad to post that before.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47633/#review134101
---


On May 20, 2016, 3:54 a.m., Zhengju Sha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47633/
> ---
> 
> (Updated May 20, 2016, 3:54 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5381
> https://issues.apache.org/jira/browse/MESOS-5381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Isolation/networking: check if IPv6 is loaded before trying to disable it
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
> 
> Diff: https://reviews.apache.org/r/47633/diff/
> 
> 
> Testing
> ---
> 
> Enniornment and steps:
> 1. Enable mesos-slave --isolation=network/port_mapping on CentOS7.2 with 
> kernel version: 3.10.0-327.10.1.el7.x86_64
> 2. Create application on marathon framework with commands such as "echo 
> hello" using MesosContainerizer
> 3. Load IPv6 module by removing "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 4. Disable IPv6 module by adding "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 
> Now mesos can run both of the testcases successfully.
> 
> 
> Thanks,
> 
> Zhengju Sha
> 
>

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46498/#review134229
---



Patch looks great!

Reviews applied: [46498]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 21, 2016, 12:24 a.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46498/
> ---
> 
> (Updated May 21, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add runtime for Appc Spec ex: command, workingdir and environment.
> 
> 
> Diffs
> -
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
>   src/Makefile.am b1c84aeb27fb86330f501ed389ec1d696cdf11a9 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 84fe52b6937c3b7d7628b17a2f045eec2f386b4d 
> 
> Diff: https://reviews.apache.org/r/46498/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44839/
---

(Updated 五月 21, 2016, 1:32 a.m.)


Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-4886
https://issues.apache.org/jira/browse/MESOS-4886


Repository: mesos


Description
---

Enabled mesos containerizer force_pull_image for appc.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 

Diff: https://reviews.apache.org/r/44839/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

[Guangya Liu]

> On 五月 20, 2016, 11:09 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/provisioner/appc/store.cpp, lines 223-224
> > 
> >
> > The logic can be much clear if we dont have this log, but I guess we 
> > may want to keep it.

Yes, it is better keep a log message here to make it clear to end user.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44839/#review134215
---


On 五月 14, 2016, 1:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44839/
> ---
> 
> (Updated 五月 14, 2016, 1:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled mesos containerizer force_pull_image for appc.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
> 
> Diff: https://reviews.apache.org/r/44839/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46498/
---

(Updated May 21, 2016, 12:24 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.


Repository: mesos


Description
---

Add runtime for Appc Spec ex: command, workingdir and environment.


Diffs (updated)
-

  include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
  include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
  src/Makefile.am b1c84aeb27fb86330f501ed389ec1d696cdf11a9 
  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 
  src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
  src/slave/containerizer/mesos/provisioner/store.hpp 
1d477ef13ddd24fd8badae0decaa4a2271ecc746 
  src/tests/containerizer/provisioner_appc_tests.cpp 
84fe52b6937c3b7d7628b17a2f045eec2f386b4d 

Diff: https://reviews.apache.org/r/46498/diff/


Testing
---


Thanks,

Srinivas Brahmaroutu

Re: Review Request 47636: Fixed some coding error in mesos-ps.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47636/#review134219
---


Ship it!




Ship It!

- Vinod Kone


On May 20, 2016, 6:07 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47636/
> ---
> 
> (Updated May 20, 2016, 6:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> cpus_system_time_secs and cpus_user_time_secs should be
> defined first before use, otherwise exception will be
> thrown if there is no time statistics.
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-ps f7fac4bab10939687cd67644851e9a29f365b4ad 
> 
> Diff: https://reviews.apache.org/r/47636/diff/
> 
> 
> Testing
> ---
> 
> root@mesos002:/usr/local/bin# mesos ps --master=192.168.56.12:5050 
> --verbose=true
> USERFRAMEWORKTASK  SLAVE  MEMTIME 
>  CPU (allocated)
> rootmesos-exe... test  mesos002   4.7 MB/160.0 MB
> 00:00:04.51   1.1
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

[Gilbert Song]

> On May 20, 2016, 4:14 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 1189
> > 
> >
> > Seems like the reporter in MESOS-5197 is requesting `LOG(INFO)`. Sorry 
> > for previous confusions.

Nvm.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46874/#review134217
---


On May 9, 2016, 3:39 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46874/
> ---
> 
> (Updated May 9, 2016, 3:39 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5347
> https://issues.apache.org/jira/browse/MESOS-5347
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The mesos-containerizer will help prepare the rootfs, mount and
> network conf for a container when launch with some flags, it
> would be helpful to print out all of the mesos-containerizer launch
> flags for trouble shooting.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
> 
> Diff: https://reviews.apache.org/r/46874/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Enhanced log message:
> I0501 14:12:17.910006  5991 containerizer.cpp:1175] Launching 
> 'mesos-containerizer' with flags 
> '--command="{"shell":true,"value":"\/root\/src\/mesos\/m1\/mesos\/build\/src\/mesos-executor"}"
>  --commands="{"commands":[{"shell":true,"value":"#!\/bin\/sh\nset -x 
> -e\n\/root\/src\/mesos\/m1\/mesos\/build\/src\/mesos-containerizer mount 
> --help=\"false\" --operation=\"make-rslave\" --path=\"\/\"\ngrep -E 
> '\/tmp\/mesos\/.+' \/proc\/self\/mountinfo | grep -v 
> 'a2cc264f-72eb-416c-b876-e4a98484a0ab' | cut -d' ' -f5 | xargs 
> --no-run-if-empty umount -l || true \n"}]}" --help="false" --pipe_read="8" 
> --pipe_write="9" 
> --sandbox="/tmp/mesos/slaves/5763efb9-8e12-4bfc-b06b-2a324881608d-S0/frameworks/425afd24-796d-42dd-98c0-593f1d71e246-/executors/test/runs/a2cc264f-72eb-416c-b876-e4a98484a0ab"
>  --user="root"'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47671: Windows: [2/2] Used `initialize()` in FlagsBase's derived classes.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47671/#review134216
---



Patch looks great!

Reviews applied: [47473, 47492, 47486, 47474, 47489, 47442, 47670, 47671]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 10:14 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47671/
> ---
> 
> (Updated May 20, 2016, 10:14 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-5428
> https://issues.apache.org/jira/browse/MESOS-5428
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: [2/2] Used `initialize()` in FlagsBase's derived classes.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp 69a1fb256fe3005e814833ecac5a5a642b585510 
>   src/executor/executor.cpp fd2d0cd64956b5a407e37ddaa1e9e35c1456d57b 
>   src/launcher/fetcher.cpp 0539b0182bd4a7178f1031ab4fee8fc79eda 
>   src/logging/flags.hpp fe40a11c6a5e3ef44ecf008d1aa03d4e74e59859 
>   src/logging/flags.cpp db8fd3e0328f0f8be6968e58b173ce4c11c8adcb 
>   src/slave/flags.hpp 3363412099ca2841e175bd6b6ed3d5f13605e6f0 
>   src/slave/flags.cpp 2d59329997197966f7d30d6f1375a988edbceb9c 
>   src/slave/main.cpp 13ddfb9ae5a1ca240b738e67391ce5c5fc9ac0b6 
> 
> Diff: https://reviews.apache.org/r/47671/diff/
> 
> 
> Testing
> ---
> 
> OSX make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46498/
---

(Updated May 20, 2016, 10:59 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.


Repository: mesos


Description
---

Add runtime for Appc Spec ex: command, workingdir and environment.


Diffs (updated)
-

  include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
  include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
  src/Makefile.am b1c84aeb27fb86330f501ed389ec1d696cdf11a9 
  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 
  src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/appc/store.cpp 
33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
  src/slave/containerizer/mesos/provisioner/store.hpp 
1d477ef13ddd24fd8badae0decaa4a2271ecc746 
  src/tests/containerizer/provisioner_appc_tests.cpp 
84fe52b6937c3b7d7628b17a2f045eec2f386b4d 

Diff: https://reviews.apache.org/r/46498/diff/


Testing
---


Thanks,

Srinivas Brahmaroutu

Re: Review Request 47671: Windows: [2/2] Used `initialize()` in FlagsBase's derived classes.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47671/
---

(Updated May 20, 2016, 10:14 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Bugs: MESOS-5428
https://issues.apache.org/jira/browse/MESOS-5428


Repository: mesos


Description
---

Windows: [2/2] Used `initialize()` in FlagsBase's derived classes.


Diffs
-

  src/exec/exec.cpp 69a1fb256fe3005e814833ecac5a5a642b585510 
  src/executor/executor.cpp fd2d0cd64956b5a407e37ddaa1e9e35c1456d57b 
  src/launcher/fetcher.cpp 0539b0182bd4a7178f1031ab4fee8fc79eda 
  src/logging/flags.hpp fe40a11c6a5e3ef44ecf008d1aa03d4e74e59859 
  src/logging/flags.cpp db8fd3e0328f0f8be6968e58b173ce4c11c8adcb 
  src/slave/flags.hpp 3363412099ca2841e175bd6b6ed3d5f13605e6f0 
  src/slave/flags.cpp 2d59329997197966f7d30d6f1375a988edbceb9c 
  src/slave/main.cpp 13ddfb9ae5a1ca240b738e67391ce5c5fc9ac0b6 

Diff: https://reviews.apache.org/r/47671/diff/


Testing
---

OSX make check


Thanks,

Daniel Pravat

Re: Review Request 47670: Windows: [1/2] Introduced `initialize()` for FlagsBase class.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47670/
---

(Updated May 20, 2016, 10:14 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Bugs: MESOS-5428
https://issues.apache.org/jira/browse/MESOS-5428


Repository: mesos


Description
---

Windows: [1/2] Introduced `initialize()` for FlagsBase class.


Diffs
-

  3rdparty/stout/include/stout/flags/flags.hpp 
91542f56431579be8a3da5ec6e3e58f68e7dfcbe 

Diff: https://reviews.apache.org/r/47670/diff/


Testing
---

OSX: make ckeck


Thanks,

Daniel Pravat

Review Request 47670: Windows: [1/2] Introduced `initialize()` for FlagsBase class.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47670/
---

Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: [1/2] Introduced `initialize()` for FlagsBase class.


Diffs
-

  3rdparty/stout/include/stout/flags/flags.hpp 
91542f56431579be8a3da5ec6e3e58f68e7dfcbe 

Diff: https://reviews.apache.org/r/47670/diff/


Testing
---

OSX: make ckeck


Thanks,

Daniel Pravat

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

[Cong Wang]

> On May 20, 2016, 5:02 a.m., Cong Wang wrote:
> > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3927
> > 
> >
> > You need to move this check into the script rather than in the C++ 
> > code. Something like "test -f /proc/sys/net/ipv6/conf/all/disable_ipv6 && 
> > echo 1 > /proc/sys/net/ipv6/conf/all/disable_ipv6".
> 
> Zhengju Sha wrote:
> Thanks for the reply.
> I thought this way before, but I notice that we also use os::exists() to 
> check other file in this function, so I choose to keep in consistent. Both of 
> the manner is okay IMHO, is there other considerations to move it to bash 
> script?
> 
> haosdent huang wrote:
> Hmm, keep consistent more reasonable. Because we have
> 
> ```
>   // Enable route_localnet on lo because by default 127.0.0.1 traffic
>   // is dropped. This feature exists on 3.6 kernel or newer.
>   if (os::exists(path::join("/proc/sys/net/ipv4/conf", lo, 
> "route_localnet"))) {
> script << "echo 1 > /proc/sys/net/ipv4/conf/" << lo << 
> "/route_localnet\n";
>   }
> ```

Nope, you don't understand it. Ipv6 module could be removed during preparation 
and launch, although not likely, but still.


- Cong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47633/#review134101
---


On May 20, 2016, 3:54 a.m., Zhengju Sha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47633/
> ---
> 
> (Updated May 20, 2016, 3:54 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5381
> https://issues.apache.org/jira/browse/MESOS-5381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Isolation/networking: check if IPv6 is loaded before trying to disable it
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
> 
> Diff: https://reviews.apache.org/r/47633/diff/
> 
> 
> Testing
> ---
> 
> Enniornment and steps:
> 1. Enable mesos-slave --isolation=network/port_mapping on CentOS7.2 with 
> kernel version: 3.10.0-327.10.1.el7.x86_64
> 2. Create application on marathon framework with commands such as "echo 
> hello" using MesosContainerizer
> 3. Load IPv6 module by removing "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 4. Disable IPv6 module by adding "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 
> Now mesos can run both of the testcases successfully.
> 
> 
> Thanks,
> 
> Zhengju Sha
> 
>

Re: Review Request 46613: Introduced filtering relevant actions and acls.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/
---

(Updated May 20, 2016, 9:05 p.m.)


Review request for Adam B, Alexander Rojas and Michael Park.


Bugs: MESOS-5169
https://issues.apache.org/jira/browse/MESOS-5169


Repository: mesos


Description (updated)
---

In order to allow for framework and task level filtering we introduce
the following authorizer actions:
* FILTER_FRAMEWORK_WITH_INFO
* FILTER_TASK_WITH_EXECUTOR_INFO = 13;
* FILTER_TASK_WITH_COMMAND_INFO = 14;
* VFILTER_TASK_WITH_TASK = 15;

Note that we need different actions for authorizing a tasks
based on the object being authorized.

We also introduce the following acls for the local authorizer:
* ViewFrameworks  (giving access to frameworks run by a
   specific OS user)
* ViewTasks view_tasks (giving access to Tasks run under a
specific OS user)


Diffs
-

  docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
  include/mesos/authorizer/acls.proto 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
  include/mesos/authorizer/authorizer.proto 
32492a59ad95df3bb673ec42321518f86c11af59 
  src/authorizer/local/authorizer.cpp aa1a9d8e5c7fb86b6310015d93aeacb466a307ef 

Diff: https://reviews.apache.org/r/46613/diff/


Testing
---

make check (OSX)


Thanks,

Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/
---

(Updated May 20, 2016, 9:03 p.m.)


Review request for Adam B, Alexander Rojas and Michael Park.


Changes
---

Addressed review.


Bugs: MESOS-5169
https://issues.apache.org/jira/browse/MESOS-5169


Repository: mesos


Description (updated)
---

In order to allow for framework and task level filtering we introduce
the following authorizer actions:
* VIEW_FRAMEWORK_WITH_INFO
* VIEW_TASK_WITH_EXECUTOR_INFO = 13;
* VIEW_TASK_WITH_COMMAND_INFO = 14;
* VIEW_TASK_WITH_TASK = 15;

Note that we need different actions for authorizing a tasks
based on the object being authorized.

We also introduce the following acls for the local authorizer:
* ViewFrameworks  (giving access to frameworks running in
a given role)
* ViewTasks view_tasks (giving access to Tasks run under a
specific OS user)


Diffs (updated)
-

  docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
  include/mesos/authorizer/acls.proto 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
  include/mesos/authorizer/authorizer.proto 
32492a59ad95df3bb673ec42321518f86c11af59 
  src/authorizer/local/authorizer.cpp aa1a9d8e5c7fb86b6310015d93aeacb466a307ef 

Diff: https://reviews.apache.org/r/46613/diff/


Testing
---

make check (OSX)


Thanks,

Joerg Schad

Re: Review Request 47386: Stout: Implemented `setHostname` on Windows.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47386/#review134202
---


Ship it!




Ship It!

- Joris Van Remoortere


On May 14, 2016, 11:58 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47386/
> ---
> 
> (Updated May 14, 2016, 11:58 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-5383
> https://issues.apache.org/jira/browse/MESOS-5383
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `setHostname` on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 9b39ce32c0269479066cf7991afaeed65d8ab547 
>   3rdparty/stout/include/stout/net.hpp 
> 1c99d893af34b834faf8c4e1bd5aee1b377af84f 
>   3rdparty/stout/include/stout/posix/net.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/windows/net.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47386/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134184
---




docs/release-guide.md (line 180)


This isn't really a step in "updating the website".  As such, I'd probably 
move this to the last step and reword it slightly.

```
5. Write a blog post announcing the new release and its features and major 
bug fixes. Include a link to the updated website.
```


- Kevin Klues


On May 20, 2016, 5:30 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134177
---



Patch looks great!

Reviews applied: [47646]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 5:30 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[haosdent huang]

> On May 20, 2016, 5:01 p.m., Kevin Klues wrote:
> > docs/release-guide.md, line 190
> > 
> >
> > s/Noted/Note
> > 
> > s/when build it/
> > s/when building it/
> > 
> > Is it obvious how to do this from the README?

Thank you very much for your reviews.

>Is it obvious how to do this from the README?

Yes, `site/README.md` include the instructions.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134161
---


On May 20, 2016, 5:29 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/
---

(Updated May 20, 2016, 5:29 p.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Address @klueska's comments


Bugs: MESOS-5423
https://issues.apache.org/jira/browse/MESOS-5423


Repository: mesos


Description
---

Updated the outdated website section in release-guide.md.


Diffs (updated)
-

  docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 

Diff: https://reviews.apache.org/r/47646/diff/


Testing
---

Could check it via github 
https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website


Thanks,

haosdent huang

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134161
---




docs/release-guide.md (line 182)


s/releases/release

s/in/on/



docs/release-guide.md (line 186)


s/for the details/for details/



docs/release-guide.md (line 187)


s/Noted/Note

s/when build it/
s/when building it/

Is it obvious how to do this from the README?



docs/release-guide.md (line 189)


s/Check/Check out/

s/update it by/update it with/

s/our new version website pages/the new version of the the website/


- Kevin Klues


On May 20, 2016, 3:34 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134159
---



Patch looks great!

Reviews applied: [47646]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 3:34 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/
---

(Updated May 20, 2016, 3:34 p.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-5423
https://issues.apache.org/jira/browse/MESOS-5423


Repository: mesos


Description
---

Updated the outdated website section in release-guide.md.


Diffs (updated)
-

  docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 

Diff: https://reviews.apache.org/r/47646/diff/


Testing
---

Could check it via github 
https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website


Thanks,

haosdent huang

Review Request 47646: Updated the outdated website section in release-guide.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/
---

Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Bugs: MESOS-5423
https://issues.apache.org/jira/browse/MESOS-5423


Repository: mesos


Description
---

Updated the outdated website section in release-guide.md.


Diffs
-

  docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 

Diff: https://reviews.apache.org/r/47646/diff/


Testing
---

Could check it via github 
https://github.com/haosdent/mesos/blob/54d210be8900839f012386514fd2c276b4b638cd/docs/release-guide.md#updating-the-website


Thanks,

haosdent huang

Re: Review Request 47645: Updated the outdated website README.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47645/#review134152
---



Patch looks great!

Reviews applied: [47645]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 2:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47645/
> ---
> 
> (Updated May 20, 2016, 2:49 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5422
> https://issues.apache.org/jira/browse/MESOS-5422
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website README.md.
> 
> 
> Diffs
> -
> 
>   site/README.md eb90a86721d9a2636f98512e2e957e375ccc5110 
> 
> Diff: https://reviews.apache.org/r/47645/diff/
> 
> 
> Testing
> ---
> 
> Could verified via my github branch.
> https://github.com/haosdent/mesos/tree/update_site_doc/site
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47645: Updated the outdated website README.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47645/
---

(Updated May 20, 2016, 2:49 p.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Add jira ticekt number.


Bugs: MESOS-5422
https://issues.apache.org/jira/browse/MESOS-5422


Repository: mesos


Description
---

Updated the outdated website README.md.


Diffs
-

  site/README.md eb90a86721d9a2636f98512e2e957e375ccc5110 

Diff: https://reviews.apache.org/r/47645/diff/


Testing
---

Could verified via my github branch.
https://github.com/haosdent/mesos/tree/update_site_doc/site


Thanks,

haosdent huang

Review Request 47645: Updated the outdated website README.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47645/
---

Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Repository: mesos


Description
---

Updated the outdated website README.md.


Diffs
-

  site/README.md eb90a86721d9a2636f98512e2e957e375ccc5110 

Diff: https://reviews.apache.org/r/47645/diff/


Testing
---

Could verified via my github branch.
https://github.com/haosdent/mesos/tree/update_site_doc/site


Thanks,

haosdent huang

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review134145
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-05-20 14:22:44 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[12354/12354] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13201/console

- Mesos ReviewBot


On May 20, 2016, 1:51 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 20, 2016, 1:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated May 20, 2016, 1:51 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Added "Limitation" section


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47641: Fix navbar alignment on large screen.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47641/#review134130
---



Patch looks great!

Reviews applied: [47641]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 8:16 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47641/
> ---
> 
> (Updated May 20, 2016, 8:16 a.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, haosdent huang, Tim Anderegg, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
> https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On screens with more than 992px navbar is aligned to the bottom
> of the header, this patch change this behaviour and navbar
> is vertically centered
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css bfee2dd6810bb341c1e8c2504d6338a76518ace9 
> 
> Diff: https://reviews.apache.org/r/47641/diff/
> 
> 
> Testing
> ---
> 
> ![compare](http://s32.postimg.org/6soj2c6h1/compare.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47635: Removed /observe document.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47635/#review134125
---



Patch looks great!

Reviews applied: [47635]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 6:17 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47635/
> ---
> 
> (Updated May 20, 2016, 6:17 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5408
> https://issues.apache.org/jira/browse/MESOS-5408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed /observe document.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md d57239edb1d2708452ce2f687634227d50bbafc4 
>   docs/endpoints/master/observe.md 9ebd527788bbd2fd2dd833242c24ac561f826c30 
> 
> Diff: https://reviews.apache.org/r/47635/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47641: Fix navbar alignment on large screen.

[Freddy Ayuso-Henson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47641/#review134121
---


Ship it!




Ship It!

- Freddy Ayuso-Henson


On May 20, 2016, 8:16 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47641/
> ---
> 
> (Updated May 20, 2016, 8:16 a.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, haosdent huang, Tim Anderegg, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
> https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On screens with more than 992px navbar is aligned to the bottom
> of the header, this patch change this behaviour and navbar
> is vertically centered
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css bfee2dd6810bb341c1e8c2504d6338a76518ace9 
> 
> Diff: https://reviews.apache.org/r/47641/diff/
> 
> 
> Testing
> ---
> 
> ![compare](http://s32.postimg.org/6soj2c6h1/compare.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47641: Fix navbar alignment on large screen.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47641/#review134120
---


Ship it!




Ship It!

- haosdent huang


On May 20, 2016, 8:16 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47641/
> ---
> 
> (Updated May 20, 2016, 8:16 a.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, haosdent huang, Tim Anderegg, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
> https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On screens with more than 992px navbar is aligned to the bottom
> of the header, this patch change this behaviour and navbar
> is vertically centered
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css bfee2dd6810bb341c1e8c2504d6338a76518ace9 
> 
> Diff: https://reviews.apache.org/r/47641/diff/
> 
> 
> Testing
> ---
> 
> ![compare](http://s32.postimg.org/6soj2c6h1/compare.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47510: Adjusted style to make website mobile friendly.

[Tomasz Janiszewski]

> On May 20, 2016, 7:33 a.m., haosdent huang wrote:
> > site/source/assets/css/main.css, lines 133-139
> > 
> >
> > Thanks @janisz's keen eyesight, this make website navbar could not 
> > align vertically. He would send a patch to fix this shortly.

Patch is here https://reviews.apache.org/r/47641/


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47510/#review134114
---


On May 18, 2016, 6:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47510/
> ---
> 
> (Updated May 18, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
> https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted style to make website mobile friendly.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
>   site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 
> 
> Diff: https://reviews.apache.org/r/47510/diff/
> 
> 
> Testing
> ---
> 
> # Note
> @vinodkone, this should credited to @fayusohenson and @janisz when submit.
> I pick the necessary changes for mobile friendly from 
> https://github.com/apache/mesos/pull/75 .
> 
> And record some simple videos under mobile, tablet and pc to show this patch.
> 
> ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif)
> ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif)
> ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 47641: Fix navbar alignment on large screen.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47641/
---

Review request for mesos, Freddy Ayuso-Henson, haosdent huang, Tim Anderegg, 
and Vinod Kone.


Bugs: MESOS-3690
https://issues.apache.org/jira/browse/MESOS-3690


Repository: mesos


Description
---

On screens with more than 992px navbar is aligned to the bottom
of the header, this patch change this behaviour and navbar
is vertically centered


Diffs
-

  site/source/assets/css/main.css bfee2dd6810bb341c1e8c2504d6338a76518ace9 

Diff: https://reviews.apache.org/r/47641/diff/


Testing
---

![compare](http://s32.postimg.org/6soj2c6h1/compare.png)


Thanks,

Tomasz Janiszewski

Re: Review Request 47636: Fixed some coding error in mesos-ps.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47636/#review134118
---



Patch looks great!

Reviews applied: [47636]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 20, 2016, 6:07 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47636/
> ---
> 
> (Updated May 20, 2016, 6:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> cpus_system_time_secs and cpus_user_time_secs should be
> defined first before use, otherwise exception will be
> thrown if there is no time statistics.
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-ps f7fac4bab10939687cd67644851e9a29f365b4ad 
> 
> Diff: https://reviews.apache.org/r/47636/diff/
> 
> 
> Testing
> ---
> 
> root@mesos002:/usr/local/bin# mesos ps --master=192.168.56.12:5050 
> --verbose=true
> USERFRAMEWORKTASK  SLAVE  MEMTIME 
>  CPU (allocated)
> rootmesos-exe... test  mesos002   4.7 MB/160.0 MB
> 00:00:04.51   1.1
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

[haosdent huang]

> On May 20, 2016, 5:02 a.m., Cong Wang wrote:
> > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3927
> > 
> >
> > You need to move this check into the script rather than in the C++ 
> > code. Something like "test -f /proc/sys/net/ipv6/conf/all/disable_ipv6 && 
> > echo 1 > /proc/sys/net/ipv6/conf/all/disable_ipv6".
> 
> Zhengju Sha wrote:
> Thanks for the reply.
> I thought this way before, but I notice that we also use os::exists() to 
> check other file in this function, so I choose to keep in consistent. Both of 
> the manner is okay IMHO, is there other considerations to move it to bash 
> script?

Hmm, keep consistent more reasonable. Because we have

```
  // Enable route_localnet on lo because by default 127.0.0.1 traffic
  // is dropped. This feature exists on 3.6 kernel or newer.
  if (os::exists(path::join("/proc/sys/net/ipv4/conf", lo, "route_localnet"))) {
script << "echo 1 > /proc/sys/net/ipv4/conf/" << lo << "/route_localnet\n";
  }
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47633/#review134101
---


On May 20, 2016, 3:54 a.m., Zhengju Sha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47633/
> ---
> 
> (Updated May 20, 2016, 3:54 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5381
> https://issues.apache.org/jira/browse/MESOS-5381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Isolation/networking: check if IPv6 is loaded before trying to disable it
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
> 
> Diff: https://reviews.apache.org/r/47633/diff/
> 
> 
> Testing
> ---
> 
> Enniornment and steps:
> 1. Enable mesos-slave --isolation=network/port_mapping on CentOS7.2 with 
> kernel version: 3.10.0-327.10.1.el7.x86_64
> 2. Create application on marathon framework with commands such as "echo 
> hello" using MesosContainerizer
> 3. Load IPv6 module by removing "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 4. Disable IPv6 module by adding "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 
> Now mesos can run both of the testcases successfully.
> 
> 
> Thanks,
> 
> Zhengju Sha
> 
>

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

[Zhengju Sha]

> On 五月 20, 2016, 5:02 a.m., Cong Wang wrote:
> > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3927
> > 
> >
> > You need to move this check into the script rather than in the C++ 
> > code. Something like "test -f /proc/sys/net/ipv6/conf/all/disable_ipv6 && 
> > echo 1 > /proc/sys/net/ipv6/conf/all/disable_ipv6".

Thanks for the reply.
I thought this way before, but I notice that we also use os::exists() to check 
other file in this function, so I choose to keep in consistent. Both of the 
manner is okay IMHO, is there other considerations to move it to bash script?


- Zhengju


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47633/#review134101
---


On 五月 20, 2016, 3:54 a.m., Zhengju Sha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47633/
> ---
> 
> (Updated 五月 20, 2016, 3:54 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5381
> https://issues.apache.org/jira/browse/MESOS-5381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Isolation/networking: check if IPv6 is loaded before trying to disable it
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
> 
> Diff: https://reviews.apache.org/r/47633/diff/
> 
> 
> Testing
> ---
> 
> Enniornment and steps:
> 1. Enable mesos-slave --isolation=network/port_mapping on CentOS7.2 with 
> kernel version: 3.10.0-327.10.1.el7.x86_64
> 2. Create application on marathon framework with commands such as "echo 
> hello" using MesosContainerizer
> 3. Load IPv6 module by removing "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 4. Disable IPv6 module by adding "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 
> Now mesos can run both of the testcases successfully.
> 
> 
> Thanks,
> 
> Zhengju Sha
> 
>

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

[Zhengju Sha]

> On 五月 20, 2016, 5:09 a.m., haosdent huang wrote:
> > Thank you for your patch. For summary and description, it should be limited 
> > in 72 characters, otherwise could not pass jenkins build.

Yeah, I received the failed message. Thanks for the reminding!


> On 五月 20, 2016, 5:09 a.m., haosdent huang wrote:
> > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3926
> > 
> >
> > I suggest to change comment like
> > ```
> >   // Disable IPv6 when IPv6 module was loaded as IPv6 packets won't be 
> > forwarded
> >   // anyway.
> > ```

Nice catch, will update it next version. Thanks!


- Zhengju


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47633/#review134094
---


On 五月 20, 2016, 3:54 a.m., Zhengju Sha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47633/
> ---
> 
> (Updated 五月 20, 2016, 3:54 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-5381
> https://issues.apache.org/jira/browse/MESOS-5381
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Isolation/networking: check if IPv6 is loaded before trying to disable it
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
> 
> Diff: https://reviews.apache.org/r/47633/diff/
> 
> 
> Testing
> ---
> 
> Enniornment and steps:
> 1. Enable mesos-slave --isolation=network/port_mapping on CentOS7.2 with 
> kernel version: 3.10.0-327.10.1.el7.x86_64
> 2. Create application on marathon framework with commands such as "echo 
> hello" using MesosContainerizer
> 3. Load IPv6 module by removing "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 4. Disable IPv6 module by adding "ipv6.disable=1" of GRUB_CMDLINE_LINUX in 
> /etc/default/grub
> 
> Now mesos can run both of the testcases successfully.
> 
> 
> Thanks,
> 
> Zhengju Sha
> 
>

Re: Review Request 47510: Adjusted style to make website mobile friendly.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47510/#review134114
---




site/source/assets/css/main.css (lines 131 - 137)


Thanks @janisz's keen eyesight, this make website navbar could not align 
vertically. He would send a patch to fix this shortly.


- haosdent huang


On May 18, 2016, 6:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47510/
> ---
> 
> (Updated May 18, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos, Freddy Ayuso-Henson, Tomasz Janiszewski, Tim 
> Anderegg, and Vinod Kone.
> 
> 
> Bugs: MESOS-3690
> https://issues.apache.org/jira/browse/MESOS-3690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted style to make website mobile friendly.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
>   site/source/layouts/layout.erb 2bf6967faad45644647b732be0fa3c410b9951c5 
> 
> Diff: https://reviews.apache.org/r/47510/diff/
> 
> 
> Testing
> ---
> 
> # Note
> @vinodkone, this should credited to @fayusohenson and @janisz when submit.
> I pick the necessary changes for mobile friendly from 
> https://github.com/apache/mesos/pull/75 .
> 
> And record some simple videos under mobile, tablet and pc to show this patch.
> 
> ![home_mobile.gif](https://issues.apache.org/jira/secure/attachment/12804724/home_mobile.gif)
> ![home_tablet.gif](https://issues.apache.org/jira/secure/attachment/12804726/home_tablet.gif)
> ![home_pc.gif](https://issues.apache.org/jira/secure/attachment/12804725/home_pc.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47635: Removed /observe document.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47635/#review134109
---


Ship it!




Ship It!

- haosdent huang


On May 20, 2016, 6:17 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47635/
> ---
> 
> (Updated May 20, 2016, 6:17 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5408
> https://issues.apache.org/jira/browse/MESOS-5408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed /observe document.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md d57239edb1d2708452ce2f687634227d50bbafc4 
>   docs/endpoints/master/observe.md 9ebd527788bbd2fd2dd833242c24ac561f826c30 
> 
> Diff: https://reviews.apache.org/r/47635/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 47635: Removed /observe document.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47635/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-5408
https://issues.apache.org/jira/browse/MESOS-5408


Repository: mesos


Description
---

Removed /observe document.


Diffs
-

  docs/endpoints/index.md d57239edb1d2708452ce2f687634227d50bbafc4 
  docs/endpoints/master/observe.md 9ebd527788bbd2fd2dd833242c24ac561f826c30 

Diff: https://reviews.apache.org/r/47635/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 47636: Fixed some coding error in mesos-ps.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47636/
---

Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.


Repository: mesos


Description
---

cpus_system_time_secs and cpus_user_time_secs should be
defined first before use, otherwise exception will be
thrown if there is no time statistics.


Diffs
-

  src/cli/mesos-ps f7fac4bab10939687cd67644851e9a29f365b4ad 

Diff: https://reviews.apache.org/r/47636/diff/


Testing
---

root@mesos002:/usr/local/bin# mesos ps --master=192.168.56.12:5050 
--verbose=true
USERFRAMEWORKTASK  SLAVE  MEMTIME   
   CPU (allocated)
rootmesos-exe... test  mesos002   4.7 MB/160.0 MB
00:00:04.51   1.1


Thanks,

Guangya Liu