Review Request 50117: Added more elapse time for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50117/ --- Review request for mesos, Benjamin Mahler, Klaus Ma, and Jiang Yan Xu.

Re: Review Request 50115: Used `Clock::settle()` to check if the operations are processed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50115/#review142533 --- Patch looks great! Reviews applied: [49943, 49781, 50060, 50061,

Review Request 50115: Used `Clock::settle()` to check if the operations are processed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50115/ --- Review request for mesos, Benjamin Mahler, Jie Yu, Klaus Ma, and Jiang Yan Xu.

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review142528 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/#review142519 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp

Re: Review Request 50114: Added missing tables attributes in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50114/#review142526 --- Patch looks great! Reviews applied: [50114] Passed command:

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review142525 --- Patch looks great! Reviews applied: [49837, 49844] Passed

Review Request 50114: Added missing tables attributes in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50114/ --- Review request for mesos, Alexander Rojas, Kapil Arya, and Vinod Kone.

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/ --- (Updated July 17, 2016, 9:15 p.m.) Review request for mesos, Vinod Kone and

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated July 17, 2016, 8:44 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 49571: Added a benchmark test for allocations and shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review142523 --- Bad patch! Reviews applied: [49571, 45967, 45966, 45964, 45963,

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated July 17, 2016, 6:31 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated July 17, 2016, 6:31 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated July 17, 2016, 6:30 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated July 17, 2016, 6:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

- Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review141305 --- On July 17, 2016, 6:28 p.m., Anindya Sinha wrote: >

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated July 17, 2016, 6:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On July 12, 2016, 7:26 a.m., Jiang Yan Xu wrote: > > Adding to the previous partial review after discussion. > > > > ## Invariant checking and documentation > > > > An overall comment is that I think since we keep track of shared resource > > across Master, allocator and sorter, each for a

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 17, 2016, 6:28 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On July 11, 2016, 6:17 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp, lines 3499-3502 > > > > > > `task.has_executor()` doesn't always lead to additional resources being > > used/charged against the

Re: Review Request 50017: WIP: Validated the resources when parsing it.

> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 49825: Implemented `CgroupsIsolatorProcess::status`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49825/#review142518 --- For this patch, I have exactly same comments with

Re: Review Request 49824: Implemented `CgroupsIsolatorProcess::usage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/#review142517 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp

Re: Review Request 49823: Implemented `CgroupsIsolatorProcess::update`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/#review142516 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp

Re: Review Request 49821: Implemented `CgroupsIsolatorProcess::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49821/#review142515 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/#review142514 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/#review142513 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review142510 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp

Re: Review Request 50017: WIP: Validated the resources when parsing it.

> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/#review142508 --- Fix it, then Ship it!