Review Request 50633: Libprocess: [1/2] Parameterized decoder tests for incremental parsing.

2016-07-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50633/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 30, 2016, 6:08 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50627: Used `await` instead of `collect` on `Subsystem` operations.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50627/ --- (Updated July 30, 2016, 6:05 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

2016-07-30 Thread Yong Tang
> On July 30, 2016, 5:36 p.m., haosdent huang wrote: > > support/mesos-style.py, line 20 > > > > > > I think we forgot update this since we update bundle dependencies last > > time. May you post this in a sperate

Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

2016-07-30 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50629/ --- (Updated July 30, 2016, 6 p.m.) Review request for mesos, haosdent huang and

Review Request 50630: Update exclued_files in mesos-style.py.

2016-07-30 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50630/ --- Review request for mesos, haosdent huang and Deshi Xiao. Repository: mesos

Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

2016-07-30 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50629/ --- Review request for mesos, haosdent huang and Deshi Xiao. Bugs: MESOS-5186

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 30, 2016, 5:26 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50627: Used `await` instead of `collect` on `Subsystem` operations.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50627/#review144262 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

2016-07-30 Thread haosdent huang
> On July 28, 2016, 12:01 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 500 > > > > > > I'd prefer we use await() so that we can get the error message for each > >

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 30, 2016, 4:25 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 30, 2016, 4:24 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50627: Used `await` instead of `collect` on `Subsystem` operations.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50627/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 30, 2016, 3:57 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 30, 2016, 3:48 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 30, 2016, 3:47 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated July 30, 2016, 3:08 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 30, 2016, 3:07 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

2016-07-30 Thread haosdent huang
> On July 28, 2016, 12:01 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 486 > > > > > > Would love to understand why test will cause this issue. > > Qian Zhang wrote: >

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

2016-07-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 30, 2016, 3:06 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50626: Made the JSON snippets complete in Scheduler HTTP API doc.

2016-07-30 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50626/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-5790

Review Request 50625: Renamed the filter for tests that depend on "perf".

2016-07-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50625/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

2016-07-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/ --- (Updated 七月 30, 2016, 9:10 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

2016-07-30 Thread Guangya Liu
> On 七月 29, 2016, 8:35 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp, lines 2515-2523 > > > > > > Can we make the initial resources another parameter? I believe Klaus > > took this approach

Re: Review Request 50569: Checked if resource is negative scalar directly in subtract.

2016-07-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50569/ --- (Updated 七月 30, 2016, 8:36 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 49571: Added a benchmark test for allocations.

2016-07-30 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated July 30, 2016, 7:09 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49571: Added a benchmark test for allocations.

2016-07-30 Thread Anindya Sinha
> On July 29, 2016, 3:26 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 252 > > > > > > new line here I do not think we need 2 lines between functions embedded in a C++ class in

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

2016-07-30 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 30, 2016, 7:03 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50205: Enhanced benchmark test for resources to include shared resources.

2016-07-30 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50205/ --- (Updated July 30, 2016, 7:03 a.m.) Review request for mesos, Klaus Ma and