> On July 28, 2016, 12:01 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 500 > > <https://reviews.apache.org/r/49827/diff/9/?file=1453251#file1453251line500> > > > > I'd prefer we use await() so that we can get the error message for each > > subsystem. I feel like we should consistently use await in this file > > (instead of collect). Can you follow up with patches to do that?
The follow up patch which replace exist `collect`s is https://reviews.apache.org/r/50627/ - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/#review143861 ----------------------------------------------------------- On July 30, 2016, 4:24 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49827/ > ----------------------------------------------------------- > > (Updated July 30, 2016, 4:24 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::cleanup`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 422b4653fc3cb3d14c94b93ff456625fc59fbb27 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > bd20631a9650cf84e99c6489b2e92bc40ed764ca > > Diff: https://reviews.apache.org/r/49827/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
