Review Request 50633: Libprocess: [1/2] Parameterized decoder tests for incremental parsing.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50633/
---

Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-5943
https://issues.apache.org/jira/browse/MESOS-5943


Repository: mesos


Description
---

The parameter allows us to control how much data is fed to the parser
per call.


Diffs
-

  3rdparty/libprocess/src/tests/decoder_tests.cpp 
4535614312373b0515025f09f9f8495f9ce353a3 

Diff: https://reviews.apache.org/r/50633/diff/


Testing
---

The tests fail during incremental parsing of URLs. This is expected. The 
subsequent patch fixes these tests.


Thanks,

Joris Van Remoortere

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated July 30, 2016, 6:08 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
422b4653fc3cb3d14c94b93ff456625fc59fbb27 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50627: Used `await` instead of `collect` on `Subsystem` operations.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50627/
---

(Updated July 30, 2016, 6:05 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Adjust style.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

In order to get the error message for each subsystem, this patch
changes to use `await` on `Subsystem` operations and combines every
unready `Future` error message.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
422b4653fc3cb3d14c94b93ff456625fc59fbb27 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/50627/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

[Yong Tang]

> On July 30, 2016, 5:36 p.m., haosdent huang wrote:
> > support/mesos-style.py, line 20
> > 
> >
> > I think we forgot update this since we update bundle dependencies last 
> > time. May you post this in a sperate patch? Need update according to 
> > current `*.tar.gz` under `3rdparty`.

Thanks haosdent. Another review request:
https://reviews.apache.org/r/50630/
has been created separately to cover the mesos-style.py changes.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/#review144266
---


On July 30, 2016, 6 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50629/
> ---
> 
> (Updated July 30, 2016, 6 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Deshi Xiao.
> 
> 
> Bugs: MESOS-5186
> https://issues.apache.org/jira/browse/MESOS-5186
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fix updated the requirement in `python/interface/setup.py.in`
> so that protobuf 3.0 is allowed.
> 
> 
> Diffs
> -
> 
>   src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa 
> 
> Diff: https://reviews.apache.org/r/50629/diff/
> 
> 
> Testing
> ---
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

[Yong Tang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/
---

(Updated July 30, 2016, 6 p.m.)


Review request for mesos, haosdent huang and Deshi Xiao.


Changes
---

Split excluded_files in mesos-style.py to Review Request 50630 
(https://reviews.apache.org/r/50630/)


Bugs: MESOS-5186
https://issues.apache.org/jira/browse/MESOS-5186


Repository: mesos


Description
---

This fix updated the requirement in `python/interface/setup.py.in`
so that protobuf 3.0 is allowed.


Diffs (updated)
-

  src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa 

Diff: https://reviews.apache.org/r/50629/diff/


Testing
---

make check (Ubuntu 14.04)


Thanks,

Yong Tang

Review Request 50630: Update exclued_files in mesos-style.py.

[Yong Tang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50630/
---

Review request for mesos, haosdent huang and Deshi Xiao.


Repository: mesos


Description
---

This fix updates excluded_files in mesos-style.py so that it
matches the current 3rd party packages.

This fix is related to https://reviews.apache.org/r/50629/


Diffs
-

  support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 

Diff: https://reviews.apache.org/r/50630/diff/


Testing
---

make check (Ubuntu 14.04)


Thanks,

Yong Tang

Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

[Yong Tang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/
---

Review request for mesos, haosdent huang and Deshi Xiao.


Bugs: MESOS-5186
https://issues.apache.org/jira/browse/MESOS-5186


Repository: mesos


Description
---

This fix updated the requirement in `python/interface/setup.py.in`
so that protobuf 3.0 is allowed.


Diffs
-

  src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa 
  support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 

Diff: https://reviews.apache.org/r/50629/diff/


Testing
---

make check (Ubuntu 14.04)


Thanks,

Yong Tang

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated July 30, 2016, 5:26 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Replace `collect` with `await`.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
422b4653fc3cb3d14c94b93ff456625fc59fbb27 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50627: Used `await` instead of `collect` on `Subsystem` operations.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50627/#review144262
---




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 209)


Hi, @jieyu. I feel these code are duplicated, should we create a util 
method in `collect.hpp`?

And for `discarded` future, we don't know which `Subsystem` it belongs to, 
should we make it include the `Subsytem` name here?


- haosdent huang


On July 30, 2016, 4:24 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50627/
> ---
> 
> (Updated July 30, 2016, 4:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
> https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to get the error message for each subsystem, this patch
> changes to use `await` on `Subsystem` operations and combines every
> unready `Future` error message.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> bd20631a9650cf84e99c6489b2e92bc40ed764ca 
> 
> Diff: https://reviews.apache.org/r/50627/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

[haosdent huang]

> On July 28, 2016, 12:01 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 500
> > 
> >
> > I'd prefer we use await() so that we can get the error message for each 
> > subsystem. I feel like we should consistently use await in this file 
> > (instead of collect). Can you follow up with patches to do that?

The follow up patch which replace exist `collect`s is 
https://reviews.apache.org/r/50627/


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49827/#review143861
---


On July 30, 2016, 4:24 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49827/
> ---
> 
> (Updated July 30, 2016, 4:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
> https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `CgroupsIsolatorProcess::cleanup`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> 422b4653fc3cb3d14c94b93ff456625fc59fbb27 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> bd20631a9650cf84e99c6489b2e92bc40ed764ca 
> 
> Diff: https://reviews.apache.org/r/49827/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated July 30, 2016, 4:25 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
422b4653fc3cb3d14c94b93ff456625fc59fbb27 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49827/
---

(Updated July 30, 2016, 4:24 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::cleanup`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
422b4653fc3cb3d14c94b93ff456625fc59fbb27 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/49827/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50627: Used `await` instead of `collect` on `Subsystem` operations.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50627/
---

Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

In order to get the error message for each subsystem, this patch
changes to use `await` on `Subsystem` operations and combines every
unready `Future` error message.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/50627/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49827/
---

(Updated July 30, 2016, 3:57 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::cleanup`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
422b4653fc3cb3d14c94b93ff456625fc59fbb27 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/49827/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated July 30, 2016, 3:48 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
422b4653fc3cb3d14c94b93ff456625fc59fbb27 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49827/
---

(Updated July 30, 2016, 3:47 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Address @jieyu's comments.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::cleanup`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
422b4653fc3cb3d14c94b93ff456625fc59fbb27 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/49827/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49828/
---

(Updated July 30, 2016, 3:08 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5039
https://issues.apache.org/jira/browse/MESOS-5039


Repository: mesos


Description
---

Added default methods implementations for `Subsystem` base class.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 

Diff: https://reviews.apache.org/r/49828/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49817/
---

(Updated July 30, 2016, 3:07 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::recover`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
422b4653fc3cb3d14c94b93ff456625fc59fbb27 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/49817/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

[haosdent huang]

> On July 28, 2016, 12:01 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 486
> > 
> >
> > Would love to understand why test will cause this issue.
> 
> Qian Zhang wrote:
> It seems that comment was introduced by this ticket: 
> https://issues.apache.org/jira/browse/MESOS-1438 , and in the test code here: 
> https://github.com/apache/mesos/blob/1.0.0/src/tests/cluster.cpp#L552:L559 , 
> I see each container created in the test will be cleaned up, and we have 
> already initiated cleanup for those containers in the test code, that might 
> be where the race occurs.

Thx @qian!


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49827/#review143861
---


On July 26, 2016, 5:11 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49827/
> ---
> 
> (Updated July 26, 2016, 5:11 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
> https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `CgroupsIsolatorProcess::cleanup`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> c57baec88437f68886702a40ec8a6a6458546119 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 348f105f9c3109a02f1dde0649f1b829cb9ddd04 
> 
> Diff: https://reviews.apache.org/r/49827/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49827/
---

(Updated July 30, 2016, 3:06 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5041
https://issues.apache.org/jira/browse/MESOS-5041


Repository: mesos


Description
---

Implemented `CgroupsIsolatorProcess::cleanup`.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
422b4653fc3cb3d14c94b93ff456625fc59fbb27 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
bd20631a9650cf84e99c6489b2e92bc40ed764ca 

Diff: https://reviews.apache.org/r/49827/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50626: Made the JSON snippets complete in Scheduler HTTP API doc.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50626/
---

Review request for mesos and Anand Mazumdar.


Bugs: MESOS-5790
https://issues.apache.org/jira/browse/MESOS-5790


Repository: mesos


Description
---

Made the JSON snippets complete in Scheduler HTTP API doc.


Diffs
-

  docs/scheduler-http-api.md 4be961214c63e4e3b25c5c350b2c4f0e66863817 

Diff: https://reviews.apache.org/r/50626/diff/


Testing
---

Viewed the scheduler-http-api doc using rake dev


Thanks,

Abhishek Dasgupta

Review Request 50625: Renamed the filter for tests that depend on "perf".

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50625/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Previously, any test case that had "Perf" in its name would only be run
when the perf(1) command was installed. This is inconsistent with other
name-based filters for test cases (e.g., "ROOT_" or "CGROUPS_"). It also
meant that the filter matched "Registrar_BENCHMARK_Test.Performance",
which was a bug (the test does not depend on perf).

Instead, use "PERF_" to indicate tests that can only be run when perf(1)
is installed.


Diffs
-

  src/tests/containerizer/cgroups_tests.cpp 
d766f0f0bfabd87904311d36f69aedf7651415b6 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 
  src/tests/containerizer/perf_tests.cpp 
3dc5b0fa90dd941408a73585197b5309e3204576 
  src/tests/environment.cpp 0d22c4be42e2c3c53b2370be0c11544aea55621b 
  src/tests/slave_recovery_tests.cpp 470fb26a2985f912b2b91d647cd7a27b8748c2a5 

Diff: https://reviews.apache.org/r/50625/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50380/
---

(Updated 七月 30, 2016, 9:10 a.m.)


Review request for mesos, Benjamin Mahler and Klaus Ma.


Bugs: MESOS-5898
https://issues.apache.org/jira/browse/MESOS-5898


Repository: mesos


Description (updated)
---

When run benchmark test for `ports` resources, the `-=` and `-` only
consumed about 10ms, this cannot reflect the real time of operating
1000 `ports` with `-=` and `-`.

The root cause is that the current calculation is always using same
port range, with port, the formula for `+` is `a+a+a+a+...+a==a`;
for `-`, it will be `a-a=0` and `0-a=0`.

With `0-a=0`, the code here
https://github.com/apache/mesos/blob/master/src/common/values.cpp#L544
will cause there is no validation as the `left` is empty after the
`ports` was subtracted to 0.

The fix is adding a new parameter `inital` act as the intial resources
for differente benchmark test. For `ports` resource, using an initial
`ports` which is different from the `resources`, this can make sure
the`ports` resources will never be subtracted to 0.


Diffs (updated)
-

  src/tests/resources_tests.cpp 4111e080b84079e100b731c9a56861b204f17388 

Diff: https://reviews.apache.org/r/50380/diff/


Testing (updated)
---

make
make check

Before fix:
```
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
Took 2.844742secs to perform 1000 'total += r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 9ms to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, 7-8, 
10-11, 13-14, 16-17, 1...
Took 2.977936secs to perform 1000 'total = total + r' operations on 
ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 9576us to perform 1000 'total = total - r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (5843 ms)
[--] 1 test from ResourcesOperators/Resources_BENCHMARK_Test (5843 ms 
total)
```

After fix:
```
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
Took 2.728995secs to perform 1000 'total += r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
ports(*):[3-5]
Took 3.641868secs to perform 1000 'total -= r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
ports(*):[3-5]
Took 2.957178secs to perform 1000 'total = total + r' operations on 
ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
ports(*):[3-5]
Took 3.631125secs to perform 1000 'total = total - r' operations on 
ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... with initial resources 
ports(*):[3-5]
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (12961 ms)
```


Thanks,

Guangya Liu

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

[Guangya Liu]

> On 七月 29, 2016, 8:35 p.m., Benjamin Mahler wrote:
> > src/tests/resources_tests.cpp, lines 2515-2523
> > 
> >
> > Can we make the initial resources another parameter? I believe Klaus 
> > took this approach initially but I had removed 'initial' to simplify the 
> > patch.
> > 
> > If we make it a parameter we can have initial ports only for the port 
> > test case.
> 
> Guangya Liu wrote:
> Hi Ben, one quick question want to get some comments from you. Regarding 
> to your comments, what about set `initial` resources for all resources types 
> including `scalar`, `range`, `reservations` and then for the new added 
> `contain` benchmark test, I can simply check if the `initial` contains 
> `resources`, what do you think of this approach?
> 
> Benjamin Mahler wrote:
> For the contains test, how about we start with three parameters: (a, b, 
> numContains)
> 
> Then we do `a.contains(b)` numContains times and `b.contains(a)` 
> numContains times?

So do you mean that I need to introduce some new parameters for `contains` 
benchmark test as following?

```
struct Parameter
{
  Resources resources1;
  Resources resources2;
  size_t numContains;
};
```

My thinking is want to levearaget the current parameters and do not introduce 
new parameters:
```
struct Parameter
{
  Resources initial;
  Resources resources;
  size_t totalOperations;
};
```

Then I will do `initial.contains(resources)` and `resources.contains(initial)` 
for `totalOperations` times.

For `Filters` or `Filtering` test, I will do `resources.nonRevocable()` for 
`totalOperations` times.

What do you think?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50380/#review144175
---


On 七月 25, 2016, 1:43 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50380/
> ---
> 
> (Updated 七月 25, 2016, 1:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Klaus Ma.
> 
> 
> Bugs: MESOS-5898
> https://issues.apache.org/jira/browse/MESOS-5898
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When run benchmark test for `ports` resources, the `-=` and `-` only
> consumed about 10ms, this cannot reflect the real time of operating
> 1000 `ports` with `-=` and `-`.
> 
> The root cause is that the current calculation is always using same
> port range, with port, the formula for `+` is `a+a+a+a+...+a==a`;
> for `-`, it will be `a-a=0` and `0-a=0`.
> 
> With `0-a=0`, the code here
> https://github.com/apache/mesos/blob/master/src/common/values.cpp#L544
> will cause there is no validation as the `left` is empty after the
> `ports` was subtracted to 0.
> 
> The fix is adding a default `ports` resources to make sure the `ports`
> resources will never be subtracted to 0.
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 4111e080b84079e100b731c9a56861b204f17388 
> 
> Diff: https://reviews.apache.org/r/50380/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Before fix:
> ```
>  ./bin/mesos-tests.sh --benchmark  
> --gtest_filter="*Resources_BENCHMARK_Test.Arithmetic/2"
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from ResourcesOperators/Resources_BENCHMARK_Test
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
> Took 3.042796secs to perform 1000 'total += r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> Took 10026us to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, 
> 7-8, 10-11, 13-14, 16-17, 1...
> Took 3.193982secs to perform 1000 'total = total + r' operations on 
> ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> Took 9142us to perform 1000 'total = total - r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> [   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (6258 
> ms)
> [--] 1 test from ResourcesOperators/Resources_BENCHMARK_Test (6258 ms 
> total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (6278 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> After fix:
> ```
>  ./bin/mesos-tests.sh --benchmark  
> --gtest_filter="*Resources_BENCHMARK_Test.Arithmetic/2"
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from ResourcesOperators/Resources_BENCHMARK_Test
> [ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
> Took 2.624597secs to perform 1000 'total += r' operations on ports(*):[1-2, 
> 4-5, 7-8, 10-11, 13-14, 16-17, 1...
> Took 3.592067secs to perform 

Re: Review Request 50569: Checked if resource is negative scalar directly in subtract.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50569/
---

(Updated 七月 30, 2016, 8:36 a.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.


Summary (updated)
-

Checked if resource is negative scalar directly in subtract.


Bugs: MESOS-5921
https://issues.apache.org/jira/browse/MESOS-5921


Repository: mesos


Description (updated)
---

When subtract resources finished, we need to call `validate` to
check if the scalar resource is negative so as to remove this
resource if it is negative. This is a bit heavy as the `validate`
did many stuffs.

This patch is simpilfying the logic by checking if the resource
is negative scalar directly.


Diffs (updated)
-

  src/common/resources.cpp 468581da550bcabf44fbaba8897d5fbbc330c2cb 
  src/v1/resources.cpp 230d55b099511499eef111bddd1c552df0093b82 

Diff: https://reviews.apache.org/r/50569/diff/


Testing (updated)
---

make
make check

```
[==] Running 3 tests from 1 test case.
[--] Global test environment set-up.
[--] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
Took 222763us to perform 5 'total += r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 231983us to perform 5 'total -= r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 679121us to perform 5 'total = total + r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 698024us to perform 5 'total = total - r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (1832 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
Took 22.630349secs to perform 10 'total += r' operations on cpus(0, 
principal_0, {key_0: value_0}):1; gpus(...
Took 22.499543secs to perform 10 'total -= r' operations on cpus(0, 
principal_0, {key_0: value_0}):1; gpus(...
Took 22.566697secs to perform 10 'total = total + r' operations on cpus(0, 
principal_0, {key_0: value_0}):1; gpus(...
Took 22.798371secs to perform 10 'total = total - r' operations on cpus(0, 
principal_0, {key_0: value_0}):1; gpus(...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (90621 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
Took 2.831782secs to perform 1000 'total += r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 8935us to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, 7-8, 
10-11, 13-14, 16-17, 1...
Took 2.96492secs to perform 1000 'total = total + r' operations on 
ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 9220us to perform 1000 'total = total - r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (5817 ms)
[--] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test (98270 ms 
total)
```


Thanks,

Guangya Liu

Re: Review Request 49571: Added a benchmark test for allocations.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
---

(Updated July 30, 2016, 7:09 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Addressed review comments, and updated test results.


Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771


Repository: mesos


Description
---

Allocations test has the following configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
e5576023e4aab930f0e2b1d82d8baa6569d852eb 

Diff: https://reviews.apache.org/r/49571/diff/


Testing (updated)
---

All tests passed.

Allocations benchmark test results
==
Support of shared resources has a small impact on runtime performance in 
allocations. Also, there is no visible impact in performance when shared 
resources are added in the tests.

With the patch (and no shared resources)

round 0 allocate took 3.3096secs to make 2000 offers
round 50 allocate took 3.302636secs to make 2000 offers
round 100 allocate took 3.321002secs to make 2000 offers
round 150 allocate took 3.305755secs to make 2000 offers
round 199 allocate took 3.305825secs to make 2000 offers

With the patch (and shared resources on all agents)
---
round 0 allocate took 3.361138secs to make 2000 offers
round 50 allocate took 3.375249secs to make 2000 offers
round 100 allocate took 3.36454secs to make 2000 offers
round 150 allocate took 3.366206secs to make 2000 offers
round 199 allocate took 3.365199secs to make 2000 offers

With the patch (and shared resources on alternate agents)
-
round 0 allocate took 3.335685secs to make 2000 offers
round 50 allocate took 3.341063secs to make 2000 offers
round 100 allocate took 3.341839secs to make 2000 offers
round 150 allocate took 3.335622secs to make 2000 offers
round 199 allocate took 3.337968secs to make 2000 offers

Based on HEAD, with all regular resources (no shared resources in HEAD 
supported)
-
round 0 allocate took 3.00921secs to make 2000 offers
round 50 allocate took 3.006498secs to make 2000 offers
round 100 allocate took 3.004949secs to make 2000 offers
round 150 allocate took 3.00702secs to make 2000 offers
round 199 allocate took 3.00633secs to make 2000 offers


Thanks,

Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

[Anindya Sinha]

> On July 29, 2016, 3:26 a.m., Guangya Liu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 252
> > 
> >
> > new line here

I do not think we need 2 lines between functions embedded in a C++ class in 
header file. Based on remaining functions in this file and couple of header 
files, I think that is the pattern.


> On July 29, 2016, 3:26 a.m., Guangya Liu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 265
> > 
> >
> > new line here

Same comment as above.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/#review144048
---


On July 28, 2016, 10:46 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49571/
> ---
> 
> (Updated July 28, 2016, 10:46 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5771
> https://issues.apache.org/jira/browse/MESOS-5771
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allocations test has the following configurations:
> (1) REGULAR: Offers from every slave have regular resources.
> (2) SHARED: Offers from every slave include a shared resource.
> (3) REGULAR: Offers from every alternate slave contain only regular
> resources; and offers from every other alternate slave contains
> a shared resource.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> bb6947fcecb5b78047e98d10fc1278c612a69548 
> 
> Diff: https://reviews.apache.org/r/49571/diff/
> 
> 
> Testing
> ---
> 
> All tests passed.
> 
> Allocations benchmark test results
> ==
> Support of shared resources has a small impact on runtime performance in 
> allocations. Also, there is no visible impact in performance when shared 
> resources are added in the tests.
> 
> With the patch (and no shared resources)
> 
> round 0 allocate took 3.19704secs to make 200 offers
> round 50 allocate took 3.240605secs to make 200 offers
> round 100 allocate took 3.227024secs to make 200 offers
> round 150 allocate took 3.225281secs to make 200 offers
> round 199 allocate took 3.26036secs to make 200 offers
> 
> With the patch (and shared resources on all agents)
> ---
> round 0 allocate took 3.279115secs to make 200 offers
> round 50 allocate took 3.273396secs to make 200 offers
> round 100 allocate took 3.278509secs to make 200 offers
> round 150 allocate took 3.275959secs to make 200 offers
> round 199 allocate took 3.278151secs to make 200 offers
> 
> With the patch (and shared resources on alternate agents)
> -
> round 0 allocate took 3.251739secs to make 200 offers
> round 50 allocate took 3.263777secs to make 200 offers
> round 100 allocate took 3.263079secs to make 200 offers
> round 150 allocate took 3.263114secs to make 200 offers
> round 199 allocate took 3.236228secs to make 200 offers
> 
> Based on HEAD, with all regular resources (no shared resources in HEAD 
> supported)
> -
> round 0 allocate took 2.925681secs to make 200 offers
> round 50 allocate took 2.922036secs to make 200 offers
> round 100 allocate took 2.909337secs to make 200 offers
> round 150 allocate took 2.914093secs to make 200 offers
> round 199 allocate took 2.923762secs to make 200 offers
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45961/
---

(Updated July 30, 2016, 7:03 a.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Michael Park, 
and Jiang Yan Xu.


Changes
---

Rebased with master.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

o Each shared resource is accouted via its share count. This count is
  updated based on the resource operations (such as add and subtract)
  in various scenarios such as task launch and terminate at multiple
  modules such as master, allocator, sorter, etc.
o Only allow DESTROY if there are no running or pending tasks using
  the volume. However, if the volume is in a pending offer to one or
  more frameworks, rescind that offer before processing the DESTROY.
o To allow multiple tasks to be launched in the same ACCEPT call
  using the same shared resource, we update the allocator and
  sorter with additional copies of shared resources to reflect the
  true shared count of allocated shared resources.


Diffs (updated)
-

  src/common/resources.cpp 468581da550bcabf44fbaba8897d5fbbc330c2cb 
  src/common/resources_utils.cpp 8e881a09500b0966b577e514077460f724868a8d 
  src/master/allocator/mesos/hierarchical.hpp 
b72ba16277a3210e4d309b616d185a10e2029a66 
  src/master/allocator/mesos/hierarchical.cpp 
7d4064535a20b93950f5a95eef1ad3f0d37d305b 
  src/master/allocator/sorter/drf/sorter.hpp 
bc6bfb2d5d3b32d55be055a0514861b4e7d889bb 
  src/master/allocator/sorter/drf/sorter.cpp 
ac85b327fc33d34246788e6a8c8bf5a486c61434 
  src/master/http.cpp e26dc2ff19fdfebc4d57009f355ebc92df3b62fd 
  src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
  src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c 
  src/master/validation.hpp 43d876b00511d4ef652c2685d4950c994b5eef31 
  src/master/validation.cpp 52002beac29c371411348cb026a216e99ac96ab2 
  src/tests/master_validation_tests.cpp 
9eb82a569f7c48caa96d4d54a93b199ccac74385 
  src/tests/sorter_tests.cpp ade356cbbba5b93a6d3e5c9de30eefd3982d15c1 
  src/v1/resources.cpp 230d55b099511499eef111bddd1c552df0093b82 

Diff: https://reviews.apache.org/r/45961/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 50205: Enhanced benchmark test for resources to include shared resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50205/
---

(Updated July 30, 2016, 7:03 a.m.)


Review request for mesos, Klaus Ma and Jiang Yan Xu.


Changes
---

Test results updated after rebase.


Bugs: MESOS-4892
https://issues.apache.org/jira/browse/MESOS-4892


Repository: mesos


Description
---

Enhanced benchmark test for resources to include shared resources.


Diffs (updated)
-

  src/tests/resources_tests.cpp 4111e080b84079e100b731c9a56861b204f17388 

Diff: https://reviews.apache.org/r/50205/diff/


Testing (updated)
---

Tests passed. Results for resources benchmark is as follows:

Minimal impact seen in Resources arithmetic with the Resources refactor changes 
to incorporate shared resources.

With shared resources patch (note that 4th test below is for shared resources 
for scalars)

[--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (806 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17032 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (1048 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3 (940 ms)
[--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test (19826 ms 
total)

HEAD

[--] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (726 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17413 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (1026 ms)
[--] 3 tests from ResourcesOperators/Resources_BENCHMARK_Test (19165 ms 
total)

Output from stdout is:

[==] Running 4 tests from 1 test case.
[--] Global test environment set-up.
[--] 4 tests from ResourcesOperators/Resources_BENCHMARK_Test
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0
Took 72635us to perform 5 'total += r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 116027us to perform 5 'total -= r' operations on cpus(*):1; gpus(*):1; 
mem(*):128; disk(*):256
Took 283213us to perform 5 'total = total + r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
Took 333641us to perform 5 'total = total - r' operations on cpus(*):1; 
gpus(*):1; mem(*):128; disk(*):256
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/0 (806 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1
Took 4.103766secs to perform 10 'total += r' operations on cpus(0, principal_0, 
{key_0: value_0}):1; gpus(...
Took 4.310104secs to perform 10 'total -= r' operations on cpus(0, principal_0, 
{key_0: value_0}):1; gpus(...
Took 4186ms to perform 10 'total = total + r' operations on cpus(0, 
principal_0, {key_0: value_0}):1; gpus(...
Took 4.380353secs to perform 10 'total = total - r' operations on cpus(0, 
principal_0, {key_0: value_0}):1; gpus(...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/1 (17032 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2
Took 483119us to perform 1000 'total += r' operations on ports(*):[1-2, 4-5, 
7-8, 10-11, 13-14, 16-17, 1...
Took 2271us to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, 7-8, 
10-11, 13-14, 16-17, 1...
Took 559844us to perform 1000 'total = total + r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1...
Took 2423us to perform 1000 'total = total - r' operations on ports(*):[1-2, 
4-5, 7-8, 10-11, 13-14, 16-17, 1...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/2 (1048 ms)
[ RUN  ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3
Took 61629us to perform 5 'total += r' operations on cpus(*):1; mem(*):128; 
disk(test)[persistentId:...
Took 98664us to perform 5 'total -= r' operations on cpus(*):1; mem(*):128; 
disk(test)[persistentId:...
Took 348041us to perform 5 'total = total + r' operations on cpus(*):1; 
mem(*):128; disk(test)[persistentId:...
Took 431057us to perform 5 'total = total - r' operations on cpus(*):1; 
mem(*):128; disk(test)[persistentId:...
[   OK ] ResourcesOperators/Resources_BENCHMARK_Test.Arithmetic/3 (940 ms)
[--] 4 tests from