Re: Review Request 53608: Added --enable-seccomp flag to configure options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53608/#review155797 --- Bad patch! Reviews applied: [53608, 53607, 53606, 53605, 53604]

Review Request 52190: Removed deprecated compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52190/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 52189: Compiler warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52189/ --- Review request for mesos. Repository: mesos Description --- Compiler

Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52210/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52364: Added basic support to invoke `docker.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52364/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50838/#review155794 --- Patch looks great! Reviews applied: [50837, 50491, 50492, 50490,

Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52544: Introduced `int_fd` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 52625: Replaced POSIX `int` with `int_fd` abstraction in `libprocess` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52625/ --- (Updated Nov. 14, 2016, 5:46 a.m.) Review request for mesos, Alex Naparu, Alex

Review Request 53706: Implemented `os::user' on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53706/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Re: Review Request 52624: Replaced POSIX `int` with `int_fd` abstraction in `src` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52624/ --- (Updated Nov. 14, 2016, 5:46 a.m.) Review request for mesos, Alex Naparu, Alex

Review Request 53707: Added a Windows isolator. Removed `#ifdef`-ed block from Posix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53707/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53708: Remove warnings from `duration.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53708/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53709: Remuved warnings from gzip.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53709/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53712: Added `system` environement variables in ` execvpe.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53712/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53710: Removed warnings from `dirent.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53710/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53714: Fixed leak in `fetcher.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53714/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53713: Reversed recoursive path creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53713/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53715: Define docker `--entrypoint` for `Windows`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53715/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53718: Defined and used Windows string `docker-mesos-executor.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53718/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53716: Used `Shell::entrypoint`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53716/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53717: Added `Winsock` initialization in `docker-mesos-executor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53717/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 53719: Created default mount point on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53719/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Re: Review Request 52972: Replaced POSIX `int` with `int_fd` abstraction in `stout` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52972/ --- (Updated Nov. 14, 2016, 5:40 a.m.) Review request for mesos, Alex Naparu, Alex

Review Request 53704: Added level of indirection for logger through IO Switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53704/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Bugs:

Review Request 53607: Added Seccomp imeplementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53607/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6581

Review Request 53608: Added --enable-seccomp flag to configure options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53608/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6581

Review Request 53605: Added --seccomp_profile flag to Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53605/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6581

Re: Review Request 53604: Added SeccompInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53604/ --- (Updated Nov. 14, 2016, 4:41 a.m.) Review request for mesos and Jie Yu.

Review Request 53606: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53606/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6581

Review Request 53604: Added SeccompInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53604/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6581

Re: Review Request 50493: Added `base` to PIDGroup.

> On Sept. 30, 2016, 12:37 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/pid_group.hpp, lines 54-59 > > > > > > We shouldn't have two ways of specifying the `base` PIDs. > > > > Let's remove

Review Request 53701: Renamed `group` in ZooKeeperPIDGroup to `observer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53701/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5828

Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50838/ --- (Updated Nov. 14, 2016, 4:06 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50838/ --- (Updated Nov. 14, 2016, 4:04 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50499: Added logic in master/main.cpp to use pid_group module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50499/ --- (Updated Nov. 14, 2016, 4:04 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50498: Added --master_pid_group flag in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50498/ --- (Updated Nov. 14, 2016, 4:03 a.m.) Review request for mesos and Joseph Wu.

Review Request 53702: Added a factory method to produce PIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53702/ --- Review request for mesos. Repository: mesos Description --- In the case

Re: Review Request 53702: Added a factory method to produce PIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53702/ --- (Updated Nov. 14, 2016, 4:01 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50498: Added --pid_group flag in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50498/ --- (Updated Nov. 14, 2016, 3:48 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50838/ --- (Updated Nov. 14, 2016, 3:48 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50499: Added logic in master/main.cpp to use pid_group module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50499/ --- (Updated Nov. 14, 2016, 3:48 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50497: Added new constructors in Log and LogProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50497/ --- (Updated Nov. 14, 2016, 3:40 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50496: Added pid group module to `createPIDGroup` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50496/ --- (Updated Nov. 14, 2016, 3:40 a.m.) Review request for mesos and Joseph Wu.

Review Request 53700: Refactored `group` in LogProcess into ZooKeeperPIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53700/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5828

Re: Review Request 50495: Added PIDGroup module struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50495/ --- (Updated Nov. 14, 2016, 3:38 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50493: Added `base` to PIDGroup.

> On Sept. 30, 2016, 12:37 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/pid_group.hpp, lines 54-59 > > > > > > We shouldn't have two ways of specifying the `base` PIDs. > > > > Let's remove

Re: Review Request 50494: Remove `base` from ZooKeeperPIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50494/ --- (Updated Nov. 14, 2016, 3:34 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50493: Added `base` to PIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50493/ --- (Updated Nov. 14, 2016, 3:33 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50490: Separated ZooKeeper PIDGroup implementation into its own cpp/hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50490/ --- (Updated Nov. 14, 2016, 3:33 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50492: Switched replicated log to use PIDGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50492/ --- (Updated Nov. 14, 2016, 3:32 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 50491: Added PIDGroup to libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50491/ --- (Updated Nov. 14, 2016, 3:32 a.m.) Review request for mesos and Joseph Wu.