----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53702/ -----------------------------------------------------------
Review request for mesos. Repository: mesos Description ------- In the case of PIDGroup module, base pid may not be available at construction time, so base pid needs to be initialized after PIDGroup construction, but before PIDGroup being passed to LogProcess constructor, since PIDGroup is a const member in the form of Shared<>. Therefore, a factory method `createPIDGroup` is added to LogProcess. To unify the implementation, we refactor ZooKeeperPIDGroup to be created by factory method as well. This is step toward modularizing PIDGroup interfaces. Diffs ----- src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 src/log/log.cpp 2301eef564f2a42958c6c2c8eef0cc4b2fd76353 src/log/pid_group/zookeeper.hpp PRE-CREATION src/log/pid_group/zookeeper.cpp PRE-CREATION Diff: https://reviews.apache.org/r/53702/diff/ Testing ------- Thanks, Jay Guo
