Re: Review Request 54770: Fixed the 'IOSwitchboardTest.KillSwitchboardContainerDestroyed' test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54770/#review159264 --- Patch looks great! Reviews applied: [54769, 54770] Passed

Re: Review Request 54768: Libprocess: Reduced binary bloat due to 'mime'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54768/#review159261 --- Patch looks great! Reviews applied: [54768] Passed command:

Re: Review Request 54769: Fixed a cleanup related bug in the IO switchboard.

> On Dec. 15, 2016, 2:21 a.m., Jie Yu wrote: > > I don't follow. onAny returns 'this', has nothing to do with the future > > returned from the callback registered. In the default (buggy case) this would be invoked:

Re: Review Request 54769: Fixed a cleanup related bug in the IO switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54769/#review159258 --- I don't follow. onAny returns 'this', has nothing to do with the

Review Request 54769: Fixed a cleanup related bug in the IO switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54769/ --- Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone. Bugs:

Re: Review Request 54764: Replaced `::pipe` with `os::pipe` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54764/#review159257 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 54768: Libprocess: Reduced binary bloat due to 'mime'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54768/#review159256 --- Fix it, then Ship it! 3rdparty/libprocess/src/mime.cpp (line

Review Request 54768: Libprocess: Reduced binary bloat due to 'mime'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54768/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 54561: Added tests for IOSwitchboard heartbeat.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54561/#review159254 --- Patch looks great! Reviews applied: [54755, 54561] Passed

Review Request 54764: Replaced `::pipe` with `os::pipe` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54764/ --- Review request for mesos. Repository: mesos Description --- Replaced

Review Request 54602: Replaced `int` with `int_fd` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54602/ --- Review request for mesos. Repository: mesos Description --- Replaced

Review Request 54762: Introduced an os::pipe abstraction to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54762/ --- Review request for mesos. Repository: mesos Description --- Introduced

Review Request 54603: Replaced `int` with `int_fd` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54603/ --- Review request for mesos. Repository: mesos Description --- Replaced

Review Request 54601: Replaced `int` with `int_fd` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54601/ --- Review request for mesos. Repository: mesos Description --- Replaced

Re: Review Request 54593: Replaced `::lseek` with `os::lseek` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54593/ --- (Updated Dec. 14, 2016, 3:52 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54596: Replaced `::dup` with `os::dup` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54596/ --- (Updated Dec. 14, 2016, 3:52 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54594: Replaced `::lseek` with `os::lseek` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54594/ --- (Updated Dec. 14, 2016, 3:52 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54595: Introduced an `os::dup` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54595/ --- (Updated Dec. 14, 2016, 3:52 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Dec. 14, 2016, 3:50 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Dec. 14, 2016, 3:50 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54590: Removed unused peek function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54590/ --- (Updated Dec. 14, 2016, 3:49 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54178: Added a fixed-capacity hashmap to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54178/ --- (Updated Dec. 14, 2016, 11:03 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54018: Enhanced LinkedHashMap to support `foreachpair` and friends.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54018/ --- (Updated Dec. 14, 2016, 10:59 p.m.) Review request for mesos and Michael Park.

Re: Review Request 54018: Enhanced LinkedHashMap to support `foreachpair` and friends.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54018/#review159247 --- Fix it, then Ship it!

Re: Review Request 54019: Modernized code to use `foreachpair` with LinkedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54019/ --- (Updated Dec. 14, 2016, 10:50 p.m.) Review request for mesos and Michael Park.

Re: Review Request 54017: Changed implementation of LinkedHashMap.

> On Dec. 14, 2016, 1:30 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/linkedhashmap.hpp, lines 32-34 > > > > > > Let's get rid of the `typedef`s here > > Neil Conway wrote: > `LinkedHashMap`

Re: Review Request 46425: Add helper function to simplify tokenize handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46425/#review159240 --- 3rdparty/stout/include/stout/strings.hpp (lines 170 - 175)

Re: Review Request 54018: Enhanced LinkedHashMap to support `foreachpair` and friends.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54018/ --- (Updated Dec. 14, 2016, 10:30 p.m.) Review request for mesos and Michael Park.

Re: Review Request 54753: Leaked module libraries to avoid inconsitencies in library unloading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54753/#review159239 --- Patch looks great! Reviews applied: [54753] Passed command:

Re: Review Request 54017: Changed implementation of LinkedHashMap.

> On Dec. 14, 2016, 9:30 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/linkedhashmap.hpp, lines 32-34 > > > > > > Let's get rid of the `typedef`s here `LinkedHashMap` previously used these `typedef`s,

Re: Review Request 54017: Changed implementation of LinkedHashMap.

> On Dec. 14, 2016, 9:32 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/linkedhashmap.hpp, line 16 > > > > > > missing `#include ` We already `#include `, so AFAIK we should be okay here. - Neil

Re: Review Request 54087: Updated stout's README.

> On Dec. 14, 2016, 9:44 p.m., Michael Park wrote: > > 3rdparty/stout/README.md, line 446 > > > > > > Let's point out that `linkedhashmap` is the thing we're talking about > > here. We're actually talking about

Re: Review Request 54087: Updated stout's README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54087/ --- (Updated Dec. 14, 2016, 10:10 p.m.) Review request for mesos and Michael Park.

Re: Review Request 54087: Updated stout's README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54087/#review159233 --- Fix it, then Ship it! 3rdparty/stout/README.md

Re: Review Request 54019: Modernized code to use `foreachpair` with LinkedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54019/#review159232 --- Ship it! Ship It! - Michael Park On Nov. 23, 2016, 6:19

Re: Review Request 54018: Enhanced LinkedHashMap to support `foreachpair` and friends.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54018/#review159230 --- Fix it, then Ship it!

Re: Review Request 54017: Changed implementation of LinkedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54017/#review159229 --- Fix it, then Ship it!

Re: Review Request 54017: Changed implementation of LinkedHashMap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54017/#review159225 --- Fix it, then Ship it!

Re: Review Request 52772: Added a filter for '_CNIPLUGINS_'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52772/ --- (Updated Dec. 14, 2016, 8:03 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54216: Fixed unsufficient root privileges check by geteuid().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54216/#review159219 --- Ship it! Ship It! - Jie Yu On Nov. 30, 2016, 6:55 p.m.,

Re: Review Request 53264: Added test for CNI port-mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/ --- (Updated Dec. 14, 2016, 7:45 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 53299: Fixed memory leak in implementation of Future::after().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53299/#review159218 --- I ran this with `./libprocess-tests

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

> On Nov. 30, 2016, 8:21 p.m., Zhitao Li wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 167 > > > > > > Do we want to consider maintain a similar hierarchy as `scratch`? It > >

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/#review159213 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 8:45

Re: Review Request 54593: Replaced `::lseek` with `os::lseek` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54593/#review159211 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:01

Re: Review Request 54594: Replaced `::lseek` with `os::lseek` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54594/#review159210 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:01

Re: Review Request 54595: Introduced an `os::dup` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54595/#review159209 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:02

Re: Review Request 54590: Removed unused peek function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54590/#review159208 --- 3rdparty/libprocess/src/io.cpp

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/#review159206 --- Ship it! Ship It! - Daniel Pravat On Dec. 13, 2016, 9:01

Re: Review Request 54211: Fixed overlay backend symlink error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54211/#review159204 --- Ship it! Ship It! - Jie Yu On Nov. 30, 2016, 6:54 p.m.,

Re: Review Request 54561: Added tests for IOSwitchboard heartbeat.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54561/ --- (Updated Dec. 14, 2016, 6:31 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 54486: Added default values for all required IOSwitchboardServerFlags.

> On Dec. 8, 2016, 11:13 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/io/switchboard_main.cpp, lines 71-76 > > > > > > Using sentinel values in the parameter domain as default values seems > >

Re: Review Request 54755: Kept the listening socket while accept is in flight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54755/#review159196 --- Fix it, then Ship it!

Re: Review Request 54755: Kept the listening socket while accept is in flight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54755/ --- (Updated Dec. 14, 2016, 6:12 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 54755: Kept the listening socket while accept is in flight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54755/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Bugs: MESOS-6795

Re: Review Request 54751: Used process::loop in infinitely recursive functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54751/#review159184 --- Ship it! Ship It! - Anand Mazumdar On Dec. 14, 2016, 4:45

Review Request 54753: Leaked module libraries to avoid inconsitencies in library unloading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54753/ --- Review request for mesos, Kapil Arya and Joseph Wu. Bugs: MESOS-6658

Re: Review Request 54751: Used process::loop in infinitely recursive functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54751/ --- (Updated Dec. 14, 2016, 4:45 p.m.) Review request for mesos, Anand Mazumdar

Review Request 54751: Used process::loop in infinitely recursive functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54751/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Re: Review Request 54085: Made internal Mesos headers more standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54085/#review159155 --- Patch looks great! Reviews applied: [54083, 54085] Passed

Re: Review Request 54081: Added `--pidfile` option to master and agent binaries.

> On Dec. 6, 2016, 10:42 p.m., Benjamin Mahler wrote: > > Thanks Ilya! > > > > Have you looked at other pidfile related libraries? Looks like BSD provides > > some functions for this (they're also available on Linux): > > https://www.freebsd.org/cgi/man.cgi?query=pidfile=3=FreeBSD+6.1-RELEASE

Re: Review Request 53344: Updated `/slaves.md` doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53344/#review159144 --- Patch looks great! Reviews applied: [53095, 52637, 52638, 52765,

Re: Review Request 54739: Used correct shell string comparison operator in test.

> On Dec. 14, 2016, 1:25 p.m., Till Toenshoff wrote: > > thanks for cleaning up Benjamin - the CI and hence the entire team will > > appreciate :) Quick note, Benjamin also did a quick sweep over the entire codebase to check for further instances of this issue and it seems we are good as all

Re: Review Request 54739: Used correct shell string comparison operator in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54739/#review159142 --- Ship it! thanks for cleaning up Benjamin - the CI and hence

Re: Review Request 54739: Used correct shell string comparison operator in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54739/ --- (Updated Dec. 14, 2016, 1:45 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 54739: Used correct shell string comparison operator in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54739/ --- Review request for mesos, Anand Mazumdar, Avinash sridharan, Jie Yu, and Till

Re: Review Request 54727: Refactored IOSwitchboardServerTest.AttachOutput test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54727/#review159131 --- Patch looks great! Reviews applied: [54720, 54727] Passed

Re: Review Request 54719: Added support for deleting CNI network from `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54719/#review159124 --- Patch looks great! Reviews applied: [54716, 54717, 54718, 54719]

Re: Review Request 54083: Made headers in stout standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54083/ --- (Updated Dec. 14, 2016, 10:04 a.m.) Review request for mesos, Michael Park and

Re: Review Request 54085: Made internal Mesos headers more standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54085/ --- (Updated Dec. 14, 2016, 10:03 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 53299: Fixed memory leak in implementation of Future::after().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53299/ --- (Updated Dec. 14, 2016, 9:22 a.m.) Review request for mesos, Benjamin Bannier,