Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/#review173411 --- src/slave/containerizer/mesos/isolators/xfs/utils.hpp Lines 46

Re: Review Request 58763: Added volume/secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58763/#review173416 --- Patch looks great! Reviews applied: [58758, 58759, 58760, 58761,

Re: Review Request 58869: Bumped the default timeout value for docker volume detach operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58869/ --- (Updated April 29, 2017, 12:39 a.m.) Review request for mesos and Gilbert

Review Request 58869: Bumped the default timeout value for docker volume detach operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58869/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58357/ --- (Updated April 29, 2017, 12:17 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 58828: Replaced std::set with hashset for framework roles.

> On April 28, 2017, 6:30 a.m., Michael Park wrote: > > It's true that we don't use `std::set` for its ordering in the general case, > > however, I think the ordering does help produce easier-to-read error > > messages. > > > > > > What do you think of preserving that property? Yes you're

Re: Review Request 56732: Remove unnecessary perf version checks.

> On April 28, 2017, 4:06 p.m., Jiang Yan Xu wrote: > > src/linux/perf.cpp > > Line 322 (original), 313 (patched) > > > > > > Now without the `process::collect`. > > > > 1. Remove from includes: > > ```

Re: Review Request 56732: Remove unnecessary perf version checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56732/#review173393 --- Fix it, then Ship it! Committing with the minor changes if no

Re: Review Request 58821: Added a test that verifies a task and its check share the work dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58821/#review173389 --- Patch looks great! Reviews applied: [58847, 58262, 58718, 58817,

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

> On April 25, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/flags/parse.hpp > > Line 96 (original), 96 (patched) > > > > > > There are more instances of erroneous absolute path

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58673/ --- (Updated April 28, 2017, 9:43 p.m.) Review request for mesos, Andrew

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/ --- (Updated April 28, 2017, 2:40 p.m.) Review request for mesos, Adam B, Anindya

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

> On April 28, 2017, 8:49 p.m., Vinod Kone wrote: > > Nice test. Modulo Jie's comment. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58263/#review173380

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58263/#review173380 --- Fix it, then Ship it! Nice test.

Re: Review Request 58758: Added secret to Volume protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58758/#review173382 --- Ship it! Ship It! - Gilbert Song On April 28, 2017, 11:49

Re: Review Request 58820: Explained how container working directory differs from its sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58820/#review173378 --- include/mesos/slave/containerizer.proto Line 186 (original), 186

Re: Review Request 58819: Clarified the comment about Container.directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58819/#review173377 --- Ship it! Ship It! - Vinod Kone On April 28, 2017, 4:14

Re: Review Request 58818: Ensured DEBUG container shares MESOS_SANDBOX with its parent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58818/#review173376 --- Ship it! Nice test. - Vinod Kone On April 28, 2017, 4:14

Re: Review Request 58817: Captured AgentID from the offer by reference in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58817/#review173375 --- Ship it! Thanks for fixing this! - Vinod Kone On April 28,

Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58262/#review173370 --- Fix it, then Ship it! LGTM modulo Jie's comments.

Re: Review Request 58487: Fix allocation quantities when shared resources are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58487/#review173369 --- Patch looks great! Reviews applied: [58485, 58486, 58487]

Re: Review Request 58847: Checkpointed and recovered ContainerLaunchInfo for non-orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58847/#review173368 --- Ship it! LGTM modulo Jie's comments. - Vinod Kone On April

Review Request 58763: Added volume/secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58763/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Review Request 58762: Use SecretFetcher to fetch secret executor environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58762/ --- Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone.

Re: Review Request 58761: Added --secret-fetcher flag for agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58761/ --- (Updated April 28, 2017, 2:51 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 58760: Added default secret fetcher module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/ --- (Updated April 28, 2017, 2:50 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 58759: Introduced SecretFetcher module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/ --- (Updated April 28, 2017, 2:50 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 58758: Added secret to Volume protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58758/ --- (Updated April 28, 2017, 2:49 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

> On April 25, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 92-108 (patched) > > > > > > I'm hoping Joe approves of this style; it's what I came up with while > >

Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows.

> On April 25, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/flags/parse.hpp > > Line 96 (original), 96 (patched) > > > > > > There are more instances of erroneous absolute path

Re: Review Request 58766: Fixed a path join issue in ProvisionerDockerBackendTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58766/#review173345 --- src/tests/containerizer/provisioner_docker_tests.cpp Line 812

Re: Review Request 58824: Disabled unit test relying on AliCloud Registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58824/#review173344 --- src/tests/containerizer/provisioner_docker_tests.cpp Line 464

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58263/#review173340 --- src/slave/containerizer/mesos/containerizer.hpp Lines 338

Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58262/#review173338 --- src/slave/containerizer/mesos/containerizer.hpp Lines 367

Re: Review Request 58821: Added a test that verifies a task and its check share the work dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58821/#review173339 --- src/tests/check_tests.cpp Lines 612-616 (patched)

Re: Review Request 58847: Checkpointed and recovered ContainerLaunchInfo for non-orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58847/#review173337 --- Fix it, then Ship it! src/slave/containerizer/mesos/paths.hpp

Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.

> On April 27, 2017, 11:15 p.m., Jie Yu wrote: > > > > Jie Yu wrote: > See my comments in https://reviews.apache.org/r/58263/ > > We should probably just checkpoint `ContainerLaunchInfo`. Yeah, this sounds like a good idea. Checkpoint the whole `ContainerLaunchInfo`, but restore

Re: Review Request 58821: Added a test that verifies a task and its check share the work dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58821/ --- (Updated April 28, 2017, 4:14 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 58820: Explained how container working directory differs from its sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58820/ --- (Updated April 28, 2017, 4:14 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58263/ --- (Updated April 28, 2017, 4:14 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 58262: Inherited environment from parent when launching a DEBUG container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58262/ --- (Updated April 28, 2017, 4:14 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 58817: Captured AgentID from the offer by reference in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58817/ --- (Updated April 28, 2017, 4:14 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 58819: Clarified the comment about Container.directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58819/ --- (Updated April 28, 2017, 4:14 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 58718: Added a test that verifies a task's env var is seen by its check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58718/ --- (Updated April 28, 2017, 4:14 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 58818: Ensured DEBUG container shares MESOS_SANDBOX with its parent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58818/ --- (Updated April 28, 2017, 4:14 p.m.) Review request for mesos, Gastón Kleiman,

Review Request 58847: Checkpointed and recovered ContainerLaunchInfo for non-orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58847/ --- Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone. Repository:

Re: Review Request 58487: Fix allocation quantities when shared resources are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58487/ --- (Updated April 28, 2017, 3:42 p.m.) Review request for mesos, James Peach and

Re: Review Request 58486: Fixed a race in `updateAllocation()` on DESTORY of a shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58486/ --- (Updated April 28, 2017, 3:42 p.m.) Review request for mesos, James Peach and

Re: Review Request 58485: Avoid a corruption while rescinding offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58485/ --- (Updated April 28, 2017, 3:42 p.m.) Review request for mesos, James Peach and

Re: Review Request 57652: Allow authenticators to return any http Response.

> On April 11, 2017, 10:17 a.m., Adam B wrote: > > 3rdparty/libprocess/include/process/authenticator.hpp > > Lines 94-95 (original), 94-95 (patched) > > > > > > I don't think either of these fields should be used to

Re: Review Request 58830: Updated Suppress / Revive calls to take multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58830/#review173311 --- Patch looks great! Reviews applied: [58828, 58829, 58830]

Re: Review Request 58754: Altered the task command used in an agent test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58754/#review173306 --- Patch looks great! Reviews applied: [58754] Passed command:

Re: Review Request 58357: Support more test frameworks in test-upgrade script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58357/#review173303 --- Patch looks great! Reviews applied: [58357] Passed command:

Re: Review Request 58830: Updated Suppress / Revive calls to take multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58830/#review173301 --- Ship it! Ship It! - Michael Park On April 27, 2017, 5:48

Re: Review Request 58828: Replaced std::set with hashset for framework roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58828/#review173302 --- Ship it! Ship It! - Michael Park On April 27, 2017, 5:43

Re: Review Request 58829: Fixed the implementation of per-role Suppress / Revive calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58829/#review173300 --- Ship it! Ship It! - Michael Park On April 27, 2017, 5:44

Re: Review Request 58828: Replaced std::set with hashset for framework roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58828/#review173299 --- It's true that we don't use `std::set` for its ordering in the