Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

2017-08-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/#review183886 --- Patch looks great! Reviews applied: [61849] Passed command:

Re: Review Request 61690: Added `--zk_session_timeout` flag for agent.

2017-08-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61690/#review183885 --- Patch looks great! Reviews applied: [61689, 61690] Passed

Re: Review Request 61801: Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.

2017-08-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61801/#review183882 --- Patch looks great! Reviews applied: [61797, 61798, 61799, 61800,

Review Request 61921: Added tests to ensure that tasks can access their parent's volumes.

2017-08-25 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61921/ --- Review request for mesos and Greg Mann. Bugs: MESOS-7916

Review Request 61920: Added a test that uses environment secrets and the DefaultExecutor.

2017-08-25 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61920/ --- Review request for mesos and Greg Mann. Bugs: MESOS-7916

Review Request 61919: Adjusted the test helpers for creating host and sandbox path volumes.

2017-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61919/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-7306

Re: Review Request 61915: Enabled `DockerContainerizerProcess::usage` for all platforms.

2017-08-25 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61915/ --- (Updated Aug. 25, 2017, 1:32 p.m.) Review request for mesos, Jie Yu, Joseph

Review Request 61915: Enabled `DockerContainerizerProcess::usage` for all platforms.

2017-08-25 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61915/ --- Review request for mesos, Jie Yu, Joseph Wu, and Li Li. Bugs: MESOS-7917

Re: Review Request 61473: Do not kill non partition aware tasks.

2017-08-25 Thread Megha Sharma
> On Aug. 10, 2017, 9 p.m., Jiang Yan Xu wrote: > > Some of the comments below were made before I started to feel that we are > > probably doing too many conversions to justify storing these tasks in > > TASK_UNREACHABLE. Perhaps we can just store them in > > `Framework.unreachableTasks` but

Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

2017-08-25 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/ --- (Updated Aug. 25, 2017, 5:34 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

2017-08-25 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/#review183858 --- src/master/main.cpp Line 138 (original), 138 (patched)

Re: Review Request 61799: Replaced ABORT with _EXIT in `childMain` to handle `os::execvpe` error.

2017-08-25 Thread Andrei Budnik
> On Aug. 24, 2017, 10:59 p.m., James Peach wrote: > > 3rdparty/libprocess/src/subprocess_posix.hpp > > Lines 200 (patched) > > > > > > Is this required to be async-signal-safe? After latest changes `_EXIT`

Re: Review Request 61798: Added _EXIT as alternative to ABORT.

2017-08-25 Thread Andrei Budnik
> On Aug. 24, 2017, 10:59 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/exit.hpp > > Lines 39 (patched) > > > > > > Move this comment to the `_EXIT()` macro. Done. > On Aug. 24, 2017, 10:59 p.m., James

Re: Review Request 61797: Added async-signal safe implementation of `write` function in stout.

2017-08-25 Thread Andrei Budnik
> On Aug. 24, 2017, 6:28 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 66 (patched) > > > > > > Write returns `ssize_t` here and in all the other variants in this file. > > > >

Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

2017-08-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60647/#review183843 --- Ship it! Ship It! - Alexander Rukletsov On July 5, 2017,

Re: Review Request 61597: Fixed linking to `IPHlpAPI` library.

2017-08-25 Thread Alexander Rukletsov
> On Aug. 18, 2017, 9:29 a.m., Alexander Rukletsov wrote: > > Ship It! I've tested the chain up to this commit in my CMake setup (integration with Qt Creator + ccache) and confirm it works as expected (targets are set up properly, building and running tests works). - Alexander

Re: Review Request 61874: Added a test for IPv6 containers on docker user networks.

2017-08-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61874/ --- (Updated Aug. 25, 2017, 6:59 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 61874: Added a test for IPv6 containers on docker user networks.

2017-08-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61874/ --- (Updated Aug. 25, 2017, 6:56 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 61873: Added test filter for docker user network tests.

2017-08-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61873/ --- (Updated Aug. 25, 2017, 6:54 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 61237: Updated docker executor to return IPv6 address of a container.

2017-08-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61237/ --- (Updated Aug. 25, 2017, 6:54 a.m.) Review request for mesos, Jie Yu and Qian