Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/#review184327 --- Patch looks great! Reviews applied: [61849] Passed command:

Re: Review Request 62005: Used 'undiscardable' to protect a future in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62005/#review184326 --- Ship it! Ship It! - Gilbert Song On Aug. 31, 2017, 4:27

Re: Review Request 62005: Used 'undiscardable' to protect a future in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62005/ --- (Updated Aug. 31, 2017, 11:27 p.m.) Review request for mesos, Benjamin

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/#review184325 --- Ship it! Ship It! - Gilbert Song On Aug. 30, 2017, 9:42

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

> On Aug. 30, 2017, 5:14 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/future.hpp > > Lines 1702-1703 (patched) > > > > > > Let's stick to the `typename std::enable_if::type = 0`

Re: Review Request 62018: Updated logging::initialize to make flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/#review184314 --- Bad patch! Reviews applied: [62018] Logs available here:

Re: Review Request 62017: Allows port mapper plugin to have optional args.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184310 --- Patch looks great! Reviews applied: [62017] Passed command:

Re: Review Request 62017: Allows port mapper plugin to have optional args.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184307 --- Patch looks great! Reviews applied: [62017] Logs available

Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/#review184306 --- Bad patch! Reviews applied: [61849] Logs available here:

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review184295 --- src/python/lib/mesos/exceptions.py Lines 30 (patched)

Re: Review Request 62016: Fixed unnecessary non-constness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62016/#review184294 --- Bad patch! Reviews applied: [62016] Logs available here:

Review Request 62018: Updated logging::initialize to make flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/ --- Review request for mesos, Andrei Budnik and Alexander Rukletsov. Bugs:

Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/ --- (Updated Aug. 31, 2017, 4:39 p.m.) Review request for mesos, Andrei Budnik and

Review Request 62017: Allows port mapper plugin to have optional args.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/ --- Review request for mesos and Avinash sridharan. Bugs: mesos-7923

Re: Review Request 62016: Fixed unnecessary non-constness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62016/#review184276 --- Ship it! Ship It! - Alexander Rojas On Aug. 31, 2017, 5:29

Review Request 62016: Fixed unnecessary non-constness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62016/ --- Review request for mesos and Alexander Rojas. Repository: mesos Description

Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/#review184269 --- Fix it, then Ship it! src/launcher/default_executor.cpp Line

Re: Review Request 61495: Add documentation for possible task reasons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61495/#review184244 --- Fix it, then Ship it! Looks very good to me. Please have a

Re: Review Request 58021: Added storage-related offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58021/ --- (Updated Aug. 31, 2017, 1:33 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 58021: Added storage-related offer operations.

> On Aug. 31, 2017, 4:14 a.m., Jie Yu wrote: > > src/common/protobuf_utils.cpp > > Lines 532-538 (original), 574-584 (patched) > > > > > > Can you change this too? like what we did for inject? Oh, of course. Not

Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61991/#review184256 --- Patch looks great! Reviews applied: [61579, 61580, 61991]

Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61991/#review184251 --- Bad patch! Reviews applied: [61579, 61580, 61991] Logs

Re: Review Request 61579: Ensured JAVA HTTP adapter propagates a subscription error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61579/ --- (Updated Aug. 31, 2017, 7:09 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 61580: Extracted JNI code into a protected function for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61580/ --- (Updated Aug. 31, 2017, 7:09 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61991/ --- (Updated Aug. 31, 2017, 7:09 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter.

> On Aug. 30, 2017, 9:45 p.m., Anand Mazumdar wrote: > > src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp > > Lines 360 (patched) > > > > > > hmm, I think we should only log things that are relevant to the >