Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-09 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/#review190672 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines

Re: Review Request 63622: Provided handling for offer operation updates.

2017-11-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/#review190671 --- Fix it, then Ship it! src/resource_provider/manager.cpp Line

Re: Review Request 63679: Added test helpers for storage operations.

2017-11-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63679/#review190673 --- Ship it! Ship It! - Jie Yu On Nov. 8, 2017, 5:55 p.m., Jan

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

2017-11-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/#review190636 --- src/slave/containerizer/mesos/containerizer.cpp Lines 2790-2792

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

2017-11-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/#review190665 --- src/slave/containerizer/mesos/provisioner/provisioner.cpp Lines

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

2017-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review190664 --- FAIL: Failed to apply the dependent review: 62145. Failed

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

2017-11-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 10, 2017, 2:13 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

2017-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190662 --- FAIL: Failed to apply the dependent review: 59988. Failed

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

2017-11-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/ --- (Updated Nov. 10, 2017, 1:24 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63710: Fixed flaky RescindRevocableOfferWithIncreasedRevocable test.

2017-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63710/#review190661 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

2017-11-09 Thread Jie Yu
> On Nov. 9, 2017, 9:08 a.m., Jan Schlicht wrote: > > src/master/master.cpp > > Lines 10966-10971 (patched) > > > > > > `Master::_apply` will currently always call `Slave::apply`. This means > > that the changes

Re: Review Request 62166: Updated RC tagging+voting mechanism.

2017-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62166/#review190659 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 62166: Updated RC tagging+voting mechanism.

2017-11-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62166/#review190658 --- Ship it! Ship It! - Vinod Kone On Nov. 9, 2017, 11:16 p.m.,

Re: Review Request 63173: Refactored and fixed `DefaultExecutorTest.CommitSuicideOnKillTask`.

2017-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63173/#review190656 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 19, 2017,

Re: Review Request 63172: Added and used more v1 scheduler API test helpers.

2017-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63172/#review190655 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 20, 2017,

Review Request 63710: Fixed flaky RescindRevocableOfferWithIncreasedRevocable test.

2017-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63710/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-7519

Re: Review Request 62166: Updated RC tagging+voting mechanism.

2017-11-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62166/ --- (Updated Nov. 9, 2017, 6:16 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 63543: Added bintray publishing scripts.

2017-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63543/#review190642 --- PASS: Mesos patch 63543 was successfully built and tested.

Re: Review Request 63543: Added bintray publishing scripts.

2017-11-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63543/ --- (Updated Nov. 9, 2017, 2:02 p.m.) Review request for mesos, James Peach and

Re: Review Request 63543: Added bintray publishing scripts.

2017-11-09 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63543/#review190630 --- Ship it! Ship It! - James Peach On Nov. 9, 2017, 7:02 p.m.,

Re: Review Request 63543: Added bintray publishing scripts.

2017-11-09 Thread Kapil Arya
> On Nov. 9, 2017, 12:46 p.m., James Peach wrote: > > support/packaging/Jenkinsfile > > Lines 16 (patched) > > > > > > Is `sh -x foo.sh arg` the same as `sh foo.sh arg`? The `-x` was to make shell output verbose --

Re: Review Request 63543: Added bintray publishing scripts.

2017-11-09 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63543/#review190618 --- support/packaging/Jenkinsfile Lines 15 (patched)

Re: Review Request 63585: Improved support/mesos-style.py structure.

2017-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63585/#review190619 --- PASS: Mesos patch 63585 was successfully built and tested.

Re: Review Request 63589: Fixed bug in tests leading to orphaned containers.

2017-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63589/#review190610 --- src/tests/slave_recovery_tests.cpp Line 1167 (original), 1167

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

2017-11-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/#review190497 --- src/slave/containerizer/composing.cpp Lines 264-265 (patched)

Re: Review Request 63703: Linted controllers.js.

2017-11-09 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63703/ --- (Updated Nov. 9, 2017, 4:35 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63694: Added context to agent processing calls.

2017-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63694/#review190601 --- src/slave/http.cpp Lines 2353-2354 (patched)

Review Request 63703: Removed unnecessary semicolon in controllers.js.

2017-11-09 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63703/ --- Review request for mesos, Benjamin Mahler and Kevin Klues. Bugs: MESOS-7924

Re: Review Request 62214: Added JavaScript linter.

2017-11-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review190597 --- Ship it! Ship It! - Kevin Klues On Oct. 18, 2017, 9:23

Re: Review Request 62214: Added JavaScript linter.

2017-11-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review190595 --- support/mesos-style.py Lines 107 (patched)

Re: Review Request 63694: Added context to agent processing calls.

2017-11-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63694/#review190594 --- Patch looks great! Reviews applied: [63694] Passed command:

Re: Review Request 62214: Added JavaScript linter.

2017-11-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/#review190593 --- Ship it! support/mesos-style.py Lines 99-111 (patched)

Re: Review Request 63581: Created virtual environment for linters in /support.

2017-11-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63581/#review190590 --- Ship it! Ship It! - Kevin Klues On Nov. 6, 2017, 4:50 p.m.,

Re: Review Request 63582: Removed pylint from the CLI requirements.

2017-11-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63582/#review190592 --- Ship it! Ship It! - Kevin Klues On Nov. 6, 2017, 4:53 p.m.,

Re: Review Request 63694: Added context to agent processing calls.

2017-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63694/#review190591 --- PASS: Mesos patch 63694 was successfully built and tested.

Re: Review Request 63622: Provided handling for offer operation updates.

2017-11-09 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/ --- (Updated Nov. 9, 2017, 2:48 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63622: Provided handling for offer operation updates.

2017-11-09 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/ --- (Updated Nov. 9, 2017, 2:47 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63655: Switched to `net::socketpair` in `ns::clone`.

2017-11-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63655/#review190577 --- Patch looks great! Reviews applied: [63654, 63655] Passed

Re: Review Request 63279: Increased check tests task resources for Windows.

2017-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63279/#review190573 --- PASS: Mesos patch 63279 was successfully built and tested. All

Re: Review Request 63555: Publish resource provider resources before container launch or update.

2017-11-09 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63555/#review190572 --- src/slave/slave.hpp Lines 538 (patched)

Re: Review Request 62579: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.

2017-11-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/#review190568 --- Patch looks great! Reviews applied: [62579] Passed command:

Re: Review Request 63279: Increased check tests task resources for Windows.

2017-11-09 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63279/ --- (Updated Nov. 9, 2017, 10:30 a.m.) Review request for mesos, Aaron Wood, Akash

Re: Review Request 63279: Increased check tests task resources for Windows.

2017-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63279/#review190562 --- Ship it! src/tests/check_tests.cpp Lines 235 (patched)

Re: Review Request 62579: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.

2017-11-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62579/#review190563 --- PASS: Mesos patch 62579 was successfully built and tested.

Re: Review Request 63662: Dropped scheduler call if a connection has been interrupted.

2017-11-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63662/#review190561 --- Ship it! Ship It! - Till Toenshoff On Nov. 9, 2017, 10

Re: Review Request 63662: Dropped scheduler call if a connection has been interrupted.

2017-11-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63662/ --- (Updated Nov. 9, 2017, 10 a.m.) Review request for mesos, Greg Mann and Till

Review Request 63694: Added context to agent processing calls.

2017-11-09 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63694/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7361

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

2017-11-09 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63689/#review190556 --- src/master/master.cpp Lines 10966-10971 (patched)

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

2017-11-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review190555 --- Bad patch! Reviews applied: [63680, 63019, 63385, 63060, 63377,