Re: Review Request 64939: Abort libprocess when a Process throws an uncaught exception.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64939/#review194733 --- Ship it! Ship It! - Ilya Pronin On Jan. 3, 2018, 5:30 p.m.,

Review Request 64941: Bumped bundled gRPC to 1.8.3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64941/ --- Review request for mesos, Jie Yu and Zhitao Li. Bugs: MESOS-8376 https://is

Review Request 64940: Prevented a crash when an agent with terminal tasks is lost.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64940/ --- Review request for mesos, Gaston Kleiman, Jie Yu, and Jiang Yan Xu. Bugs: MESOS

Review Request 64939: Abort libprocess when a Process throws an uncaught exception.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64939/ --- Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ilya Pronin, Ji

Re: Review Request 64929: Documented a rate limiting bug in marking agents unreachable.

> On Jan. 4, 2018, 12:50 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 2013 (patched) > > > > > > Don't we have the same problem in `SlaveObserver::markUnrechable`? If > > yes, we should probably ment

Re: Review Request 64929: Documented a rate limiting bug in marking agents unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64929/#review194730 --- Fix it, then Ship it! src/master/master.cpp Lines 2013 (patche

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194726 --- Fix it, then Ship it! It's probably worth taking a look at thes

Re: Review Request 64928: Added CHECKs to prevent accidental overwrite of slaves.unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64928/#review194728 --- Ship it! Ship It! - Vinod Kone On Jan. 3, 2018, 10:48 p.m.,

Re: Review Request 64927: Updated the master to use .at for const access to `slaves.unreachable`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64927/#review194727 --- Ship it! Ship It! - Vinod Kone On Jan. 3, 2018, 10:48 p.m.,

Review Request 64938: Fixed RecoverTest.CatchupTruncated test flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64938/ --- Review request for mesos and Jie Yu. Bugs: MESOS-8377 https://issues.apache

Review Request 64936: Improved the documentation of protos related to operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64936/ --- Review request for mesos and Greg Mann. Repository: mesos Description ---

Re: Review Request 64916: Added validation for operations applied on resource provider resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64916/#review194724 --- Ship it! Ship It! - Jie Yu On Jan. 3, 2018, 1:24 p.m., Jan S

Review Request 64933: Fixed flaky PartitionedSlaveReregistrationMasterFailover test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64933/ --- Review request for mesos, Alexander Rukletsov and Megha Sharma. Bugs: MESOS-833

Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/ --- Review request for mesos, Greg Mann and Jie Yu. Repository: mesos Description

Review Request 64928: Added CHECKs to prevent accidental overwrite of slaves.unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64928/ --- Review request for mesos, Benno Evers and Vinod Kone. Repository: mesos Descr

Review Request 64931: Added a TODO for informing frameworks that an agent is unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64931/ --- Review request for mesos, Benno Evers and Vinod Kone. Repository: mesos Descr

Review Request 64930: Unified the marking agent unreachable logic in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64930/ --- Review request for mesos, Benno Evers and Vinod Kone. Repository: mesos Descr

Review Request 64927: Updated the master to use .at for const access to `slaves.unreachable`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64927/ --- Review request for mesos, Benno Evers and Vinod Kone. Repository: mesos Descr

Review Request 64929: Documented a rate limiting bug in marking agents unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64929/ --- Review request for mesos, Benno Evers and Vinod Kone. Bugs: MESOS-8386 http

Re: Review Request 63423: Cleared the executor auth token after using it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63423/ --- (Updated Jan. 3, 2018, 10:42 p.m.) Review request for mesos and Greg Mann. Bu

Re: Review Request 63422: Added os::eraseenv to clear the old environment value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63422/ --- (Updated Jan. 3, 2018, 10:41 p.m.) Review request for mesos and Greg Mann. Su

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote: > > docs/csi.md > > Lines 415 (patched) > > > > > > this is a protobuf3 type, for which there are specific rules re: > > JSON-ification: > > https://developers.g

Re: Review Request 64920: Introduced `upgradeResources` to complement `downgradeResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64920/#review194717 --- Fix it, then Ship it! Looks good, although I was puzzled about

Re: Review Request 64919: Updated the comment for `precomputeResourcesContainment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64919/#review194715 --- Ship it! Ship It! - Benjamin Mahler On Jan. 3, 2018, 7:01 p.

Re: Review Request 64924: Fixed the broken GRPC build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64924/#review194710 --- Ship it! Ship It! - Chun-Hung Hsiao On Jan. 3, 2018, 7:55 p.

Review Request 64924: Fixed the broken GRPC build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64924/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description -

Re: Review Request 64739: Upgraded resources that come from `protobuf::read`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64739/#review194707 --- src/resource_provider/storage/provider.cpp Lines 921 (patched)

Review Request 64923: Added replicated log reader catch-up section to the upgrades doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64923/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973 https://issues.apache

Review Request 64922: Added VOTING replica catch-up section to replicated log docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64922/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973 https://issues.apache

Review Request 64921: Fixed a typo and formatting in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64921/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7973 https://issues.apache

Re: Review Request 64898: Removed duplicated code that tests for removable tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64898/#review194706 --- src/master/master.cpp Lines 10171 (patched)

Re: Review Request 64743: Enabled function sections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64743/#review194705 --- Ship it! I can't vouch for the compiler flags themselves, but t

Review Request 64920: Introduced `upgradeResources` to complement `downgradeResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64920/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8375 https://issu

Review Request 64919: Updated the comment for `precomputeResourcesContainment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64919/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 64515: Used `reserve_resources` ACL for static reservations.

> On Dec. 13, 2017, 11:32 a.m., James Peach wrote: > > src/master/master.cpp > > Line 3876 (original), 3881 (patched) > > > > > > You can now log the `SlaveID` here. The `SlaveInfo` here may not have a `SlaveID` if

Re: Review Request 64889: Fixed handling of checkpointed resources for RP-capable agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64889/#review194703 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp Lines

Re: Review Request 64515: Used `reserve_resources` ACL for static reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64515/ --- (Updated Jan. 3, 2018, 11 a.m.) Review request for mesos, Alexander Rojas and J

Re: Review Request 64515: Used `reserve_resources` ACL for static reservations.

> On Dec. 13, 2017, 3:54 a.m., Alexander Rojas wrote: > > src/master/master.cpp > > Lines 6138-6141 (original), 6169-6173 (patched) > > > > > > How about: > > > > _Not authorized to register agent with(out)

Re: Review Request 64888: Added check for handling of checkpointed resources in reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64888/#review194704 --- src/tests/slave_recovery_tests.cpp Lines 4873 (patched)

Re: Review Request 64888: Added check for handling of checkpointed resources in reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64888/#review194701 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp Lines

Re: Review Request 64891: Future-proofed use of agent capabilities in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64891/#review194700 --- Ship it! Ship It! - Jie Yu On Jan. 2, 2018, 5:23 p.m., Benja

Review Request 64916: Added validation for operations applied on resource provider resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64916/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-8219 htt

Re: Review Request 64888: Added check for handling of checkpointed resources in reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64888/#review194691 --- Ship it! The patch itself looks good, but you should replace 'c

Re: Review Request 64889: Fixed handling of checkpointed resources for RP-capable agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64889/#review194690 --- Ship it! Ship It! - Benno Evers On Jan. 2, 2018, 5:27 p.m.,

Re: Review Request 64891: Future-proofed use of agent capabilities in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64891/#review194689 --- Ship it! Ship It! - Benno Evers On Jan. 2, 2018, 5:23 p.m.,

Review Request 64211: Added configure/make options to build the new CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8240 https://issues.a