Re: Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

2018-01-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65252/#review195869 --- PASS: Mesos patch 65252 was successfully built and tested.

Review Request 65252: Updated the v1/mesos.proto to keep consistancy with general mesos.proto.

2018-01-19 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65252/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman,

Re: Review Request 65203: Updated the CHANGELOG for 1.5.0 release.

2018-01-19 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65203/ --- (Updated Jan. 19, 2018, 6:01 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 65109: Fixed a bug relating to lingering executors.

2018-01-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65109/ --- (Updated Jan. 19, 2018, 5:39 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery.

2018-01-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65182/#review195862 --- PASS: Mesos patch 65182 was successfully built and tested.

Re: Review Request 65057: Tested that op status updates dropped en route to master are resent.

2018-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65057/#review195861 --- Ship it! Ship It! - Greg Mann On Jan. 19, 2018, 11:07 p.m.,

Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests.

2018-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65060/#review195860 --- src/tests/storage_local_resource_provider_tests.cpp Lines

Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery.

2018-01-19 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65182/ --- (Updated Jan. 19, 2018, 3:07 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 65057: Tested that op status updates dropped en route to master are resent.

2018-01-19 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65057/ --- (Updated Jan. 19, 2018, 3:07 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 65182: Tested that agent resends unacknowledged op status updates on recovery.

2018-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65182/#review195857 --- Fix it, then Ship it!

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

2018-01-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review195852 --- PASS: Mesos patch 61172 was successfully built and tested.

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

2018-01-19 Thread Eric Chung
> On Jan. 18, 2018, 1:59 p.m., Kevin Klues wrote: > > src/python/lib/mesos/exceptions.py > > Lines 27-33 (patched) > > > > > > I would prefer to do this at each call site instead of wrapping it up > > and hiding

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

2018-01-19 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Jan. 19, 2018, 8:48 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 65232: Resumed the clock if necessary when destroying test agent.

2018-01-19 Thread Greg Mann
> On Jan. 19, 2018, 5:03 p.m., Benjamin Bannier wrote: > > Thanks for this fix Greg. This will help remove some unsafe boilerplate > > from tests. We should probably follow up with a tech-debt ticket removing > > unnecessary clock resumes in tests. Created

Re: Review Request 65232: Resumed the clock if necessary when destroying test agent.

2018-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65232/ --- (Updated Jan. 19, 2018, 5:36 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64998: Added a SLRP test for CSI plugin restart.

2018-01-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64998/#review195834 --- Fix it, then Ship it! src/slave/container_daemon_process.hpp

Re: Review Request 65232: Resumed the clock if necessary when destroying test agent.

2018-01-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65232/#review195836 --- Fix it, then Ship it! Thanks for this fix Greg. This will help

Re: Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews.

2018-01-19 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65208/#review195826 --- Ship it! Ship It! - Armand Grillet On Jan. 18, 2018, 10:53

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

2018-01-19 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 19, 2018, 2:37 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65090: Mesos flags related to ZooKeeper use SecurePathOrValue.

2018-01-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65090/#review195813 --- FAIL: Failed to apply the dependent review: 65226. Failed

Re: Review Request 65226: Added SecurePathOrValue for file flags which need not to leak contents.

2018-01-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65226/ --- (Updated Jan. 19, 2018, 2:06 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 65090: Mesos flags related to ZooKeeper use SecurePathOrValue.

2018-01-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65090/ --- (Updated Jan. 19, 2018, 2:05 p.m.) Review request for mesos and Greg Mann.