Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196621 --- src/tests/master_tests.cpp Lines 8772 (patched)

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196620 --- Looks great, thanks Jan! I left some comments below on the agent A

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 26, 2018, 9:20 p.m., Vinod Kone wrote: > > src/slave/http.cpp > > Lines 1685 (patched) > > > > > > Not yours, but can we make the logging consistent here and in master > > for operator api handlers? Looks

Re: Review Request 65427: Used unique CSI plugin names for SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65427/#review196618 --- Ship it! Ship It! - Gaston Kleiman On Jan. 30, 2018, 5 p.m.,

Re: Review Request 65427: Used unique CSI plugin names for SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65427/#review196617 --- Ship it! Ship It! - Greg Mann On Jan. 31, 2018, 1 a.m., Chun

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review196614 --- PASS: Mesos patch 65448 was successfully built and tested. Review

Re: Review Request 65445: Added new protobuf field `launch_executor` in RunTask(Group)Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65445/#review196613 --- PASS: Mesos patch 65445 was successfully built and tested. Review

Re: Review Request 65451: Fixed `contributors.yaml`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65451/#review196611 --- Ship it! Ship It! - Greg Mann On Jan. 31, 2018, 11:28 p.m.,

Review Request 65448: Added a test to ensure master removes executors that never launched.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone. Bug

Review Request 65449: Fixed an issue where executor info linger on master if failed to launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65449/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone. Bug

Review Request 65447: Refactored couple of launch task sanity checks into a single code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65447/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone. Rep

Review Request 65446: Added helper function for the agent to send `ExitedExecutorMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65446/ --- Review request for mesos. Bugs: MESOS-1720 https://issues.apache.org/jira/b

Review Request 65445: Added new protobuf field `launch_executor` in RunTask(Group)Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65445/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone. Bug

Re: Review Request 65451: Fixed `contributors.yaml`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65451/#review196601 --- PASS: Mesos patch 65451 was successfully built and tested. Review

Review Request 65451: Fixed `contributors.yaml`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65451/ --- Review request for mesos and Greg Mann. Repository: mesos Description ---

Re: Review Request 65438: Fixed flaky SlaveTest.RegisteredAgentReregisterAfterFailover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65438/#review196597 --- Ship it! Ship It! - James Peach On Jan. 31, 2018, 5:58 p.m.,

Re: Review Request 65442: Made `ns::setns` overloads consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65442/#review196596 --- PASS: Mesos patch 65442 was successfully built and tested. Review

Re: Review Request 65441: Deleted deprecated Windows build script.

> On Jan. 31, 2018, 12:23 p.m., Mesos Reviewbot Windows wrote: > > PASS: Mesos patch 65441 was successfully built and tested. > > > > Reviews applied: `['65441']` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441 That confirms

Re: Review Request 65442: Made `ns::setns` overloads consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65442/#review196594 --- Ship it! Ship It! - Jie Yu On Jan. 31, 2018, 9 p.m., James P

Review Request 65442: Made `ns::setns` overloads consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65442/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- O

Re: Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65361/#review196591 --- Ship it! Ship It! - Greg Mann On Jan. 29, 2018, 10:09 p.m.,

Re: Review Request 65424: Improved task status acknowledgement logging messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65424/#review196590 --- Ship it! Ship It! - Greg Mann On Jan. 30, 2018, 9:35 p.m., G

Re: Review Request 65360: Made `master::receive()` drop `ACKNOWLEDGE_OPERATION_STATUS` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65360/#review196589 --- Ship it! Ship It! - Greg Mann On Jan. 26, 2018, 10:08 p.m.,

Re: Review Request 65441: Deleted deprecated Windows build script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65441/#review196587 --- PASS: Mesos patch 65441 was successfully built and tested. Review

Re: Review Request 65439: Made cleanliness checks in post-reviews.py less strict.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65439/#review196586 --- PASS: Mesos patch 65439 was successfully built and tested. Review

Re: Review Request 65426: Made gRPC calls wait for the channel to be ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65426/#review196585 --- Ship it! Ship It! - Greg Mann On Jan. 31, 2018, 7:20 p.m., C

Re: Review Request 65426: Made gRPC calls wait for the channel to be ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65426/#review196584 --- Ship it! Ship It! - Gilbert Song On Jan. 31, 2018, 11:20 a.m

Re: Review Request 65426: Made gRPC calls wait for the channel to be ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65426/ --- (Updated Jan. 31, 2018, 7:20 p.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 65426: Made gRPC calls wait for the channel to be ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65426/#review196580 --- 3rdparty/libprocess/include/process/grpc.hpp Lines 142 (patched)

Re: Review Request 65426: Made gRPC calls wait for the channel to be ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65426/#review196582 --- Ship it! LGTM. Long term, let's expose those knobs to the calle

Re: Review Request 65441: Deleted deprecated Windows build script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65441/#review196578 --- Before we commit this, we need to look at these two references: `

Review Request 65441: Deleted deprecated Windows build script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65441/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Re: Review Request 65437: Added documentation for fault domains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65437/#review196576 --- PASS: Mesos patch 65437 was successfully built and tested. Review

Re: Review Request 65438: Fixed flaky SlaveTest.RegisteredAgentReregisterAfterFailover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65438/#review196575 --- PASS: Mesos patch 65438 was successfully built and tested. Review

Re: Review Request 65439: Made cleanliness checks in post-reviews.py less strict.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65439/#review196574 --- Ship it! Can you please add tillt and/or bbannier as reviewers

Re: Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65409/ --- (Updated Jan. 31, 2018, 10:33 a.m.) Review request for mesos, Akash Gupta, Gast

Re: Review Request 65437: Added documentation for fault domains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65437/#review196571 --- docs/fault-domains.md Lines 74 (patched)

Re: Review Request 65202: Adopted `DEFAULT_TEST_TIMEOUT` in Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review196572 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 65438: Fixed flaky SlaveTest.RegisteredAgentReregisterAfterFailover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65438/ --- Review request for mesos, Alexander Rukletsov and James Peach. Bugs: MESOS-8232

Review Request 65439: Made cleanliness checks in post-reviews.py less strict.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65439/ --- Review request for mesos. Repository: mesos Description --- These checks

Review Request 65437: Added documentation for fault domains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65437/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-8483 https://issues.ap

Re: Review Request 65432: Added `examples/flags.hpp` to `src/Makefile.am`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65432/#review196567 --- Ship it! Ship It! - Till Toenshoff On Jan. 31, 2018, 9:20 a.

Re: Review Request 65432: Added `examples/flags.hpp` to `src/Makefile.am`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65432/#review196565 --- PASS: Mesos patch 65432 was successfully built and tested. Review

Re: Review Request 65432: Added `examples/flags.hpp` to `src/Makefile.am`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65432/#review196559 --- PASS: Mesos patch 65432 was successfully built and tested. Review

Review Request 65432: Added `examples/flags.hpp` to `src/Makefile.am`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65432/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --