Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66836/#review202048
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66423', '66424', '66425', '66426', '66427', '66428', 
'66455', '66429', '66430', '66431', '66432', '66434', '66435', '66436', 
'66437', '66433', '66438', '66439', '66440', '66442', '66443', '66444', 
'66445', '66578', '66641', '66773', '66790', '66834', '66835', '66836']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66836

Relevant logs:

- 
[libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66836/logs/libprocess-tests-stdout.log):

```
[ RUN  ] TimeTest.Output
[   OK ] TimeTest.Output (0 ms)
[--] 4 tests from TimeTest (6 ms total)

[--] 3 tests from TimeSeriesTest
[ RUN  ] TimeSeriesTest.Set
[   OK ] TimeSeriesTest.Set (1 ms)
[ RUN  ] TimeSeriesTest.Sparsify
[   OK ] TimeSeriesTest.Sparsify (1 ms)
[ RUN  ] TimeSeriesTest.Truncate
[   OK ] TimeSeriesTest.Truncate (1 ms)
[--] 3 tests from TimeSeriesTest (6 ms total)

[--] 3 tests from JWTTest
[ RUN  ] JWTTest.Parse
[   OK ] JWTTest.Parse (6 ms)
[ RUN  ] JWTTest.Create
[   OK ] JWTTest.Create (0 ms)
[ RUN  ] JWTTest.Stringify
[   OK ] JWTTest.Stringify (1 ms)
[--] 3 tests from JWTTest (12 ms total)

[--] 1 test from SSL
[ RUN  ] SSL.Disabled
[   OK ] SSL.Disabled (9 ms)
[--] 1 test from SSL (10 ms total)

[--] 17 tests from SSLTest
[ RUN  ] SSLTest.SSLSocket
```

- 
[libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66836/logs/libprocess-tests-stderr.log):

```
*** Check failure stack trace: ***
*** Aborted at 1524804359 (unix time) try "date -d @1524804359" if you are 
using GNU date ***
@ 0x7ff6d6ad494d os::WindowsFD::operator __int64
@ 0x7ff6d6aac3d7 
process::network::internal::LibeventSSLSocketImpl::accept_SSL_callback
@ 0x7ff6d6aac0f9 
process::network::internal::LibeventSSLSocketImpl::accept_callback
@ 0x7ff6d6ad8044  ?? 
@ 0x7ff6d6aafb35 
::
@ 0x7ff6d6b99584 listener_read_cb
@ 0x7ff6d6b71c5a event_persist_closure
@ 0x7ff6d6b73ea1 event_process_active_single_queue
@ 0x7ff6d6b7124a event_process_active
@ 0x7ff6d6b67f8b event_base_loop
@ 0x7ff6d6a36941 process::EventLoop::run
@ 0x7ff6d6547b8a __cdecl*)(void)
@ 0x7ff6d659d300 __cdecl*)(void)
@ 0x7ff6d6557c6c __cdecl*)(void)>,std::default_delete > >::_Execute<0
@ 0x7ff6d665629a __cdecl*)(void)>,std::default_delete > >::_Ru
@ 0x7ff6d6642658 __cdecl*)(void)>,std::default_delete > >::_G
@ 0x7ff6d5f7856d std::_Pad::_Call_func
@ 0x7ffbb5f811e8 _register_onexit_function
@ 0x7ffbb5f80e01 _register_onexit_function
@ 0x7ffbcfd71fe4 BaseThreadInitThunk
@ 0x7ffbcfeaefc1 RtlUserThreadStart
```

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66836/logs/mesos-tests-stdout.log):

```
[   OK ] ContentType/SchedulerTest.Revive/1 (255 ms)
[ RUN  ] ContentType/SchedulerTest.Suppress/0
[   OK ] ContentType/SchedulerTest.Suppress/0 (277 ms)
[ RUN  ] ContentType/SchedulerTest.Suppress/1
[   OK ] ContentType/SchedulerTest.Suppress/1 (275 ms)
[ RUN  ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0
[   OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0 (274 ms)
[ RUN  ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1
[   OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1 (269 ms)
[ RUN  ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0
[   OK ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0 (316 
ms)
[ RUN  ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1
[   OK ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1 (328 
ms)
[ RUN  ] ContentType/SchedulerTest.Message/0
[   OK ] ContentType/SchedulerTest.Message/0 (318 ms)
[ RUN  ] ContentType/SchedulerTest.Message/1
[   OK ] ContentType/SchedulerTest.Message/1 (330 ms)
[ RUN  ] ContentType/SchedulerTest.Request/0
[   OK ] ContentType/SchedulerTest.Request/0 (128 ms)
[ RUN  ] ContentType/SchedulerTest.Request/1
[   OK ] ContentType/SchedulerTest.Request/1 (122 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (87 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] 

Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66836/
---

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.


Repository: mesos


Description
---

Use the stout wrapper instead of `::socket` so we have built-in error
checking (and don't have to worry about types).


Diffs
-

  src/checks/tcp_connect.cpp f5df732415b1e3ac02e9624909d822febe60fe8c 


Diff: https://reviews.apache.org/r/66836/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66835/
---

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.


Repository: mesos


Description
---

Replaced `int` and `HANDLE` types with `int_fd`.


Diffs
-

  src/slave/containerizer/mesos/launch.hpp 
0f66d6b49cbea9964457e890eff3cc7f1e058118 


Diff: https://reviews.apache.org/r/66835/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Review Request 66834: Windows: Specialized `flags::parse`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/
---

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.


Repository: mesos


Description
---

Windows: Specialized `flags::parse`.


Diffs
-

  3rdparty/stout/include/stout/flags/parse.hpp 
eb6d5272ffefcfe4fe7b97f9c7c7084893269b64 


Diff: https://reviews.apache.org/r/66834/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66773/
---

(Updated April 26, 2018, 9:21 p.m.)


Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu.


Changes
---

Rebased.


Bugs: MESOS-8275
https://issues.apache.org/jira/browse/MESOS-8275


Repository: mesos


Description
---

The functions `mode()`, `dev()`, and `inode()` are unused and do not
make sense on Windows, so they were explicitly deleted. The function
`mtime()` is used and has a logical mapping, `GetFileTime()`. However,
Windows reports time differently from POSIX, so a conversion must also
be performed such that the API `os::stat::mtime()` remains consistent
with its POSIX version.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/permissions.hpp 
453e60c7268db516c2c94501e11a92fe8f490498 
  3rdparty/stout/include/stout/os/windows/stat.hpp 
c04953ee42f45dd80b6362fbeeddf4a0a20e7412 
  3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 


Diff: https://reviews.apache.org/r/66773/diff/2/

Changes: https://reviews.apache.org/r/66773/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/
---

(Updated April 26, 2018, 9:20 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Fixed tests to explicitly construct since `WindowsFD` constructors are now 
explicit.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Fixed `os::sleep()` to return an invalid parameter error if given a
negative value.

Fixed tests around the `cloexec` and `nonblock` stubs.

Extended the `bootid` test to use `std::chrono` to assert the boot
id (which is the system boot time) is a reasonable value.

Permanently disabled `OsTest.Libraries` because there is no
equivalent.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/bootid.hpp 
d24e115b97ebcabfa808a9437fb41512f25a5271 
  3rdparty/stout/include/stout/windows/os.hpp 
900baf9be4e3089cb43e444b14b155a80bcd1591 
  3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 


Diff: https://reviews.apache.org/r/66578/diff/2/

Changes: https://reviews.apache.org/r/66578/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66437/
---

(Updated April 26, 2018, 9:17 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Please review again!

* Added some `static_asserts` to document the underlying types.
* Made the `HANDLE`, `SOCKET`, and `intptr_t` constructors `explicit`.
* Added more commentary.
* Ordered the functions according to the style guide.
* Ran `clang-format` on the buffer.
* Changed the stream output so it can be split on `=` easily.
* Removed ordering operators between two `WindowsFD` types.
* Marked the `std::hash` specialization as `noexcept`.
* Return `std::hash` of the underlying types for consistency.
* Explicitly constructed `int_fd` where now needed.


Bugs: MESOS-8675 and MESOS-8683
https://issues.apache.org/jira/browse/MESOS-8675
https://issues.apache.org/jira/browse/MESOS-8683


Repository: mesos


Description
---

After all the CRT APIs were replaced with Windows APIs, we no longer
needed to support the semantics of an `int` file descriptor in
general (in the sense of opening a CRT handle that's associated with
the actual kernel object for the given `HANDLE`). There are specific
use cases (usually third-party code) which still require a CRT
int-like file descriptor, which the `crt()` function explicitly
allocates (this allocation used to be done in the constructor).

Thus the entire `FD_CRT` type was removed from the `WindowsFD`
abstraction. It still acts like an `int` in the sense that it can be
constructed from one and compared to one. However, construction via
`int` only supports the standard file descriptors 0, 1, and 2 for
`stdin`, `stdout`, and `stderr`. Any other construction creates an
`int_fd` which holds an `INVALID_HANDLE_VALUE`. When being compared to
an `int`, the abstraction simply returns -1 if it is invalid (based on
the result of the `is_valid()` method) or 0 if it is valid. This is to
support the semantics of checking validity by something like
`if (fd < 0)` or `if (fd == -1)`.

With the deletion of the `FD_CRT` type from `WindowsFD`, all the Stout
APIs that switched on the type were simplified, with the last of the
CRT code deleted.

Thanks to the introduction of the private `int get_valid()` function,
and the removal of the `FD_CRT` type, the comparison operators became
much simpler.

Several unit tests in the `FsTest` suite became cross-platform, with
the `Close` test being simplified to test against an `int_fd`.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/close.hpp 
ff635e44235d63888a210cd68d49f6678a851e31 
  3rdparty/stout/include/stout/os/windows/dup.hpp 
265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 
  3rdparty/stout/include/stout/os/windows/fcntl.hpp 
bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa 
  3rdparty/stout/include/stout/os/windows/fd.hpp 
d7f8cdf1ad877eb55589bf5a9e75d295f91990a7 
  3rdparty/stout/include/stout/os/windows/pipe.hpp 
365db9480f6258a03ef2e760a19abef8ab177e58 
  3rdparty/stout/include/stout/os/windows/read.hpp 
8047ad590fcc46d3ec46b551472d8c518ae49cc1 
  3rdparty/stout/include/stout/os/windows/socket.hpp 
259b05b8c85e399feaccec698d58b7d540cad368 
  3rdparty/stout/include/stout/os/windows/write.hpp 
71006489918d9495d37d2fdfdca08b40b419481a 
  3rdparty/stout/tests/os/filesystem_tests.cpp 
c190baa2230298e428d4034b90dccffb59b4e710 
  3rdparty/stout/tests/os/socket_tests.cpp 
8ea0f1238e4293a5cd313b4ee38a920b381f4022 


Diff: https://reviews.apache.org/r/66437/diff/6/

Changes: https://reviews.apache.org/r/66437/diff/5-6/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66811: Added `libacl` as a dependency of stout.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66811/#review202046
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On April 26, 2018, 6:35 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66811/
> ---
> 
> (Updated April 26, 2018, 6:35 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8809
> https://issues.apache.org/jira/browse/MESOS-8809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `libacl` as a dependency of stout.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt b7362d2be75e4de06092f16698a784b7a78994cb 
>   3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc 
>   3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da 
>   3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5 
> 
> 
> Diff: https://reviews.apache.org/r/66811/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 66840: Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66840/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8809
https://issues.apache.org/jira/browse/MESOS-8809


Repository: mesos


Description
---

Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.


Diffs
-

  support/mesos-build/centos-7.dockerfile 
acdb44db281e9a156cbd684d2159ab4a5c65e8c4 
  support/mesos-build/ubuntu-16.04-arm.dockerfile 
6d76090c466f84748df307888721d77a5f583290 
  support/mesos-build/ubuntu-16.04.dockerfile 
0bbaa035f401c2c91e4e921cfe9abeb3953885a5 


Diff: https://reviews.apache.org/r/66840/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 66811: Added `libacl` as a dependency of stout.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66811/
---

(Updated April 27, 2018, 9:35 a.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8809
https://issues.apache.org/jira/browse/MESOS-8809


Repository: mesos


Description
---

Added `libacl` as a dependency of stout.


Diffs (updated)
-

  3rdparty/CMakeLists.txt b7362d2be75e4de06092f16698a784b7a78994cb 
  3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc 
  3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da 
  3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5 


Diff: https://reviews.apache.org/r/66811/diff/2/

Changes: https://reviews.apache.org/r/66811/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 66832: Updated mesos source for Gauge -> PullGauge renaming.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66832/#review202043
---



Patch looks great!

Reviews applied: [66828, 66830, 66831, 66832]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 26, 2018, 2:54 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66832/
> ---
> 
> (Updated April 26, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-8851
> https://issues.apache.org/jira/browse/MESOS-8851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated mesos source for Gauge -> PullGauge renaming.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp f25324d198014146d380c1362ade4d9d5f0f9b7f 
>   src/examples/disk_full_framework.cpp 
> b6029dc5362ef57c9b24f182fadaa18fd5adee90 
>   src/examples/long_lived_framework.cpp 
> 53e3ec99d4081a12e2138e79154b07ad5d5ef503 
>   src/log/log.hpp be038d19d0066c52729246d68840a6e4e1d0c23f 
>   src/log/metrics.hpp b537e0a78cbae6f61f48bdfa63f2d91d88f777a3 
>   src/master/allocator/mesos/metrics.hpp 
> d56a10b2d949180c081e7e285e8d60e6ea12ecfa 
>   src/master/allocator/mesos/metrics.cpp 
> 4892dbce65e2f7c12ba5105e28855ba6b6bf800e 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> ff63fbac5bbcf54e1ae39c3b650c0dafe7ea46d4 
>   src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c 
>   src/master/metrics.hpp 5414c4790f4606f910b0de81cbb08d398a0f3745 
>   src/master/metrics.cpp 4cc96a1be532d6c7333a9fcdf8739d7640180777 
>   src/master/registrar.cpp b0c281753d91d6b5abb1af065dec5e3feba0912f 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
>   src/sched/sched.cpp b682d1b8a8a986edbda0bec9c940adb3f10f1c7e 
>   src/scheduler/scheduler.cpp c0dff5345cc1866f9a4dcab6cdeed3e7d815a348 
>   src/slave/containerizer/fetcher_process.hpp 
> 034fe34fea2928475774f3c67174af97a9ef37f3 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
> d933af4e5a605f63d3c4bc584e82de7f3f80da55 
>   src/slave/gc_process.hpp 433b0e00fd30e1e43906cc436dfd58055910d699 
>   src/slave/metrics.hpp b771c4b54efb6a2ea841e99c16e098b33302ca89 
>   src/slave/metrics.cpp 44294af7cac29e462330d94217eed9f767972f0e 
>   src/slave/slave.hpp c35996bdd564075b9b8f1467e13e24a6531d022e 
> 
> 
> Diff: https://reviews.apache.org/r/66832/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 66832: Updated mesos source for Gauge -> PullGauge renaming.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66832/#review202037
---



PASS: Mesos patch 66832 was successfully built and tested.

Reviews applied: `['66828', '66830', '66831', '66832']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66832

- Mesos Reviewbot Windows


On April 26, 2018, 2:54 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66832/
> ---
> 
> (Updated April 26, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-8851
> https://issues.apache.org/jira/browse/MESOS-8851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated mesos source for Gauge -> PullGauge renaming.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp f25324d198014146d380c1362ade4d9d5f0f9b7f 
>   src/examples/disk_full_framework.cpp 
> b6029dc5362ef57c9b24f182fadaa18fd5adee90 
>   src/examples/long_lived_framework.cpp 
> 53e3ec99d4081a12e2138e79154b07ad5d5ef503 
>   src/log/log.hpp be038d19d0066c52729246d68840a6e4e1d0c23f 
>   src/log/metrics.hpp b537e0a78cbae6f61f48bdfa63f2d91d88f777a3 
>   src/master/allocator/mesos/metrics.hpp 
> d56a10b2d949180c081e7e285e8d60e6ea12ecfa 
>   src/master/allocator/mesos/metrics.cpp 
> 4892dbce65e2f7c12ba5105e28855ba6b6bf800e 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> ff63fbac5bbcf54e1ae39c3b650c0dafe7ea46d4 
>   src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c 
>   src/master/metrics.hpp 5414c4790f4606f910b0de81cbb08d398a0f3745 
>   src/master/metrics.cpp 4cc96a1be532d6c7333a9fcdf8739d7640180777 
>   src/master/registrar.cpp b0c281753d91d6b5abb1af065dec5e3feba0912f 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
>   src/sched/sched.cpp b682d1b8a8a986edbda0bec9c940adb3f10f1c7e 
>   src/scheduler/scheduler.cpp c0dff5345cc1866f9a4dcab6cdeed3e7d815a348 
>   src/slave/containerizer/fetcher_process.hpp 
> 034fe34fea2928475774f3c67174af97a9ef37f3 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
> d933af4e5a605f63d3c4bc584e82de7f3f80da55 
>   src/slave/gc_process.hpp 433b0e00fd30e1e43906cc436dfd58055910d699 
>   src/slave/metrics.hpp b771c4b54efb6a2ea841e99c16e098b33302ca89 
>   src/slave/metrics.cpp 44294af7cac29e462330d94217eed9f767972f0e 
>   src/slave/slave.hpp c35996bdd564075b9b8f1467e13e24a6531d022e 
> 
> 
> Diff: https://reviews.apache.org/r/66832/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review202036
---



Patch looks great!

Reviews applied: [65505]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 26, 2018, 5 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65505/
> ---
> 
> (Updated April 26, 2018, 5 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Kevin Klues.
> 
> 
> Bugs: MESOS-8734
> https://issues.apache.org/jira/browse/MESOS-8734
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test was removed in fd4b9af147, but it's important to check that
> after termination of a nested container, its termination status is
> available. This property is used in default executor.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> 661be81d6036113295876546f565264b843b704d 
> 
> 
> Diff: https://reviews.apache.org/r/65505/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 66831: Renamed Gauge to PullGauge and documented differences to PushGauge.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66831/
---

Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, James Peach, 
and Vinod Kone.


Bugs: MESOS-8851
https://issues.apache.org/jira/browse/MESOS-8851


Repository: mesos


Description
---

Given `PushGauge`, it makes sense to explicitly distinguish the two
gauge types and document the the caveats of `PullGauge`.


Diffs
-

  3rdparty/libprocess/include/Makefile.am 
cd2c3bc62df8de5b50ec2fa830b3e2634ba11e28 
  3rdparty/libprocess/include/process/metrics/gauge.hpp 
474f8e80b0128ae8d742a022733019351710ef48 
  3rdparty/libprocess/include/process/metrics/metric.hpp 
21f162d5b7d9e56dc3289d65b6d86deb4c2fa721 
  3rdparty/libprocess/include/process/metrics/pull_gauge.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/system.hpp 
6bd815daa27c069e25461e73fcc7327c4645e9fc 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 
f2bd99bd289d728932b3206958902a99e436eaa7 
  3rdparty/libprocess/src/tests/system_tests.cpp 
17f288146c81b37a900b3df7d1797ba7bdfd00ca 


Diff: https://reviews.apache.org/r/66831/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Review Request 66828: Introduced a push-based gauge metric.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66828/
---

Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, James Peach, 
and Vinod Kone.


Bugs: MESOS-8851
https://issues.apache.org/jira/browse/MESOS-8851


Repository: mesos


Description
---

A push-based gauge differs from a pull-based gauge in that the
client is responsible for pushing the latest value into the gauge
whenever it changes. This can be challenging in some cases as it
requires the client to have a good handle on when the gauge value
changes (rather than just computing the current value when asked).

It is highly recommended to use push-based gauges if possible as
they provide significant performance benefits over pull-based
gauges. Pull-based gauge suffer from delays getting processed on
the event queue of a `Process`, as well as incur computation cost
on the `Process` each time the metrics are collected. Push-based
gauges, on the other hand, incur no cost to the owning `Process`
when metrics are collected, and instead incur a trivial cost when
the `Process` pushes new values in.


Diffs
-

  3rdparty/libprocess/include/Makefile.am 
cd2c3bc62df8de5b50ec2fa830b3e2634ba11e28 
  3rdparty/libprocess/include/process/metrics/push_gauge.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/66828/diff/1/


Testing
---

Test added in the subsequent patch.


Thanks,

Benjamin Mahler

Review Request 66832: Updated mesos source for Gauge -> PullGauge renaming.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66832/
---

Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod 
Kone.


Bugs: MESOS-8851
https://issues.apache.org/jira/browse/MESOS-8851


Repository: mesos


Description
---

Updated mesos source for Gauge -> PullGauge renaming.


Diffs
-

  src/examples/balloon_framework.cpp f25324d198014146d380c1362ade4d9d5f0f9b7f 
  src/examples/disk_full_framework.cpp b6029dc5362ef57c9b24f182fadaa18fd5adee90 
  src/examples/long_lived_framework.cpp 
53e3ec99d4081a12e2138e79154b07ad5d5ef503 
  src/log/log.hpp be038d19d0066c52729246d68840a6e4e1d0c23f 
  src/log/metrics.hpp b537e0a78cbae6f61f48bdfa63f2d91d88f777a3 
  src/master/allocator/mesos/metrics.hpp 
d56a10b2d949180c081e7e285e8d60e6ea12ecfa 
  src/master/allocator/mesos/metrics.cpp 
4892dbce65e2f7c12ba5105e28855ba6b6bf800e 
  src/master/allocator/sorter/drf/metrics.hpp 
61568cb520826ab59d675824b212e0d3deb63764 
  src/master/allocator/sorter/drf/metrics.cpp 
ff63fbac5bbcf54e1ae39c3b650c0dafe7ea46d4 
  src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c 
  src/master/metrics.hpp 5414c4790f4606f910b0de81cbb08d398a0f3745 
  src/master/metrics.cpp 4cc96a1be532d6c7333a9fcdf8739d7640180777 
  src/master/registrar.cpp b0c281753d91d6b5abb1af065dec5e3feba0912f 
  src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
  src/sched/sched.cpp b682d1b8a8a986edbda0bec9c940adb3f10f1c7e 
  src/scheduler/scheduler.cpp c0dff5345cc1866f9a4dcab6cdeed3e7d815a348 
  src/slave/containerizer/fetcher_process.hpp 
034fe34fea2928475774f3c67174af97a9ef37f3 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
d933af4e5a605f63d3c4bc584e82de7f3f80da55 
  src/slave/gc_process.hpp 433b0e00fd30e1e43906cc436dfd58055910d699 
  src/slave/metrics.hpp b771c4b54efb6a2ea841e99c16e098b33302ca89 
  src/slave/metrics.cpp 44294af7cac29e462330d94217eed9f767972f0e 
  src/slave/slave.hpp c35996bdd564075b9b8f1467e13e24a6531d022e 


Diff: https://reviews.apache.org/r/66832/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Review Request 66830: Added a test for PushGauge.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66830/
---

Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod 
Kone.


Bugs: MESOS-8851
https://issues.apache.org/jira/browse/MESOS-8851


Repository: mesos


Description
---

Added a test for PushGauge.


Diffs
-

  3rdparty/libprocess/src/tests/metrics_tests.cpp 
f2bd99bd289d728932b3206958902a99e436eaa7 


Diff: https://reviews.apache.org/r/66830/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66050/#review202032
---




src/master/master.cpp
Line 4565 (original), 4563 (patched)


As discussed, let's add the following variable:
```
// TODO(zhitao): Remove this once `GROW_VOLUME` and `SHRINK_VOLUME` become
// non-speculative.
Resources resizedResources;
```



src/master/master.cpp
Lines 4947-4954 (patched)


As discussed, let's do:
```
CHECK_EQ(1u, _conversions->size());
const Resources& consumed = _conversions->at(0).consumed;
const Resources& converted = _conversinos->at(0).converted;

if (!_offeredResources.contains(consumed)) {
  drop(...);
  continue;
}

_offeredResources -= consumed;
resizedResources += converted;
```
here and below. We can drop r/66568.



src/master/master.cpp
Lines 5503-5510 (original), 5636-5643 (patched)


As discussed, let's do
```
// TODO(zhitao): Remove `resizedResources` once `GROW_VOLUME` and
// `SHRINK_VOLUME` become non-speculative.
if (!_offeredResources.empty() || !resizedResources.empty()) {
  allocator->recoverResources(..., _offeredResources + resizedResources, 
...);
}
```


- Chun-Hung Hsiao


On April 24, 2018, 9:16 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66050/
> ---
> 
> (Updated April 24, 2018, 9:16 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new offer operations are implemented as speculative operations, but
> we will use validation to make them non-speculative on API level so that
> we can transition later without a breaking change.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 78bffd8595f0e9f34e981548d8136ff94160573b 
>   src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
>   src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
>   src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 
> 
> 
> Diff: https://reviews.apache.org/r/66050/diff/13/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66817/#review202030
---



Patch looks great!

Reviews applied: [8, 9, 66670, 66671, 66817]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 26, 2018, 5:18 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66817/
> ---
> 
> (Updated April 26, 2018, 5:18 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
> Zhang.
> 
> 
> Bugs: MESOS-8732
> https://issues.apache.org/jira/browse/MESOS-8732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enforces all tests that don't specify a containerizer to use
> composing containerizer. This is needed to make sure that composing
> containerizer is used as a default containerizer for most of tests.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 
> 
> 
> Diff: https://reviews.apache.org/r/66817/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66310/#review202029
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On April 26, 2018, 12:39 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66310/
> ---
> 
> (Updated April 26, 2018, 12:39 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8735
> https://issues.apache.org/jira/browse/MESOS-8735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to support recovering resource provider manager information
> in the future, we need to adjust the construction of the manager to be
> able to consume a registrar.
> 
> This patch lays the groundwork by adjusting interfaces and their
> usage; we will make use of the passed on information in a following
> patch.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/manager.hpp bc017fa3998b780cec82718cabe2a8b470a66db2 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
>   src/resource_provider/registrar.cpp 
> 92ef9aecb1e93d10f46e53984391558f9901a60b 
>   src/slave/slave.cpp d0ff5f872433b3891b32e35aea6212bf45693ae5 
>   src/tests/resource_provider_manager_tests.cpp 
> c52541bf130ccf4795b989b53331176a64a097ea 
> 
> 
> Diff: https://reviews.apache.org/r/66310/diff/10/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66817/#review202026
---



PASS: Mesos patch 66817 was successfully built and tested.

Reviews applied: `['8', '9', '66670', '66671', '66817']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66817

- Mesos Reviewbot Windows


On April 26, 2018, 5:18 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66817/
> ---
> 
> (Updated April 26, 2018, 5:18 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
> Zhang.
> 
> 
> Bugs: MESOS-8732
> https://issues.apache.org/jira/browse/MESOS-8732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enforces all tests that don't specify a containerizer to use
> composing containerizer. This is needed to make sure that composing
> containerizer is used as a default containerizer for most of tests.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 
> 
> 
> Diff: https://reviews.apache.org/r/66817/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review202022
---



PASS: Mesos patch 65505 was successfully built and tested.

Reviews applied: `['65505']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65505

- Mesos Reviewbot Windows


On April 26, 2018, 10 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65505/
> ---
> 
> (Updated April 26, 2018, 10 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Kevin Klues.
> 
> 
> Bugs: MESOS-8734
> https://issues.apache.org/jira/browse/MESOS-8734
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test was removed in fd4b9af147, but it's important to check that
> after termination of a nested container, its termination status is
> available. This property is used in default executor.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
> 661be81d6036113295876546f565264b843b704d 
> 
> 
> Diff: https://reviews.apache.org/r/65505/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66531: Added new authorization for `ResizeVolume`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66531/#review201978
---


Fix it, then Ship it!





src/authorizer/local/authorizer.cpp
Lines 910-914 (patched)


Let's move this below `case authorization::CREATE_VOLUME` for consistency.



src/master/master.hpp
Lines 895 (patched)


s/`resource`/`volume`/. Or if you prefer keeping the parameter name as 
`resource`, please update the above comment: `@param resource`, as well as the 
variable name in `Master::authorizeResizeVolume()` in `master.cpp`.



src/master/master.cpp
Lines 4993 (patched)


`to grow a volume`



src/master/master.cpp
Lines 5000 (patched)


`to grow a volume`



src/master/master.cpp
Lines 5086 (patched)


`to shrink a volume`



src/master/master.cpp
Lines 5093 (patched)


`to shrink a volume`


- Chun-Hung Hsiao


On April 20, 2018, 11:16 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66531/
> ---
> 
> (Updated April 20, 2018, 11:16 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
> https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new authorization action is modelled after `CreateVolume`, and will
> be shared by both `GROW_VOLUME` and `SHRINK_VOLUME` operations and
> corresponding operator APIs.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 8ef33210644e7d2924b402a3158b1b38c1fdb464 
>   include/mesos/authorizer/authorizer.proto 
> 1508c01130013d74ed2b2574a2428f38e3d2c064 
>   src/authorizer/local/authorizer.cpp 
> c098ba9ded1b29a2e079cf09ab80b61f6fa4af05 
>   src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
> 
> 
> Diff: https://reviews.apache.org/r/66531/diff/4/
> 
> 
> Testing
> ---
> 
> Manually created ACL and verified that untrusted principals will not allow to 
> grow/shrink volumes.
> Also created unit test in next patch.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66749: Added more logging to agent recovery path.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66749/#review202016
---


Ship it!




Ship It!

- Greg Mann


On April 23, 2018, 10:30 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66749/
> ---
> 
> (Updated April 23, 2018, 10:30 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-8793
> https://issues.apache.org/jira/browse/MESOS-8793
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added logging in some agent recovery continuations to
> make analyzing agent recovery related issue less painful.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.cpp 
> 186102c66d373dcd799cadd9fed7d1c8cb894971 
>   src/slave/containerizer/docker.cpp a4c9c10e91e75f406329cbb2086f39b549cbeed0 
>   src/slave/containerizer/mesos/containerizer.cpp 
> def09f1104213bf73d9f95cb5ad2fb80e3bdb04a 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> af34a856e092a880a0809da34ead9d8588b0ac8f 
>   src/slave/slave.cpp 9d2d1928b231044988f1855eb518448db38ff04f 
> 
> 
> Diff: https://reviews.apache.org/r/66749/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66799/#review202015
---


Ship it!




Ship It!

- Greg Mann


On April 25, 2018, 4:46 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66799/
> ---
> 
> (Updated April 25, 2018, 4:46 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8687
> https://issues.apache.org/jira/browse/MESOS-8687
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test used to be sporadically segfault as described in MESOS-8687.
> The suspected cause is that a in a master actor, the `httpSequence`
> field was lazily initialized in `ProcessBase::consume()` and afterwards
> a call to `ProcessBase::_consume()` was dispatched, where it was
> assumed that `httpSequence` is already initialized.
> 
> However, during this test the master actor would be destroyed and a
> new actor would be spawned with the same PID. The dispatched method
> would be called on this new actor and find `httpSequence` to be not
> initialized, leading to a crash.
> 
> This patch introduces a call to `Clock::settle()` after the master
> is shut down to ensure the outstanding `_consume()` gets discarded
> before starting the new master actor.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 
> 
> 
> Diff: https://reviews.apache.org/r/66799/diff/1/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*MasterAPITest*MasterFailover*" 
> --gtest_repeat=100 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66817/
---

Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
Zhang.


Bugs: MESOS-8732
https://issues.apache.org/jira/browse/MESOS-8732


Repository: mesos


Description
---

This patch enforces all tests that don't specify a containerizer to use
composing containerizer. This is needed to make sure that composing
containerizer is used as a default containerizer for most of tests.


Diffs
-

  src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 


Diff: https://reviews.apache.org/r/66817/diff/1/


Testing
---

internal CI


Thanks,

Andrei Budnik

Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/
---

(Updated April 26, 2018, 5 p.m.)


Review request for mesos, Jie Yu, Joseph Wu, and Kevin Klues.


Changes
---

rebased with the current master


Repository: mesos


Description
---

This test was removed in fd4b9af147, but it's important to check that
after termination of a nested container, its termination status is
available. This property is used in default executor.


Diffs (updated)
-

  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
661be81d6036113295876546f565264b843b704d 


Diff: https://reviews.apache.org/r/65505/diff/2/

Changes: https://reviews.apache.org/r/65505/diff/1-2/


Testing
---

internal CI


Thanks,

Andrei Budnik

Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66815/#review202013
---



PASS: Mesos patch 66815 was successfully built and tested.

Reviews applied: `['66815']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66815

- Mesos Reviewbot Windows


On April 26, 2018, 3:24 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66815/
> ---
> 
> (Updated April 26, 2018, 3:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8797
> https://issues.apache.org/jira/browse/MESOS-8797
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This would fail in some cases where the optional
> message is `None`, e.g. when the container is in
> killing state.
> 
> 
> Diffs
> -
> 
>   src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b 
> 
> 
> Diff: https://reviews.apache.org/r/66815/diff/1/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests 
> --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0 
> --gtest_repeat=500 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 66814: Added a test `FsAclTest.ManipulateAcl`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66814/#review202012
---



PASS: Mesos patch 66814 was successfully built and tested.

Reviews applied: `['66811', '66812', '66813', '66814']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66814

- Mesos Reviewbot Windows


On April 26, 2018, 7:09 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66814/
> ---
> 
> (Updated April 26, 2018, 7:09 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8809
> https://issues.apache.org/jira/browse/MESOS-8809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `FsAclTest.ManipulateAcl`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> c190baa2230298e428d4034b90dccffb59b4e710 
> 
> 
> Diff: https://reviews.apache.org/r/66814/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66815/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-8797
https://issues.apache.org/jira/browse/MESOS-8797


Repository: mesos


Description
---

This would fail in some cases where the optional
message is `None`, e.g. when the container is in
killing state.


Diffs
-

  src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b 


Diff: https://reviews.apache.org/r/66815/diff/1/


Testing
---

`./src/mesos-tests 
--gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0 
--gtest_repeat=500 --gtest_break_on_failure`


Thanks,

Benno Evers

Review Request 66814: Added a test `FsAclTest.ManipulateAcl`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66814/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8809
https://issues.apache.org/jira/browse/MESOS-8809


Repository: mesos


Description
---

Added a test `FsAclTest.ManipulateAcl`.


Diffs
-

  3rdparty/stout/tests/os/filesystem_tests.cpp 
c190baa2230298e428d4034b90dccffb59b4e710 


Diff: https://reviews.apache.org/r/66814/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang

Review Request 66813: Added `setfacl()` and `getfacl()` in stout.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66813/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8809
https://issues.apache.org/jira/browse/MESOS-8809


Repository: mesos


Description
---

Added `setfacl()` and `getfacl()` in stout.


Diffs
-

  3rdparty/stout/include/Makefile.am 52f81a8590e7a223cde0dbffc354af39b8325635 
  3rdparty/stout/include/stout/os.hpp aee041891b7e7ff93a0b1ac31019a7a3d4eae962 
  3rdparty/stout/include/stout/os/acl.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/acl.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/acl.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/66813/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang

Review Request 66812: Added `libacl` as a dependency of Mesos.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66812/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8809
https://issues.apache.org/jira/browse/MESOS-8809


Repository: mesos


Description
---

Added `libacl` as a dependency of Mesos.


Diffs
-

  configure.ac 6e91ecf4659ebec2e124ca4b2218c830608abeb0 
  docs/building.md 0def32bf7d98ffca6dec51c63fcd6de798b3ee69 
  src/Makefile.am 7e91681e3b8b217f8b23fa5347e059640c62fc65 


Diff: https://reviews.apache.org/r/66812/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang

Review Request 66811: Added `libacl` as a dependency of stout.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66811/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8809
https://issues.apache.org/jira/browse/MESOS-8809


Repository: mesos


Description
---

Added `libacl` as a dependency of stout.


Diffs
-

  3rdparty/CMakeLists.txt b7362d2be75e4de06092f16698a784b7a78994cb 
  3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc 
  3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da 
  3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5 


Diff: https://reviews.apache.org/r/66811/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 63372: Added documentation for memory profiling.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review202003
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['63372']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372/logs/mesos-tests-stdout.log):

```
[ RUN  ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1
[   OK ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1 
(14643 ms)
[ RUN  ] ContentType/SchedulerTest.ShutdownExecutor/0
[   OK ] ContentType/SchedulerTest.ShutdownExecutor/0 (14518 ms)
[ RUN  ] ContentType/SchedulerTest.ShutdownExecutor/1
[   OK ] ContentType/SchedulerTest.ShutdownExecutor/1 (14787 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/0
[   OK ] ContentType/SchedulerTest.Decline/0 (14814 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/1
[   OK ] ContentType/SchedulerTest.Decline/1 (14502 ms)
[ RUN  ] ContentType/SchedulerTest.Revive/0
[   OK ] ContentType/SchedulerTest.Revive/0 (14124 ms)
[ RUN  ] ContentType/SchedulerTest.Revive/1
[   OK ] ContentType/SchedulerTest.Revive/1 (14456 ms)
[ RUN  ] ContentType/SchedulerTest.Suppress/0
[   OK ] ContentType/SchedulerTest.Suppress/0 (14385 ms)
[ RUN  ] ContentType/SchedulerTest.Suppress/1
[   OK ] ContentType/SchedulerTest.Suppress/1 (14771 ms)
[ RUN  ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0
[   OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0 (19123 
ms)
[ RUN  ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1
[   OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1 (19412 
ms)
[ RUN  ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0
[   OK ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0 
(19153 ms)
[ RUN  ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1
[   OK ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1 
(19597 ms)
[ RUN  ] ContentType/SchedulerTest.Message/0
[   OK ] ContentType/SchedulerTest.Message/0 (14646 ms)
[ RUN  ] ContentType/SchedulerTest.Message/1
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63372/logs/mesos-tests-stderr.log):

```
I0426 12:58:15.384744 13740 master.cpp:8935] Framework failover timeout, 
removing framework a9f53d22-f71b-4a55-bca3-07bc218ca97c- (default)
I0426 12:58:15.384744 13740 master.cpp:9829] Removing framework 
a9f53d22-f71b-4a55-bca3-07bc218ca97c- (default)
I0426 12:58:15.385751 13740 master.cpp:10547] Updating the state of task 
66141341-0244-477b-a7ad-c081b6abd91b of framework 
a9f53d22-f71b-4a55-bca3-07bc218ca97c- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0426 12:58:15.385751  4956 slave.cpp:3919] Shutting down framework 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-
I0426 12:58:15.385751  4956 slave.cpp:6616] Shutting down executor 'default' of 
framework a9f53d22-f71b-4a55-bca3-07bc218ca97c- (via HTTP)
I0426 12:58:15.387814 13740 master.cpp:10646] Removing task 
66141341-0244-477b-a7ad-c081b6abd91b with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework a9f53d22-f71b-4a55-bca3-07bc218ca97c- on 
agent a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 at slave(421)@172.27.128.1:5 
(winbldsrv-02)
I0426 12:58:15.389746 13740 master.cpp:10675] Removing executor 'default' with 
resources [] of framework a9f53d22-f71b-4a55-bca3-07bc218ca97c- on agent 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 at slave(421)@172.27.128.1:5 
(winbldsrv-02)
I0426 12:58:15.391746 13276 hierarchical.cpp:344] Removed framework 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-
I0426 12:58:15.392760 16168 slave.cpp:919] Agent terminating
W0426 12:58:15.392760 16168 slave.cpp:3915] Ignoring shutdown framework 
a9f53d22-f71b-4a55-bca3-07bc218ca97c- because it is terminating
I0426 12:58:15.392760  5328 master.cpp:1296] Agent 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 at slave(421)@172.27.128.1:5 
(winbldsrv-02) disconnected
I0426 12:58:15.393760  5328 master.cpp:3296] Disconnecting agent 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 at slave(421)@172.27.128.1:5 
(winbldsrv-02)
I0426 12:58:15.393760  5328 master.cpp:3315] Deactivating agent 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 at slave(421)@172.27.128.1:5 
(winbldsrv-02)
I0426 12:58:15.394780 11792 hierarchical.cpp:766] Agent 
a9f53d22-f71b-4a55-bca3-07bc218ca97c-S0 deactivated
I0426 12:58:15.417757 

Re: Review Request 66311: Set up recovery code paths of resource provider manager.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66311/
---

(Updated April 26, 2018, 2:39 p.m.)


Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.


Changes
---

Deferred function accessing registrar actor state.


Bugs: MESOS-8735
https://issues.apache.org/jira/browse/MESOS-8735


Repository: mesos


Description
---

This patch adjusts the control flow of the resource provider manager
so that we can in the future make use of persisted resource provider
information. While this patch sets up the needed flow, it does not
implement recovery logic, yet.


Diffs (updated)
-

  src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
  src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 
  src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b 
  src/tests/resource_provider_manager_tests.cpp 
c52541bf130ccf4795b989b53331176a64a097ea 


Diff: https://reviews.apache.org/r/66311/diff/10/

Changes: https://reviews.apache.org/r/66311/diff/9-10/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66310/
---

(Updated April 26, 2018, 2:39 p.m.)


Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.


Changes
---

Explicitly tore down resource provider manager with the agent.

This prevents multiple resource provider managers from being active when
an agent is terminated (without being destructed) and reassigned from a
newly constructed one.


Bugs: MESOS-8735
https://issues.apache.org/jira/browse/MESOS-8735


Repository: mesos


Description
---

In order to support recovering resource provider manager information
in the future, we need to adjust the construction of the manager to be
able to consume a registrar.

This patch lays the groundwork by adjusting interfaces and their
usage; we will make use of the passed on information in a following
patch.


Diffs (updated)
-

  src/resource_provider/manager.hpp bc017fa3998b780cec82718cabe2a8b470a66db2 
  src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
  src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b 
  src/slave/slave.cpp d0ff5f872433b3891b32e35aea6212bf45693ae5 
  src/tests/resource_provider_manager_tests.cpp 
c52541bf130ccf4795b989b53331176a64a097ea 


Diff: https://reviews.apache.org/r/66310/diff/10/

Changes: https://reviews.apache.org/r/66310/diff/9-10/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66644/#review201999
---



Patch looks great!

Reviews applied: [66644]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 25, 2018, 3:46 p.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66644/
> ---
> 
> (Updated April 25, 2018, 3:46 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: 8750
> https://issues.apache.org/jira/browse/8750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A RunTask messsage could get dropped for an agent while it's
> disconnected from the master and when such an agent goes unreachable
> then this dropped task gets added to the unreachable tasks.
> When the agent reregisters, tasks reported by it are removed from the 
> unreachableTasks bookkeeping on the master but since the
> agent doesn't know about the dropped task so it doesn't get removed
> from the unreachableTasks leading to a master check failure when
> this inconsistency is detected during framework removal.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 
>   src/tests/partition_tests.cpp 9138e5c745cf354a3573e1ab0b251d46702833cc 
> 
> 
> Diff: https://reviews.apache.org/r/66644/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>

Re: Review Request 63371: Added unit test for new MemoryProfiler class.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63371/#review201998
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['63371']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63371

Relevant logs:

- 
[libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63371/logs/libprocess-tests-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(874):
 warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_core.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1275):
 warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss 
of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_core.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1456):
 warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss 
of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_core.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\buffer.c(3099):
 warning C4244: 'function': conversion from 'int64_t' to 'unsigned int', 
possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(499):
 warning C4244: '=': conversion from 'int64_t' to 'long', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(504):
 warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(185):
 warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(230):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(587):
 warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(598):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(654):
 warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(656):
 warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(675):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201997
---



I'll fix the outstanding issues, make minor adjustments, align accordinf to the 
80 chars per line rule and commit this shortly.


docs/memory-profiling.md
Lines 50 (patched)


can be beneficial



docs/memory-profiling.md
Lines 98 (patched)


... with the `/stop`...


- Alexander Rukletsov


On April 25, 2018, 2:07 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated April 25, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/9/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 192 (patched)
> > 
> >
> > Let's have an inline link in form []() for consistency.
> 
> Benno Evers wrote:
> The problem is that the url itself contains a `)`, confusing the markdown 
> parser. It's possible to escape that `)` with a backslash, but then the link 
> will be incorrect for people reading the markdown directly.

We can use another link, e.g., http://jemalloc.net/jemalloc.3.html. Moreover, 
the latter points to the version bundled with Mesos.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201770
---


On April 25, 2018, 2:07 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated April 25, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/9/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 66405: Doc improvements (wip).

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66405/
---

Review request for mesos.


Repository: mesos


Description
---

Doc improvements (wip).


Testing
---


Thanks,

Benno Evers

Re: Review Request 63371: Added unit test for new MemoryProfiler class.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63371/
---

(Updated April 26, 2018, 9:59 a.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Added unit test for new MemoryProfiler class.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am c895d3ac7b9cc5ffd6c8b57ff24def866eb0213d 
  3rdparty/libprocess/src/tests/CMakeLists.txt 
d624402bc9efb43a130a2afdf27cfc1aa69010e4 
  3rdparty/libprocess/src/tests/memory_profiler_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63371/diff/4/

Changes: https://reviews.apache.org/r/63371/diff/3-4/


Testing
---


Thanks,

Benno Evers

Re: Review Request 63372: Added documentation for memory profiling.

[Alexander Rukletsov]

> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 122-124 (patched)
> > 
> >
> > Is `dot` tool required as well?
> 
> Benno Evers wrote:
> Wasn't that what you found testing on Mac?
> 
> Alexander Rukletsov wrote:
> That was a test on linux. Have you confirmed?

Looks like this according to 
http://download.redis.io/redis-stable/deps/jemalloc/bin/jeprof.in


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201770
---


On April 25, 2018, 2:07 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> ---
> 
> (Updated April 25, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/9/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66799/#review201988
---



Patch looks great!

Reviews applied: [66799]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 25, 2018, 4:46 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66799/
> ---
> 
> (Updated April 25, 2018, 4:46 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8687
> https://issues.apache.org/jira/browse/MESOS-8687
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test used to be sporadically segfault as described in MESOS-8687.
> The suspected cause is that a in a master actor, the `httpSequence`
> field was lazily initialized in `ProcessBase::consume()` and afterwards
> a call to `ProcessBase::_consume()` was dispatched, where it was
> assumed that `httpSequence` is already initialized.
> 
> However, during this test the master actor would be destroyed and a
> new actor would be spawned with the same PID. The dispatched method
> would be called on this new actor and find `httpSequence` to be not
> initialized, leading to a crash.
> 
> This patch introduces a call to `Clock::settle()` after the master
> is shut down to ensure the outstanding `_consume()` gets discarded
> before starting the new master actor.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 
> 
> 
> Diff: https://reviews.apache.org/r/66799/diff/1/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*MasterAPITest*MasterFailover*" 
> --gtest_repeat=100 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66644/#review201987
---



PASS: Mesos patch 66644 was successfully built and tested.

Reviews applied: `['66644']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66644

- Mesos Reviewbot Windows


On April 25, 2018, 3:46 p.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66644/
> ---
> 
> (Updated April 25, 2018, 3:46 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: 8750
> https://issues.apache.org/jira/browse/8750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A RunTask messsage could get dropped for an agent while it's
> disconnected from the master and when such an agent goes unreachable
> then this dropped task gets added to the unreachable tasks.
> When the agent reregisters, tasks reported by it are removed from the 
> unreachableTasks bookkeeping on the master but since the
> agent doesn't know about the dropped task so it doesn't get removed
> from the unreachableTasks leading to a master check failure when
> this inconsistency is detected during framework removal.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 
>   src/tests/partition_tests.cpp 9138e5c745cf354a3573e1ab0b251d46702833cc 
> 
> 
> Diff: https://reviews.apache.org/r/66644/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>