> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote: > > docs/memory-profiling.md > > Lines 192 (patched) > > <https://reviews.apache.org/r/63372/diff/7/?file=2004744#file2004744line192> > > > > Let's have an inline link in form []() for consistency. > > Benno Evers wrote: > The problem is that the url itself contains a `)`, confusing the markdown > parser. It's possible to escape that `)` with a backslash, but then the link > will be incorrect for people reading the markdown directly.
We can use another link, e.g., http://jemalloc.net/jemalloc.3.html. Moreover, the latter points to the version bundled with Mesos. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review201770 ----------------------------------------------------------- On April 25, 2018, 2:07 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63372/ > ----------------------------------------------------------- > > (Updated April 25, 2018, 2:07 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Added documentation for memory profiling. > > > Diffs > ----- > > CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b > docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f > docs/memory-profiling.md PRE-CREATION > > > Diff: https://reviews.apache.org/r/63372/diff/9/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
