Re: Review Request 67331: Documented the `linux/devices` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67331/#review203922 --- Fix it, then Ship it! docs/isolators/linux-devices.md Lines

Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67255/ --- (Updated May 25, 2018, 10:39 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67009: Added tests of resource provider registrar recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67009/#review203911 --- src/tests/resource_provider_manager_tests.cpp Lines 846

Re: Review Request 67318: Updated python.m4 to be compatible with Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67318/#review203914 --- Patch looks great! Reviews applied: [67318] Passed command:

Re: Review Request 67264: Unmounted any dangling persistent volume in gc paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67264/#review203912 --- src/slave/gc.cpp Lines 221 (patched)

Review Request 67331: Documented the `linux/devices` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67331/ --- Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Bugs:

Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/#review203910 --- Ship it! Ship It! - Jie Yu On May 24, 2018, 12:47 a.m.,

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65666/#review203909 --- Ship it! Ship It! - Jie Yu On May 22, 2018, 11:33 p.m.,

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/#review203901 --- Fix it, then Ship it!

Re: Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67313/#review203907 --- Ship it! Ship It! - Joseph Wu On May 24, 2018, 7:52 p.m.,

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

> On May 25, 2018, 12:35 p.m., Benjamin Bannier wrote: > > docs/developer-guide.md > > Lines 128 (patched) > > > > > > Thanks for capturing this! > > > > As a high level comment, I believe this doc should

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

> On May 25, 2018, 10:33 a.m., James Peach wrote: > > docs/developer-guide.md > > Lines 152 (patched) > > > > > > "If you need to build cquery from source, the cquery wiki provides a > > decent ..." Oops. -

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67308/#review203902 --- docs/developer-guide.md Lines 128 (patched)

Re: Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67313/#review203900 --- Patch looks great! Reviews applied: [67313] Passed command:

Re: Review Request 67145: Added `linux/devices` isolator whitelist tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67145/#review203898 --- Ship it! Ship It! - Jie Yu On May 24, 2018, 12:28 a.m.,

Re: Review Request 67098: Updated the container launcher mount sequence.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67098/#review203897 --- Ship it! Ship It! - Jie Yu On May 24, 2018, 12:27 a.m.,

Re: Review Request 67303: Added documentation for resource provider and CSI plugin metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67303/ --- (Updated May 25, 2018, 6:30 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 67328: Used italic fonts to denote placeholdes in metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67328/ --- Review request for mesos, Greg Mann and Joerg Schad. Repository: mesos

Re: Review Request 67288: White list fds that child processes can inherit in mesos containerizer.

> On May 24, 2018, 10:32 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1878 (patched) > > > > > > Oh, also, we only need to send `pipes[0]`; as the child process

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67308/#review203894 --- Fix it, then Ship it! docs/developer-guide.md Lines 152

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67308/#review203893 --- Patch looks great! Reviews applied: [67308] Passed command:

Re: Review Request 67320: Sent task (health) check updates over the operator streaming API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67320/#review203885 --- src/tests/api_tests.cpp Lines 2386 (patched)

Re: Review Request 67270: Fixed compilation issues in libprocess example.

> On May 25, 2018, 3:37 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/examples/example.cpp > > Line 106 (original), 98 (patched) > > > > > > If you add this and the one below you should remove the `using`

Re: Review Request 67270: Fixed compilation issues in libprocess example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67270/#review203886 --- 3rdparty/libprocess/examples/example.cpp Line 106 (original), 98

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203883 --- src/slave/containerizer/mesos/launch.cpp Lines 1122 (patched)

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203871 --- 3rdparty/libprocess/include/process/grpc.hpp Lines 27 (patched)

Re: Review Request 67312: Updated mesos to use vector instead of list where possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67312/#review203875 --- Patch looks great! Reviews applied: [67309, 67310, 67311, 67312]

Re: Review Request 67320: Sent task (health) check updates over the operator streaming API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67320/ --- (Updated May 25, 2018, 1:52 p.m.) Review request for mesos and Zhitao Li.

Re: Review Request 67320: Sent task (health) check updates over the operator streaming API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67320/ --- (Updated May 25, 2018, 1:51 p.m.) Review request for mesos and Zhitao Li.

Re: Review Request 67317: Fixed flaky `TerminatedNestedStatus` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67317/#review203873 --- Ship it! Ship It! - Qian Zhang On May 25, 2018, 6:50 p.m.,

Review Request 67322: Added Python 2 check for Python bindings when using `configure`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67322/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-8955

Re: Review Request 67321: Fixed python3/post-reviews.py type error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67321/#review203865 --- Ship it! Ship It! - Alexander Rukletsov On May 25, 2018,

Re: Review Request 67320: Sent task (health) check updates over the operator streaming API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67320/#review203860 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 67321: Fixed python3/post-reviews type error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67321/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8954

Re: Review Request 67305: Moved the "Resource Provider" section to `resource-provider.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67305/#review203859 --- Patch looks great! Reviews applied: [65665, 65666, 67224, 67255,

Re: Review Request 67318: Updated python.m4 to be compatible with Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67318/ --- (Updated May 25, 2018, 10:54 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67217/ --- (Updated May 25, 2018, 10:51 a.m.) Review request for mesos, Benjamin Bannier

Review Request 67317: Fixed flaky `TerminatedNestedStatus` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67317/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian

Re: Review Request 67318: Updated python.m4 to be compatible with Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67318/#review203858 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67280: Added libprocess example code to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67280/#review203857 --- Ship it! Ship It! - Benno Evers On May 24, 2018, 11:52

Re: Review Request 67320: Sent task (health) check updates over the operator streaming API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67320/ --- (Updated May 25, 2018, 10:21 a.m.) Review request for mesos and Zhitao Li.

Review Request 67320: Sent task (health) check updates over the operator streaming API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67320/ --- Review request for mesos and Zhitao Li. Repository: mesos Description

Re: Review Request 67304: Added missing calls to the scheduler API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67304/#review203854 --- Patch looks great! Reviews applied: [67304] Passed command: