Re: Review Request 68808: Avoided dirtying the DRF sorter when an allocation is performed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68808/#review208982 --- PASS: Mesos patch 68808 was successfully built and tested. Review

Re: Review Request 68732: Cached weights in the sorters nodes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review208981 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 68833: Use total cluster resources as framework sorter "total".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68833/ --- Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Meng Zhu. Bugs:

Review Request 68808: Avoided dirtying the DRF sorter when an allocation is performed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68808/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Bugs: MESOS-9249 htt

Re: Review Request 68832: Add unit tests for Stout `path::normalize` function in POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68832/#review208980 --- PASS: Mesos patch 68832 was successfully built and tested. Review

Re: Review Request 68832: Add unit tests for Stout `path::normalize` function in POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68832/#review208978 --- Ship it! Ship It! - Eric Chung On Sept. 25, 2018, 12:05 a.m.

Re: Review Request 65811: Added Stout `path::normalize` function for POSIX paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review208977 --- Ship it! Ship It! - Eric Chung On Sept. 25, 2018, 12:08 a.m.

Re: Review Request 68732: Cached weights in the sorters nodes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/ --- (Updated Sept. 25, 2018, 12:22 a.m.) Review request for mesos, Gastón Kleiman a

Re: Review Request 68830: Added the Mesos 1.7.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68830/ --- (Updated Sept. 24, 2018, 5:12 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68830: Added the Mesos 1.7.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68830/ --- (Updated Sept. 24, 2018, 5:11 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65811: Added Stout `path::normalize` function for POSIX paths.

> On March 16, 2018, 11:17 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 65 (patched) > > > > > > Can you add some tests for this? This warrents some tests. Also, please > > reach out to And

Re: Review Request 65811: Added Stout `path::normalize` function for POSIX paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated Sept. 25, 2018, 12:08 a.m.) Review request for mesos, Anish Gupta, Eri

Review Request 68832: Add unit tests for Stout `path::normalize` function in POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68832/ --- Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, Jam

Re: Review Request 68813: Added support for `Option` / `Option`.

> On Sept. 23, 2018, 11:31 a.m., Benjamin Bannier wrote: > > I am not convinced we should add this. The alternative of using e.g., an > > `Option` or `Option` seems to not only produce correct > > behavior (even when wrapping a ptr to `const`), but also caution users > > enough that noting her

Re: Review Request 68830: Added the Mesos 1.7.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68830/#review208971 --- Fix it, then Ship it! You can attach the benchmark image to thi

Re: Review Request 68830: Added the Mesos 1.7.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68830/#review208966 --- site/source/blog/2018-09-24-mesos-1-7-0-released.md Lines 30 (pat

Re: Review Request 68830: Added the Mesos 1.7.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68830/#review208965 --- FAIL: Failed to apply the current review. Failed command: `python

Review Request 68830: Added the Mesos 1.7.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68830/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Greg Mann. Repo

Review Request 68829: Updated website for 1.7.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68829/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description -

Re: Review Request 65811: Added Stout `path::normalize` function for POSIX paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review208963 --- Ship it! Ship It! - Eric Chung On Sept. 24, 2018, 8:40 p.m.,

Re: Review Request 65811: Added Stout `path::normalize` function for POSIX paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated Sept. 24, 2018, 8:40 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

> On Sept. 24, 2018, 7:53 p.m., Eric Chung wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 63 (patched) > > > > > > perhaps rephrase as: `...without touching the actual filesystem.` Fixed. > On Sept. 24,

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated Sept. 24, 2018, 8:38 p.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 68403: Updated tests for XFS disk resource statistics.

> On Sept. 20, 2018, 10:15 p.m., Ilya Pronin wrote: > > src/tests/containerizer/xfs_quota_tests.cpp > > Lines 879-881 (original), 904-906 (patched) > > > > > > Nit: move `usage()` call below the started/working "lock

Re: Review Request 68402: Added a test for XFS persistent volume isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68402/ --- (Updated Sept. 24, 2018, 8:15 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 68826: Fixed bug in `verify-reviews` due to mismatched types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68826/#review208960 --- PASS: Mesos patch 68826 was successfully built and tested. Review

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review208903 --- 3rdparty/stout/include/stout/path.hpp Lines 63 (patched)

Re: Review Request 68826: Fixed bug in `verify-reviews` due to mismatched types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68826/#review208959 --- Ship it! LGTM from my limited understanding of python - Vinod

[GitHub] jpeach commented on issue #311: BugFix backporting 1.4.x

jpeach commented on issue #311: BugFix backporting 1.4.x URL: https://github.com/apache/mesos/pull/311#issuecomment-424091137 ``` ../../src/tests/master_validation_tests.cpp:880:33: error: unused variable 'capabilities' [-Werror,-Wunused-variable] protobuf::slave::Capabilities capab

Re: Review Request 68818: Fixed accidental use-after-move.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68818/#review208956 --- Ship it! ah, thanks for catching this! - Meng Zhu On Sept. 2

Re: Review Request 68826: Fixed bug in `verify-reviews` due to mismatched types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68826/ --- (Updated Sept. 24, 2018, 11:27 a.m.) Review request for mesos, Benjamin Bannier

Review Request 68826: Fixed bug in `verify-reviews` due to mismatched types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68826/ --- Review request for mesos, Benjamin Bannier and Vinod Kone. Repository: mesos

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/ --- (Updated Sept. 24, 2018, 4:58 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

> On Sept. 20, 2018, 12:59 a.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 347-348 (patched) > > > > > > Are we checking this in case multiple volumes have the same project

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/#review208951 --- Ship it! Ship It! - James Peach On Sept. 23, 2018, 8:44 p.m.