Re: Review Request 69274: Reduced default oversubscription in parallel test runner.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69274/#review210395
---



PASS: Mesos patch 69274 was successfully built and tested.

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2579/mesos-review-69274

- Mesos Reviewbot Windows


On Nov. 7, 2018, 8:30 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69274/
> ---
> 
> (Updated Nov. 7, 2018, 8:30 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reduced default oversubscription in parallel test runner.
> 
> 
> Diffs
> -
> 
>   support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 
> 
> 
> Diff: https://reviews.apache.org/r/69274/diff/1/
> 
> 
> Testing
> ---
> 
> Executed `mesos-tests` in parallel with default settings.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69280: Fixed flakiness in `PartitionTest.TaskCompletedOnPartitionedAgent`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69280/#review210394
---



PASS: Mesos patch 69280 was successfully built and tested.

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2578/mesos-review-69280

- Mesos Reviewbot Windows


On Nov. 7, 2018, 9:34 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69280/
> ---
> 
> (Updated Nov. 7, 2018, 9:34 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-6990
> https://issues.apache.org/jira/browse/MESOS-6990
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test wasn't ensuring that the TASK_FINISHED update gets
> processed by the agent before it re-registers with the master, so
> sometimes the master will forward the old TASK_RUNNING state.
> 
> 
> Diffs
> -
> 
>   src/tests/partition_tests.cpp 788d3b988cf7de206f295bffdc0376e7e1242349 
> 
> 
> Diff: https://reviews.apache.org/r/69280/diff/1/
> 
> 
> Testing
> ---
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 69278: Added hierchical allocator benchmarks to the cmake build.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69278/#review210393
---



PASS: Mesos patch 69278 was successfully built and tested.

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2577/mesos-review-69278

- Mesos Reviewbot Windows


On Nov. 7, 2018, 1:17 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69278/
> ---
> 
> (Updated Nov. 7, 2018, 1:17 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added hierchical allocator benchmarks to the cmake build.
> 
> 
> Diffs
> -
> 
>   src/tests/CMakeLists.txt 00dbdee1c06e7571fa799850cdaf7f2ccadc8bea 
> 
> 
> Diff: https://reviews.apache.org/r/69278/diff/1/
> 
> 
> Testing
> ---
> 
> * `ninja check`.
> * executed `mesos-tidy` with default against source file; no violations 
> reported.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69016: Added a test `SubprocessTest.WhiteListFds`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69016/#review210409
---


Ship it!




Ship It!

- Gilbert Song


On Oct. 14, 2018, 7:11 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69016/
> ---
> 
> (Updated Oct. 14, 2018, 7:11 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9152 and MESOS-9164
> https://issues.apache.org/jira/browse/MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `SubprocessTest.WhiteListFds`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> e6742ecfc8f5e0a5cf7f4a53f3df4a3dd48e5ea9 
> 
> 
> Diff: https://reviews.apache.org/r/69016/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68995/#review210412
---


Ship it!




Ship It!

- Gilbert Song


On Oct. 14, 2018, 7:14 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68995/
> ---
> 
> (Updated Oct. 14, 2018, 7:14 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9164
> https://issues.apache.org/jira/browse/MESOS-9164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We do not need this child hook since any file descripters need
> to unset the close-on-exec flag can be put in the `whitelist_fds`
> parameter of the `subprocess` method.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 135bf243c7e51c88fed6c67804af7f04a2098981 
>   3rdparty/libprocess/src/subprocess.cpp 
> c0640de2dc4278b884282dfaad98c49c3b067a5b 
> 
> 
> Diff: https://reviews.apache.org/r/68995/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68991: Added a test `FsTest.Lsof`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68991/#review210406
---


Ship it!




Ship It!

- Gilbert Song


On Oct. 18, 2018, 11:58 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68991/
> ---
> 
> (Updated Oct. 18, 2018, 11:58 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9152
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `FsTest.Lsof`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> 29f06f3dd126007d6b3a81f31795270f0654b847 
> 
> 
> Diff: https://reviews.apache.org/r/68991/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68644: Closed all file descriptors except `whitelist_fds` in posix/subprocess.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68644/#review210408
---


Ship it!




Ship It!

- Gilbert Song


On Oct. 16, 2018, 11:43 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68644/
> ---
> 
> (Updated Oct. 16, 2018, 11:43 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9152 and MESOS-9164
> https://issues.apache.org/jira/browse/MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Closed all file descriptors except `whitelist_fds` in posix/subprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/posix/subprocess.hpp 
> 007058b61fdcd4716aa793516c842c3cef8c0a29 
>   3rdparty/libprocess/src/subprocess.cpp 
> c0640de2dc4278b884282dfaad98c49c3b067a5b 
> 
> 
> Diff: https://reviews.apache.org/r/68644/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68646: Updated launchers to use subprocess's `whitelist_fds` parameter.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68646/#review210411
---


Ship it!




Ship It!

- Gilbert Song


On Oct. 14, 2018, 7:12 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68646/
> ---
> 
> (Updated Oct. 14, 2018, 7:12 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9164
> https://issues.apache.org/jira/browse/MESOS-9164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated launchers to use subprocess's `whitelist_fds` parameter.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launcher.cpp 
> a18bdff6b64f978b87af16c2655d07ba8553bc95 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> e9ab36a16b24a123a660506d55f16dea16dee911 
> 
> 
> Diff: https://reviews.apache.org/r/68646/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68643: Updated `MesosContainerizerLaunch` to call `os::lsof()`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68643/#review210407
---


Ship it!




Ship It!

- Gilbert Song


On Oct. 19, 2018, 8:37 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68643/
> ---
> 
> (Updated Oct. 19, 2018, 8:37 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9152
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `MesosContainerizerLaunch` to call `os::lsof()`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launch.cpp 
> 7193da0a094df3e441e185c62b3a0379a0bdc4a2 
> 
> 
> Diff: https://reviews.apache.org/r/68643/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69234: Made nested container runs as its parent container's user by default.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69234/#review210403
---


Ship it!




Ship It!

- Gilbert Song


On Nov. 5, 2018, 12:02 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69234/
> ---
> 
> (Updated Nov. 5, 2018, 12:02 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9332
> https://issues.apache.org/jira/browse/MESOS-9332
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made nested container runs as its parent container's user by default.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 03a4e0f1567b27b2efd8a443caea3a2a087d858c 
>   src/slave/http.cpp 0d27ab576d5fa52c06826703e3dad38c2d374cc9 
> 
> 
> Diff: https://reviews.apache.org/r/69234/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 69293: Disabled parallel test execution for reviewbot.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69293/
---

Review request for mesos, Benjamin Mahler and Vinod Kone.


Repository: mesos


Description
---

Currently no dedicated handling of XML reporting from multiple gtest
shards is implemented in our gtest runner.

This patch disables the now default-enabled parallel test runner for
any build & tests cycles under the ASF CI reviewbot job.


Diffs
-

  support/jenkins/reviewbot.sh 0dd81fd1c067dfe84c4e638ebcee87bc6d4d73a7 


Diff: https://reviews.apache.org/r/69293/diff/1/


Testing
---

NOTE: The flags for `Mesos-Buildbot` are configured directly in Jenkins and 
already adjusted.


Thanks,

Benjamin Bannier

Review Request 69291: Simplified writing out test report xml files.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69291/
---

Review request for mesos and James Peach.


Repository: mesos


Description
---

Simplified writing out test report xml files.


Diffs
-

  support/mesos-build/entrypoint.sh 012f003b3cf22b49a442df293f1b6224c074e383 


Diff: https://reviews.apache.org/r/69291/diff/1/


Testing
---


Thanks,

Vinod Kone

Review Request 69289: Added a test to verify `unsuppressOffers` behavior.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69289/
---

Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Greg Mann.


Bugs: MESOS-9028
https://issues.apache.org/jira/browse/MESOS-9028


Repository: mesos


Description
---

This test verifies that when framework unsuppresses,
it will resume getting offers from unfiltered agent resources.
And filtered agent resources should remain being filtered.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
3034d460dd48b5134cfd4a24c54775222a348e32 


Diff: https://reviews.apache.org/r/69289/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Review Request 69290: Added a new scheduler v1 call `unsuppress`.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69290/
---

Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Greg Mann.


Bugs: MESOS-9028
https://issues.apache.org/jira/browse/MESOS-9028


Repository: mesos


Description
---

`unsuppress` informs master to resume sending offers to
the framework without altering any existing filters.
Master will return 200 OK for the request after processing.


Diffs
-

  include/mesos/scheduler/scheduler.proto 
f6a780a7b75878b9e74402a28a25bb868f7ac36f 
  include/mesos/v1/scheduler/scheduler.proto 
fcfec5e417463103e98dd6917722b4fde41cac7c 
  src/master/http.cpp 75ab6ea422a77e25049cd6afe007507d11650a06 
  src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
  src/master/master.cpp f88c7c1f03f0de7236aad9e3bf4bfac82e91bc65 
  src/master/validation.cpp 5768ac8fe802f28855fbd7be135c75532771 


Diff: https://reviews.apache.org/r/69290/diff/1/


Testing
---

make check


Thanks,

Meng Zhu

Review Request 69288: Added `unsuppressOffers()` to the allocator.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69288/
---

Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Greg Mann.


Bugs: MESOS-9028
https://issues.apache.org/jira/browse/MESOS-9028


Repository: mesos


Description
---

Informs the allocator to resume sending offers
to this framework for the specified roles.
Unlike `reviveOffers()`, this does not affect
any filters that the framework currently has.


Diffs
-

  include/mesos/allocator/allocator.hpp 
2a6849bf698f171fc31c84165bd574b8f4f846ea 
  src/master/allocator/mesos/allocator.hpp 
2d83f382eed9d9dca218adf84bc03883f7486349 
  src/master/allocator/mesos/hierarchical.hpp 
a4425bc952864d6a0dacee4ae92637fd31e4a45f 
  src/master/allocator/mesos/hierarchical.cpp 
cc8ab919aedb33cf424edfdb622ca13a2cc8ff0f 
  src/tests/allocator.hpp 9437f581458a290b08dd0cae195906a2421484b5 


Diff: https://reviews.apache.org/r/69288/diff/1/


Testing
---

make check
dedicated test in r/69289/


Thanks,

Meng Zhu

Re: Review Request 69291: Simplified writing out test report xml files.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69291/
---

(Updated Nov. 7, 2018, 10:36 p.m.)


Review request for mesos and James Peach.


Changes
---

trailing slash.


Repository: mesos


Description
---

Simplified writing out test report xml files.


Diffs (updated)
-

  support/mesos-build/entrypoint.sh 012f003b3cf22b49a442df293f1b6224c074e383 


Diff: https://reviews.apache.org/r/69291/diff/2/

Changes: https://reviews.apache.org/r/69291/diff/1-2/


Testing
---


Thanks,

Vinod Kone

Re: Review Request 69291: Simplified writing out test report xml files.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69291/#review210389
---


Ship it!




Ship It!

- James Peach


On Nov. 7, 2018, 10:36 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69291/
> ---
> 
> (Updated Nov. 7, 2018, 10:36 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Simplified writing out test report xml files.
> 
> 
> Diffs
> -
> 
>   support/mesos-build/entrypoint.sh 012f003b3cf22b49a442df293f1b6224c074e383 
> 
> 
> Diff: https://reviews.apache.org/r/69291/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 68832: Add unit tests for Stout `path::normalize` function in POSIX.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/
---

(Updated Nov. 7, 2018, 10:29 p.m.)


Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, 
James Peach, and Zhitao Li.


Changes
---

Rebranch the commit parent to #65811


Bugs: MESOS-8257 and MESOS-9009
https://issues.apache.org/jira/browse/MESOS-8257
https://issues.apache.org/jira/browse/MESOS-9009


Repository: mesos


Description
---

Add unit tests for Stout `path::normalize` function in POSIX.


Diffs
-

  3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41 


Diff: https://reviews.apache.org/r/68832/diff/2/


Testing
---

`make check`


Thanks,

Jason Lai

Re: Review Request 68832: Add unit tests for Stout `path::normalize` function in POSIX.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/
---

(Updated Nov. 7, 2018, 10:10 p.m.)


Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, 
James Peach, and Zhitao Li.


Changes
---

Required for [MESOS-9009](https://issues.apache.org/jira/browse/MESOS-9009)


Bugs: MESOS-8257 and MESOS-9009
https://issues.apache.org/jira/browse/MESOS-8257
https://issues.apache.org/jira/browse/MESOS-9009


Repository: mesos


Description
---

Add unit tests for Stout `path::normalize` function in POSIX.


Diffs
-

  3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41 


Diff: https://reviews.apache.org/r/68832/diff/2/


Testing
---

`make check`


Thanks,

Jason Lai

Re: Review Request 65811: Added Stout `path::normalize` function for POSIX paths.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/
---

(Updated Nov. 7, 2018, 10:10 p.m.)


Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Changes
---

Required for [MESOS-9009](https://issues.apache.org/jira/browse/MESOS-9009)


Bugs: MESOS-8257 and MESOS-9009
https://issues.apache.org/jira/browse/MESOS-8257
https://issues.apache.org/jira/browse/MESOS-9009


Repository: mesos


Description
---

Added `path::normalize` to normalize a given pathname and remove
redundant separators and up-level references.

This function follows the rules described in `path_resolution(7)`
for Linux. However, it only performs pure lexical processing without
touching the actual filesystem.


Diffs
-

  3rdparty/stout/include/stout/path.hpp 
ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7 


Diff: https://reviews.apache.org/r/65811/diff/9/


Testing
---

`make tests and make check` with https://reviews.apache.org/r/68832/


Thanks,

Jason Lai

Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69286/
---

Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, 
and James Peach.


Bugs: MESOS-9009
https://issues.apache.org/jira/browse/MESOS-9009


Repository: mesos


Description
---

Added a new agent flag `--host_path_volume_force_creation` for
the `volume/host_path` isolator. The flag takes a colon-separated
whitelist of paths, under which non-existing host paths are allowed to
be created.

If the flag is not specified, the isolator behaves in the original way
of prohibiting all non-existing host paths from being created.


Diffs
-

  src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8 
  src/Makefile.am c17eae4ff1d019d515f67d81821e933ecb5dc190 
  src/slave/containerizer/mesos/isolators/volume/host_path.hpp 
4b509e91a056381ca90293d16a400ea4368234a3 
  src/slave/containerizer/mesos/isolators/volume/host_path.cpp 
88ecf91d91e2bebd484a4ac94510a14b3500dbfb 
  src/slave/containerizer/mesos/isolators/volume/utils.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/volume/utils.cpp PRE-CREATION 
  src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 
  src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 


Diff: https://reviews.apache.org/r/69286/diff/1/


Testing
---


Thanks,

Jason Lai

Review Request 69287: Added test cases for the `volume/host_path` isolator.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69287/
---

Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, 
and James Peach.


Bugs: MESOS-9009
https://issues.apache.org/jira/browse/MESOS-9009


Repository: mesos


Description
---

Added test cases for the `volume/host_path` isolator for whitelisted
non-existing host paths.


Diffs
-

  src/tests/containerizer/volume_host_path_isolator_tests.cpp 
81bf72e869d36edb162b121f9e84a53d2096dae3 


Diff: https://reviews.apache.org/r/69287/diff/1/


Testing
---

`make check`


Thanks,

Jason Lai

Re: Review Request 69280: Fixed flakiness in `PartitionTest.TaskCompletedOnPartitionedAgent`.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69280/#review210386
---


Ship it!




Ship It!

- Benjamin Bannier


On Nov. 7, 2018, 10:34 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69280/
> ---
> 
> (Updated Nov. 7, 2018, 10:34 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-6990
> https://issues.apache.org/jira/browse/MESOS-6990
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test wasn't ensuring that the TASK_FINISHED update gets
> processed by the agent before it re-registers with the master, so
> sometimes the master will forward the old TASK_RUNNING state.
> 
> 
> Diffs
> -
> 
>   src/tests/partition_tests.cpp 788d3b988cf7de206f295bffdc0376e7e1242349 
> 
> 
> Diff: https://reviews.apache.org/r/69280/diff/1/
> 
> 
> Testing
> ---
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 69275: Added environment sanity check to parallel test runner.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69275/#review210385
---



PASS: Mesos patch 69275 was successfully built and tested.

Reviews applied: `['69274', '69275']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2576/mesos-review-69275

- Mesos Reviewbot Windows


On Nov. 7, 2018, 3:41 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69275/
> ---
> 
> (Updated Nov. 7, 2018, 3:41 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a check to the parallel test runner that catches
> setups where the user is not allowed to launch many process (e.g., the
> default value for `ulimit -u` on centos7).
> 
> This can lead to test execution failures if many `mesos-tests`
> instances are run in parallel on machines with many cores (by default
> the parallel test runner would execute `nproc` shards which would fork
> potentially multiple executable launching `nproc` libprocess worker
> threads).
> 
> 
> Diffs
> -
> 
>   support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 
> 
> 
> Diff: https://reviews.apache.org/r/69275/diff/2/
> 
> 
> Testing
> ---
> 
> Executed `mesos-tests` in parallel with default settings.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 68804: Added Stout `os::readlink` function for POSIX paths.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68804/
---

(Updated Nov. 7, 2018, 9:22 p.m.)


Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and 
Zhitao Li.


Changes
---

Rebased to master


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added `os::readlink` for reading value of a POSIX symbolic link.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/readlink.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/68804/diff/2/

Changes: https://reviews.apache.org/r/68804/diff/1-2/


Testing
---


Thanks,

Jason Lai

Re: Review Request 69272: Clarified some comments about the usage of offer filters.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69272/#review210382
---


Ship it!




Ship It!

- Joseph Wu


On Nov. 7, 2018, 10:40 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69272/
> ---
> 
> (Updated Nov. 7, 2018, 10:40 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved formatting in the scheduler API description, and updated comments to 
> explicitly mention the default value for the `refuse_offers` field.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp 7e029f1bc614df7dbc7814c1af359f74dd2ed783 
>   src/master/master.cpp 868787bb2f9d879531402f83507b322462322efc 
> 
> 
> Diff: https://reviews.apache.org/r/69272/diff/1/
> 
> 
> Testing
> ---
> 
> None, since no code was changed.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69273/#review210383
---




src/tests/slave_recovery_tests.cpp
Line 4739 (original), 4742 (patched)


Now that the clock is paused, we should deterministically not get extra 
offers.  You can probably remove these blocks from the test.

Here and throughout the test.



src/tests/slave_recovery_tests.cpp
Line 4827 (original), 4841-4845 (patched)


There is always a non-zero delay between the agent's startup and 
subscribing to the master:
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1306-L1321

There isn't a great way to wait for the agent to detect the master, and 
then advance the clock.  Instead, try setting 
`slaveFlags.registration_backoff_factor = Seconds(0);`.  I think that should 
bypass this small subscription delay.


- Joseph Wu


On Nov. 7, 2018, 10:40 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69273/
> ---
> 
> (Updated Nov. 7, 2018, 10:40 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9358
> https://issues.apache.org/jira/browse/MESOS-9358
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed some flakyness from the test
> SlaveRecoveryTest.AgentReconfigurationWithRunningTask
> by removing the `refuse_offers` filter and by pausing
> the clock whenever possible during the test.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 
> 
> 
> Diff: https://reviews.apache.org/r/69273/diff/1/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*ReconfigurationWithRunning*" 
> --gtest_repeat=200`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 69280: Fixed flakiness in `PartitionTest.TaskCompletedOnPartitionedAgent`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69280/
---

Review request for mesos and Benjamin Bannier.


Bugs: MESOS-6990
https://issues.apache.org/jira/browse/MESOS-6990


Repository: mesos


Description
---

The test wasn't ensuring that the TASK_FINISHED update gets
processed by the agent before it re-registers with the master, so
sometimes the master will forward the old TASK_RUNNING state.


Diffs
-

  src/tests/partition_tests.cpp 788d3b988cf7de206f295bffdc0376e7e1242349 


Diff: https://reviews.apache.org/r/69280/diff/1/


Testing
---

Ran in repetition.


Thanks,

Benjamin Mahler

Re: Review Request 69275: Added environment sanity check to parallel test runner.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69275/#review210384
---


Ship it!




Ship It!

- Armand Grillet


On Nov. 7, 2018, 10:41 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69275/
> ---
> 
> (Updated Nov. 7, 2018, 10:41 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a check to the parallel test runner that catches
> setups where the user is not allowed to launch many process (e.g., the
> default value for `ulimit -u` on centos7).
> 
> This can lead to test execution failures if many `mesos-tests`
> instances are run in parallel on machines with many cores (by default
> the parallel test runner would execute `nproc` shards which would fork
> potentially multiple executable launching `nproc` libprocess worker
> threads).
> 
> 
> Diffs
> -
> 
>   support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 
> 
> 
> Diff: https://reviews.apache.org/r/69275/diff/2/
> 
> 
> Testing
> ---
> 
> Executed `mesos-tests` in parallel with default settings.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69275: Added environment sanity check to parallel test runner.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69275/
---

(Updated Nov. 7, 2018, 10:41 p.m.)


Review request for mesos, Armand Grillet and Benjamin Mahler.


Repository: mesos


Description
---

This patch adds a check to the parallel test runner that catches
setups where the user is not allowed to launch many process (e.g., the
default value for `ulimit -u` on centos7).

This can lead to test execution failures if many `mesos-tests`
instances are run in parallel on machines with many cores (by default
the parallel test runner would execute `nproc` shards which would fork
potentially multiple executable launching `nproc` libprocess worker
threads).


Diffs (updated)
-

  support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 


Diff: https://reviews.apache.org/r/69275/diff/2/

Changes: https://reviews.apache.org/r/69275/diff/1-2/


Testing
---

Executed `mesos-tests` in parallel with default settings.


Thanks,

Benjamin Bannier

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

(Updated Nov. 7, 2018, 9:23 p.m.)


Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and 
Zhitao Li.


Changes
---

Rebased to master


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added an overloaded version of `os::realpath` to stout.

The new `os::realpath` function is used for evaluating real path
within a scoped root directory.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/8/

Changes: https://reviews.apache.org/r/65812/diff/7-8/


Testing
---


Thanks,

Jason Lai

Re: Review Request 69279: Updated Build bot to write out test report xml files.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69279/#review210381
---


Ship it!




Ship It!

- James Peach


On Nov. 7, 2018, 9:28 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69279/
> ---
> 
> (Updated Nov. 7, 2018, 9:28 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This can be used by Jenkins to display test trends.
> 
> 
> Diffs
> -
> 
>   support/mesos-build.sh d146cc104ea330bfdcbfed497267e6a1465db0bc 
>   support/mesos-build/entrypoint.sh ec98cc8b1fdcd0a32ed32cfeb69dfb976f82b81d 
> 
> 
> Diff: https://reviews.apache.org/r/69279/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually with a custom jenkins job.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 69277: Updated autotools build to use parallel test runner by default.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69277/#review210380
---


Ship it!




Ship It!

- Benjamin Bannier


On Nov. 7, 2018, 10:19 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69277/
> ---
> 
> (Updated Nov. 7, 2018, 10:19 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The parallel test runner completes much faster than running the
> tests serially, so we would like to get this benefit to all
> developers by default.
> 
> At some point, we'll also have to update the cmake build.
> 
> 
> Diffs
> -
> 
>   configure.ac 1caab4d0630821a937d92f3c788a01ae3b5dc228 
> 
> 
> Diff: https://reviews.apache.org/r/69277/diff/1/
> 
> 
> Testing
> ---
> 
> Configured and ensured the parallel test runner was the
> default when using make check.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 69278: Added hierchical allocator benchmarks to the cmake build.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69278/#review210379
---


Ship it!




Ship It!

- Joseph Wu


On Nov. 7, 2018, 1:17 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69278/
> ---
> 
> (Updated Nov. 7, 2018, 1:17 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added hierchical allocator benchmarks to the cmake build.
> 
> 
> Diffs
> -
> 
>   src/tests/CMakeLists.txt 00dbdee1c06e7571fa799850cdaf7f2ccadc8bea 
> 
> 
> Diff: https://reviews.apache.org/r/69278/diff/1/
> 
> 
> Testing
> ---
> 
> * `ninja check`.
> * executed `mesos-tidy` with default against source file; no violations 
> reported.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 69279: Updated Build bot to write out test report xml files.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69279/
---

Review request for mesos and James Peach.


Repository: mesos


Description
---

This can be used by Jenkins to display test trends.


Diffs
-

  support/mesos-build.sh d146cc104ea330bfdcbfed497267e6a1465db0bc 
  support/mesos-build/entrypoint.sh ec98cc8b1fdcd0a32ed32cfeb69dfb976f82b81d 


Diff: https://reviews.apache.org/r/69279/diff/1/


Testing
---

Tested manually with a custom jenkins job.


Thanks,

Vinod Kone

Re: Review Request 69276: Fixed flakiness in `FsTest.Used`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69276/#review210378
---


Ship it!




Ship It!

- Joseph Wu


On Nov. 7, 2018, 1:16 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69276/
> ---
> 
> (Updated Nov. 7, 2018, 1:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9316
> https://issues.apache.org/jira/browse/MESOS-9316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unfortunately, we cannot easily verify that the value coming from
> `fs::used()` is correct, as the filesystem may be modified at any
> point in time.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> 29f06f3dd126007d6b3a81f31795270f0654b847 
> 
> 
> Diff: https://reviews.apache.org/r/69276/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 68832: Add unit tests for Stout `path::normalize` function in POSIX.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/
---

(Updated Nov. 7, 2018, 9:26 p.m.)


Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, 
James Peach, and Zhitao Li.


Changes
---

Rebased to master


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Add unit tests for Stout `path::normalize` function in POSIX.


Diffs (updated)
-

  3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41 


Diff: https://reviews.apache.org/r/68832/diff/2/

Changes: https://reviews.apache.org/r/68832/diff/1-2/


Testing (updated)
---

`make check`


Thanks,

Jason Lai

Re: Review Request 67175: Added support for marking slave mounts.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67175/
---

(Updated Nov. 7, 2018, 9:24 p.m.)


Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and 
Zhitao Li.


Changes
---

Rebased to master


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added utility function for marking slave mounts in the mount table.


Diffs (updated)
-

  src/linux/fs.hpp 31969f6ba82bf5ee549bfdf9698a21adaa486a90 
  src/linux/fs.cpp 5cdffe1f4c7f00aee5b8f640e7cfa4a0018cfa0a 


Diff: https://reviews.apache.org/r/67175/diff/3/

Changes: https://reviews.apache.org/r/67175/diff/2-3/


Testing
---


Thanks,

Jason Lai

Re: Review Request 69276: Fixed flakiness in `FsTest.Used`.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69276/#review210377
---


Ship it!




Ship It!

- James Peach


On Nov. 7, 2018, 9:16 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69276/
> ---
> 
> (Updated Nov. 7, 2018, 9:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James Peach.
> 
> 
> Bugs: MESOS-9316
> https://issues.apache.org/jira/browse/MESOS-9316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unfortunately, we cannot easily verify that the value coming from
> `fs::used()` is correct, as the filesystem may be modified at any
> point in time.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> 29f06f3dd126007d6b3a81f31795270f0654b847 
> 
> 
> Diff: https://reviews.apache.org/r/69276/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 69276: Fixed flakiness in `FsTest.Used`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69276/
---

Review request for mesos, Benjamin Bannier and James Peach.


Bugs: MESOS-9316
https://issues.apache.org/jira/browse/MESOS-9316


Repository: mesos


Description
---

Unfortunately, we cannot easily verify that the value coming from
`fs::used()` is correct, as the filesystem may be modified at any
point in time.


Diffs
-

  3rdparty/stout/tests/os/filesystem_tests.cpp 
29f06f3dd126007d6b3a81f31795270f0654b847 


Diff: https://reviews.apache.org/r/69276/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Review Request 69278: Added hierchical allocator benchmarks to the cmake build.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69278/
---

Review request for mesos and Meng Zhu.


Repository: mesos


Description
---

Added hierchical allocator benchmarks to the cmake build.


Diffs
-

  src/tests/CMakeLists.txt 00dbdee1c06e7571fa799850cdaf7f2ccadc8bea 


Diff: https://reviews.apache.org/r/69278/diff/1/


Testing
---

* `ninja check`.
* executed `mesos-tidy` with default against source file; no violations 
reported.


Thanks,

Benjamin Bannier

Review Request 69277: Updated autotools build to use parallel test runner by default.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69277/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

The parallel test runner completes much faster than running the
tests serially, so we would like to get this benefit to all
developers by default.

At some point, we'll also have to update the cmake build.


Diffs
-

  configure.ac 1caab4d0630821a937d92f3c788a01ae3b5dc228 


Diff: https://reviews.apache.org/r/69277/diff/1/


Testing
---

Configured and ensured the parallel test runner was the
default when using make check.


Thanks,

Benjamin Mahler

Re: Review Request 65811: Added Stout `path::normalize` function for POSIX paths.

[Jason Lai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/
---

(Updated Nov. 7, 2018, 9:22 p.m.)


Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Changes
---

Rebased to master


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added `path::normalize` to normalize a given pathname and remove
redundant separators and up-level references.

This function follows the rules described in `path_resolution(7)`
for Linux. However, it only performs pure lexical processing without
touching the actual filesystem.


Diffs (updated)
-

  3rdparty/stout/include/stout/path.hpp 
ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7 


Diff: https://reviews.apache.org/r/65811/diff/9/

Changes: https://reviews.apache.org/r/65811/diff/8-9/


Testing
---

`make tests and make check` with https://reviews.apache.org/r/68832/


Thanks,

Jason Lai

Re: Review Request 69274: Reduced default oversubscription in parallel test runner.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69274/#review210376
---


Ship it!




Ship It!

- Armand Grillet


On Nov. 7, 2018, 9:30 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69274/
> ---
> 
> (Updated Nov. 7, 2018, 9:30 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reduced default oversubscription in parallel test runner.
> 
> 
> Diffs
> -
> 
>   support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 
> 
> 
> Diff: https://reviews.apache.org/r/69274/diff/1/
> 
> 
> Testing
> ---
> 
> Executed `mesos-tests` in parallel with default settings.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69275: Added environment sanity check to parallel test runner.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69275/#review210375
---


Fix it, then Ship it!





support/mesos-gtest-runner.py
Lines 212 (patched)


Double space here.


- Armand Grillet


On Nov. 7, 2018, 9:30 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69275/
> ---
> 
> (Updated Nov. 7, 2018, 9:30 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a check to the parallel test runner that catches
> setups where the user is not allowed to launch many process (e.g., the
> default value for `ulimit -u` on centos7).
> 
> This can lead to test execution failures if many `mesos-tests`
> instances are run in parallel on machines with many cores (by default
> the parallel test runner would execute `nproc` shards which would fork
> potentially multiple executable launching `nproc` libprocess worker
> threads).
> 
> 
> Diffs
> -
> 
>   support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 
> 
> 
> Diff: https://reviews.apache.org/r/69275/diff/1/
> 
> 
> Testing
> ---
> 
> Executed `mesos-tests` in parallel with default settings.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67022/#review210372
---



Bad review!

Reviews applied: [67022]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On Sept. 13, 2018, 5:17 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67022/
> ---
> 
> (Updated Sept. 13, 2018, 5:17 p.m.)
> 
> 
> Review request for mesos, Eric Chung and Jason Lai.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp fd53d90776967ae97575140778129d6fddd726d2 
>   src/slave/slave.cpp e6c7e686f287fb4448a0074d4e99298665fc866d 
> 
> 
> Diff: https://reviews.apache.org/r/67022/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 69275: Added environment sanity check to parallel test runner.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69275/#review210374
---


Ship it!




Ship It!

- Benjamin Mahler


On Nov. 7, 2018, 8:30 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69275/
> ---
> 
> (Updated Nov. 7, 2018, 8:30 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a check to the parallel test runner that catches
> setups where the user is not allowed to launch many process (e.g., the
> default value for `ulimit -u` on centos7).
> 
> This can lead to test execution failures if many `mesos-tests`
> instances are run in parallel on machines with many cores (by default
> the parallel test runner would execute `nproc` shards which would fork
> potentially multiple executable launching `nproc` libprocess worker
> threads).
> 
> 
> Diffs
> -
> 
>   support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 
> 
> 
> Diff: https://reviews.apache.org/r/69275/diff/1/
> 
> 
> Testing
> ---
> 
> Executed `mesos-tests` in parallel with default settings.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69274: Reduced default oversubscription in parallel test runner.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69274/#review210373
---


Ship it!




Ship It!

- Benjamin Mahler


On Nov. 7, 2018, 8:30 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69274/
> ---
> 
> (Updated Nov. 7, 2018, 8:30 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reduced default oversubscription in parallel test runner.
> 
> 
> Diffs
> -
> 
>   support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 
> 
> 
> Diff: https://reviews.apache.org/r/69274/diff/1/
> 
> 
> Testing
> ---
> 
> Executed `mesos-tests` in parallel with default settings.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69273/#review210371
---



PASS: Mesos patch 69273 was successfully built and tested.

Reviews applied: `['69272', '69273']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2575/mesos-review-69273

- Mesos Reviewbot Windows


On Nov. 7, 2018, 6:40 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69273/
> ---
> 
> (Updated Nov. 7, 2018, 6:40 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9358
> https://issues.apache.org/jira/browse/MESOS-9358
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed some flakyness from the test
> SlaveRecoveryTest.AgentReconfigurationWithRunningTask
> by removing the `refuse_offers` filter and by pausing
> the clock whenever possible during the test.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 
> 
> 
> Diff: https://reviews.apache.org/r/69273/diff/1/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*ReconfigurationWithRunning*" 
> --gtest_repeat=200`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 69274: Reduced default oversubscription in parallel test runner.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69274/
---

Review request for mesos, Armand Grillet and Benjamin Mahler.


Repository: mesos


Description
---

Reduced default oversubscription in parallel test runner.


Diffs
-

  support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 


Diff: https://reviews.apache.org/r/69274/diff/1/


Testing
---

Executed `mesos-tests` in parallel with default settings.


Thanks,

Benjamin Bannier

Review Request 69275: Added environment sanity check to parallel test runner.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69275/
---

Review request for mesos, Armand Grillet and Benjamin Mahler.


Repository: mesos


Description
---

This patch adds a check to the parallel test runner that catches
setups where the user is not allowed to launch many process (e.g., the
default value for `ulimit -u` on centos7).

This can lead to test execution failures if many `mesos-tests`
instances are run in parallel on machines with many cores (by default
the parallel test runner would execute `nproc` shards which would fork
potentially multiple executable launching `nproc` libprocess worker
threads).


Diffs
-

  support/mesos-gtest-runner.py 9cf72af246a2fabf2cb57ed42136eeaaa1495f20 


Diff: https://reviews.apache.org/r/69275/diff/1/


Testing
---

Executed `mesos-tests` in parallel with default settings.


Thanks,

Benjamin Bannier

Review Request 69273: Fixed flaky agent reconfiguration test.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69273/
---

Review request for mesos, Greg Mann and Joseph Wu.


Bugs: MESOS-9358
https://issues.apache.org/jira/browse/MESOS-9358


Repository: mesos


Description
---

Removed some flakyness from the test
SlaveRecoveryTest.AgentReconfigurationWithRunningTask
by removing the `refuse_offers` filter and by pausing
the clock whenever possible during the test.


Diffs
-

  src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c 


Diff: https://reviews.apache.org/r/69273/diff/1/


Testing
---

`./src/mesos-tests --gtest_filter="*ReconfigurationWithRunning*" 
--gtest_repeat=200`


Thanks,

Benno Evers

Review Request 69272: Clarified some comments about the usage of offer filters.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69272/
---

Review request for mesos, Greg Mann and Joseph Wu.


Repository: mesos


Description
---

Improved formatting in the scheduler API description, and updated comments to 
explicitly mention the default value for the `refuse_offers` field.


Diffs
-

  include/mesos/scheduler.hpp 7e029f1bc614df7dbc7814c1af359f74dd2ed783 
  src/master/master.cpp 868787bb2f9d879531402f83507b322462322efc 


Diff: https://reviews.apache.org/r/69272/diff/1/


Testing
---

None, since no code was changed.


Thanks,

Benno Evers

Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67022/#review210367
---


Fix it, then Ship it!





src/slave/slave.cpp
Lines 1592 (patched)


I just noticed, there seems to be no reason to restrict it to the 
`any`-case, we probably also want to checkpoint the new state if it changed 
under the `additive` policy. So the condition could just be

```
if (requiredMasterCapabilities.agentUpdate) {
  [...]
```


- Benno Evers


On Sept. 13, 2018, 5:17 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67022/
> ---
> 
> (Updated Sept. 13, 2018, 5:17 p.m.)
> 
> 
> Review request for mesos, Eric Chung and Jason Lai.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp fd53d90776967ae97575140778129d6fddd726d2 
>   src/slave/slave.cpp e6c7e686f287fb4448a0074d4e99298665fc866d 
> 
> 
> Diff: https://reviews.apache.org/r/67022/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>