Re: Review Request 69397: Used high-level `FrameworkInfo` validation function in tests.

2018-12-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69397/#review211211 --- Ship it! Ship It! - Benjamin Mahler On Dec. 11, 2018, 1:48 p

Re: Review Request 69398: Added validation for framework IDs.

2018-12-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69398/#review211210 --- Fix it, then Ship it! Great description, thank you! I think we

Re: Review Request 69505: Added an operation status update manager to the agent.

2018-12-11 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69505/#review211209 --- Ship it! Ship It! - Gastón Kleiman On Dec. 10, 2018, 3:34 p.

Re: Review Request 69543: Implemented recovery for volume gid manager.

2018-12-11 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69543/#review211200 --- src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manag

Re: Review Request 69551: Renamed `Metrics()` function in test utils.

2018-12-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69551/#review211195 --- PASS: Mesos patch 69551 was successfully built and tested. Review

Re: Review Request 69398: Added validation for framework IDs.

2018-12-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69398/#review211196 --- PASS: Mesos patch 69398 was successfully built and tested. Review

Re: Review Request 69542: Made non-root containers can access SANDBOX_PATH volume of PARENT type.

2018-12-11 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69542/#review211193 --- src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp L

Re: Review Request 69541: Added volume gid manager.

2018-12-11 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/#review211192 --- src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manag

Re: Review Request 69479: Added the flag `--task_supplementary_groups` to command executor.

2018-12-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69479/ --- (Updated Dec. 11, 2018, 11:06 p.m.) Review request for mesos, Andrei Budnik, Gi

Review Request 69553: Changed the definition of `uid_t` and `gid_t` to UNIT for Windows.

2018-12-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69553/ --- Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, a

Re: Review Request 69397: Used high-level `FrameworkInfo` validation function in tests.

2018-12-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69397/ --- (Updated Dec. 11, 2018, 2:48 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69541: Added volume gid manager.

2018-12-11 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/#review211189 --- src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manag

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

2018-12-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review211190 --- PASS: Mesos patch 69547 was successfully built and tested. Review

Re: Review Request 69398: Added validation for framework IDs.

2018-12-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69398/ --- (Updated Dec. 11, 2018, 2:48 p.m.) Review request for mesos, Benjamin Mahler an

Review Request 69551: Renamed `Metrics()` function in test utils.

2018-12-11 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69551/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

2018-12-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66815/#review211188 --- Fix it, then Ship it! src/launcher/default_executor.cpp Line 9

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

2018-12-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/ --- (Updated Dec. 11, 2018, 8:17 p.m.) Review request for mesos. Changes ---

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-12-11 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/#review211187 --- Ship it! Ship It! - Benno Evers On Dec. 11, 2018, 1:20 a.m.,