Review Request 69895: Made SLRP `PublishResources` test to check persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69895/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9544 https://iss

Review Request 69893: Clean up persistent volumes on SLRP disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69893/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs: M

Review Request 69892: Made SLRP recover node-published volumes after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69892/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs: M

Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69894/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs: M

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/ --- (Updated Feb. 5, 2019, 7:38 a.m.) Review request for mesos, Benjamin Bannier, G

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212541 --- PASS: Mesos patch 69890 was successfully built and tested. Review

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

> On Feb. 5, 2019, 12:31 a.m., Klaus Ma wrote: > > Ship It! LGTM overall, but I don-t have enough experience right now to review the detail, please wait for BenM's comments :) - Klaus --- This is an automatically generated e-mail. To r

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212539 --- Ship it! Ship It! - Klaus Ma On Feb. 4, 2019, 8:29 p.m., Ben

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69876/#review212538 --- Fix it, then Ship it! src/tests/master_tests.cpp Lines 9419 (p

Re: Review Request 69880: Added header comments for two master methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69880/#review212537 --- PASS: Mesos patch 69880 was successfully built and tested. Review

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212536 --- PASS: Mesos patch 69821 was successfully built and tested. Review

Re: Review Request 69880: Added header comments for two master methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69880/#review212532 --- Fix it, then Ship it! src/master/master.hpp Lines 665 (patched

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Feb. 4, 2019, 9:58 p.m., Benjamin Mahler wrote: > > Can you split this change apart so that I can review more easily and we can > > land it faster? > > > > (1) The plumbing and storage of the information: this is an easy change > > that doesn't require much thought, it looks good and can

Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9523 ht

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212530 --- PASS: Mesos patch 69885 was successfully built and tested. Review

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 4, 2019, 11:05 p.m.) Review request for mesos, Benjamin Mahler an

Review Request 69889: Stored static framework offer filters in allocator framework class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69889/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9523 ht

Re: Review Request 69871: Added more documentation for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69871/#review212528 --- Fix it, then Ship it! LGTM! docs/scheduler-http-api.md Lines

Re: Review Request 69880: Added header comments for two master methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69880/ --- (Updated Feb. 4, 2019, 9:41 p.m.) Review request for mesos, Gastón Kleiman, Jos

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212525 --- Ship it! src/tests/resources_tests.cpp Lines 3892 (patched)

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212523 --- Can you split this change apart so that I can review more easily a

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 4, 2019, 9:37 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 69818: Added offer filters to static framework configuration.

> On Feb. 4, 2019, 9:31 p.m., Benjamin Mahler wrote: > > src/master/framework.cpp > > Lines 504 (patched) > > > > > > The comment you mentioned seems to be missing? Accidentially squashed it into https://reviews.apa

Re: Review Request 69818: Added offer filters to static framework configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/ --- (Updated Feb. 4, 2019, 9:37 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 69818: Added offer filters to static framework configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/#review212522 --- Fix it, then Ship it! src/master/framework.cpp Lines 504 (patc

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

> On Feb. 4, 2019, 7:22 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp > > Lines 3883-3887 (original), 3883-3891 (patched) > > > > > > I love the spirit of this change, but this seems pretty bizzare?

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/ --- (Updated Feb. 4, 2019, 9:29 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212519 --- src/tests/resources_tests.cpp Lines 3883-3887 (original), 3883-38

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212518 --- PASS: Mesos patch 69885 was successfully built and tested. Review

Review Request 69885: Sped up some resource benchmark test instantiations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/ --- Review request for mesos, Benjamin Mahler and Klaus Ma. Bugs: MESOS-8835 ht

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212516 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 4, 2019, 12:14 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69818: Added offer filters to static framework configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/ --- (Updated Feb. 4, 2019, 12:14 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 69818: Added offer filters to static framework configuration.

> On Jan. 31, 2019, 10 p.m., Benjamin Mahler wrote: > > src/master/framework.cpp > > Lines 504 (patched) > > > > > > Can you guard this with a has check? > > > > As it stands it will produce a different mess

Re: Review Request 69818: Added offer filters to static framework configuration.

> On Jan. 29, 2019, 9:14 p.m., Benjamin Mahler wrote: > > I think you missed my top level comment from the last review to add context > > to the commit about the min allocatable flag and how this is providing a > > per-framework/role override of that global flag? > > > > Also, we're missing a

Re: Review Request 69818: Added offer filters to static framework configuration.

> On Jan. 29, 2019, 4:09 a.m., Benjamin Mahler wrote: > > include/mesos/mesos.proto > > Lines 1519 (patched) > > > > > > I'm not sure if this gives much information to the reader, thoughts on > > the following? > >

Re: Review Request 69862: Validated static framework offer filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69862/ --- (Updated Feb. 4, 2019, 12:14 p.m.) Review request for mesos, Benjamin Mahler an