Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69922/#review212663 --- PASS: Mesos patch 69922 was successfully built and tested.

Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69922/ --- (Updated Feb. 8, 2019, 5:50 a.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69922/#review212658 --- PASS: Mesos patch 69922 was successfully built and tested.

Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69922/ --- (Updated Feb. 8, 2019, 1:44 a.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69922/ --- (Updated Feb. 8, 2019, 1:29 a.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69922/#review212657 --- PASS: Mesos patch 69922 was successfully built and tested.

Re: Review Request 69910: Added tests for feedback for operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69910/#review212650 --- Ship it! Ship It! - Greg Mann On Feb. 7, 2019, 9:53 p.m.,

Re: Review Request 69910: Added tests for feedback for operations on agent default resources.

> On Feb. 7, 2019, 4:32 p.m., Greg Mann wrote: > > src/tests/agent_operation_feedback_tests.cpp > > Lines 179 (patched) > > > > > > We should probably advance the clock by a multiple of this, like Benno > > was

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69911/#review212654 --- Fix it, then Ship it!

Re: Review Request 69913: Added more operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69913/ --- (Updated Feb. 8, 2019, 12:33 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 69920: Removed `MasterAPITest.OperationFeedbackOnAgentDefaultResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69920/#review212652 --- Ship it! Ship It! - Greg Mann On Feb. 7, 2019, 9:53 p.m.,

Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69922/#review212653 --- Fix it, then Ship it!

Re: Review Request 69910: Added tests for feedback for operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69910/#review212651 --- src/tests/agent_operation_feedback_tests.cpp Lines 179 (patched)

Re: Review Request 69919: Added missing periods at the end of comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69919/#review212649 --- Ship it! Ship It! - Greg Mann On Feb. 7, 2019, 9:54 p.m.,

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69911/#review212647 --- PASS: Mesos patch 69911 was successfully built and tested.

Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69922/ --- Review request for mesos, Gastón Kleiman and Joseph Wu. Bugs: MESOS-9538

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

> On Feb. 5, 2019, 12:28 a.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9419 (patched) > > > > > > We should consider making the agent not recover the operation status > > update manager if

Review Request 69920: Removed `MasterAPITest.OperationFeedbackOnAgentDefaultResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69920/ --- Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu. Bugs:

Review Request 69919: Added missing periods at the end of comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69919/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9473

Re: Review Request 69910: Added tests for feedback for operations on agent default resources.

> On Feb. 7, 2019, 9:24 a.m., Greg Mann wrote: > > I just realized this test is doing the same thing as > > `MasterAPITest.OperationFeedbackOnAgentDefaultResources`, maybe we should > > just move that one to your new file? Or remove that one and retain this one? Removing that test in

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

> On Feb. 7, 2019, 10:09 a.m., Greg Mann wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 945 (patched) > > > > > > Use `GetParam()` here? Already done in https://reviews.apache.org/r/69913/. I

Re: Review Request 69913: Added more operation reconciliation tests.

> On Feb. 7, 2019, 10:32 a.m., Greg Mann wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 943-945 (original), 943-947 (patched) > > > > > > Ah, looks like this part of the diff belongs in a previous

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69911/ --- (Updated Feb. 7, 2019, 1:55 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 69912: Added agent/RP IDs to some operation updates generated by the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69912/ --- (Updated Feb. 7, 2019, 1:54 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 69910: Added tests for feedback for operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69910/ --- (Updated Feb. 7, 2019, 1:53 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 69913: Added more operation reconciliation tests.

> On Feb. 7, 2019, 10:32 a.m., Greg Mann wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 1244 (patched) > > > > > > I think the detector isn't necessary in this test? `StartSlave()` needs the

Re: Review Request 69912: Added agent/RP IDs to some operation updates generated by the master.

> On Feb. 7, 2019, 10:15 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 9089 (patched) > > > > > > s/Some(resourceProviderId.get())/resourceProviderId/ Note that `resourceProviderId` is a `Result` and

Re: Review Request 69913: Added more operation reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69913/#review212635 --- Fix it, then Ship it! Nit: the commit message says that

Re: Review Request 69912: Added agent/RP IDs to some operation updates generated by the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69912/#review212634 --- Fix it, then Ship it! src/master/master.cpp Lines 9089

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69911/#review212632 --- Fix it, then Ship it!

Re: Review Request 69910: Added tests for feedback for operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69910/#review212631 --- I just realized this test is doing the same thing as

Re: Review Request 69891: Sent operation updates to schedulers when agents are removed.

> On Feb. 5, 2019, 4:57 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 10950 (patched) > > > > > > I don't know if sending UNREACHABLE for all the 3 cases when > > `_removeSlave` is called is the