Re: Review Request 71333: Avoided copying the clientPath in the sorter.

2019-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71333/#review217344 --- Patch looks great! Reviews applied: [71333] Passed command:

Review Request 71333: Avoided copying the clientPath in the sorter.

2019-08-20 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71333/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217341 --- Bad review! Reviews applied: [71303, 71301, 71269, 71258, 71257,

Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

2019-08-20 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71301/ --- (Updated Aug. 20, 2019, 4:10 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71174: Recovered network info for nested/standalone containers in CNI isolator.

2019-08-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71174/#review217339 --- Fix it, then Ship it!

Re: Review Request 71318: Added agent reactivations to the existing agent draining tests.

2019-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71318/#review217336 --- Patch looks great! Reviews applied: [71314, 71315, 71316, 71317,

Re: Review Request 71318: Added agent reactivations to the existing agent draining tests.

2019-08-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71318/ --- (Updated Aug. 20, 2019, 10:28 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

2019-08-20 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71301/#review217335 --- src/master/allocator/mesos/hierarchical.cpp Line 556 (original),

Re: Review Request 71297: Fixed a flaky operation reconciliation test.

2019-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71297/#review217334 --- Patch looks great! Reviews applied: [71297] Passed command:

Re: Review Request 71329: Updated CentOS 6 dockerfile to properly install devtoolset-7.

2019-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71329/#review217333 --- Ship it! Ship It! - Benjamin Bannier On Aug. 20, 2019, 2:52

Review Request 71329: Updated CentOS 6 dockerfile to properly install devtoolset-7.

2019-08-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71329/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 71300: Removed mesos-style transition script.

2019-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71300/#review217330 --- Bad review! Reviews applied: [71300, 71209, 71208, 71207, 71206,

Re: Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

2019-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71207/ --- (Updated Aug. 20, 2019, 1:49 p.m.) Review request for mesos and Till

Re: Review Request 71206: Removed old mesos-style and references.

2019-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71206/ --- (Updated Aug. 20, 2019, 1:49 p.m.) Review request for mesos and Till

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/ --- (Updated Aug. 20, 2019, 1:48 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/ --- (Updated Aug. 20, 2019, 1:48 p.m.) Review request for mesos and Till

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-20 Thread Benjamin Bannier
> On Aug. 19, 2019, 12:56 p.m., Benno Evers wrote: > > docs/advanced-contribution.md > > Line 69 (original), 69 (patched) > > > > > > This became a bit ambiguous now, i.e. is only the second step or the > > whole

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217328 --- Bad review! Reviews applied: [71303, 71301, 71269, 71258, 71257,

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

2019-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/#review217327 --- Patch looks great! Reviews applied: [71284, 71285] Passed

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- (Updated Aug. 20, 2019, 11:26 a.m.) Review request for mesos and Chun-Hung

Re: Review Request 71150: Factored out storage provider method to update resources.

2019-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71150/ --- (Updated Aug. 20, 2019, 11:25 a.m.) Review request for mesos and Chun-Hung

Re: Review Request 71318: Added agent reactivations to the existing agent draining tests.

2019-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71318/#review217325 --- Bad patch! Reviews applied: [71314, 71315, 71316, 71317, 71318]