Re: Review Request 71520: Fixed inefficient `hashmap` access patterns.

2019-09-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71520/#review217890 --- Bad patch! Reviews applied: [71519, 71520] Failed command:

Re: Review Request 71522: Added missing member initialization in `JSON::WriterProxy`.

2019-09-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71522/#review217888 --- Fix it, then Ship it!

Re: Review Request 71519: Fixed inefficient `hashmap` access patterns.

2019-09-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71519/#review217886 --- Ship it! The review looks good, but this sentence from the

Re: Review Request 71523: Bumped mesos-tidy onto upstream release_90.

2019-09-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71523/#review217885 --- Ship it! Ship It! - Benno Evers On Sept. 20, 2019, 7:53

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-20 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217884 --- Ship it! Ship It! - Till Toenshoff On Sept. 19, 2019, 2:35

Re: Review Request 71523: Bumped mesos-tidy onto upstream release_90.

2019-09-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71523/#review217882 --- Patch looks great! Reviews applied: [71522, 71523] Passed

Re: Review Request 71520: Fixed inefficient `hashmap` access patterns.

2019-09-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71520/#review217879 --- Bad review! Reviews applied: [71520, 71519] Error: Circular

Review Request 71523: Bumped mesos-tidy onto upstream release_90.

2019-09-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71523/ --- Review request for mesos and Benno Evers. Repository: mesos Description

Review Request 71522: Added missing member initialization in `JSON::WriterProxy`.

2019-09-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71522/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Repository: mesos