[GitHub] [mesos] bmahler closed pull request #353: Hook manager mutex and global variable enhancement.

[GitBox]

bmahler closed pull request #353: Hook manager mutex and global variable 
enhancement.
URL: https://github.com/apache/mesos/pull/353
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 72269: Added resource limits to the web UI.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/#review220084
---



Patch looks great!

Reviews applied: [72269]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On March 25, 2020, 7:20 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72269/
> ---
> 
> (Updated March 25, 2020, 7:20 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-10055
> https://issues.apache.org/jira/browse/MESOS-10055
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added resource limits to the web UI.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent-executor.html 
> 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 
> 
> 
> Diff: https://reviews.apache.org/r/72269/diff/1/
> 
> 
> Testing
> ---
> 
> Viewed manually in a web browser.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.

[Andrei Sekretenko]

> On March 25, 2020, 7:20 p.m., Benjamin Mahler wrote:
> > docs/scheduler-http-api.md
> > Lines 529-530 (patched)
> > 
> >
> > Is this true?
> > 
> > 
> > https://github.com/apache/mesos/blob/1.9.0/src/master/allocator/mesos/hierarchical.cpp#L765-L766
> > 
> > ```
> >   suppressRoles(framework, suppressedRoles - oldSuppressedRoles);
> >   reviveRoles(framework, (oldSuppressedRoles - suppressedRoles) & 
> > newRoles);
> > ```
> > 
> > 1. suppress roles that transitioned into supressed
> > 2. revive roles that were transitioned out of supressed
> > 
> > So, more like "For roles that were transitioned out of suppressed, 
> > offer filters (set by `ACCEPT`/`DECLINE`) will be cleared.
> > 
> > Right?

Yes, you are right, existing roles that have filters but are not suppressed 
will not have the filters cleared. 
Will amend this line.


> On March 25, 2020, 7:20 p.m., Benjamin Mahler wrote:
> > docs/scheduler-http-api.md
> > Lines 534-535 (patched)
> > 
> >
> > Huh? Which fields are being referred to here?

Everything not named above: all the fileds except for `principal`, `user`, 
`checkpoint`, `roles`/`role` and, obviously, except of `id`.


There, actually, is a good question: how well tested is update of other fields 
and what we can document here?

I tried to dig into the current state a bit. 

First, there are basic tests that resubscription/UPDATE_FRAMEWORK can change 
all other fields in `FrameworkInfo` as reported by Master.

Then, I would say, there are three categories of fields:
1) `name`, `hostname`, `webui_url` and `labels`: these are not really used by 
Mesos, basic tests seem enough.

2) `failover_timeout` and `offer_filters`: don't see where we test the effects 
of updating them, but those effects look more or less trivial.

3) `capabilities` field: changing some of them has non-trivial effects. 
   For example, removing `REVOCABLE_RESOURCES` results in rescinging offered 
revocable resources; this particular scenario is tested. 
   At this point I'm not really sure that every non-trivial capability change 
is well-designed and covered by tests.

Do you have any suggestions how to better document all this stuff? 
Can we safely say that Mesos supports update of (1)? How about (2)?
What to state about `capabilities` other than `REVOCABLE_RESOURCES`?...


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72267/#review220079
---


On March 25, 2020, 2:08 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72267/
> ---
> 
> (Updated March 25, 2020, 2:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-9979
> https://issues.apache.org/jira/browse/MESOS-9979
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs for UPDATE_FRAMEWORK call.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
> 
> 
> Diff: https://reviews.apache.org/r/72267/diff/1/
> 
> 
> Testing
> ---
> 
> Checked rendering in Github: 
> https://github.com/asekretenko/mesos/blob/update_framework_doc/docs/scheduler-http-api.md
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72267/#review220079
---



Oh yeah forgot about this, thanks for adding it!


docs/scheduler-http-api.md
Lines 528 (patched)


I assume this is the same as when a role is suppressed via SUPPRESS call?



docs/scheduler-http-api.md
Lines 529-530 (patched)


Is this true?


https://github.com/apache/mesos/blob/1.9.0/src/master/allocator/mesos/hierarchical.cpp#L765-L766

```
  suppressRoles(framework, suppressedRoles - oldSuppressedRoles);
  reviveRoles(framework, (oldSuppressedRoles - suppressedRoles) & newRoles);
```

1. suppress roles that transitioned into supressed
2. revive roles that were transitioned out of supressed

So, more like "For roles that were transitioned out of suppressed, offer 
filters (set by `ACCEPT`/`DECLINE`) will be cleared.

Right?



docs/scheduler-http-api.md
Lines 534-535 (patched)


Huh? Which fields are being referred to here?



docs/scheduler-http-api.md
Lines 575-579 (patched)


Can you link to the ticket here?


- Benjamin Mahler


On March 25, 2020, 2:08 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72267/
> ---
> 
> (Updated March 25, 2020, 2:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-9979
> https://issues.apache.org/jira/browse/MESOS-9979
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs for UPDATE_FRAMEWORK call.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
> 
> 
> Diff: https://reviews.apache.org/r/72267/diff/1/
> 
> 
> Testing
> ---
> 
> Checked rendering in Github: 
> https://github.com/asekretenko/mesos/blob/update_framework_doc/docs/scheduler-http-api.md
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Review Request 72269: Added resource limits to the web UI.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/
---

Review request for mesos and Qian Zhang.


Bugs: MESOS-10055
https://issues.apache.org/jira/browse/MESOS-10055


Repository: mesos


Description
---

Added resource limits to the web UI.


Diffs
-

  src/webui/app/agents/agent-executor.html 
7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 


Diff: https://reviews.apache.org/r/72269/diff/1/


Testing
---

Viewed manually in a web browser.


Thanks,

Greg Mann

Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72267/#review220078
---



Patch looks great!

Reviews applied: [72267]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On March 25, 2020, 2:08 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72267/
> ---
> 
> (Updated March 25, 2020, 2:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-9979
> https://issues.apache.org/jira/browse/MESOS-9979
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs for UPDATE_FRAMEWORK call.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 
> 
> 
> Diff: https://reviews.apache.org/r/72267/diff/1/
> 
> 
> Testing
> ---
> 
> Checked rendering in Github: 
> https://github.com/asekretenko/mesos/blob/update_framework_doc/docs/scheduler-http-api.md
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Review Request 72267: Added docs for UPDATE_FRAMEWORK call.

[Andrei Sekretenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72267/
---

Review request for mesos, Benjamin Mahler and Greg Mann.


Bugs: MESOS-9979
https://issues.apache.org/jira/browse/MESOS-9979


Repository: mesos


Description
---

Added docs for UPDATE_FRAMEWORK call.


Diffs
-

  docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 


Diff: https://reviews.apache.org/r/72267/diff/1/


Testing
---

Checked rendering in Github: 
https://github.com/asekretenko/mesos/blob/update_framework_doc/docs/scheduler-http-api.md


Thanks,

Andrei Sekretenko

[GitHub] [mesos] asfgit closed pull request #354: Avoid error on mesos logs upon docker image fetch

[GitBox]

asfgit closed pull request #354: Avoid error on mesos logs upon docker image 
fetch
URL: https://github.com/apache/mesos/pull/354
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services