Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72267/#review220646 --- Patch looks great! Reviews applied: [72267] Passed command:

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated May 6, 2020, 12:24 a.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 72473: Fixed src/Makefile.am to include Web UI roles tree files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72473/#review220645 --- Patch looks great! Reviews applied: [72473] Passed command:

Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72267/#review220644 --- Fix it, then Ship it! docs/scheduler-http-api.md Lines

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220643 --- Patch looks great! Reviews applied: [72368, 72364] Passed

Re: Review Request 72473: Fixed src/Makefile.am to include Web UI roles tree files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72473/#review220642 --- Ship it! Ship It! - Benjamin Mahler On May 5, 2020, 6:04

Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72267/ --- (Updated May 5, 2020, 7:06 p.m.) Review request for mesos, Benjamin Mahler and

Review Request 72473: Fixed src/Makefile.am to include Web UI roles tree files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72473/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-10125

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/#review220641 --- Ship it! Ship It! - Andrei Sekretenko On May 5, 2020, 5:52

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220640 --- Ship it! Ship It! - Greg Mann On May 5, 2020, 2:05 p.m.,

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

> On May 5, 2020, 12:27 p.m., Andrei Sekretenko wrote: > > src/tests/slave_tests.cpp > > Lines 12227-12228 (patched) > > > > > > I 'm not sure if these assertions add any value: these properties of V1 > > API are

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated May 5, 2020, 5:51 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/ --- (Updated May 5, 2020, 5:52 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

> On May 5, 2020, 5:41 a.m., Greg Mann wrote: > > src/tests/master_draining_tests.cpp > > Lines 368-370 (patched) > > > > > > I don't usually need to resume the clock to get a task running update > > to go through,

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220637 --- Patch looks great! Reviews applied: [72368, 72364] Passed

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

> On May 5, 2020, 5:41 a.m., Greg Mann wrote: > > src/tests/master_draining_tests.cpp > > Lines 239 (patched) > > > > > > Nit: s/lead to crash/lead to a crash/ Rewrote the comment to reflect the fact that this also

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/ --- (Updated May 5, 2020, 2:05 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 72368: Fixed a bug in the agent's draining handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72368/#review220634 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220627 --- Patch looks great! Reviews applied: [72368, 72364] Passed

Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72399/ --- (Updated May 5, 2020, 4:11 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72305: Sent appropriate task status reason when task over memory request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72305/#review220626 --- The code changes in this patch has been reverted, so

Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.

> On May 5, 2020, 12:27 a.m., Greg Mann wrote: > > I would recommend updating the description so that instead of saying we > > "don't need to add" the new reason, say that "it is not possible for Mesos > > to provide" the reason, so we must remove it. Done. - Qian

Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72442/ --- (Updated May 5, 2020, 3:53 p.m.) Review request for mesos, Andrei Budnik and