Re: Review Request 72410: Updated existing documentation for resource limits.

2020-05-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72410/#review220669 --- Ship it! Ship It! - Qian Zhang On May 7, 2020, 8:35 a.m.,

Re: Review Request 72410: Updated existing documentation for resource limits.

2020-05-06 Thread Greg Mann
> On April 28, 2020, 9:59 a.m., Qian Zhang wrote: > > docs/task-state-reasons.md > > Lines 126-133 (patched) > > > > > > If we revert the changes about > > `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in > >

Re: Review Request 72475: Logged connection error message before shutting down the executor.

2020-05-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72475/#review220668 --- Ship it! Ship It! - Qian Zhang On May 7, 2020, 1:46 a.m.,

Re: Review Request 72410: Updated existing documentation for resource limits.

2020-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72410/ --- (Updated May 7, 2020, 12:35 a.m.) Review request for mesos, Andrei Budnik,

[GitHub] [mesos] cf-natali commented on pull request #362: Keep retrying to remove cgroup on EBUSY.

2020-05-06 Thread GitBox
cf-natali commented on pull request #362: URL: https://github.com/apache/mesos/pull/362#issuecomment-624914041 Note that this might help us alleviate https://issues.apache.org/jira/browse/MESOS-8038 If a process cannot be killed - e.g. stuck in uninterruptible D state - the cgroup

[GitHub] [mesos] vinodkone commented on pull request #362: Keep retrying to remove cgroup on EBUSY.

2020-05-06 Thread GitBox
vinodkone commented on pull request #362: URL: https://github.com/apache/mesos/pull/362#issuecomment-624911683 I'll let @abudnik and @qianzhangxa review this since they have the most context. This is an automated message

[GitHub] [mesos] cf-natali commented on pull request #362: Keep retrying to remove cgroup on EBUSY.

2020-05-06 Thread GitBox
cf-natali commented on pull request #362: URL: https://github.com/apache/mesos/pull/362#issuecomment-624897538 @vinodkone This is an automated message from the Apache Git Service. To respond to the message, please log

Re: Review Request 72478: Changed permissions for domain sockets to allow non-root executors.

2020-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72478/#review220663 --- Patch looks great! Reviews applied: [72475, 72478] Passed

Review Request 72478: Changed permissions for domain sockets to allow non-root executors.

2020-05-06 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72478/ --- Review request for mesos, Andrei Sekretenko, Benjamin Mahler, Greg Mann, and

Re: Review Request 72475: Logged connection error message before shutting down the executor.

2020-05-06 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72475/ --- (Updated Май 6, 2020, 5:46 п.п.) Review request for mesos, Andrei Sekretenko,

Re: Review Request 71300: Removed mesos-style transition script.

2020-05-06 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71300/#review220659 --- As 1.10 release is near, I have landed this into master (cannot

Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.

2020-05-06 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72267/ --- (Updated May 6, 2020, 3:10 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 72475: Added log message in executor's `disconnected` method before shutdown.

2020-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72475/#review220658 --- Patch looks great! Reviews applied: [72475] Passed command:

Review Request 72475: Added log message in executor's `disconnected` method before shutdown.

2020-05-06 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72475/ --- Review request for mesos, Andrei Sekretenko, Benjamin Mahler, Greg Mann, and