---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39852/#review110539
---
Ship it!
Ship It!
- Alex Naparu
On Nov. 16, 2015, 9:15 a.m
/grp.hpp (line
37)
<https://reviews.apache.org/r/39888/#comment170464>
Returning NULL without setting errno is probably not a good idea. We might
want to standardize on '0' for group/user IDs on Windows.
- Alex Naparu
On Nov. 16, 2015, 9:15 a.m., Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/#review110538
---
Ship it!
Ship It!
- Alex Naparu
On Nov. 16, 2015, 9:15 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/#review110542
---
Ship it!
Ship It!
- Alex Naparu
On Nov. 16, 2015, 9:14 a.m
/rmdir.hpp (line 62)
<https://reviews.apache.org/r/39584/#comment170217>
Nit: You're not reusing these, so might as well inline the calls.
- Alex Naparu
On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote:
>
> ---
> This is a
S for all FS-related ops. That will be true in the vast
majority of cases these days.
- Alex Naparu
On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
ng ::RemoveDirectory here, which will delete the directory when
the last handle is closed. Unless that's not the desired behavior...
- Alex Naparu
On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote:
>
> ---
> This is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/#review112620
---
Ship it!
Ship It!
- Alex Naparu
On Jan. 4, 2016, 6:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39805/#review112621
---
Ship it!
Ship It!
- Alex Naparu
On Jan. 4, 2016, 6:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39802/#review112619
---
Ship it!
Ship It!
- Alex Naparu
On Jan. 4, 2016, 11:20 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review112618
---
Ship it!
Ship It!
- Alex Naparu
On Jan. 4, 2016, 12:02 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/#review112622
---
Ship it!
Ship It!
- Alex Naparu
On Nov. 16, 2015, 9:14 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41604/#review112623
---
Ship it!
Ship It!
- Alex Naparu
On Dec. 23, 2015, 6:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review111725
---
Ship it!
Ship It!
- Alex Naparu
On Dec. 23, 2015, 2:15 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42035/#review114114
---
Ship it!
Ship It!
- Alex Naparu
On Jan. 7, 2016, 9:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43905/#review120957
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 25, 2016, 7:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43904/#review120958
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 25, 2016, 7:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/#review120964
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 25, 2016, 7:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43906/#review120968
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 25, 2016, 7:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43903/#review120956
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 25, 2016, 7:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43908/#review120966
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 25, 2016, 7:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43407/#review119925
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 12:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43409/#review119926
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 12:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43411/#review119929
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 12:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43415/#review119930
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 2:08 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43413/#review119931
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 12:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43414/#review119932
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 12:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43415/#review119933
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 2:08 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43416/#review119935
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 12:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43417/#review119936
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 12:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43691/#review119940
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 2:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43418/#review119938
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 1:01 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43692/#review119941
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 2:26 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43693/#review119942
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 2:27 a.m
tps://reviews.apache.org/r/43694/#comment181329>
Maybe remove it altogether?
- Alex Naparu
On Feb. 18, 2016, 2:28 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43694/#review119944
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 2:28 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43695/#review119945
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 2:28 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43700/#review119947
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 2:31 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43689/#review119946
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 2:29 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/#review119948
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 5:49 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43698/#review119949
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 4:34 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43699/#review119950
---
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 4:35 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/#review128564
---
Ship it!
Ship It!
- Alex Naparu
On April 10, 2016, 10:34
? What about mesos?
> > I'm guessing we'll want to have something like:
> > ```
> > Try winsock_initialize = winsock_initialize();
> > ...
> > ```
> >
> > and do this in `libprocess::initialize()`
> >
> > Thoughts?
>
> Alex Naparu wrote:
>
if you wrote it as "if
(!::GetEnvironmentVariable..."
- Alex Naparu
On April 11, 2016, 4:20 a.m., Daniel Pravat wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
--
On April 11, 2016, 8:28 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46008/
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45614/#review128556
---
Ship it!
Ship It!
- Alex Naparu
On April 2, 2016, 6:35 a.m
/close.hpp (line 29)
<https://reviews.apache.org/r/45614/#comment191990>
`return ErrnoError()` if this fails? Same for ::closesocket().
- Alex Naparu
On April 2, 2016, 6:35 a.m., Daniel Pravat wrote:
>
> ---
> This is a
hink these can be negative, consider using ULARGE_INTEGER instead.
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 429)
<https://reviews.apache.org/r/46013/#comment192008>
Do you need system_time and use
)
<https://reviews.apache.org/r/46008/#comment191974>
We must also call WSACleanup on successful WSAStartup, per MSDN.
- Alex Naparu
On April 11, 2016, 8:28 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46008/#review128543
---
Ship it!
Ship It!
- Alex Naparu
On April 11, 2016, 8:28 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44131/#review128553
---
Ship it!
Ship It!
- Alex Naparu
On April 11, 2016, 4:21 a.m
mplemented" error?
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 228)
<https://reviews.apache.org/r/44123/#comment192054>
We don't have a X_OK flag in Windows, so we might want to mask that out
before calling `::access`.
- Alex Naparu
On April 11, 2016, 4:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44760/#review124144
---
Ship it!
Ship It!
- Alex Naparu
On March 17, 2016, 6:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47489/#review133614
---
Ship it!
Ship It!
- Alex Naparu
On May 17, 2016, 7:55 p.m
> On April 12, 2016, 11:10 p.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 383
> > <https://reviews.apache.org/r/46013/diff/2/?file=1339790#file1339790line383>
> >
> > Can you document this flag a bit
(line 310)
<https://reviews.apache.org/r/46013/#comment192236>
`break` is not needed after `return`
- Alex Naparu
On April 13, 2016, 10:06 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail.
57 matches
Mail list logo