----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44123/#review128561 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 134) <https://reviews.apache.org/r/44123/#comment191995> You can probably inline this. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 212) <https://reviews.apache.org/r/44123/#comment191996> This would probably fit on one line if you wrote it as "if (!::GetEnvironmentVariable..." - Alex Naparu On April 11, 2016, 4:20 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44123/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 4:20 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Stout: [1/2] Implemented assorted `os::` functions on Windows. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > edaa76a5322d0bf60b7172405aa754b5aca95458 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > c48106e5905e3be0faeba7177ef534766089faff > > Diff: https://reviews.apache.org/r/44123/diff/ > > > Testing > ------- > > OSX: make check > > > Thanks, > > Daniel Pravat > >
