Re: Review Request 58394: Setup new directory for python http client lib in src/python.

2017-04-13 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review171950 --- Ship it! Ship It! - Jason Lai On April 12, 2017, 9:44 p.m

Re: Review Request 58279: Lazily unmount persistent volumes in DockerContainerizer.

2017-04-10 Thread Jason Lai
665 (original), 667 (patched) <https://reviews.apache.org/r/58279/#comment244413> Nit ditto https://reviews.apache.org/r/58278/diff/1?file=1686582#file1686582line829. Not in the scope of this diff though. - Jason Lai On April 7, 2017, 11:46 p.m., Jie Yu

Re: Review Request 58278: Lazily unmount persistent volumes in MesosContainerizer.

2017-04-10 Thread Jason Lai
would be really rare but not impossible. Would we consider addressing cases like this? - Jason Lai On April 7, 2017, 11:45 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 54987: Updated `docs/monitoring/md` for new slave event queue metrics.

2016-12-22 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/#review160001 --- Ship it! Ship It! - Jason Lai On Dec. 22, 2016, 5:13 p.m

Re: Review Request 54986: Added metric for slave message queue.

2016-12-22 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54986/#review159998 --- Ship it! LGTM - Jason Lai On Dec. 22, 2016, 5:12 p.m

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

2016-12-21 Thread Jason Lai
ether after @jieyu's comment. - Jason --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/#review159876 --- On Dec. 21, 2016, 8:06 p.m., Jason Lai wrote: > > -

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

2016-12-21 Thread Jason Lai
s_devices; > > repeated DeviceLimit write_iops_devices; > > } > > > > message Statistics { > > repeated CFQ::Statistics cfq; > > repeated CFQ::Statistics cfq_recursive; > > } > > > >

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

2016-12-21 Thread Jason Lai
<https://reviews.apache.org/r/54693/diff/1/?file=1582391#file1582391line2200> > > > > I'd move this to CgroupInfo::Blkio::Operation Done. I have instead moved it to `CgroupInfo::Blkio::Statistics::Operation` as it is stats-specific. - Jason --- This is an automatically generated e

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

2016-12-21 Thread Jason Lai
/mesos.proto 0017d3d9d46433b391703025f611ce437bbc7ebe Diff: https://reviews.apache.org/r/54693/diff/ Testing --- Thanks, Jason Lai

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

2016-12-20 Thread Jason Lai
0017d3d9d46433b391703025f611ce437bbc7ebe Diff: https://reviews.apache.org/r/54693/diff/ Testing --- Thanks, Jason Lai

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

2016-12-20 Thread Jason Lai
/54693/diff/ Testing --- Thanks, Jason Lai

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

2016-12-20 Thread Jason Lai
/54693/diff/ Testing --- Thanks, Jason Lai

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

2016-12-20 Thread Jason Lai
enerated e-mail. To reply, visit: https://reviews.apache.org/r/54693/#review158963 --- On Dec. 13, 2016, 5:12 a.m., Jason Lai wrote: > > --- > This is an automati

Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

2016-12-12 Thread Jason Lai
0017d3d9d46433b391703025f611ce437bbc7ebe src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp PRE-CREATION Diff: https://reviews.apache.org/r/54693/diff/ Testing --- Thanks, Jason Lai

Re: Review Request 53546: Added stub classes for rest cgroups subsystems.

2016-11-22 Thread Jason Lai
blkio 5 150 1 memory 10 208 1 devices 7 150 1 freezer 9 21 1 net_cls 6 21 1 perf_event 8 21 1 net_prio6 21 1 pids4 152 1 ``` - Jason Lai On Nov. 15, 2016, 5:18 p.m., haosdent huang wrote

Re: Review Request 53546: Added stub classes for rest cgroups subsystems.

2016-11-22 Thread Jason Lai
src/slave/containerizer/mesos/isolators/cgroups/subsystems/pid.cpp (lines 29 - 41) <https://reviews.apache.org/r/53546/#comment226895> `PidsSubsystem` and `"cgroups-pids-subsystem"`? - Jason Lai On Nov. 15, 2016, 5:18 p.m., haosdent huang wrote: > > ---

<    1   2