/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b
Diff: https://reviews.apache.org/r/46613/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
src/authorizer/local/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b
Diff: https://reviews.apache.org/r/46613/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/#review134631
---
On May 22, 2016, 9:25 p.m., Joerg Schad wrote:
>
> -
entire chain.
Thanks,
Joerg Schad
/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e
Diff: https://reviews.apache.org/r/47558/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
/r/47559/diff/
Testing
---
make check + (sudo) make check on various linux systems
Thanks,
Joerg Schad
://reviews.apache.org/r/47704/diff/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
://reviews.apache.org/r/47736/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e
Diff: https://reviews.apache.org/r/47558/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
/local/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b
Diff: https://reviews.apache.org/r/46613/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
/47558/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
.
Repository: mesos
Description
---
Used Tasked ObjectAllower to filter /state endpoint.
Diffs (updated)
-
src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3
Diff: https://reviews.apache.org/r/47704/diff/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
)
Thanks,
Joerg Schad
613/#comment199745>
move &&
src/authorizer/local/authorizer.cpp (line 238)
<https://reviews.apache.org/r/46613/#comment199747>
indentation
src/authorizer/local/authorizer.cpp (line 239)
<https://reviews.apache.org
g/r/47704/#comment199770>
use std::tie
src/master/http.cpp (line 1648)
<https://reviews.apache.org/r/47704/#comment199771>
move to function
- Joerg Schad
On May 25, 2016, 4:58 p.m., Joerg Schad wrote:
>
> --
/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b
Diff: https://reviews.apache.org/r/46613/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
629135f0dc59346f0fcddb2cbe65ca5770fad34e
Diff: https://reviews.apache.org/r/47558/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
/r/47559/diff/
Testing
---
make check + (sudo) make check on various linux systems
Thanks,
Joerg Schad
.
Repository: mesos
Description
---
Used Tasked ObjectAllower to filter /state endpoint.
Diffs (updated)
-
src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3
Diff: https://reviews.apache.org/r/47704/diff/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
: https://reviews.apache.org/r/47736/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
://reviews.apache.org/r/47736/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
037c4336276258d671d0b1bf66cdab50b5bf9fb8
src/messages/messages.cpp 41dcdb3996ce173fb0a56704053e4b4e03f6dd63
src/messages/messages.proto 7fd3a2a3540e57bd1ce02a15de54123bf22b074c
Diff: https://reviews.apache.org/r/47490/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
/tests/common/http_tests.cpp 300f7cc21239b7d8727f7f0f02963f1af0dc80d7
Diff: https://reviews.apache.org/r/47069/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
://reviews.apache.org/r/46613/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
line 624)
<https://reviews.apache.org/r/46613/#comment199856>
remove else
src/authorizer/local/authorizer.cpp (line 628)
<https://reviews.apache.org/r/46613/#comment199857>
Similar default.
- Joerg Schad
On May 26, 2016, 1:07 a.m., Joerg Schad wrote:
>
>
://reviews.apache.org/r/46613/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b
Diff: https://reviews.apache.org/r/46613/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
---
Object field `user` should be `users`.
Diffs
-
include/mesos/authorizer/acls.proto b178f53a299a2941afc073af963f6aff26af1ca8
Diff: https://reviews.apache.org/r/47875/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
b36b439a1fa07c52146deff2b90728f92676ade3
src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653
src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e
Diff: https://reviews.apache.org/r/47558/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
/r/47559/diff/
Testing
---
make check + (sudo) make check on various linux systems
Thanks,
Joerg Schad
.
Repository: mesos
Description
---
Used Tasked ObjectAllower to filter /state endpoint.
Diffs (updated)
-
src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3
Diff: https://reviews.apache.org/r/47704/diff/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
: https://reviews.apache.org/r/47736/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
g/r/47558/#comment199866>
Add empty line
src/master/http.cpp (line 173)
<https://reviews.apache.org/r/47558/#comment199867>
start on newline, each new line
src/master/http.cpp (line 190)
<https://reviews.apache.org/r/47558/#comment199868>
Task&
dc53bc4374aea98b5ed41ade5617374d2447229b
src/tests/dynamic_weights_tests.cpp 362c59aae7b305710d5985bfec28f881be3b64b8
Diff: https://reviews.apache.org/r/47940/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
g/r/47558/#comment200151>
if genericAcls.isNone -> return falseObjectAllower
src/authorizer/local/authorizer.cpp (line 599)
<https://reviews.apache.org/r/47558/#comment200150>
Individual lines
src/master/http.cpp (line 157)
<h
b36b439a1fa07c52146deff2b90728f92676ade3
src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653
src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e
Diff: https://reviews.apache.org/r/47558/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
/r/47559/diff/
Testing
---
make check + (sudo) make check on various linux systems
Thanks,
Joerg Schad
://reviews.apache.org/r/47704/diff/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
ace9b698f46e143795c82324a87a0d7827fb
src/authorizer/local/authorizer.cpp 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029
src/tests/dynamic_weights_tests.cpp 362c59aae7b305710d5985bfec28f881be3b64b8
Diff: https://reviews.apache.org/r/47940/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
54bfb46a807677f4a4a2bb88dcb78a358cf5121a
Diff: https://reviews.apache.org/r/47977/diff/
Testing
---
make check (OSx).
Thanks,
Joerg Schad
://reviews.apache.org/r/47736/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
tps://reviews.apache.org/r/47891/#comment200360>
command is required in ExecutorInfo.
src/authorizer/local/authorizer.cpp (line 152)
<https://reviews.apache.org/r/47891/#comment200361>
Note that at least with the other Actions non-existent `value` implies `ANY`
- Joerg Schad
On May 27
ttps://reviews.apache.org/r/47558/#comment200333>
indent
src/master/http.cpp (line 233)
<https://reviews.apache.org/r/47558/#comment200338>
Move up
- Joerg Schad
On May 27, 2016, 3:48 a.m., Joerg Schad wrote:
>
> ---
b36b439a1fa07c52146deff2b90728f92676ade3
src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653
src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e
Diff: https://reviews.apache.org/r/47558/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
/r/47559/diff/
Testing
---
make check + (sudo) make check on various linux systems
Thanks,
Joerg Schad
.
Repository: mesos
Description
---
Used TaskObjectAllower to filter /state endpoint.
Diffs (updated)
-
src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3
Diff: https://reviews.apache.org/r/47704/diff/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
Park.
Repository: mesos
Description
---
Used TaskObjectAllower to filter /tasks endpoint.
Diffs (updated)
-
src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3
Diff: https://reviews.apache.org/r/47736/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
bbbf0a00e486b96e036f59a3107789d0322bc6cd
src/tests/mesos.hpp 041cd42e2aaf5e57d7d575e5f4a97b71c01528b9
src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e
Diff: https://reviews.apache.org/r/47558/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
: https://reviews.apache.org/r/47559/diff/
Testing
---
make check + (sudo) make check on various linux systems
Thanks,
Joerg Schad
)
Thanks,
Joerg Schad
)
Thanks,
Joerg Schad
/authorizer.proto (line 64)
<https://reviews.apache.org/r/48037/#comment200516>
Does this empty line still make sense?
- Joerg Schad
On May 30, 2016, 1:17 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail.
tps://reviews.apache.org/r/48037/#comment200517>
I guess we also need to copy this new field over to the C++ object, or? See
`Future authorized(const authorization::Request& request)`
- Joerg Schad
On May 30, 2016, 1:17 p.m., Michael
> On May 30, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/authorizer/authorizer.hpp, line 58
> > <https://reviews.apache.org/r/48037/diff/1/?file=1400966#file1400966line58>
> >
> > I guess we also need to copy this new field over to the C++ object
tps://reviews.apache.org/r/48038/#comment200519>
Just curious: will we keep this around after the deprecation cycle?
- Joerg Schad
On May 30, 2016, 1:17 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail.
: https://reviews.apache.org/r/47559/diff/
Testing
---
make check + (sudo) make check on various linux systems
Thanks,
Joerg Schad
)
Thanks,
Joerg Schad
/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616
src/tests/mesos.hpp 041cd42e2aaf5e57d7d575e5f4a97b71c01528b9
src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e
Diff: https://reviews.apache.org/r/47558/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
)
Thanks,
Joerg Schad
c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616
src/tests/mesos.hpp 041cd42e2aaf5e57d7d575e5f4a97b71c01528b9
src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e
Diff: https://reviews.apache.org/r/47558/diff/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
/r/47559/diff/
Testing
---
make check + (sudo) make check on various linux systems
Thanks,
Joerg Schad
.
Repository: mesos
Description
---
Used TaskObjectAllower to filter /state endpoint.
Diffs (updated)
-
src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616
Diff: https://reviews.apache.org/r/47704/diff/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
Michael Park.
Repository: mesos
Description
---
Used TaskObjectAllower to filter /tasks endpoint.
Diffs (updated)
-
src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616
Diff: https://reviews.apache.org/r/47736/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
---
tested entire chain.
Thanks,
Joerg Schad
/47704/diff/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
Michael Park.
Repository: mesos
Description (updated)
---
Used TaskObjectApprover to filter /tasks endpoint.
Diffs
-
src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616
Diff: https://reviews.apache.org/r/47736/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
://reviews.apache.org/r/47736/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
.
Repository: mesos
Description (updated)
---
Used TaskObjectApprover to filter /state endpoint.
Diffs
-
src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616
Diff: https://reviews.apache.org/r/47704/diff/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48052/#review135562
---
Ship it!
Ship It!
- Joerg Schad
On May 30, 2016, 11:46 p.m
same request via new
authorizer interface implicitly.
Diffs
-
src/tests/authorization_tests.cpp 54bfb46a807677f4a4a2bb88dcb78a358cf5121a
Diff: https://reviews.apache.org/r/47977/diff/
Testing
---
make check (OSx).
Thanks,
Joerg Schad
/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
---
Repair() is only called fir failed futures.
Diffs
-
src/slave/http.cpp 0b83f6dbd51f39380d75334e6e4cbe3211d04c44
Diff: https://reviews.apache.org/r/48053/diff/
Testing
---
Thanks,
Joerg Schad
,
Joerg Schad
authorization based endpoint filtering documentation.
Diffs
-
docs/authorization.md 723d98c859bef04448b105905443d5e7beaa968c
Diff: https://reviews.apache.org/r/48058/diff/
Testing
---
Viewed via gist:
https://gist.github.com/joerg84/44045c005949f25df401de726ca41433
Thanks,
Joerg
/diff/
Testing
---
Viewed via gist:
https://gist.github.com/joerg84/44045c005949f25df401de726ca41433
Thanks,
Joerg Schad
/
Testing
---
tested entire chain.
Thanks,
Joerg Schad
`.
Diffs (updated)
-
src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616
Diff: https://reviews.apache.org/r/47559/diff/
Testing
---
make check + (sudo) make check on various linux systems
Thanks,
Joerg Schad
)
-
src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616
Diff: https://reviews.apache.org/r/47704/diff/
Testing
---
Make check (OSX)
Thanks,
Joerg Schad
)
-
src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616
Diff: https://reviews.apache.org/r/47736/diff/
Testing
---
make check (OSX)
Thanks,
Joerg Schad
/diff/
Testing
---
make check (OSx).
Thanks,
Joerg Schad
)
+ 100x repeat on new tests.
Thanks,
Joerg Schad
/diff/
Testing (updated)
---
Viewed via gist:
https://gist.github.com/joerg84/44045c005949f25df401de726ca41433
Also checked via website docker container.
Thanks,
Joerg Schad
5c221f059585d49be5848bc0b655adab6b02
Diff: https://reviews.apache.org/r/48054/diff/
Testing
---
make check (OSx)
+ 100x repeat on new tests.
Thanks,
Joerg Schad
---
Added `ObjectApprover` and endpoint filtering to the CHANGELOG.
Diffs
-
CHANGELOG c778aeed24579d9c0ca880e7ebfa61a25f3cdd63
Diff: https://reviews.apache.org/r/48092/diff/
Testing
---
Thanks,
Joerg Schad
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48054/#review135679
-------
On May 31, 2016, 4:24 p.m., Joerg Schad wrote:
>
> ---
5c221f059585d49be5848bc0b655adab6b02
Diff: https://reviews.apache.org/r/48054/diff/
Testing
---
make check (OSx)
+ 100x repeat on new tests.
Thanks,
Joerg Schad
tps://reviews.apache.org/r/48093/#comment200735>
only if they set an object (e.g., the teardown)
- Joerg Schad
On May 31, 2016, 9:15 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
5c221f059585d49be5848bc0b655adab6b02
src/tests/mesos.hpp 041cd42e2aaf5e57d7d575e5f4a97b71c01528b9
src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e
Diff: https://reviews.apache.org/r/48101/diff/
Testing
---
make check OSx
Thanks,
Joerg Schad
eviews.apache.org/r/48092/#review135720
---
On May 31, 2016, 11:14 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To re
c778aeed24579d9c0ca880e7ebfa61a25f3cdd63
Diff: https://reviews.apache.org/r/48092/diff/
Testing
---
Thanks,
Joerg Schad
5d7b5d13ebcf543cd908c33fbfdf541b78869bc7
src/tests/mesos.cpp 6c64bd547413d68de842ee03b13c12bbbf51779c
Diff: https://reviews.apache.org/r/48101/diff/
Testing
---
make check OSx
Thanks,
Joerg Schad
5d7b5d13ebcf543cd908c33fbfdf541b78869bc7
src/tests/mesos.cpp 6c64bd547413d68de842ee03b13c12bbbf51779c
Diff: https://reviews.apache.org/r/48101/diff/
Testing
---
make check OSx
Thanks,
Joerg Schad
5d7b5d13ebcf543cd908c33fbfdf541b78869bc7
src/tests/mesos.cpp 6c64bd547413d68de842ee03b13c12bbbf51779c
Diff: https://reviews.apache.org/r/48101/diff/
Testing
---
make check OSx
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48137/#review135817
---
Ship it!
Ship It!
- Joerg Schad
On June 1, 2016, 5:16 p.m
://reviews.apache.org/r/48263/diff/
Testing
---
viewed documentation via gist:
https://gist.github.com/joerg84/0971f48b8ae88a335f88c1344d4cf180
Thanks,
Joerg Schad
9e0f0b4f01ae6e466f6d44433a83edcebba4167a
Diff: https://reviews.apache.org/r/48264/diff/
Testing
---
make check (OSX) + repeat new test 100 times
Thanks,
Joerg Schad
semantic of the `Request` protobug message with
MESOS-5405 should be added to the CHANGELOG.
Diffs
-
CHANGELOG cbc1a037467c1bfeb1b499afcc8f6764b88bff58
Diff: https://reviews.apache.org/r/48267/diff/
Testing
---
Thanks,
Joerg Schad
901 - 1000 of 1143 matches
Mail list logo
